RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-19 Thread Paul Zimmerman
From: Anton Tikhomirov [mailto:av.tikhomi...@samsung.com] Sent: Wednesday, December 18, 2013 11:18 PM On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: Hi, Hi, On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: In accordance with

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-19 Thread Anton Tikhomirov
Hi, On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: Hi, Hi, On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: In accordance with specification, when sent data length is please mention section of specification.

[PATCH] USB: chipidea: fix error path

2013-12-19 Thread Sascha Hauer
devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Peter Chen peter.c...@freescale.com Cc: linux-usb@vger.kernel.org ---

Re: Debugging XHCI hardware issues?

2013-12-19 Thread Florian Echtler
Hello Paul, On 19.12.2013 00:40, Paul Zimmerman wrote: The exact same code works when the device is attached to the NEC controller (transferring 33792 bytes per ISO packet as requested), but fails on the Intel controller (transferring only 11264 bytes, exactly 1/3 of the requested size).

Re: [PATCH] USB: chipidea: fix error path

2013-12-19 Thread Peter Chen
On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Peter Chen peter.c...@freescale.com

RE: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.

2013-12-19 Thread David Laight
From: Freddy Xin On 2013年12月16日 18:09, David Laight wrote: I was thinking of something like: skb = netdev_alloc_skb(dev, length + dev-skb_align, gfp); if (NET_IP_ALIGN skb !(ev-driver_flags FLAG_HW_IPALIGN)) skb_reserve(skb, NET_IP_ALIGN); It might even be reasonable to remove the

[PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Rashika Kheria
Include appropriate header file include/linux/usb/otg.h in core/hcd.c because function usb_bus_start_enum() has its prototype declaration in include/linux/usb/otg.h. This eliminates the following warning in core/hcd.c: drivers/usb/core/hcd.c:2295:5: warning: no previous prototype for

[PATCH 2/7] drivers: usb: Include appropriate header file in configfs.c

2013-12-19 Thread Rashika Kheria
Include appropriate header file drivers/usb/gadget/configfs.h in gadget/configfs.c because function unregister_gadget_item() has its prototype declaration in gadget/configfs.h. This eliminates the following warning in gadget/configfs.c: drivers/usb/gadget/configfs.c:994:6: warning: no previous

[PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Rashika Kheria
Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h: include/linux/usb/hcd.h:311:44: warning: ‘struct

[PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c

2013-12-19 Thread Rashika Kheria
Include header file include/linux/usb/hcd.h in host/pci-quirks.c because function usb_hcd_amd_remote_wakeup_quirk() has its prototype declaration in include/linux/usb/hcd.h. This eliminates the following warning in host/pci-quirks.c: drivers/usb/host/pci-quirks.c:253:5: warning: no previous

[PATCH 5/7] drivers: usb: Mark function as static in usbsevseg.c

2013-12-19 Thread Rashika Kheria
Mark function my_memlen() as static in misc/usbsevseg.c because it is not used outside this file. This eliminates the following warning in misc/usbsevseg.c: drivers/usb/misc/usbsevseg.c:60:15: warning: no previous prototype for ‘my_memlen’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria

[PATCH 6/7] drivers: usb: Mark function as static in metro-usb.c

2013-12-19 Thread Rashika Kheria
Mark function metrousb_is_unidirectional_mode() in serial/metro-usb.c because it is not used outside this file. This eliminates the following warning in serial/metro-usb.c: drivers/usb/serial/metro-usb.c:57:12: warning: no previous prototype for ‘metrousb_is_unidirectional_mode’

[PATCH 7/7] drivers: usb: Include appropriate header file in phy-am335x-control.c

2013-12-19 Thread Rashika Kheria
Include header file drivers/usb/phy/am35x-phy-control.h in phy/phy-am335x-control.c because function am335x_get_phy_control() has its prototype declaration in drivers/usb/phy/am35x-phy-control.h. Also, remove definition of structure phy_control because it is already defined in the included

[PATCH v2 01/12] libusbg: Surround header with include guards.

2013-12-19 Thread Krzysztof Opasiak
Surround header with include guards to protect against multiple inclusion. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- include/gadget/gadget.h |4 1 file changed, 4 insertions(+) diff --git a/include/gadget/gadget.h b/include/gadget/gadget.h index 9bca97e..f3c08e9 100644

[PATCH v2 03/12] libusbg: Fix gadget-acm-ecm example to cleanup at exit.

2013-12-19 Thread Krzysztof Opasiak
Make use of previously unused variable ret to cleanup afterr successful gadget creation. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- Changes since v1: - change labels on more suitable for given context examples/gadget-acm-ecm.c | 20 ++-- 1 file changed,

[PATCH v2 07/12] libusbg: Add missing config attrs parsing while new config creation.

2013-12-19 Thread Krzysztof Opasiak
Afther creation of configuration its attributes left uninitialized. Config attrs should be initialized with default values provided by kernel. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gadget.c

[PATCH v2 05/12] libusbg: Fix memory leak when unable to create directory.

2013-12-19 Thread Krzysztof Opasiak
Free the memory allocated for gadget/config/function structure when faild to create suitable directory. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gadget.c b/src/gadget.c index aea9b2e..f613c3e 100644 ---

[PATCH v2 11/12] libusbg: Replace memcpy with structure assign.

2013-12-19 Thread Krzysztof Opasiak
Use the assign operator for structure instead of using memcpy with hard coded size. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- Changes since v1: - replace memcpy with direct structure assignment src/gadget.c |8 1 file changed, 4 insertions(+), 4

[PATCH v2 06/12] libusbg: Add error handling to gadget_read_string.

2013-12-19 Thread Krzysztof Opasiak
Add error handling when gadget_read_buf return NULL. If read of string fails, the string should be set as empty. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- Changes since v1: - Remove additional check of p variable src/gadget.c | 23 +-- 1 file

[PATCH v2 00/12] libusbg: Cleanup, bug fix and refactoring.

2013-12-19 Thread Krzysztof Opasiak
Dear Matt, Please excuse me my passivity after discussuon about libusbg some time ago. I had to close some other issues before taking up this one. Recently I looked into code of libusbg, build it and found some errors which are fixed in attached patches. Moreover I have done some clean up and

[PATCH v2 02/12] libusbg: Add missing return statement in non-void functions.

2013-12-19 Thread Krzysztof Opasiak
Add return 0 in functions which return non-void to suppress compiler complaint. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c |4 1 file changed, 4 insertions(+) diff --git a/src/gadget.c b/src/gadget.c index 8ca68b3..8320f34 100644 --- a/src/gadget.c +++

[PATCH v2 12/12] libusbg: Replace directory names with defines.

2013-12-19 Thread Krzysztof Opasiak
Replace strings, functions, configs strings placed everywhere in code with macro defintions STRINGS_DIR, FUNCTIONS_DIR and CONFIGS_DIR. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c | 37 +++-- 1 file changed, 23 insertions(+), 14

[PATCH v2 08/12] libusbg: Separate parsing gadget attributes and strings.

2013-12-19 Thread Krzysztof Opasiak
Gadget attributes and strings are logically independent, so they should be initialized in separate functions. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index

[PATCH v2 10/12] libusbg: Move symlink creation after memory allocation.

2013-12-19 Thread Krzysztof Opasiak
Move creation of symlink after memory allocation for binding structure. Fix missing initialization of parent. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gadget.c b/src/gadget.c

[PATCH v2 09/12] libusbg: Initialize gadget attributes and strings while gadget creation

2013-12-19 Thread Krzysztof Opasiak
Fix gadget_create_gadget function to initialize gadget attributes and strings with default values provided by kernel. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gadget.c b/src/gadget.c

[PATCH v2 04/12] libusbg: Move directory creation before writing attributes.

2013-12-19 Thread Krzysztof Opasiak
Change order of gadget creation and attribute writting to fix No such file or directory error while creating new gadget. Signed-off-by: Krzysztof Opasiak k.opas...@samsung.com --- src/gadget.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gadget.c

RE: [PATCH v2 12/12] libusbg: Replace directory names with defines.

2013-12-19 Thread David Laight
From: Krzysztof Opasiak Replace strings, functions, configs strings placed everywhere in code with macro defintions STRINGS_DIR, FUNCTIONS_DIR and CONFIGS_DIR. I'm not convinced this is an improvement, do you have a further change in mind? It also isn't entirely clear there aren't some other

ftdi_sio: FTDI UART buffer overrun, no Bi requests for 200ms

2013-12-19 Thread Chris Sykes
Hi, I have a user space application which communicates with an embedded micro-controller over USB via an FTDI FT232H chip. I'm seeing occasional data loss while reading data transmitted by the micro, and I believe that when this occurs the FTDI UART Rx fifo is being overrun (there's no flow

RE: ftdi_sio: FTDI UART buffer overrun, no Bi requests for 200ms

2013-12-19 Thread David Laight
From: Chris Sykes I have a user space application which communicates with an embedded micro-controller over USB via an FTDI FT232H chip. I'm seeing occasional data loss while reading data transmitted by the micro, and I believe that when this occurs the FTDI UART Rx fifo is being overrun

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-19 Thread Andreas Naumann
Am 19.12.2013 00:40, schrieb Grazvydas Ignotas: On Wed, Dec 18, 2013 at 5:35 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: From: Andreas Naumann anaum...@ultratronik.de This is a hard to reproduce problem which leads to

[PATCH v8 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-12-19 Thread Matt Porter
This adds a pair of APIs that allows the generic PHY subsystem to provide information on the PHY bus width. The PHY provider driver may use phy_set_bus_width() to set the bus width that the PHY supports. The controller driver may then use phy_get_bus_width() to fetch the PHY bus width in order to

[PATCH v8 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-12-19 Thread Matt Porter
Add a binding that describes the Broadcom Kona USB2 PHY found on the BCM281xx family of SoCs. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/phy/bcm-phy.txt | 15 +++ 1 file changed, 15 insertions(+)

[PATCH v8 9/9] ARM: dts: add usb udc support to bcm281xx

2013-12-19 Thread Matt Porter
Adds USB OTG/PHY and clock support to BCM281xx and enables UDC support on the bcm11351-brt and bcm28155-ap boards. Signed-off-by: Matt Porter mpor...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- arch/arm/boot/dts/bcm11351-brt.dts

[PATCH v8 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem

2013-12-19 Thread Matt Porter
Adds support for querying the phy bus width from the generic phy subsystem. Configure UTMI bus width in GUSBCFG based on this value. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com --- drivers/usb/gadget/s3c-hsotg.c | 14 +-

[PATCH v8 3/9] usb: gadget: s3c-hsotg: enable build for other platforms

2013-12-19 Thread Matt Porter
Remove unused Samsung-specific machine include and Kconfig dependency on S3C. Signed-off-by: Matt Porter mpor...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org Reviewed-by: Tim Kryger tim.kry...@linaro.org --- drivers/usb/gadget/Kconfig | 7 +++

[PATCH v8 4/9] usb: gadget: s3c-hsotg: add snps,dwc2 compatible string

2013-12-19 Thread Matt Porter
Enable support for the dwc2 binding. Signed-off-by: Matt Porter mpor...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index db797f2..cbfbf41 100644 ---

[PATCH v8 5/9] usb: gadget: s3c-hsotg: enable generic phy support

2013-12-19 Thread Matt Porter
Adds support for the generic PHY subsystem. Generic PHY support is probed and then the driver falls back to checking for an old style USB PHY and pdata if not found. Signed-off-by: Matt Porter mpor...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c | 55 ++

Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-19 Thread Matt Porter
On Thu, Dec 19, 2013 at 11:19:35AM +0530, Kishon Vijay Abraham I wrote: Hi Felipe, On Wednesday 18 December 2013 09:55 PM, Felipe Balbi wrote: On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: Add a driver for the internal Broadcom Kona USB 2.0 PHY found on the BCM281xx family

[PATCH v8 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-19 Thread Matt Porter
Add a driver for the internal Broadcom Kona USB 2.0 PHY found on the BCM281xx family of SoCs. Signed-off-by: Matt Porter mpor...@linaro.org --- drivers/phy/Kconfig | 6 ++ drivers/phy/Makefile| 1 + drivers/phy/phy-bcm-kona-usb2.c | 158

[PATCH v8 2/9] staging: dwc2: update DT binding to add generic clock/phy properties

2013-12-19 Thread Matt Porter
dwc2/s3c-hsotg require a single clock to be specified and optionally a generic phy. On the s3c-hsotg driver old style USB phy support is present as a fallback so the generic phy properties are optional. Signed-off-by: Matt Porter mpor...@linaro.org Acked-by: Kishon Vijay Abraham I kis...@ti.com

[PATCH v8 0/9] USB Device Controller support for BCM281xx

2013-12-19 Thread Matt Porter
Changes since v7: - Register phy provider with generic phy subsystem only after the generic phy has been allocated and configured. Changes since v6: - Drop dependency on the Exynos generic phy conversion series - Bring back original patch that converts s3c-hsotg

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 03:38:18PM +0900, Anton Tikhomirov wrote: Hi, Hi, On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote: WARN_ON(ret 0); Regards Pratyush By the way, chaining additional (auxiliary) TRB would allow complying with

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 07:03:48AM +, Paul Zimmerman wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Wednesday, December 18, 2013 10:03 PM On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: Hi,

Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-19 Thread Felipe Balbi
Hi, On Thu, Dec 19, 2013 at 11:19:35AM +0530, Kishon Vijay Abraham I wrote: On Wednesday 18 December 2013 09:55 PM, Felipe Balbi wrote: On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: Add a driver for the internal Broadcom Kona USB 2.0 PHY found on the BCM281xx family of SoCs.

Re: [PATCH] usb/gadget: should use u16 type variable to store MaxPower

2013-12-19 Thread Felipe Balbi
On Tue, Dec 17, 2013 at 11:47:42AM +, Du, ChangbinX wrote: From 7e827a0d300e084f74c65122baa5e3193f9a7f18 Mon Sep 17 00:00:00 2001 From: Du, Changbin changbinx...@intel.com Date: Mon, 16 Dec 2013 20:32:13 +0800 Subject: [PATCH] usb/gadget: should use u16 type variable to store MaxPower

Re: [PATCH] usb: musb: finish suspend/reset work independently from musb_hub_control()

2013-12-19 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 08:23:46PM +0100, Daniel Mack wrote: Currently, resume and reset is completed when the USB core calls back the root hub, asking for the port's state. This results in unpredictable timing of state assertion, which in turn renders some USB devices unusable after resume.

RE: [PATCH] usb: xhci: Less verbose tracing of short receives

2013-12-19 Thread David Laight
From: David Laight Only receive TD can have a transfer length less than the transfer size, so rename COMP_SHORT_TX to COMP_SHORT_RX, XHCI_TRUST_TX_LENGTH to XHCI_TRUST_RX_LENGTH. handle_tx_event() is called for both receive and transmit completions so rename to handle_data_event(). In

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-19 Thread Felipe Balbi
Hi, On Thu, Dec 19, 2013 at 09:48:24AM +1100, Stephen Rothwell wrote: On Wed, 18 Dec 2013 09:58:33 -0600 Felipe Balbi ba...@ti.com wrote: are you sure that patch is included ? I have just checked on greg/usb-linus that it's impossible to make CONFIG_USB=m and CONFIG_ISP1301_OMAP=y (same

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 09:16:50AM -0600, Felipe Balbi wrote: Hi, On Thu, Dec 19, 2013 at 09:48:24AM +1100, Stephen Rothwell wrote: On Wed, 18 Dec 2013 09:58:33 -0600 Felipe Balbi ba...@ti.com wrote: are you sure that patch is included ? I have just checked on greg/usb-linus that

Re: [PATCH] usb: musb: finish suspend/reset work independently from musb_hub_control()

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 08:53:16AM -0600, Felipe Balbi wrote: On Wed, Dec 18, 2013 at 08:23:46PM +0100, Daniel Mack wrote: Currently, resume and reset is completed when the USB core calls back the root hub, asking for the port's state. This results in unpredictable timing of state

Re: [PATCH v2 2/3] usb: musb: add support for JZ4740 usb device controller

2013-12-19 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 12:56:00AM +0100, Apelete Seketeli wrote: Add support for Ingenic JZ4740 USB Device Controller through a specific musb glue layer. The platform data already available in tree for that USB Device Controller was previously used by an out-of-tree USB gadget driver which

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h:

Re: [PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb/hcd.h in host/pci-quirks.c because function usb_hcd_amd_remote_wakeup_quirk() has its prototype declaration in include/linux/usb/hcd.h. This eliminates the following warning in host/pci-quirks.c:

Re: [PATCH 4/7] drivers: usb: Include appropriate header file in pci-quirks.c

2013-12-19 Thread josh
On Thu, Dec 19, 2013 at 10:51:50AM -0500, Alan Stern wrote: On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb/hcd.h in host/pci-quirks.c because function usb_hcd_amd_remote_wakeup_quirk() has its prototype declaration in include/linux/usb/hcd.h. This

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 06:45 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in

RE: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread David Laight
From: Rashika Kheria Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in include/linux/usb/hcd.h:

xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-19 Thread Denis Turischev
The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. The bug can be avoided if the USB ports are switched back to EHCI on

Re: ftdi_sio: FTDI UART buffer overrun, no Bi requests for 200ms

2013-12-19 Thread Greg KH
On Thu, Dec 19, 2013 at 01:38:54PM +, Chris Sykes wrote: Hi, I have a user space application which communicates with an embedded micro-controller over USB via an FTDI FT232H chip. I'm seeing occasional data loss while reading data transmitted by the micro, and I believe that when this

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
On Thu, Dec 19, 2013 at 10:45:42AM -0500, Alan Stern wrote: On Thu, 19 Dec 2013, Rashika Kheria wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h.

Re: xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-19 Thread Greg KH
On Thu, Dec 19, 2013 at 06:29:14PM +0200, Denis Turischev wrote: The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. The

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote: Include appropriate header file include/linux/usb/otg.h in core/hcd.c because function usb_bus_start_enum() has its prototype declaration in include/linux/usb/otg.h. This eliminates the following warning in core/hcd.c:

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Sergei Shtylyov wrote: Hello. On 12/19/2013 06:45 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Rashika Kheria
On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote: Include appropriate header file include/linux/usb/otg.h in core/hcd.c because function usb_bus_start_enum() has its prototype declaration in

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013 j...@joshtriplett.org wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy of making all headers self-contained, and then only including

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:38 PM, Alan Stern wrote: Include header file include/linux/usb.h in include/linux/usb/hcd.h because structures usb_device, usb_host_config and usb_interface have their definitions in include/linux/usb.h. This eliminates the following warning in

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread josh
On Thu, Dec 19, 2013 at 11:48:15AM -0500, Alan Stern wrote: On Thu, 19 Dec 2013 j...@joshtriplett.org wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote: On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote: Include appropriate header file include/linux/usb/otg.h in core/hcd.c

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2013 07:48 PM, Alan Stern wrote: Of course, people have varying opinions on this issue. As far as I know, there is no fixed policy in the kernel about nested includes. True. I personally prefer the policy of making all headers self-contained, and then only including

Re: ftdi_sio: FTDI UART buffer overrun, no Bi requests for 200ms

2013-12-19 Thread Chris Sykes
On 19.12.2013 16:34, Greg KH wrote: Was anything else going on on your machine during that time period? USB can be held off for long periods of time for no real reason, but that does seem like a long time. Hi Greg, Nothing significant was going on at the time as far as I can tell, no

[PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-19 Thread Denis Turischev
The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. The bug can be avoided if the USB ports are switched back to EHCI on

RE: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread David Laight
These warning are non-default GCC warnings. These can be seen either by adding W=1 while running make (i.e. make W=1) or adding -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile. By default, we don't care about 'W=1' warnings, as no one sees them, and they don't matter.

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2013-12-19 Thread Sarah Sharp
This is actually v2. On Thu, Dec 19, 2013 at 07:07:33PM +0200, Denis Turischev wrote: The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote: Include appropriate header file include/linux/usb/otg.h in core/hcd.c because function usb_bus_start_enum() has its prototype declaration in include/linux/usb/otg.h. This eliminates the following warning in core/hcd.c:

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-19 Thread Sarah Sharp
On Wed, Dec 18, 2013 at 04:05:05PM -0800, James Bottomley wrote: On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: On Wed, 18 Dec 2013, Sarah Sharp wrote: On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: This set should fix our target problems with USB by making the

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Josh Triplett
On Thu, Dec 19, 2013 at 08:58:02AM -0800, Greg Kroah-Hartman wrote: On Thu, Dec 19, 2013 at 10:11:45PM +0530, Rashika Kheria wrote: On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:

Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

2013-12-19 Thread Josh Triplett
On Thu, Dec 19, 2013 at 05:33:09PM -, David Laight wrote: These warning are non-default GCC warnings. These can be seen either by adding W=1 while running make (i.e. make W=1) or adding -Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile. By default, we don't care

Re: [PATCH 3/7] drivers: usb: Include appropriate header file in hcd.h

2013-12-19 Thread Alan Stern
On Thu, 19 Dec 2013, Sergei Shtylyov wrote: I don't really see how C language design can justify header files that once included, require each .c file to #include other headers ahead of them, each time such header is used. In my opinion, it's just crazy. Okay, you've convinced me. In

hibernation and HIRD threshold

2013-12-19 Thread Felipe Balbi
Hi Paul, I'm reading section 12.3.6.1 on Databook 2.70a. In step 5, databook mentions we should set DCTL.HIRD_Thres[4] to 1, and DCTL.HIRD_Thres[3:0] to an appropriate value, but on Table 6-61 Device Control Register: DCTL (page 540) there's a note stating that This field must be set to ‘0’

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-19 Thread James Bottomley
On Thu, 2013-12-19 at 10:26 -0800, Sarah Sharp wrote: On Wed, Dec 18, 2013 at 04:05:05PM -0800, James Bottomley wrote: On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: On Wed, 18 Dec 2013, Sarah Sharp wrote: On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote:

Re: [PATCH v7 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-12-19 Thread Andrew Lunn
+* endpoint, with a multiplex header. The second bulk in is +* used for events. Throw away all but the first two bulk in +* urbs. +*/ + for (i = 2; i serial-num_bulk_in; ++i) { + port = serial-port[i]; + for (j = 0; j

RE: hibernation and HIRD threshold

2013-12-19 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, December 19, 2013 11:49 AM Hi Paul, I'm reading section 12.3.6.1 on Databook 2.70a. In step 5, databook mentions we should set DCTL.HIRD_Thres[4] to 1, and DCTL.HIRD_Thres[3:0] to an appropriate value, but on Table 6-61 Device

[PATCH v3 2/2] usb: musb: fix setting JZ4740 gadget periphal mode on reset

2013-12-19 Thread Apelete Seketeli
JZ4740 USB Device Controller is not OTG compatible and does not have DEVCTL register in silicon. During ethernet-over-usb transactions, on reset, musb driver tries to read from DEVCTL and consequently sets device as host (A-Device) instead of peripheral (B-Device), which makes it a composite

[PATCH v3 1/2] usb: musb: add support for JZ4740 usb device controller

2013-12-19 Thread Apelete Seketeli
Add support for Ingenic JZ4740 USB Device Controller through a specific musb glue layer. JZ4740 UDC not being OTG compatible and missing some hardware registers, this musb glue layer is written from scratch to be used in gadget mode only and take silicon design specifics into account.

[PATCH v3 0/2] Add USB support for Ingenic JZ4740

2013-12-19 Thread Apelete Seketeli
Hello, Following the fix I submitted a few weeks ago, here is a set of patches that adds USB support for the Ingenic JZ4740 MIPS SoC. The JZ4740 is found in the Ben NanoNote handheld computer which is built by the Qi-Hardware community. Even though Ben NanoNote is already supported in the

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-19 Thread Stephen Rothwell
Hi Felipe, On Thu, 19 Dec 2013 09:30:34 -0600 Felipe Balbi ba...@ti.com wrote: Actually, when I merged greg/usb-linus on top of my 'next', I got a conflict which was enough to solve as below: commit d86c94d1ddeb496cf53ace1a76274ebb1d935671 Merge: c139e14 fb5f183 Author: Felipe Balbi

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-19 Thread Sarah Sharp
On Wed, Dec 18, 2013 at 11:24:47AM -, David Laight wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit systems) so requires an additional page.

Re: [PATCH v4 06/15] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2013-12-19 Thread David Brown
On Tue, Nov 12, 2013 at 04:51:41PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: ...In case this attribute isn't passed via DT, USB DRD controllers should default to

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-19 Thread David Brown
On Tue, Nov 26, 2013 at 10:38:46AM -0600, Felipe Balbi wrote: Hi, On Tue, Nov 12, 2013 at 04:51:35PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Hi, Patches have been tested on top of Stephen's clock controller patches[1] and recent fixes for chipidea msm glue layer

Re: hibernation and HIRD threshold

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 08:01:08PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, December 19, 2013 11:49 AM Hi Paul, I'm reading section 12.3.6.1 on Databook 2.70a. In step 5, databook mentions we should set DCTL.HIRD_Thres[4] to 1, and

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-19 Thread Felipe Balbi
On Fri, Dec 20, 2013 at 08:15:09AM +1100, Stephen Rothwell wrote: Hi Felipe, On Thu, 19 Dec 2013 09:30:34 -0600 Felipe Balbi ba...@ti.com wrote: Actually, when I merged greg/usb-linus on top of my 'next', I got a conflict which was enough to solve as below: commit

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 03:03:15PM -0800, David Brown wrote: On Tue, Nov 26, 2013 at 10:38:46AM -0600, Felipe Balbi wrote: Hi, On Tue, Nov 12, 2013 at 04:51:35PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Hi, Patches have been tested on top of Stephen's clock

[PATCH] USB: c67x00: remove CONFIG_USB_DEBUG dependancy

2013-12-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org This removes the usage of CONFIG_USB_DEBUG in the c67x00 driver. There was only one place, where the TD was dumped to the kernel log, and that was using the dynamic debug infrastructure already, with the exception of the call to

[PATCH] USB: core: remove CONFIG_USB_DEBUG usage

2013-12-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org CONFIG_USB_DEBUG is going away, so remove the few places in the USB core that relied on them. This means that we always now do the debug checks for every urb submitted, which is a good idea, as who knows how many driver bugs we have been

[PATCH] USB: gadget: fix up some comments about CONFIG_USB_DEBUG

2013-12-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org These two gadget drivers said that their #endif was for CONFIG_USB_DEBUG, but they really were not, so fix them up to be correct. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH] Watchdog: pcwd_usb: remove CONFIG_USB_DEBUG usage

2013-12-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org CONFIG_USB_DEBUG is going away, and all of the other USB drivers no longer rely on debug module parameters for debugging lines, so move the pcwd_usb driver to use the dynamic debug infrastructure to be more in line with the rest of the kernel.

Hello dear

2013-12-19 Thread annstokesz
Hello dear I will be very happy to be your friend. My name is miss. Ann Stokes. Please i will like you to write me through my email address ( ann...@yahoo.fr ) . I will send my pictures to you and also tell you more about myself when i receive your email. I will be waiting for your mail in my mail

[PATCH] usb: musb: Remove USB_GADGET driver dependency

2013-12-19 Thread Ezequiel Garcia
This USB controller is dual-role, but can also work in host-only mode. There's no reason to condition the entire driver to USB_GADGET. Fix this by removing the dependency. Tested on a Beaglebone black (AM335x) using a regular USB mass storage device. Signed-off-by: Ezequiel Garcia

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-19 Thread Anton Tikhomirov
Hi, On Thu, Dec 19, 2013 at 03:38:18PM +0900, Anton Tikhomirov wrote: Hi, Hi, On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote: WARN_ON(ret 0); Regards Pratyush By the way, chaining additional (auxiliary) TRB would allow complying

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-19 Thread Steve Calfee
On Wed, Dec 18, 2013 at 3:24 AM, David Laight david.lai...@aculab.com wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit systems) so requires an

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-19 Thread David Cohen
On Wed, Dec 18, 2013 at 11:24:47AM -, David Laight wrote: This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit systems) so requires an additional page.

  1   2   >