On 06/15/2014 10:42 AM, Yang,Wei wrote:
Its v4, sorry for missing it in subject.
Alan, How about this version?
Cheers
Wei
Regards
Wei
On 06/15/2014 10:40 AM, wei.y...@windriver.com wrote:
From: Yang Wei wei.y...@windriver.com
While loading g_mass_storage module, the following warning
is
Hello,
I recently started to develop a USB kernel driver for a GoogleSummer Of Code
project and I'm running in some small issues. The source code is available at
https://github.com/ungureanuvladvictor/ADK-Driver/blob/master/adk-driver.c .
The driver matches the VID/PID of a LG Nexus5 and tries in
Hi Laurent,
Thank you for a thorough review of the whole series.
W dniu 16.06.2014 19:39, Laurent Pinchart pisze:
Hi Andrzej,
Thank you for the patch.
git am complains with
Applying: usb/gadget: f_uvc: add configfs support
/home/laurent/src/kernel/media.git/.git/rebase-apply/patch:40:
On 17 June 2014 09:31:07 CEST, Vlad Ungureanu v...@vdev.ro wrote:
The driver matches the VID/PID of a LG Nexus5 and tries in the probe
function
to switch it to ADK Mode *Accessory Development Kit Mode*.
This sounds like something you'd normally do from userspace.
The problem is that my
On Tue, 2014-06-17 at 09:31 +0200, Vlad Ungureanu wrote:
Hello,
I recently started to develop a USB kernel driver for a GoogleSummer Of Code
project and I'm running in some small issues. The source code is available at
On 17 June 2014 09:31:07 CEST, Vlad Ungureanu v...@vdev.ro wrote:
The driver matches the VID/PID of a LG Nexus5 and tries in the probe
function
to switch it to ADK Mode *Accessory Development Kit Mode*.
This sounds like something you'd normally do from userspace.
We are trying to use
On Tue, 2014-06-17 at 09:31 +0200, Vlad Ungureanu wrote:
Hello,
I recently started to develop a USB kernel driver for a GoogleSummer Of Code
project and I'm running in some small issues. The source code is available
at
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote:
If that is not your intention, then you need to be more specific in the
match table.
Yes, it matches the whole device so that is why every interface gets probed. I
will change that.
That's problematic. You need to find out what
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote:
If that is not your intention, then you need to be more specific in the
match table.
Yes, it matches the whole device so that is why every interface gets
probed. I
will change that.
That's problematic. You need to
You have exceeded the limit of your mailbox set by our IT Service, and
from now you cannot be receiving all incoming emails and also some of your
outgoing emails will not be delivered and LASTLY, your account will be
'DE-ACTIVATED' within 24 hours from now. To prevent , you are advised to
click on
Hi,
I get the splat below on latest linus/master + tip/master, i.e.
3.16-rc1+. More info available upon request:
...
[3.366557] xhci_hcd :00:14.0: xHCI Host Controller
[3.367225] xhci_hcd :00:14.0: new USB bus registered, assigned bus
number 2
[3.368064] usb usb2: New USB
On Tue, 2014-06-17 at 12:19 +0200, Vlad Ungureanu wrote:
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote:
If that is not your intention, then you need to be more specific in the
match table.
Yes, it matches the whole device so that is why every interface gets
Vlad Ungureanu v...@vdev.ro writes:
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote:
If that is not your intention, then you need to be more specific in the
match table.
Yes, it matches the whole device so that is why every interface gets
probed. I
will change that.
'err' is uninitialized, rather print the error code directly.
This also fixes following warning.
drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
dev_err(dev, unable to
Hello,
On 2014-06-17 13:08, Tushar Behera wrote:
'err' is uninitialized, rather print the error code directly.
This also fixes following warning.
drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized
in this
On Tue, 2014-06-17 at 12:19 +0200, Vlad Ungureanu wrote:
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote:
If that is not your intention, then you need to be more specific in
the match table.
Yes, it matches the whole device so that is why every interface gets
The drivers/usb/gadget directory contains many files.
Files which are related can be distributed into separate directories.
This patch moves the legacy gadgets (i.e. those not using configfs)
into a separate directory.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
The drivers/usb/gadget directory contains many files.
Files which are related can be distributed into separate directories.
This patch moves the UDC drivers into a separate directory.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/Kconfig|
The drivers/usb/gadget directory contains many files.
Files which are related can be distributed into separate directories.
This patch moves the USB functions implementations into a separate directory.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/Makefile
This is a follow-up to this thread:
http://www.spinics.net/lists/linux-usb/msg107611.html
This refactoring has been accepted well, so I am sending it
once 3.16-rc1 is out in order to make it easy to apply it.
The cleanup rearranges the way source code files are located in the
drivers/usb/gadget
On Tue, Jun 17, 2014 at 01:01:55AM +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
---
Changes in v2:
- sorted headers to alphabetic order
- using
hi all:
I use kernel 3.8.0
And when I plug in webcam in my platform xhci host, I get below message:
platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion
platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments
platform-xhci platform-xhci.0: ERROR Transfer
The tegra_ehci_hcd structure is located in the private space allocated
by the core USB code so it must not be accessed after the HCD is
freed.
Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com
---
drivers/usb/host/ehci-tegra.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Tue, 17 Jun 2014, Yang,Wei wrote:
On 06/15/2014 10:42 AM, Yang,Wei wrote:
Its v4, sorry for missing it in subject.
Alan, How about this version?
Cheers
Wei
...
Signed-off-by: Yang Wei wei.y...@windriver.com
Acked-by: Alan Stern st...@rowland.harvard.edu
That is a strange
On Tue, 17 Jun 2014, Vlad Ungureanu wrote:
To go into ADK mode the host needs to send the Android device a series of usb
control messages with different data. This yes can be done from userspace but
when the device goes into the ADK mode I need to handle it into Kernel space.
The end goal of
On Tue, 2014-06-17 at 10:22 -0400, Alan Stern wrote:
On Tue, 17 Jun 2014, Vlad Ungureanu wrote:
To go into ADK mode the host needs to send the Android device a series of
usb
control messages with different data. This yes can be done from userspace
but
when the device goes into the
On Tue, Jun 17, 2014 at 10:07:38PM +0800, vichy wrote:
hi all:
I use kernel 3.8.0
That's a very old, and unsupported kernel version. I suggest you update
to something more modern, especially for xhci issues as loads of them
have been fixed since 3.8 was released. If you are stuck with 3.8 due
On Tue, 17 Jun 2014, Tuomas Tynkkynen wrote:
The tegra_ehci_hcd structure is located in the private space allocated
by the core USB code so it must not be accessed after the HCD is
freed.
Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com
---
drivers/usb/host/ehci-tegra.c | 3 ++-
1
hi Greg:
2014-06-17 22:25 GMT+08:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jun 17, 2014 at 10:07:38PM +0800, vichy wrote:
hi all:
I use kernel 3.8.0
That's a very old, and unsupported kernel version. I suggest you update
Yes. it is pretty old kernel.
But i have git diff the xhci-mem.c
From: vichy
hi all:
I use kernel 3.8.0
And when I plug in webcam in my platform xhci host, I get below message:
platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion
platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments
platform-xhci
Change r8a66597-udc to use devm functions and cleanup the result.
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Update driver to use devm_kzalloc() to make tracking of resources
easier. Also remove the exit point via cleanup as there's no
cleanup necessary from this point now.
As a note, also removes the error print as the allocation calls
produce errors if they do not return memory.
Signed-off-by: Ben
With the updates for devm, the cleanup path no longer needs to
check for NULL device state, so remove it and return directly
if the irq resource missing
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 10 +++---
1 file changed, 3 insertions(+), 7
Change the sudmac register handling in the devm_ioremap_resource
to use the devm variant.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git
Use the devm_request_irq() call to get the interrupt for the
device and have it automatically free on exit.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
With the devm additions, the clean_up and clean_up3 are now
not needed or used. Change clean_up3 and make everything use
clean_up2 and just remove clean_up.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 5 ++---
1 file changed, 2 insertions(+), 3
Change to using the devm_clk_get() to get the clock and
have it automatically freed on exit.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
hello.
On 06/17/2014 07:14 PM, Ben Dooks wrote:
Remove usages of pdev-dev in the driver probe function
s/Remove/Replace/?
with just dev to make the references to it easier to
write. Convert all the current users of it to use it.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Remove usages of pdev-dev in the driver probe function
with just dev to make the references to it easier to
write. Convert all the current users of it to use it.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/usb/gadget/r8a66597-udc.c | 18 +-
1 file changed, 9
---
drivers/usb/gadget/r8a66597-udc.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb/gadget/r8a66597-udc.c
index aff0a67..7f3af74 100644
--- a/drivers/usb/gadget/r8a66597-udc.c
+++
hi david:
platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion
platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments
platform-xhci platform-xhci.0: ERROR Transfer event TRB DMA ptr not
part of current TD
under what circumstance the controller will
On 06/13/2014 03:06 AM, Lu Baolu wrote:
When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend,
xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some
Intel
platforms may get a spurious wakeup, even if PCI PME# is disabled.
This patch should be
If the descriptors do not need any strings and user space sends empty
set of strings, the ffs-stringtabs field remains NULL. Thus
*ffs-stringtabs in functionfs_bind leads to a NULL pointer
dereferenece.
The bug was introduced by commit [fd7c9a007f: “use usb_string_ids_n()”].
While at it, remove
From: vichy
hi david:
platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion
platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments
platform-xhci platform-xhci.0: ERROR Transfer event TRB DMA ptr not
part of current TD
under what
On 06/17/2014 08:17 AM, Tuomas Tynkkynen wrote:
The tegra_ehci_hcd structure is located in the private space allocated
by the core USB code so it must not be accessed after the HCD is
freed.
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
This seems to be a
On Thu, 12 Jun 2014 10:20:54 -0400 (EDT), Alan Stern wrote:
Dennis and Matteo:
I promised to send both of you a patch changing the way ohci-hcd
handles hardware bugs. Well, it's finally ready for testing. There's
only a limited amount I can do on my own machine, so now it's up to
you
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Changes in v2:
- sorted headers to alphabetic order
- using devm_kzalloc
- using BIT(n)
- using usb_control_msg instead of usb_submit_urb
- removing unneeded code
hi david:
2014-06-17 23:50 GMT+08:00 David Laight david.lai...@aculab.com:
From: vichy
hi david:
platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring
expansion
platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments
platform-xhci platform-xhci.0: ERROR
On Sun, Jun 15 2014, wei.y...@windriver.com wrote:
From: Yang Wei wei.y...@windriver.com
While loading g_mass_storage module, the following warning
is triggered.
WARNING: at drivers/usb/gadget/composite.c:
usb_composite_setup_continue: Unexpected call
Modules linked in: fat vfat minix
Hi Sarah,
Looks like XHCI is not honoring URB_ZERO_PACKET flag set by class drivers.
I came across a patch from David Laight dated Nov 2013. But i couldn't
find it in latest kernel tree. Are you planning to add support using
David's patch (or any other patch) in near future? From current
On Tue, 17 Jun 2014, Stephen Warren wrote:
On 06/17/2014 08:17 AM, Tuomas Tynkkynen wrote:
The tegra_ehci_hcd structure is located in the private space allocated
by the core USB code so it must not be accessed after the HCD is
freed.
diff --git a/drivers/usb/host/ehci-tegra.c
Hello there,
[linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1528] -
[linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1535]:
(style) Mismatching assignment and comparison, comparison 'nt==17' is always
false.
Source code is
nt = 0x3 (usb_endpoint_maxp(desc) 11);
buffer_size =
On Fri, Jun 13, 2014 at 11:35:13AM +0300, Alexey Tulia wrote:
This fixes the following warning:
- WARNING: __constant_cpu_to_le32 should be cpu_to_le32
What produces this warning?
Signed-off-by: Alexey Tulia alexey.tu...@gmail.com
---
drivers/staging/usbip/vhci_hcd.c | 2 +-
1
Hi all,
We have a custom board that has been running on the v3.0 kernel
for a while. Since that kernel version is deprecated we are working
on upgrading to the 3.10 kernel (some products are 3.10-ltsi so trying
to be common).
Everything is now working except the USB gadget support. This is a
Fallout / regression fixes for the port power control rework that landed
in 3.16-rc1.
1/ Cosmetic fix to an error message
2/ Handle ACPI port-location-data conflicts by disabling port power off
rather than spewing a backtrace and trying to continue.
3/ Handle hubs that do not support port
In the case where platform firmware has specified conflicting values for
port locations it is confusing and otherwise not helpful to throw a
backtrace. Instead, include enough information to determine that
firmware has done something wrong and globally disable port poweroff.
Signed-off-by: Dan
Commit 9262c19d14c4 usb: disable port power control if not supported in
wHubCharacteristics gated enabling runtime pm for usb_port devices on
whether the parent hub supports power control, which causes a
regression. The port must still be allowed to carry out runtime pm
callbacks and receive a
Reading through a recent bug report [1], Alan notes:
Dan, the warning message in hub_suspend() should mention that the
child device isn't suspended yet.
...update the warning from:
usb usb3-port4: not suspended yet
...to:
usb usb3-port4: device 3-4: not suspended yet
[1]:
On Tue, Jun 17, 2014 at 04:16:16PM -0700, Dan Williams wrote:
Fallout / regression fixes for the port power control rework that landed
in 3.16-rc1.
1/ Cosmetic fix to an error message
2/ Handle ACPI port-location-data conflicts by disabling port power off
rather than spewing a
On Mon, 2014-06-16 at 00:28 +0400, Wahib wrote:
Hi Davidlohr!
Don't worry. I am not discouraged. :)
I understand your concern that the patch feels superficial. It's what the task
asked us to do. I suspect the author(s) of the Eudyptula Challenge designed
this task to get us involved with
On Tue, Jun 17, 2014 at 5:06 PM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Jun 17, 2014 at 04:16:16PM -0700, Dan Williams wrote:
Fallout / regression fixes for the port power control rework that landed
in 3.16-rc1.
1/ Cosmetic fix to an error message
2/ Handle ACPI
On 06/17/2014 10:18 PM, Alan Stern wrote:
That is a strange question to ask. If you did not know that I approved
the patch, why did you insert my Acked-By:?
I added your Acked-By, as when you reviewed V3, you mentioned that I
*may* add your Acked-by in this patch. If I misunderstood your
Hi,
On Tue, Jun 17, 2014 at 04:04:04PM -0700, Barry G wrote:
Hi all,
We have a custom board that has been running on the v3.0 kernel
for a while. Since that kernel version is deprecated we are working
on upgrading to the 3.10 kernel (some products are 3.10-ltsi so trying
3.10 is a pretty
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-msm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-tegra.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ohci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/gr_udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/lpc32xx_udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/lpc32xx_udc.c
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-msm-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-tegra-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
Hi Felipe,
On Fri, Jun 13, 2014 at 11:25 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Fri, Jun 13, 2014 at 09:20:31PM +0900, Yoshihiro Shimoda wrote:
The R-Car H2 and M2 SoCs come with an xHCI controller that requires
some specific initializations related to the firmware downloading and
some
72 matches
Mail list logo
