Re: [PATCH 7/8] phy: helpers for USB ULPI PHY registering

2015-01-30 Thread Felipe Balbi
On Fri, Jan 30, 2015 at 12:33:01PM +0200, Heikki Krogerus wrote: On Thu, Jan 29, 2015 at 10:11:24AM -0600, Felipe Balbi wrote: On Thu, Jan 29, 2015 at 04:34:41PM +0200, Heikki Krogerus wrote: On Wed, Jan 28, 2015 at 11:03:55PM -0600, Felipe Balbi wrote: On Fri, Jan 23, 2015 at 05:12:57PM

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread David Cohen
On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote: Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to ULPI which can. why not ? The BIOS might not need to use the PHY (or USB) at all, it can very well decide to never turn it on,

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread David Cohen
On Fri, Jan 30, 2015 at 10:14:12AM -0600, Felipe Balbi wrote: On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote: Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to ULPI which can. why not ? The BIOS might not need to use the

Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-30 Thread Felipe Balbi
Hi, On Thu, Jan 29, 2015 at 10:23:12AM -0600, Felipe Balbi wrote: On Tue, Jan 27, 2015 at 09:22:50AM -0600, Felipe Balbi wrote: Hi, On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote: These patches add support for XHCI compliant Host controller found on Fujitsu Socs, and

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Robert Jarzmik
Fabio Estevam feste...@gmail.com writes: On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit

[PATCH v3 2/2] usb: phy: generic: fix the vbus interrupt request

2015-01-30 Thread Robert Jarzmik
Declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq requested with handler=NULL and !ONESHOT for irq 63 This was introduced by commit usb: phy: generic: add vbus support.

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Felipe Balbi
On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote: Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to ULPI which can. why not ? The BIOS might not need to use the PHY (or USB) at all, it can very well decide to never turn it on,

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: By using only the usb interface number for the rfkill name, we might have a name conflicts in case two similar hso devices are connected. In this patch, the name of the hso rfkill interface embed the value of a counter that is

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Robert Jarzmik
Fabio Estevam feste...@gmail.com writes: Since the power GPIO is mapped as active-low, its actual signal will be 0 after this code. Contrary to the legacy integer GPIO interface, the active-low property is handled during mapping and is thus transparent to GPIO consumers. ,which is exactly

[PATCH v3 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Robert Jarzmik
All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Tested-by: Fabio Estevam

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Felipe Balbi
On Fri, Jan 30, 2015 at 08:25:23AM -0800, David Cohen wrote: On Fri, Jan 30, 2015 at 10:14:12AM -0600, Felipe Balbi wrote: On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote: Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
On Fri, 2015-01-30 at 17:15 +0100, Olivier Sobrie wrote: Hello Dan, On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote: On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: By using only the usb interface number for the rfkill name, we might have a name conflicts in case

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread David Cohen
On Fri, Jan 30, 2015 at 02:18:42PM +0200, Heikki Krogerus wrote: Hi, What exactly are we breaking here? The USB on BYT-CR does not work yet with the mainline kernel, or does it? To enable it, I already suggested the BYT quirk (attached again). It used to work with mainline with

Re: [PATCH] usb: gadget: OS desc type unicode multi

2015-01-30 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 03:19:57PM +0100, Mario Schuknecht wrote: Add missing case USB_EXT_PROP_UNICODE_MULTI in function fill_ext_prop(). Introduce a separate function which fills a buffer with multiple NULL-terminated Unicode strings. Signed-off-by: Mario Schuknecht

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Olivier Sobrie
Hello Dan, On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote: On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: By using only the usb interface number for the rfkill name, we might have a name conflicts in case two similar hso devices are connected. In this patch, the

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Felipe Balbi
On Fri, Jan 30, 2015 at 08:20:38AM -0800, David Cohen wrote: On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote: Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to ULPI which can. why not ? The BIOS might not need to use the

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Andi Kleen
We don't need any backward compatility, why not fix the broken drivers that are using memory outside of what they are asking for? That's not ok no matter what, right? How would you find them all? We don't even know which place in XHCI is the culprit here. Yes iff you can find them it would

[PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-01-30 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Commit 9eb0797722895f4309b4 (sb: phy: generic: fix the gpios to be optional) calls gpiod_direction_output() in the probe function, so there is no need to call it again, as we can simply call gpiod_set_value() directly. Also, in

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-01-30 Thread Fabio Estevam
Hi Felipe, On Fri, Jan 30, 2015 at 7:59 PM, Felipe Balbi ba...@ti.com wrote: - gpiod_direction_output(nop-gpiod_reset, !asserted); + if (asserted) + goto skip_delay; why skip it ? Let's suppose we have an active-low GPIO USB phy reset pin. In usb_gen_phy_init() we call

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Sergei Shtylyov
On 01/30/2015 10:54 PM, Tim Chen wrote: Commit d92ef66c4f8f (x86: make dma_alloc_coherent() return zeroed memory if CMA is enabled) changed the dma_alloc_coherent page clearance from using an __GFP_ZERO in page allocation to not setting the flag but doing an explicit memory clear at the end.

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Tim Chen
On Fri, 2015-01-30 at 11:58 -0800, Greg KH wrote: Shouldn't this go to stable trees too? Yes. Added the stable tag in updated patch that's resent. Also, why is the xhci driver not asking for the memory it is going to need? If it wants to use the full page, shouldn't it ask for it? I

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Greg KH
On Fri, Jan 30, 2015 at 02:01:58PM -0800, Tim Chen wrote: On Fri, 2015-01-30 at 11:58 -0800, Greg KH wrote: Shouldn't this go to stable trees too? Yes. Added the stable tag in updated patch that's resent. Also, why is the xhci driver not asking for the memory it is going to

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Tim Chen
On Fri, 2015-01-30 at 14:07 -0800, Greg KH wrote: On Fri, Jan 30, 2015 at 02:01:58PM -0800, Tim Chen wrote: On Fri, 2015-01-30 at 11:58 -0800, Greg KH wrote: Shouldn't this go to stable trees too? Yes. Added the stable tag in updated patch that's resent. Also, why is

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Tim Chen
On Sat, 2015-01-31 at 00:03 +0300, Sergei Shtylyov wrote: On 01/30/2015 10:54 PM, Tim Chen wrote: return NULL; } + /* round up to full page size */ + size = (((size-1) PAGE_SHIFT) + 1) * PAGE_SIZE; This is quite suboptimal formula, we can do without shifts

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-01-30 Thread Felipe Balbi
On Fri, Jan 30, 2015 at 07:27:16PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Commit 9eb0797722895f4309b4 (sb: phy: generic: fix the gpios to be optional) calls gpiod_direction_output() in the probe function, so there is no need to call it again, as we can

hello

2015-01-30 Thread Director Western Union Bank
Reply.rtf Description: RTF file

[PATCH] USB: fix use-after-free bug in usb_hcd_unlink_urb()

2015-01-30 Thread Alan Stern
The usb_hcd_unlink_urb() routine in hcd.c contains two possible use-after-free errors. The dev_dbg() statement at the end of the routine dereferences urb and urb-dev even though both structures may have been deallocated. This patch fixes the problem by storing urb-dev in a local variable

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Greg KH
On Fri, Jan 30, 2015 at 11:54:01AM -0800, Tim Chen wrote: Commit d92ef66c4f8f (x86: make dma_alloc_coherent() return zeroed memory if CMA is enabled) changed the dma_alloc_coherent page clearance from using an __GFP_ZERO in page allocation to not setting the flag but doing an explicit memory

hello

2015-01-30 Thread Director Western Union Bank
-- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-30 Thread Tim Chen
Commit d92ef66c4f8f (x86: make dma_alloc_coherent() return zeroed memory if CMA is enabled) changed the dma_alloc_coherent page clearance from using an __GFP_ZERO in page allocation to not setting the flag but doing an explicit memory clear at the end. However the memory clear only covered the

[GIT PULL] USB driver fixes for 3.19-rc7

2015-01-30 Thread Greg KH
The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc: Linux 3.19-rc5 (2015-01-18 18:02:20 +1200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.19-rc7 for you to fetch changes up to

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-01-30 Thread Fabio Estevam
On Fri, Jan 30, 2015 at 8:13 PM, Fabio Estevam feste...@gmail.com wrote: Hi Felipe, On Fri, Jan 30, 2015 at 7:59 PM, Felipe Balbi ba...@ti.com wrote: - gpiod_direction_output(nop-gpiod_reset, !asserted); + if (asserted) + goto skip_delay; why skip it ? Let's suppose

Re: [GIT PULL] USB-serial fixes for v3.19-rc7

2015-01-30 Thread Greg Kroah-Hartman
On Fri, Jan 30, 2015 at 02:04:26PM +0100, Johan Hovold wrote: Hi Greg, Here's a final pull-request for 3.19. Thanks, Johan The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc: Linux 3.19-rc5 (2015-01-18 18:02:20 +1200) are available in the git

Re: [GIT PULL] USB-serial updates for v3.20-rc1

2015-01-30 Thread Greg Kroah-Hartman
On Fri, Jan 30, 2015 at 02:09:18PM +0100, Johan Hovold wrote: Greg, Here are my updates for 3.20. Only two clean ups this time. Thanks, Johan The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc: Linux 3.19-rc5 (2015-01-18 18:02:20 +1200) are available

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
+Thomas (for irq/dummychip.c question) Hi, On 30/01/15 13:09, Roger Quadros wrote: Chanwoo, On 30/01/15 02:06, Chanwoo Choi wrote: Hi Roger, On 01/29/2015 08:26 PM, Roger Quadros wrote: Chanwoo, On 29/01/15 03:49, Chanwoo Choi wrote: Hi Roger, We need to discuss one point about

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
On 30/01/15 02:11, Chanwoo Choi wrote: Hi Roger, On 01/28/2015 09:15 PM, Roger Quadros wrote: This driver observes the USB ID pin connected over a GPIO and updates the USB cable extcon states accordingly. The existing GPIO extcon driver is not suitable for this purpose as it needs to be

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-01-30 Thread Roger Quadros
Hi, On 30/01/15 13:04, Roger Quadros wrote: Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name for USB-Host cable state is USB-Host and not USB-HOST as per drivers/extcon/extcon-class.c extcon_cable_name. Change all instances of USB-HOST to USB-Host.

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-30 Thread Alan Stern
On Fri, 30 Jan 2015, Peter Chen wrote: The chipidea driver is structured in an odd way. It looks like the PCI device combines a host controller and a device controller (and maybe even an OTG controller) into a single device. Any problems for that? No, but it is odd and it requires

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Fabio Estevam
Hi Robert, On Fri, Jan 30, 2015 at 6:02 AM, Robert Jarzmik robert.jarz...@free.fr wrote: Fabio Estevam feste...@gmail.com writes: Why do you set it to zero independently of the GPIO active level flag? I don't. Please have a look at gpiod_direction_output() first, especially : if

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Fabio Estevam
On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. The

Re: [PATCH v3 2/2] chipidea: pci: add comment regarding to ehci-pci driver

2015-01-30 Thread Alexander Shishkin
Andy Shevchenko andriy.shevche...@linux.intel.com writes: The patch points a developer of ChipIdea PCI driver to the bypass_pci_id_table in ehci-pci driver. The table allows to skip a probe stage in ehci-pci for certain IDs. There is no functional change. Signed-off-by: Andy Shevchenko

Re: [PATCH] USB: usbfs: allow URBs to be reaped after disconnection

2015-01-30 Thread Oliver Neukum
On Thu, 2015-01-29 at 12:53 -0500, Alan Stern wrote: On Thu, 29 Jan 2015, Oliver Neukum wrote: On Thu, 2015-01-29 at 11:29 -0500, Alan Stern wrote: The usbfs API has a peculiar hole: Users are not allowed to reap their URBs after the device has been disconnected. There doesn't seem to

Re: [PATCH] usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

2015-01-30 Thread Geert Uytterhoeven
Hi Shimoda-san, On Fri, Jan 30, 2015 at 7:58 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: This patch fixes an issue that the following commit causes NULL pointer dereference in dma_release_channel(). usb: renesas_usbhs: add support for requesting DT DMA (commit id

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Heikki Krogerus
Also, I was chatting in private with David and, apparently, there's a way to request for eye diagram data from BIOS straight. That's more in-line with what we would do for DT-based boots, passing that eye-diagram data as a DT attribute. Care to comment ?

Re: [PATCH v3 1/2] ehci-pci: disable for Intel MID platforms

2015-01-30 Thread Alexander Shishkin
Andy Shevchenko andriy.shevche...@linux.intel.com writes: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes ehci-pci to be ignored in favour of ChipIdea controller. Maybe you should say that this patch adds a

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Heikki Krogerus
Hi, You can't really compare a bus like i2c, which can't enumerate devices natively, to ULPI which can. why not ? The BIOS might not need to use the PHY (or USB) at all, it can very well decide to never turn it on, right ? If ULPI was seen as a bus, then no. BIOS would have definitely

Re: [PATCH 7/8] phy: helpers for USB ULPI PHY registering

2015-01-30 Thread Heikki Krogerus
On Thu, Jan 29, 2015 at 10:11:24AM -0600, Felipe Balbi wrote: On Thu, Jan 29, 2015 at 04:34:41PM +0200, Heikki Krogerus wrote: On Wed, Jan 28, 2015 at 11:03:55PM -0600, Felipe Balbi wrote: On Fri, Jan 23, 2015 at 05:12:57PM +0200, Heikki Krogerus wrote: ULPI PHYs need to be bound to

[PATCH v2 06/12] usb: dwc2: gadget: add unaligned buffers support

2015-01-30 Thread Mian Yousaf Kaukab
When using DMA, dwc2 requires buffers to be 4 bytes aligned. Use bounce buffers if they are not. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/core.h | 2 ++

[PATCH v2 04/12] usb: dwc2: gadget: fix a typo in comment

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com s3c_hsotg_process_req_feature comments was not correct Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Gregory Herrero gregory.herr...@intel.com --- drivers/usb/dwc2/gadget.c | 2 +- 1 file

[PATCH v2 02/12] usb: dwc2: gadget: fix clear halt feature handling

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com When clearing HALT on an endpoint, req-complete of in progress requests must be called with locks off. New request should only be started if there is not already a pending request on the endpoint. Tested-by: Robert Baldyga r.bald...@samsung.com

[PATCH v2 00/12] usb: second series of updates for dwc2 driver

2015-01-30 Thread Mian Yousaf Kaukab
Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches are verified on dwc2 v3.0a with dedicated fifos. Main focus of testing was with dma enabled. Although basic testing without dma was also done. This is based on testing/next

[PATCH v2 03/12] usb: dwc2: gadget: add TEST_MODE feature support

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Handle SET_FEATURE TEST_MODE request sent by the host. Slightly rework FEATURE request handling to allow parsing other request types than Endpoint. Also add a debugfs to change test mode value from user space. Tested-by: Robert Baldyga

[PATCH v2 01/12] usb: dwc2: host: resume root hub on remote wakeup

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com When a remote wakeup happens during bus_suspend, hcd needs to resume its root hub. Acked-by: John Youn johny...@synopsys.com Signed-off-by: Gregory Herrero gregory.herr...@intel.com --- drivers/usb/dwc2/hcd.c | 6 -- 1 file changed, 4

[PATCH v2 09/12] usb: dwc2: gadget: fix debug message for zlp

2015-01-30 Thread Mian Yousaf Kaukab
Print debug message according to zlp direction. Always saying Sending is misleading. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 7 ++- 1 file changed, 6

[PATCH v2 07/12] usb: dwc2: gadget: add reset flag in init function

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Add a flag to request physical reset of the controller when s3c_hsotg_core_init_disconnected is called. During the usb reset, controller must not be fully reconfigured and resetted. Else this leads to shorter chirp-k duration during enumeration.

[PATCH v2 12/12] usb: dwc2: gadget: initialize controller in pullup callback

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com USB reset interrupt is no more used to reset the controller. Thus, reset the controller in pullup callback as described by Synopsys programming guide. Otherwise enumeration sometimes fails when usb configuration is switched without physical

[PATCH v2 08/12] usb: dwc2: gadget: don't modify pullup status during reset

2015-01-30 Thread Mian Yousaf Kaukab
From: Gregory Herrero gregory.herr...@intel.com Pullup doesn't need to be enabled during usb reset since it is already enabled. This leads to shorter chirp-k duration if done during usb reset. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com

[PATCH v2 11/12] usb: dwc2: gadget: replace constants with defines

2015-01-30 Thread Mian Yousaf Kaukab
Defines are more readable and searchable than constants. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 24 drivers/usb/dwc2/hw.h | 1

[PATCH v2 10/12] usb: dwc2: gadget: fix phy interface configuration

2015-01-30 Thread Mian Yousaf Kaukab
hsotg-phyif is set in dwc2_gadget_init according to phy interface width. Use it for configuration instead of hardcoded value. Moreover, set USB turnaround time according to phy width. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Mian

[PATCH v2 05/12] usb: dwc2: gadget: remove hardcoded if (0) and if (1) checks

2015-01-30 Thread Mian Yousaf Kaukab
Remove dead code as well. Tested-by: Robert Baldyga r.bald...@samsung.com Acked-by: John Youn johny...@synopsys.com Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com --- drivers/usb/dwc2/gadget.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

2015-01-30 Thread Robert Jarzmik
Fabio Estevam feste...@gmail.com writes: Why do you set it to zero independently of the GPIO active level flag? I don't. Please have a look at gpiod_direction_output() first, especially : if (test_bit(FLAG_ACTIVE_LOW, desc-flags)) ,which correctly puts the GPIO output to the correct

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
On 29/01/15 18:56, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [150129 03:34]: On 28/01/15 19:09, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [150128 04:15]: On 28/01/15 04:19, Chanwoo Choi wrote: I still fail to understand that we need to call disable_irq() in .suspend() and

[PATCH v2 08/11] hso: move tty_unregister outside hso_serial_common_free()

2015-01-30 Thread Olivier Sobrie
The function hso_serial_common_free() is called either by the cleanup method of the tty or by the usb disconnect method. In the former case, the usb_disconnect() has been already called and the sysfs group associated to the device has been removed. By calling tty_unregister directly from the

[PATCH v2 05/11] hso: fix small indentation error

2015-01-30 Thread Olivier Sobrie
Simply remove the useless extra tab. Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a49ac2e..2f2343d 100644 --- a/drivers/net/usb/hso.c +++

[GIT PULL] USB-serial updates for v3.20-rc1

2015-01-30 Thread Johan Hovold
Greg, Here are my updates for 3.20. Only two clean ups this time. Thanks, Johan The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc: Linux 3.19-rc5 (2015-01-18 18:02:20 +1200) are available in the git repository at:

Re: [PATCH] usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

2015-01-30 Thread Simon Horman
On Fri, Jan 30, 2015 at 03:58:23PM +0900, Yoshihiro Shimoda wrote: This patch fixes an issue that the following commit causes NULL pointer dereference in dma_release_channel(). usb: renesas_usbhs: add support for requesting DT DMA (commit id abd2dbf6bb1b5f3a03a8c76b1a8879da1dd30caa) The

Re: usb-storage URB use-after-free

2015-01-30 Thread Joe Lawrence
On Thu, 29 Jan 2015 11:42:18 -0500 Alan Stern st...@rowland.harvard.edu wrote: On Wed, 28 Jan 2015, Joe Lawrence wrote: This one should have gone over to linux-usb. -- Joe On 01/28/2015 05:04 PM, Joe Lawrence wrote: Hello linux-usb, We've hit a USB use-after-free on

[GIT PULL] USB-serial fixes for v3.19-rc7

2015-01-30 Thread Johan Hovold
Hi Greg, Here's a final pull-request for 3.19. Thanks, Johan The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc: Linux 3.19-rc5 (2015-01-18 18:02:20 +1200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git

Re: [PATCH v2 2/7] usb: extcon: Fix USB-Host cable name

2015-01-30 Thread Roger Quadros
Felipe Chanwoo, On 26/01/15 14:15, Roger Quadros wrote: The recommended name for USB-Host cable state is USB-Host and not USB-HOST as per drivers/extcon/extcon-class.c extcon_cable_name. Change all instances of USB-HOST to USB-Host. Signed-off-by: Roger Quadros rog...@ti.com

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-30 Thread Heikki Krogerus
Hi, What exactly are we breaking here? The USB on BYT-CR does not work yet with the mainline kernel, or does it? To enable it, I already suggested the BYT quirk (attached again). It used to work with mainline with minor restrictions. It stopped working (and I failed to catch it

[PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Olivier Sobrie
By using only the usb interface number for the rfkill name, we might have a name conflicts in case two similar hso devices are connected. In this patch, the name of the hso rfkill interface embed the value of a counter that is incremented each time a new rfkill interface is added. Suggested-by:

[PATCH v2 10/11] hso: add missing cancel_work_sync in disconnect()

2015-01-30 Thread Olivier Sobrie
For hso serial devices, two cancel_work_sync were missing in the disconnect method. Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c916ab5..c14fc80 100644 ---

[PATCH v2 09/11] hso: update serial_table in usb disconnect method

2015-01-30 Thread Olivier Sobrie
The serial_table is used to map the minor number of the usb serial device to its associated context. The table is updated in the probe method and in hso_serial_ref_free() which is called either from the tty cleanup method or from the usb disconnect method. This patch ensures that the serial_table

[PATCH v2 07/11] hso: replace reset_device work by usb_queue_reset_device()

2015-01-30 Thread Olivier Sobrie
There is no need for a dedicated reset work in the hso driver since there is already a reset work foreseen in usb_interface that does the same. Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 25 + 1 file changed, 1 insertion(+), 24

[PATCH v2 06/11] hso: rename hso_dev into serial in hso_free_interface()

2015-01-30 Thread Olivier Sobrie
In other functions of the driver, variables of type struct hso_serial are denoted by serial and variables of type struct hso_device are denoted by hso_dev. This patch makes the hso_free_interface() consistent with these notations. Signed-off-by: Olivier Sobrie oliv...@sobrie.be ---

Re: [PATCH v3 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-30 Thread Roger Quadros
Chanwoo, On 30/01/15 02:06, Chanwoo Choi wrote: Hi Roger, On 01/29/2015 08:26 PM, Roger Quadros wrote: Chanwoo, On 29/01/15 03:49, Chanwoo Choi wrote: Hi Roger, We need to discuss one point about 'id_irqwake'. I don't recommend to use 'id_irqwake' field. And I catch build warning by

[PATCH v2 00/11] hso: fix some problems in the disconnect path

2015-01-30 Thread Olivier Sobrie
These patches attempt to fix some problems I observed when the hso device is disconnected. Several patches of this serie are fixing crashes or memleaks when a hso device is disconnected. This serie of patches is based on v3.18. changes in v2: - Last patch of the serie dropped since another patch

[PATCH v2 02/11] hso: fix crash when device disappears while serial port is open

2015-01-30 Thread Olivier Sobrie
When the device disappear, the function hso_disconnect() is called to perform cleanup. In the cleanup function, hso_free_interface() calls tty_port_tty_hangup() in view of scheduling a work to hang up the tty if needed. If the port was not open then hso_serial_ref_free() is called directly to

[PATCH v2 01/11] hso: remove useless header file timer.h

2015-01-30 Thread Olivier Sobrie
No timer related function is used in this driver. Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index babda7d..cb0bcc1 100644 --- a/drivers/net/usb/hso.c +++

[PATCH v2 03/11] hso: fix memory leak when device disconnects

2015-01-30 Thread Olivier Sobrie
In the disconnect path, tx_buffer should freed like tx_data to avoid a memory leak when the device disconnects. Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index

[PATCH v2 04/11] hso: fix memory leak in hso_create_rfkill()

2015-01-30 Thread Olivier Sobrie
When the rfkill interface was created, a buffer containing the name of the rfkill node was allocated. This buffer was never freed when the device disappears. To fix the problem, we put the name given to rfkill_alloc() in the hso_net structure. Signed-off-by: Olivier Sobrie oliv...@sobrie.be ---