linux/uaccess.h was originally being pulled
indirectly through some other header, however
it's not anymore, so we need to include it
directly
Reported-by: Jim Davis jim.ep...@gmail.com
Suggested-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Felipe Balbi ba...@ti.com
---
On Thu, Aug 06, 2015 at 03:03:48PM +0800, Baolin Wang wrote:
This patch introduces the usb charger driver based on usb gadget that
makes an enhancement to a power driver. It works well in practice but
that requires a system with suitable hardware.
The basic conception of the usb charger is
On Thu, Aug 06, 2015 at 11:21:22AM -0500, Felipe Balbi wrote:
Hi,
On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided
Hi folks,
if your patches aren't in my tree yet, it's too late, sorry.
We have a total of 145 non-merge commits, here's dirstat:
$ git diff --dirstat next ^cbfe8fa6cd67 | sort -rn
21.0% drivers/usb/gadget/udc/
19.9% drivers/usb/musb/
12.9% drivers/usb/phy/
11.7%
On Thu, Aug 06, 2015 at 10:37:11AM +0300, Mathias Nyman wrote:
On 06.08.2015 02:29, Greg KH wrote:
On Thu, Aug 06, 2015 at 09:13:12AM +1000, Gavin Shan wrote:
On Mon, Jul 27, 2015 at 12:08:05PM +1000, Gavin Shan wrote:
When xhci_mem_cleanup() is called, it's possible that the command
timer
* Kishon Vijay Abraham I kis...@ti.com [150805 07:28]:
Hi Roger,
On Wednesday 05 August 2015 01:38 PM, Roger Quadros wrote:
On 05/08/15 11:02, Roger Quadros wrote:
Kishon,
On 04/08/15 18:30, Kishon Vijay Abraham I wrote:
Add syscon-otghs property and remove the deprecated ctrl-module
* Kishon Vijay Abraham I kis...@ti.com [150805 07:10]:
On Wednesday 05 August 2015 01:31 PM, Tony Lindgren wrote:
We don't have syscon-otghs and to me it seems we need a PHY driver
as I pointed out at:
If *syscon-otghs* is not present, then it'll fall-back to using the
*ctrl-module*.
Hi Alan,
On Wed, Aug 5, 2015 at 7:15 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Wed, 5 Aug 2015, Greg KH wrote:
hm, wait, is this really the n_gsm line discipline? Or is it something
else?
g_serial is the device side of a serial connection, there is no cable
removed notification
This patch introduces the usb charger driver based on usb gadget that
makes an enhancement to a power driver. It works well in practice but
that requires a system with suitable hardware.
The basic conception of the usb charger is that, when one usb charger
is added or removed by reporting from
On 7 August 2015 at 00:39, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Aug 06, 2015 at 03:03:48PM +0800, Baolin Wang wrote:
This patch introduces the usb charger driver based on usb gadget that
makes an enhancement to a power driver. It works well in practice but
that requires a system
On Thu, Aug 06, 2015 at 03:09:54PM +0200, Tomeu Vizoso wrote:
If usbmisc hasn't probed yet, defer the probe.
It's not enough to check if the platform device for the OF node of the
usbmisc has been registered, but it also needs to have been probed
already before we can call
On Fri, Aug 07, 2015 at 10:11:47AM +0800, Peter Chen wrote:
On Thu, Aug 06, 2015 at 03:09:54PM +0200, Tomeu Vizoso wrote:
If usbmisc hasn't probed yet, defer the probe.
It's not enough to check if the platform device for the OF node of the
usbmisc has been registered, but it also needs
On Wed, Aug 5, 2015 at 6:09 PM, Peter Stuge pe...@stuge.se wrote:
Greg KH wrote:
int fd = open(/dev/ttyGS0, O_RDWR | O_NONBLOCK);
This line discipline is very different from the traditional tty
line discipline
..
this is a character device, with a very specific line discipline
Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided by PMICs meaning that either vendors must add this in their kernels
or USB gadget devices based on Linux (such as mobile phones) may not
On Wed, Aug 5, 2015 at 5:29 PM, Greg KH g...@kroah.com wrote:
On Wed, Aug 05, 2015 at 04:40:21PM +0100, Laszlo Papp wrote:
On Wed, Aug 5, 2015 at 3:56 PM, Greg KH g...@kroah.com wrote:
On Wed, Aug 05, 2015 at 11:05:56AM +0100, Laszlo Papp wrote:
Hi,
The code below reproduces the issue.
The usb charger framework is based on usb gadget, and each usb gadget
can be one usb charger to set the current limitation.
This patch adds a notifier mechanism for usb charger to report to usb
charger when the usb gadget state is changed.
Also we introduce a callback 'get_charger_type' which
On 8/6/2015 10:58 AM, Robert Baldyga wrote:
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform
Hi Felipe,
These are remaining patches of my series plus one which remained from
series [1].
[1] usb: gadget: get rid of UDC name-based quirks
https://lkml.org/lkml/2015/7/28/29
Best regards,
Robert Baldyga
Changelog:
v8:
- addressed comments from Sergei Shtylyov
v7:
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
This header file contains helpers for quirks based on UDC controller name.
Since we have generic quirk bitfields in usb_gadget structure for all of
these quirks we don't need to have this header any longer.
This patch removes gadget_chips.h file and makes sure that it's no longer
included
Rework ep_matches() function to make it shorter and more readable.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/epautoconf.c | 81 -
1 file changed, 32 insertions(+), 49 deletions(-)
diff --git
Add callback that is called by epautoconf to allow UDC driver match the
best endpoint for specific descriptor. It's intended to supply mechanism
which allows to get rid of chip-specific endpoint matching code from
epautoconf.
If gadget has set 'ep_match' callback we prefer to call it first, and
Dear Alan
sorry for late reply.
This patch has been difficult to coordinate because it affects exactly
the same code as another recent fix (I really goofed when writing the
977dcfdc6031 commit). Here's my version of it, based on Greg's
usb-linus branch as of about a week ago; the topmost commit
Hello.
On 8/6/2015 10:58 AM, Robert Baldyga wrote:
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
Move ep_matches() function to udc-core and rename it to
usb_gadget_ep_match_desc(). This function can be used by UDC drivers
in 'match_ep' callback to avoid writing lots of repetitive code.
Replace all calls of ep_matches() with usb_gadget_ep_match_desc().
Signed-off-by: Robert Baldyga
Move find_ep() to udc-core and rename it to gadget_find_ep_by_name().
It can be used in UDC drivers, especially in 'match_ep' callback after
moving chip-specific endpoint matching logic from epautoconf to UDC
drivers.
Replace all calls of find_ep() function with gadget_find_ep_by_name().
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
On Thu, Aug 06, 2015 at 09:39:05AM -0700, Greg KH wrote:
On Thu, Aug 06, 2015 at 03:03:48PM +0800, Baolin Wang wrote:
+static void usb_charger_release(struct device *dev)
+{
+ struct usb_charger *uchger = dev_get_drvdata(dev);
+ if (!atomic_dec_and_test(uchger-count)) {
+
On Thu, 6 Aug 2015, Laszlo Papp wrote:
Hi Alan,
On Wed, Aug 5, 2015 at 7:15 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Wed, 5 Aug 2015, Greg KH wrote:
hm, wait, is this really the n_gsm line discipline? Or is it something
else?
g_serial is the device side of a serial
On Thu, Aug 6, 2015 at 2:52 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 6 Aug 2015, Laszlo Papp wrote:
Hi Alan,
On Wed, Aug 5, 2015 at 7:15 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Wed, 5 Aug 2015, Greg KH wrote:
hm, wait, is this really the n_gsm line discipline?
On Thu, 6 Aug 2015, Laszlo Papp wrote:
You should also add a printk statement to the disconnect callback so
that you can verify whether it really is getting called.
Thanks. Should that also be called if I just boot up the board with
Linux on it while the cable is not attached.
No. It
Mathias,
Does changing the delay time in the busyloop make a difference?
We have found that this was a hardware problem in our design.
-jfs
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Felipe,
These are remaining patches of my series plus one which remained from
series [1].
In this version of this patch set I have changed gadget_find_ep_by_name()
to exported symbol, as Alan suggested.
[1] usb: gadget: get rid of UDC name-based quirks
https://lkml.org/lkml/2015/7/28/29
Incoming packets in high speed are randomly corrupted by h/w
resulting in multiple errors. This workaround makes FS as
default mode in all affected socs by disabling HS chirp
signalling.This errata does not affect FS and LS mode.
Forces all HS devices to connect in FS mode for all socs
affected
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
Add callback that is called by epautoconf to allow UDC driver match the
best endpoint for specific descriptor. It's intended to supply mechanism
which allows to get rid of chip-specific endpoint matching code from
epautoconf.
If gadget has set 'ep_match' callback we prefer to call it first, and
Move ep_matches() function to udc-core and rename it to
usb_gadget_ep_match_desc(). This function can be used by UDC drivers
in 'match_ep' callback to avoid writing lots of repetitive code.
Replace all calls of ep_matches() with usb_gadget_ep_match_desc().
Signed-off-by: Robert Baldyga
Move find_ep() to udc-core and rename it to gadget_find_ep_by_name().
It can be used in UDC drivers, especially in 'match_ep' callback after
moving chip-specific endpoint matching logic from epautoconf to UDC
drivers.
Replace all calls of find_ep() function with gadget_find_ep_by_name().
Rework ep_matches() function to make it shorter and more readable.
Signed-off-by: Robert Baldyga r.bald...@samsung.com
---
drivers/usb/gadget/epautoconf.c | 81 -
1 file changed, 32 insertions(+), 49 deletions(-)
diff --git
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
This header file contains helpers for quirks based on UDC controller name.
Since we have generic quirk bitfields in usb_gadget structure for all of
these quirks we don't need to have this header any longer.
This patch removes gadget_chips.h file and makes sure that it's no longer
included
Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching
process. Function does the same that was done by chip-specific code inside
of epautoconf. Now this code can be removed from there to separate generic code
from platform specific logic.
Signed-off-by: Robert Baldyga
Hey Hans,
I've tried getting your musb stuff working on a cubietruck, but i don't
seem to see this patch on your linux-sunxi/sunxi-wip branch on github?
Is your github branch fully functional at the moment?
What I have done so far, is build the kernel using sunxi_defconfig and
enabled
2015-07-07 14:28 GMT+03:00 Evgen Druzhynin evgen.druzhy...@gmail.com:
2015-07-07 14:06 GMT+03:00 Johan Hovold jo...@kernel.org:
I'll try to find exact kernel version where issue was introduced ASAP.
Hi all,
Root cause is chinese Arduino board (ID 1a86:7523 QinHeng Electronics
HL-340 USB-Serial
[ +cc Felipe ]
Hi Laszlo,
On 08/06/2015 10:03 AM, Laszlo Papp wrote:
On Thu, Aug 6, 2015 at 2:52 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 6 Aug 2015, Laszlo Papp wrote:
On Wed, Aug 5, 2015 at 7:15 PM, Alan Stern st...@rowland.harvard.edu
wrote:
On Wed, 5 Aug 2015, Greg KH
Building with the attached random configuration file,
drivers/usb/gadget/function/f_mass_storage.c: In function ‘fsg_main_thread’:
drivers/usb/gadget/function/f_mass_storage.c:2520:2: error: implicit
declaration of function ‘set_fs’
[-Werror=implicit-function-declaration]
set_fs(get_ds());
^
On Thu, Aug 6, 2015 at 4:16 PM, Peter Hurley pe...@hurleysoftware.com wrote:
[ +cc Felipe ]
Hi Laszlo,
On 08/06/2015 10:03 AM, Laszlo Papp wrote:
On Thu, Aug 6, 2015 at 2:52 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 6 Aug 2015, Laszlo Papp wrote:
On Wed, Aug 5, 2015 at 7:15
Hi Greg
There xhci patches for usb-next include support for a couple new xhci 1.1
features, support for zero packet bulk transfers and some other minor
changes
-Mathias
Lu Baolu (2):
xhci: xHCI 1.1: Contiguous Frame ID Capability (CFC)
xhci: xHCI 1.1: Stopped - Short Packet Capability (SPC)
From: Lu Baolu baolu...@linux.intel.com
This patch enables xhci driver to support SPC by handling
Stopped - Short Packet event in transfer event path.
If SPC = '1' and the stop endpoint command is executed, after a Short
Packet condition has been detected, but before the end of the TD has been
From: Lu Baolu baolu...@linux.intel.com
If the Contiguous Frame ID Capability is supported (CFC = 1),
then the xHC shall match the Frame ID in every Isoch TD with
SIA = 0 against the Frame Index of the MFINDEX register. This
rule ensures resynchronization of Isoch TDs even if some are
dropped due
Hi,
On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided by PMICs meaning that either vendors must add this in their kernels
From: Rafał Miłecki zaj...@gmail.com
Right now xhci-plat-hcd can be built when using one of platform specific
drivers only (mvebu/rcar). There shouldn't be such limitation as some
platforms may not require any quirks and may want to just use a generic
driver (generic-xhci / xhci-hcd).
From: Saurabh Karajgaonkar skara...@visteon.com
Replace redundant variable use in return statement.
Signed-off-by: Saurabh Karajgaonkar skara...@visteon.com
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
---
drivers/usb/host/xhci.c | 6 +-
1 file changed, 1 insertion(+), 5
From: Reyad Attiyat reyad.atti...@gmail.com
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
Signed-off-by: Mathias Nyman
On 06.08.2015 02:29, Greg KH wrote:
On Thu, Aug 06, 2015 at 09:13:12AM +1000, Gavin Shan wrote:
On Mon, Jul 27, 2015 at 12:08:05PM +1000, Gavin Shan wrote:
When xhci_mem_cleanup() is called, it's possible that the command
timer isn't initialized and scheduled. For those cases, to delete
the
g_nokia now has mass_storage function, so it should
depend on CONFIG_BLOCK.
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/usb/gadget/legacy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/legacy/Kconfig
b/drivers/usb/gadget/legacy/Kconfig
index
On Thu, 6 Aug 2015, Jim Davis wrote:
Building with the attached random configuration file,
drivers/usb/gadget/function/f_mass_storage.c: In function ‘fsg_main_thread’:
drivers/usb/gadget/function/f_mass_storage.c:2520:2: error: implicit
declaration of function ‘set_fs’
Hi,
On 06-08-15 10:22, Olliver Schinagl wrote:
Hey Hans,
I've tried getting your musb stuff working on a cubietruck, but i don't seem to
see this patch on your linux-sunxi/sunxi-wip branch on github? Is your github
branch fully functional at the moment?
What I have done so far, is build the
Commit fb91cddc54e7 (usb: musb: Remove DMA
ifdef for musb_gadget.c short_packet) tried
to remove DMA ifdeferry from musb_gadget.c
but ended up leaving some around.
Remove them so that when building kernels with
all DMA engines enabled, we don't end up trying
to allocte channels twice.
since commit 33c300cb90a6 (usb: musb: dsps:
don't fake of_node to musb core) we have been
preventing CPPI 4.1 from probing due to NULL
of_node. We can't revert said commit otherwise
a different regression would show up, so the fix
is to look for the parent device's (glue layer's)
of_node instead,
61 matches
Mail list logo
