Re: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

On 11/6/2015 9:55 AM, Felipe Balbi wrote: > > Hi, > > "McCauley, Ben" writes: >> Felipe, >> >> -Original Message- >> From: Felipe Balbi [mailto:ba...@ti.com] >> Sent: Friday, November 06, 2015 10:06 AM >> To: McCauley, Ben >> Cc:

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

Alan, On Fri, Nov 6, 2015 at 7:40 AM, Alan Stern wrote: > On Thu, 5 Nov 2015, Doug Anderson wrote: > >> Alan, >> >> On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: >> > On Wed, 4 Nov 2015, Doug Anderson wrote: >> > >> >> In the ChromeOS

[PATCH v2 1/4] usb: dwc2: rockchip: Make the max_transfer_size automatic

Previously we needed to set the max_transfer_size to explicitly be 65535 because the old driver would detect that our hardware could support much bigger transfers and then would try to do them. This wouldn't work since the DMA alignment code couldn't support it. Later in commit e8f8c14d9da7

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

lyz@, On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: > Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN > packet between SSPLIT-begin and SSPLIT-end. > > Signed-off-by: Yunzhi Li > --- > drivers/usb/dwc2/hcd.c | 4 > 1 file

[RFC PATCH] usb: dwc2: host: Rewrite the microframe scheduler

The old microframe scheduler was terribly hard to follow and (it seemed to me) that it had some bugs in it. Let's re-write it in a simpler, easier-to-read way. Hopefully this will work better. Note: no known problems are fixed by this patch, and in fact I can see very little impact of the

[PATCH v2 4/4] usb: dwc2: host: Giveback URB in tasklet context

In commit 94dfd7edfd5c ("USB: HCD: support giveback of URB in tasklet context") support was added to give back the URB in tasklet context. Let's take advantage of this in dwc2. This speeds up the dwc2 interrupt handler considerably. Note that this requires the change ("usb: dwc2: host: Add a

[PATCH v2 2/4] usb: dwc2: host: Get aligned DMA in a more supported way

All other host controllers who want aligned buffers for DMA do it a certain way. Let's do that too instead of working behind the USB core's back. This makes our interrupt handler not take forever and also rips out a lot of code, simplifying things a bunch. This also has the side effect of

[PATCH v2 0/4] dwc2: Speed up the interrupt handler quite a bit

The dwc2 interrupt handler is quite slow. On rk3288 with a few things plugged into the ports and with cpufreq locked at 696MHz (to simulate real world idle system), I can easily observe dwc2_handle_hcd_intr() taking > 120 us, sometimes > 150 us. Note that SOF interrupts come every 125 us with

[PATCH v2 3/4] usb: dwc2: host: Add a delay before releasing periodic bandwidth

We'd like to be able to use HCD_BH in order to speed up the dwc2 host interrupt handler quite a bit. However, according to the kernel doc for usb_submit_urb() (specifically the part about "Reserved Bandwidth Transfers"), we need to keep a reservation active as long as a device driver keeps

Re: USB scanner stops working with xhci_hcd URB transfer length is wrong, xHC issue? req. len = 0, act. len = 4294967288

On 11/06/2015 10:34 AM, Felipe Balbi wrote: Hi, Orion Poplawski writes: See https://bugzilla.kernel.org/show_bug.cgi?id=107331 Trying to use my scanner. Worked for a while, but now access fails. Get this in log: okay, first things first. Which kernel version are you

Re: [PATCH 03/23] usb: gadget: f_sourcesink: free requests in sourcesink_disable()

On Tue, Nov 03, 2015 at 01:53:42PM +0100, Robert Baldyga wrote: > USB requests in SourceSink function are allocated in sourcesink_get_alt() > function, so we prefer to free them rather in sourcesink_disable() than > in source_sink_complete() when request is completed with error. It provides >

Re: [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB

On Fri, Nov 06, 2015 at 12:04:06AM -0600, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross > --- > drivers/usb/chipidea/ci_hdrc_msm.c |3 ++- > 1 file changed, 2

Re: [PATCH 03/23] usb: gadget: f_sourcesink: free requests in sourcesink_disable()

On 11/06/2015 10:48 AM, Peter Chen wrote: On Fri, Nov 06, 2015 at 09:50:11AM +0100, Robert Baldyga wrote: On 11/06/2015 09:15 AM, Peter Chen wrote: On Tue, Nov 03, 2015 at 01:53:42PM +0100, Robert Baldyga wrote: USB requests in SourceSink function are allocated in sourcesink_get_alt()

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

hi John , As we talked yesterday, I tried to fix the split schedule sequence. This patch will avoid scheduling SSPLIT-IN packet for another device between SSPLIT-OUT-begin and SSPLIT-OUT-end, now the keyboard and Jebra audio speaker could work together well, but I'm not sure if this is

Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB

On 11/06/2015 08:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross With these patches I see significant improvement in throughput on my db410c board. Tested-by:

Re: [PATCH 2/2] USB: serial: Another Infineon flash loader USB ID

Hi Jonas, 2015-11-05 13:57 GMT+01:00 Jonas Jonsson : > This has been seen on a Telit UE910 modem. > > Signed-off-by: Jonas Jonsson > --- > drivers/usb/serial/usb-serial-simple.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 03/23] usb: gadget: f_sourcesink: free requests in sourcesink_disable()

On 11/06/2015 09:15 AM, Peter Chen wrote: > On Tue, Nov 03, 2015 at 01:53:42PM +0100, Robert Baldyga wrote: >> USB requests in SourceSink function are allocated in sourcesink_get_alt() >> function, so we prefer to free them rather in sourcesink_disable() than >> in source_sink_complete() when

Re: [PATCH 03/23] usb: gadget: f_sourcesink: free requests in sourcesink_disable()

On Fri, Nov 06, 2015 at 09:50:11AM +0100, Robert Baldyga wrote: > On 11/06/2015 09:15 AM, Peter Chen wrote: > > On Tue, Nov 03, 2015 at 01:53:42PM +0100, Robert Baldyga wrote: > >> USB requests in SourceSink function are allocated in sourcesink_get_alt() > >> function, so we prefer to free them

Re: [PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

Hi Doug, On Thu, Nov 05, 2015 at 04:32:46PM -0800, Doug Anderson wrote: > Hi, > > On Thu, Nov 5, 2015 at 12:41 AM, Gregory Herrero > wrote: > > Hi, > > > > This patchset contains bug fixes for host descriptor dma mode. > > > > Descriptor dma mode can't be used as the

[RFC] usb: dwc2: hcd: fix split schedule issue

Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN packet between SSPLIT-begin and SSPLIT-end. Signed-off-by: Yunzhi Li --- drivers/usb/dwc2/hcd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index

Re: [PATCH v5 3/5] gadget: Support for the usb charger framework

Hi Baolin, [auto build test WARNING on v4.3-rc7] [also build test WARNING on next-20151106] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-usb-charger-framework-to-deal-with-the-usb-gadget-power-negotation/20151106-194008 reproduce: make htmldocs All warnings (new ones

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

Hello. On 11/06/2015 12:44 AM, Felipe Balbi wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

On 11/06/2015 01:08 PM, Felipe Balbi wrote: Hi, Bin Liu writes: Hi, On 11/06/2015 11:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. Commit 20357720 claims throughput improvement for MSC/UVC,

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

On Fri, 6 Nov 2015, Bin Liu wrote: > This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. > > Commit 20357720 claims throughput improvement for MSC/UVC, but I > don't see much improvement. Following are the MSC measurement using > dd on AM335x GP EVM. > > with BCD_BH:read:

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

Hi, Bin Liu writes: > Hi, > > On 11/06/2015 11:56 AM, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >>> This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. >>> >>> Commit 20357720 claims throughput improvement for MSC/UVC, but I >>> don't see much

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

Hi, On 11/06/2015 01:23 PM, Alan Stern wrote: On Fri, 6 Nov 2015, Bin Liu wrote: This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. Commit 20357720 claims throughput improvement for MSC/UVC, but I don't see much improvement. Following are the MSC measurement using dd on AM335x GP

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

On Thu, 5 Nov 2015, Doug Anderson wrote: > Alan, > > On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > > On Wed, 4 Nov 2015, Doug Anderson wrote: > > > >> In the ChromeOS gerrit > >> Julius Werner > >> points

Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB

On Fri, 6 Nov 2015, Georgi Djakov wrote: > On 11/06/2015 08:04 AM, Andy Gross wrote: > > This patch sets the AHBMODE to allow for posted data writes. This > > results in higher performance. > > > > Signed-off-by: Andy Gross > > With these patches I see significant

Re: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

Hi, "McCauley, Ben" writes: > The max speed was always being set to USB_SUPER_SPEED > even when the phy was only capable of HIGH_SPEED. This this statement is untrue > uses the value set for the phy to set the max for the > gadget. It resolves an issue with Window PCs

[PATCH] USB: DCW3: GADGET: Set Correct Max Speed

The max speed was always being set to USB_SUPER_SPEED even when the phy was only capable of HIGH_SPEED. This uses the value set for the phy to set the max for the gadget. It resolves an issue with Window PCs where they report that using a USB3.0 port would result in better performance even when

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

Hi, On 11/05/2015 03:44 PM, Felipe Balbi wrote: Hi, Bin Liu writes: Hi, On 11/05/2015 03:07 PM, Felipe Balbi wrote: Hi again, Felipe Balbi writes: Hi, Sergei Shtylyov writes: On 11/05/2015 11:34 PM, Bin Liu wrote:

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

Hi, Bin Liu writes: > I would also add a very verbose and descriptive comment on that > particular location so we never forget about these MUSB oddities next > time someone's looking at this. Also, leave the WARN() alone. We don't want FIFOFLUSH to ever fail.

[PATCH v3] usb: musb: fix tx fifo flush handling

Here are a few changes in musb_h_tx_flush_fifo(). - It has been observed that sometimes (if not always) musb is unable to flush tx fifo during urb dequeue when disconnect a device. But it seems to be harmless, since the tx fifo flush is done again in musb_ep_program() when re-use the hw_ep.

Re: [PATCH v5 1/5] gadget: Introduce the notifier functions

On Fri, Nov 06, 2015 at 07:35:10PM +0800, Baolin Wang wrote: > The usb charger framework is based on usb gadget. The usb charger > need to be notified the state changing of usb gadget to confirm the > usb charger state. > > Thus this patch adds a notifier mechanism for usb gadget to report a >

Re: [PATCH v3] usb: musb: fix tx fifo flush handling

Hi, Bin Liu writes: > Here are a few changes in musb_h_tx_flush_fifo(). > > - It has been observed that sometimes (if not always) musb is unable > to flush tx fifo during urb dequeue when disconnect a device. But > it seems to be harmless, since the tx fifo flush is done again

Re: [PATCH v5 5/5] power: wm831x_power: Support USB charger current limit management

Hi Baolin, [auto build test ERROR on v4.3-rc7] [also build test ERROR on next-20151106] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-usb-charger-framework-to-deal-with-the-usb-gadget-power-negotation/20151106-194008 config: i386-allmodconfig (attached as .config

Re: [PATCH v5 1/5] gadget: Introduce the notifier functions

Hi Baolin, [auto build test WARNING on v4.3-rc7] [also build test WARNING on next-20151106] url: https://github.com/0day-ci/linux/commits/Baolin-Wang/Introduce-usb-charger-framework-to-deal-with-the-usb-gadget-power-negotation/20151106-194008 reproduce: make htmldocs All warnings (new ones

Re: USB scanner stops working with xhci_hcd URB transfer length is wrong, xHC issue? req. len = 0, act. len = 4294967288

Hi, Orion Poplawski writes: > See https://bugzilla.kernel.org/show_bug.cgi?id=107331 > > Trying to use my scanner. Worked for a while, but now access fails. Get this > in log: okay, first things first. Which kernel version are you using ? Care to capture a usbmon trace ?

[PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

added iounmap inorder to free memory mapped to base before returning Signed-off-by: Saurabh Sengar --- drivers/usb/host/pci-quirks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c

[PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. Commit 20357720 claims throughput improvement for MSC/UVC, but I don't see much improvement. Following are the MSC measurement using dd on AM335x GP EVM. with BCD_BH:read: 14.9MB/s, write: 20.9MB/s without BCD_BH: read: 15.2MB/s,

[PATCH v5 5/5] power: wm831x_power: Support USB charger current limit management

Integrate with the newly added USB charger interface to limit the current we draw from the USB input based on the input device configuration identified by the USB stack, allowing us to charge more quickly from high current inputs without drawing more current than specified from others.

[PATCH v5 2/5] gadget: Introduce the usb charger framework

This patch introduces the usb charger driver based on usb gadget that makes an enhancement to a power driver. It works well in practice but that requires a system with suitable hardware. The basic conception of the usb charger is that, when one usb charger is added or removed by reporting from

USB scanner stops working with xhci_hcd URB transfer length is wrong, xHC issue? req. len = 0, act. len = 4294967288

See https://bugzilla.kernel.org/show_bug.cgi?id=107331 Trying to use my scanner. Worked for a while, but now access fails. Get this in log: Nov 05 20:25:51 pacas.cora.nwra.com kernel: usb 1-3: new full-speed USB device number 3 using xhci_hcd Nov 05 20:25:52 pacas.cora.nwra.com kernel: usb

Re: [PATCH v3] usb: musb: fix tx fifo flush handling

Hi, On 11/06/2015 11:11 AM, Felipe Balbi wrote: Hi, Bin Liu writes: Here are a few changes in musb_h_tx_flush_fifo(). - It has been observed that sometimes (if not always) musb is unable to flush tx fifo during urb dequeue when disconnect a device. But it seems to be

[PATCH v5 3/5] gadget: Support for the usb charger framework

For supporting the usb charger, it adds the usb_charger_init() and usb_charger_exit() functions for usb charger initialization and exit. Introduce a callback 'get_charger_type' which will implemented by user for usb gadget operations to get the usb charger type. Signed-off-by: Baolin Wang

[PATCH v5 0/5] Introduce usb charger framework to deal with the usb gadget power negotation

Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not

[PATCH v5 4/5] gadget: Integrate with the usb gadget supporting for usb charger

When the usb gadget supporting for usb charger is ready, the usb charger should get the type by the 'get_charger_type' callback which is implemented by the usb gadget operations, and get the usb charger pointer from struct 'usb_gadget'. Signed-off-by: Baolin Wang ---

[PATCH v5 1/5] gadget: Introduce the notifier functions

The usb charger framework is based on usb gadget. The usb charger need to be notified the state changing of usb gadget to confirm the usb charger state. Thus this patch adds a notifier mechanism for usb gadget to report a event to usb charger when the usb gadget state is changed. Signed-off-by:

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

On Mon, Oct 12, 2015 at 01:37:40PM -0500, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: > > On Wed, Sep 02, 2015 at 05:09:39PM +0900, Masakazu Mokuno wrote: > >> Hi, > >> > >> On Mon, 31 Aug 2015 11:54:13 -0500 > >> Felipe Balbi wrote: > >> > >> > On Mon,

Re: [PATCH v3] usb: musb: fix tx fifo flush handling

On 11/06/2015 11:29 AM, Bin Liu wrote: Hi, On 11/06/2015 11:11 AM, Felipe Balbi wrote: Hi, Bin Liu writes: Here are a few changes in musb_h_tx_flush_fifo(). - It has been observed that sometimes (if not always) musb is unable to flush tx fifo during urb dequeue when

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

Hi, Bin Liu writes: > This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. > > Commit 20357720 claims throughput improvement for MSC/UVC, but I > don't see much improvement. Following are the MSC measurement using > dd on AM335x GP EVM. > > with BCD_BH:read: 14.9MB/s,

[PATCH v4] usb: musb: fix tx fifo flush handling

Here are a few changes in musb_h_tx_flush_fifo(). - It has been observed that sometimes (if not always) musb is unable to flush tx fifo during urb dequeue when disconnect a device. But it seems to be harmless, since the tx fifo flush is done again in musb_ep_program() when re-use the hw_ep.

Re: [PATCH] Revert "usb: musb: musb_host: Enable HCD_BH flag to handle urb return in bottom half"

Hi, On 11/06/2015 11:56 AM, Felipe Balbi wrote: Hi, Bin Liu writes: This reverts commit 2035772010db634ec8566b658fb1cd87ec47ac77. Commit 20357720 claims throughput improvement for MSC/UVC, but I don't see much improvement. Following are the MSC measurement using dd on AM335x

RE: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

Felipe, -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, November 06, 2015 10:06 AM To: McCauley, Ben Cc: linux-usb@vger.kernel.org; Schroeder, Jay Subject: Re: [PATCH] USB: DCW3: GADGET: Set Correct Max

Re: [PATCH v3] usb: musb: fix tx fifo flush handling

Hi, Bin Liu writes: > Hi, > > On 11/06/2015 11:11 AM, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >>> Here are a few changes in musb_h_tx_flush_fifo(). >>> >>> - It has been observed that sometimes (if not always) musb is unable >>>to flush tx fifo

RE: [PATCH] USB: DCW3: GADGET: Set Correct Max Speed

Hi, "McCauley, Ben" writes: > Felipe, > > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, November 06, 2015 10:06 AM > To: McCauley, Ben > Cc: linux-usb@vger.kernel.org; Schroeder, Jay

Re: [PATCH 1/2] cdc_acm: Ignore Infineon Flash Loader utility

On Thu, Nov 05, 2015 at 01:57:43PM +0100, Jonas Jonsson wrote: > Some modems, such as the Telit UE910, are using an Infineon Flash Loader > utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC > Data). The latter can be used as a serial interface to upgrade the > firmware of the

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

Hi, Heikki Krogerus writes: > On Mon, Oct 12, 2015 at 01:37:40PM -0500, Felipe Balbi wrote: >> >> Hi, >> >> Felipe Balbi writes: >> > On Wed, Sep 02, 2015 at 05:09:39PM +0900, Masakazu Mokuno wrote: >> >> Hi, >> >> >> >> On Mon, 31 Aug 2015

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

On Fri, Nov 06, 2015 at 02:48:00PM +0200, Heikki Krogerus wrote: > On Mon, Oct 12, 2015 at 01:37:40PM -0500, Felipe Balbi wrote: > > > > Hi, > > > > Felipe Balbi writes: > > > On Wed, Sep 02, 2015 at 05:09:39PM +0900, Masakazu Mokuno wrote: > > >> Hi, > > >> > > >> On Mon, 31 Aug

Re: [PATCH v5 1/5] gadget: Introduce the notifier functions

On Fri, Nov 06, 2015 at 08:56:44AM -0800, Greg KH wrote: > On Fri, Nov 06, 2015 at 07:35:10PM +0800, Baolin Wang wrote: > > Thus this patch adds a notifier mechanism for usb gadget to report a > > event to usb charger when the usb gadget state is changed. > I thought we said we did not want