RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs

HI "Du, Changbin" writes: >> before I review your patches, one comment >> >> changbin...@intel.com writes: >> > From: "Du, Changbin" >> > >> > The first patch removed unnecessary checking for debugfs api call; >> > The second patch fix a memory

RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs

> before I review your patches, one comment > > changbin...@intel.com writes: > > From: "Du, Changbin" > > > > The first patch removed unnecessary checking for debugfs api call; > > The second patch fix a memory leak issue; > > The third patch add one new entry to debufs.

Re: DWC3: Clock Domain Crossing erratum description.

Hi, Kirill Dronov writes: > I'm working on USB device bringup on Intel E3800 – based board. DWC3 > core configured as DRD in device mode. The only connected device phy > is SMSC 3310 (USB2 ULPI). DWC3 core version is 2.10A. Gadget zero > driver can be loaded, but device

Re: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs

Hi, before I review your patches, one comment changbin...@intel.com writes: > From: "Du, Changbin" > > The first patch removed unnecessary checking for debugfs api call; > The second patch fix a memory leak issue; > The third patch add one new entry to debufs. > > Du,

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

On 06/04/16 19:53, Greg KH wrote: On Tue, Apr 05, 2016 at 06:42:51PM +1000, Brian Chadwick wrote: SETUP: i7 16GB Computer. 1 x PCI-x USB3 adaptor card (i think uses xhci-hcd)04:00.0 USB controller: Renesas Technology Corp. uPD720202 USB 3.0 Host Controller (rev 02) Kernel driver in use:

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: >> > What happened to getting internal help in designing this api? This >> > shouldn't be my job :) >> >> I looked at this Baolu but, at least to me, it's unclear what

Re: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi, Peter Chen writes: >> >> > In below change of usb_gadget_vbus_draw(), already can get charger >> >> > type via usb_charger_get_type(). >> >> > >> >> > static inline int usb_gadget_vbus_draw(struct usb_gadget *gadget, >> >> > unsigned mA) { >> >> > + enum

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 01:25:06PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> >

Re: [PATCH v9 2/4] gadget: Support for the usb charger framework

On Wed, Apr 06, 2016 at 04:58:03PM +0300, Felipe Balbi wrote: > > Hi, > > Jun Li writes: > >> >> >> > Since we already have get_charger_type callback at usb_charger > >> >> >> > structure, why we still need this API at usb_gadget_ops? > >> >> >> > >> >> >> In case some users

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

On Wed, Apr 06, 2016 at 01:25:06PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: > >> Peter Chen writes: > >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi

Re: [PATCH v2 10/14] USB: ch341: fix coding style

On 04/06/2016 08:10 PM, Johan Hovold wrote: > As Joe already said, we generally don't want indentation-only changes to > existing code. Just try to stick to the style of the driver (even if > it's inconsistent at times). > Hm, I don't get it. I understand that white-space-only changes are

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

On Wed, 6 Apr 2016, Dmitry Torokhov wrote: > >>> [ 685.425634] atkbd serio0: Unknown key pressed (translated set 2, > >>> code 0xa8 on isa0060/serio0). > >>> [ 685.425648] atkbd serio0: Use 'setkeycodes e028 ' to make it > >>> known. > >>> > >>> Known issue? > >>> > >>> Do you need more input?

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

On Wed, 6 Apr 2016, Greg KH wrote: > On Wed, Apr 06, 2016 at 04:08:04PM +0300, Mathias Nyman wrote: > > We don't want to runtime suspend a bus if there is an event pending. > > The roothub on a NEC uPD720200 host with a single USB3 device connected > > might go back to runtime suspend immediately

Re: [PATCH v2 2/3] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

On Wed, Apr 06, 2016 at 11:44:05PM +0800, changbin...@intel.com wrote: > From: "Du, Changbin" > > Signed-off-by: Du, Changbin > --- You need a changelog entry in order for a patch to be able to be accepted. thanks, greg k-h -- To unsubscribe from

Oops in 4.6-rc2: NULL pointer dereference in cdc-acm

Hi, I'm getting a kernel oops when I plug some smartphone via USB to my laptop, which is currently running the v4.6-rc2. The problem seems to be caused by a81cf9799ad7 ("cdc-acm: implement put_char() and flush_chars()"). A simple NULL pointer check prevents the crash, but since I have no use of

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

On Wed, Apr 06, 2016 at 04:08:04PM +0300, Mathias Nyman wrote: > We don't want to runtime suspend a bus if there is an event pending. > The roothub on a NEC uPD720200 host with a single USB3 device connected > might go back to runtime suspend immediately after runtime resume as > hub might not yet

Re: [PATCH v2 10/14] USB: ch341: fix coding style

On Wed, Apr 06, 2016 at 07:58:36PM +0200, Grigori Goronzy wrote: > On 04/02/2016 07:29 PM, Joe Perches wrote: > > Most of the whitespace only changes are undesired. > > Well, the style wasn't very consistent. I think consistency is > important. So I took the liberty of deciding for one style and

Re: [PATCH v2 14/14] USB: ch341: implement tx_empty callback

On 04/03/2016 06:03 PM, Karl Palsson wrote: > > Grigori Goronzy wrote: >> The status bit was found with USB captures of the Windows >> driver and some luck. Tested on CH340G and CH341A. > > By my reversing, bit 0x4, is "multiple status changes since last > interrupt" >

Re: [PATCH v2 10/14] USB: ch341: fix coding style

On 04/02/2016 07:29 PM, Joe Perches wrote: > Most of the whitespace only changes are undesired. > Well, the style wasn't very consistent. I think consistency is important. So I took the liberty of deciding for one style and stuck to it. > Multi-line statements here are using alignment to >

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

On Wed, Apr 06, 2016 at 06:13:42PM +0530, Kishon Vijay Abraham I wrote: > On Friday 04 March 2016 09:49 PM, Thierry Reding wrote: [...] > > +struct tegra124_xusb_fuse_calibration { > > + u32 hs_curr_level[3]; > > + u32 hs_iref_cap; > > + u32 hs_term_range_adj; > > + u32 hs_squelch_level; >

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

On Tue, Apr 05, 2016 at 03:10:16PM -0600, Stephen Warren wrote: > On 04/05/2016 08:44 AM, Thierry Reding wrote: > > On Wed, Mar 16, 2016 at 11:59:44AM -0600, Stephen Warren wrote: > > > On 03/04/2016 09:19 AM, Thierry Reding wrote: > > > > From: Thierry Reding > > > > > > > >

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

On Wed, Apr 6, 2016 at 3:27 AM, Sedat Dilek wrote: > On Wed, Apr 6, 2016 at 11:35 AM, Sedat Dilek wrote: >> On Wed, Apr 6, 2016 at 11:27 AM, Sedat Dilek wrote: >>> Hi, >>> >>> I cannot use cursor up and down on my notebook and

Re: [PATCH v9 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Wed, Apr 06, 2016 at 09:15:26AM +0800, Peter Chen wrote: > > > No, this comment is common one, but only for SW detection. Eg, when > > > the PMIC tells you it is a SDP, you can't notify to charger IC about > > > 500mA at once, you need to do it after host allows you to do it. > > Note that

RE: [PATCH 1/2] usb: xhci: ring: simplify count_trbs() a little bit

From: Felipe Balbi > Sent: 06 April 2016 14:25 > If we _know_ length is 0, we can just return 1 early. Does that happen often enough to be an optimisation? Looks like a mispredicted branch to me. David -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

Alan Stern writes: > On Wed, 6 Apr 2016, Bjørn Mork wrote: >> Alan Stern writes: >> > On Wed, 6 Apr 2016, Mathias Nyman wrote: >> > >> >> We don't want to runtime suspend a bus if there is an event pending. >> >> The roothub on a NEC

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

On Wed, 6 Apr 2016, Bjørn Mork wrote: > Alan Stern writes: > > > On Wed, 6 Apr 2016, Mathias Nyman wrote: > > > >> We don't want to runtime suspend a bus if there is an event pending. > >> The roothub on a NEC uPD720200 host with a single USB3 device connected > >>

[PATCH v2 1/3] usb: dwc3: make dwc3_debugfs_init return value be void

From: "Du, Changbin" Debugfs init failure is not so important. We can continue our job on this failure. Also no need to check debugfs_create_file call results. Signed-off-by: Du, Changbin --- drivers/usb/dwc3/core.c| 10 +-

[PATCH v2 3/3] usb: dwc3: add debugfs node to dump FIFO/Queue available space

From: "Du, Changbin" For DWC3 USB controller, the Global Debug Queue/FIFO Space Available Register(GDBGFIFOSPACE) can be used to dump FIFO/Queue available space. This can be used to check some special issues, like whether data is successfully copied from memory to fifo

[PATCH v2 2/3] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

From: "Du, Changbin" Signed-off-by: Du, Changbin --- drivers/usb/dwc3/debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c index 071b286..2d4f397 100644 ---

[PATCH] option.c: Support for Gemalto's Cinterion PH8 and AHxx products added

Added support for Gemalto's Cinterion PH8 and AHxx products with 2 RmNet Interfaces and products with 1 RmNet + 1 USB Audio interface. The RmNet and USB Audio interfaces are blacklisted because they will be handled by other drivers. In addition some minor renaming and formatting. Signed-off-by:

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

Alan Stern writes: > On Wed, 6 Apr 2016, Mathias Nyman wrote: > >> We don't want to runtime suspend a bus if there is an event pending. >> The roothub on a NEC uPD720200 host with a single USB3 device connected >> might go back to runtime suspend immediately after

Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

On Wed, 6 Apr 2016, Michal Nazarewicz wrote: > On Tue, Apr 05 2016, Alan Stern wrote: > > Suppose one usb_function is carrying out an I/O operation while > > another one in the same config gets a Set-Interface request from the > > host. > > That cannot happen. A single instance of mass_storage

Re: [PATCH 3/7] xhci: Don't suspend a xhci usb bus if there is a pending event.

On Wed, 6 Apr 2016, Mathias Nyman wrote: > We don't want to runtime suspend a bus if there is an event pending. > The roothub on a NEC uPD720200 host with a single USB3 device connected > might go back to runtime suspend immediately after runtime resume as > hub might not yet see any port changes

Re: [PATCH v1] net: cdc_ncm: update datagram size after changing mtu

Robert Dobrowolski writes: > From: Rafal Redzimski > > Current implementation updates the mtu size and notify cdc_ncm > device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram > size change instead of changing

[PATCH v2 2/2] phy: Group vendor specific phy drivers

Adding vendor specific directories in phy to group phy drivers under their respective vendor umbrella. Also updated the MAINTAINERS file to reflect the correct directory structure for phy drivers. Signed-off-by: Vivek Gautam Acked-by: Heiko Stuebner

[PATCH 1/2] phy: Move ULPI phy header out of driver to includes path

Although ULPI phy is currently being used by tusb1210, there can be other consumers too in future. So move this to the includes path for phy. Signed-off-by: Vivek Gautam --- {drivers => include/linux}/phy/ulpi_phy.h | 0 1 file changed, 0 insertions(+), 0 deletions(-)

DWC3: Clock Domain Crossing erratum description.

Hi. I'm working on USB device bringup on Intel E3800 – based board. DWC3 core configured as DRD in device mode. The only connected device phy is SMSC 3310 (USB2 ULPI). DWC3 core version is 2.10A. Gadget zero driver can be loaded, but device enumeration fails: device is detected by host, speed

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi, Jun Li writes: >> >> >> > Since we already have get_charger_type callback at usb_charger >> >> >> > structure, why we still need this API at usb_gadget_ops? >> >> >> >> >> >> In case some users want to get charger type at gadget level. >> >> >> >> >> > Why gadget needs to

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, April 06, 2016 8:56 PM > To: Jun Li ; Baolin Wang ; Peter > Chen > Cc: Greg KH ; Sebastian Reichel >

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

Hi Kishon, On Wed, Apr 6, 2016 at 5:51 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 01 April 2016 07:05 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Fri, Apr 1, 2016 at 6:05 AM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Friday 01 April 2016 04:59 PM,

Re: [PATCH] usb: gadget: f_fs: Fix EFAULT generation for async read operations

Hi Al, Lars-Peter Clausen writes: > In the current implementation functionfs generates a EFAULT for async read > operations if the read buffer size is larger than the URB data size. Since > a application does not necessarily know how much data the host side is > going to send

[PATCH 0/2] usb: xhci: couple cleanups

Hi, The following two patches are tiny simplifications two count_trbs() and count_sg_trbs_needed() which make the code slightly easier to read. Felipe Balbi (2): usb: xhci: ring: simplify count_trbs() a little bit usb: xhci: ring: simplify count_sg_trbs_needed()

[PATCH 1/2] usb: xhci: ring: simplify count_trbs() a little bit

If we _know_ length is 0, we can just return 1 early. While at that, we're also adding a comment referencing the location where the 64KiB boundary is mentioned in the xhci spec. This will prevent people from thinking this isn't necessary in the future. We're also changing the bitwise-and

[PATCH 2/2] usb: xhci: ring: simplify count_sg_trbs_needed()

we _know_ that for_each_sg() will only iterate over number of mapped sgs, so there's no need to count full_len and break out when it reaches zero. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 14 +- 1 file changed, 5 insertions(+), 9

[PATCH 6/7] usb: xhci: fix wild pointers in xhci_mem_cleanup

From: Lu Baolu This patch fixes some wild pointers produced by xhci_mem_cleanup. These wild pointers will cause system crash if xhci_mem_cleanup() is called twice. Reported-and-tested-by: Pengcheng Li Signed-off-by: Lu Baolu

[PATCH 5/7] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

From: Yoshihiro Shimoda This patch fixes an issue that cannot work if R-Car Gen2/3 run on above 4GB physical memory environment to use a quirk XHCI_NO_64BIT_SUPPORT. Cc: Signed-off-by: Yoshihiro Shimoda

[PATCH 2/7] xhci: resume USB 3 roothub first

Give USB3 devices a better chance to enumerate at USB 3 speeds if they are connected to a suspended host. Solves an issue with NEC uPD720200 host hanging when partially enumerating a USB3 device as USB2 after host controller runtime resume. Cc: Tested-by: Mike Murdoch

[PATCH 4/7] usb: host: xhci: add a new quirk XHCI_NO_64BIT_SUPPORT

From: Yoshihiro Shimoda On some xHCI controllers (e.g. R-Car SoCs), the AC64 bit (bit 0) of HCCPARAMS1 is set to 1. However, the xHCs don't support 64-bit address memory pointers actually. So, in this case, this driver should call dma_set_coherent_mask(dev,

[PATCH 7/7] xhci: fix 10 second timeout on removal of PCI hotpluggable xhci controllers

PCI hotpluggable xhci controllers such as some Alpine Ridge solutions will remove the xhci controller from the PCI bus when the last USB device is disconnected. Add a flag to indicate that the host is being removed to avoid queueing configure_endpoint commands for the dropped endpoints. For PCI

[PATCH 0/7] xhci fixes for usb-linus

Hi Greg These xhci fixes solve various small issues such as: * USB 3 device enumeration issues after runtime resume seen on NEC hosts * Add a PCI ID and needed quirk for a new controller * Remove extra 10 seconds driver timeouts on PCI hotplugged xhcis * R-Car SoC xhci quirks to solve their

[PATCH 1/7] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

From: Rafal Redzimski Broxton B0 also requires XHCI_PME_STUCK_QUIRK. Adding PCI device ID for Broxton B and adding to quirk. Cc: Signed-off-by: Rafal Redzimski Signed-off-by: Robert Dobrowolski

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi, Jun Li writes: >> >> On 6 April 2016 at 15:19, Peter Chen wrote: >> >> > On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote: >> >> >> >> >> >> @@ -563,6 +564,8 @@ struct usb_gadget_ops { >> >> >> struct usb_ep *(*match_ep)(struct

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

Hi, On Friday 01 April 2016 07:05 PM, Vivek Gautam wrote: > Hi, > > > On Fri, Apr 1, 2016 at 6:05 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 01 April 2016 04:59 PM, Vivek Gautam wrote: >>> Adding vendor specific directories in phy to group >>> phy drivers under

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, April 06, 2016 8:22 PM > To: Jun Li ; Baolin Wang ; Peter > Chen > Cc: Greg KH ; Sebastian Reichel >

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

Hi, On Friday 04 March 2016 09:49 PM, Thierry Reding wrote: > From: Thierry Reding > > Add a new driver for the XUSB pad controller found on NVIDIA Tegra SoCs. > This hardware block used to be exposed as a pin controller, but it turns > out that this isn't a good fit. The

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hello. On 4/6/2016 9:44 AM, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char*extcon_name; + char*cable_name; + int (*cable_set_cb)(struct intel_mux_dev *mux); + int (*cable_unset_cb)(struct

RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

Hi, (please make sure to break your lines at 80-characters. Documentation/email-clients.txt has several tips for different email clients ;-)) "Du, Changbin" writes: >> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc) >> >goto err1; >> >} >>

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi, Jun Li writes: >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Baolin Wang >> Sent: Wednesday, April 06, 2016 6:47 PM >> To: Peter Chen >> Cc: Felipe Balbi

RE: [PATCH v9 2/4] gadget: Support for the usb charger framework

Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Wednesday, April 06, 2016 6:47 PM > To: Peter Chen > Cc: Felipe Balbi ; Greg KH

Re: [PATCH v2 07/14] USB: ch341: add support for parity, frame length, stop bits

On Sat, 2 Apr 2016 19:07:16 +0200 Grigori Goronzy wrote: > With the new reinitialization method, configuring parity, different > frame lengths and different stop bit settings work as expected on > both CH340G and CH341A. This has been extensively tested with a > logic

Re: [PATCH v2 01/14] USB: ch341: improve documentation

On Sat, 2 Apr 2016 19:07:10 +0200 Grigori Goronzy wrote: > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ch341.c

RE: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Hi > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Wednesday, April 06, 2016 7:31 PM > To: Jun Li > Cc: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead.org; peter.c...@freescale.com; >

[PATCH v1] net: cdc_ncm: update datagram size after changing mtu

From: Rafal Redzimski Current implementation updates the mtu size and notify cdc_ncm device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram size change instead of changing rx_urb_size. Whenever mtu is being changed, datagram size should also be updated.

RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space

> > This can be used to check some special issues, like whether data is > > successfully copied from memory to fifo when a trb is blocked. > > > > Signed-off-by: Du, Changbin > > --- > > drivers/usb/dwc3/core.h| 5 + > > drivers/usb/dwc3/debugfs.c | 45 >

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

On 6 April 2016 at 16:26, Jun Li wrote: > Hi > >> + */ >> +static enum usb_charger_type >> +usb_charger_get_type_by_others(struct usb_charger *uchger) { >> + if (uchger->type != UNKNOWN_TYPE) >> + return uchger->type; >> + >> + if (uchger->psy) { >> +

Re: dwc3: wakeup request details (was: Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer)

Hi John, Felipe Balbi writes: > Felipe Balbi writes: >> Synopsys Databook says we should move link to U0 >> before issuing a Start Transfer command. We could >> require the gadget driver to call >> usb_gadget_wakeup() however I feel

Re: [PATCH v9 2/4] gadget: Support for the usb charger framework

On 6 April 2016 at 15:19, Peter Chen wrote: > On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote: >> >> @@ -563,6 +564,8 @@ struct usb_gadget_ops { >> struct usb_ep *(*match_ep)(struct usb_gadget *, >> struct usb_endpoint_descriptor *,

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

On Wed, Apr 6, 2016 at 12:33 PM, Jiri Kosina wrote: > On Wed, 6 Apr 2016, Sedat Dilek wrote: > >> >> I cannot use cursor up and down on my notebook and see this in my dmesg. >> >> >> >> [ 685.425634] atkbd serio0: Unknown key pressed (translated set 2, >> >> code 0xa8 on

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

On Wed, 6 Apr 2016, Sedat Dilek wrote: > >> I cannot use cursor up and down on my notebook and see this in my dmesg. > >> > >> [ 685.425634] atkbd serio0: Unknown key pressed (translated set 2, > >> code 0xa8 on isa0060/serio0). > >> [ 685.425648] atkbd serio0: Use 'setkeycodes e028 ' to make

Re: [Linux-v4.6-rc2] atkbd serio0: Unknown key pressed (translated set 2, code 0xa8 on isa0060/serio0).

On Wed, Apr 6, 2016 at 11:35 AM, Sedat Dilek wrote: > On Wed, Apr 6, 2016 at 11:27 AM, Sedat Dilek wrote: >> Hi, >> >> I cannot use cursor up and down on my notebook and see this in my dmesg. >> >> [ 685.425634] atkbd serio0: Unknown key pressed

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> > On Fri, Apr 01,

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Hi, Peter Chen writes: > On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> >> Peter Chen writes: >> >> > On Fri, Apr 01,

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: >> On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: >> > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >> >> >>> diff --git

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

On 04/06/2016 10:52 AM, Pavel Machek wrote: Hi! Lets say we have /sys/class/pattern/lp5533::0 /sys/class/pattern/software::0 /sys/class/led/n900::red ; default trigger "lp5533::0:0" /sys/class/led/n900::green ; default trigger "lp5533::0:1" /sys/class/led/n900::blue ; default trigger

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

On Tue, Apr 05, 2016 at 06:42:51PM +1000, Brian Chadwick wrote: > SETUP: > > i7 16GB Computer. > > 1 x PCI-x USB3 adaptor card (i think uses xhci-hcd)04:00.0 USB controller: > Renesas Technology Corp. uPD720202 USB 3.0 Host Controller (rev 02) > Kernel driver in use: xhci_hcd > > 2 x USB3

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:58:52PM +0800, Lu Baolu wrote: > Hi, > > On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > >> > >>> diff --git

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: > Hi, > > On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

Hi! > >As I see it the current blinking support then would be one special case of a > >pattern. > >As a consequence once having pattern support we might be able to switch > >users of blinking > >to pattern and remove the blinking support. > > Let's split patterns related discussion into a

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

Hi! > > We would probably need additional op in the LED core : color_set. > > > > Having the color set to nonzero value would signify the the three LED > > class devices are in sync and that setting a trigger on any of them > > applies to the remaining two ones. It would have to be considered >

RE: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Baolin Wang > Sent: Friday, April 01, 2016 3:22 PM > To: ba...@kernel.org; gre...@linuxfoundation.org; s...@kernel.org; > dbarysh...@gmail.com; dw...@infradead.org >

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

Hi! > >Lets say we have > > > >/sys/class/pattern/lp5533::0 > >/sys/class/pattern/software::0 > > > >/sys/class/led/n900::red ; default trigger "lp5533::0:0" > >/sys/class/led/n900::green ; default trigger "lp5533::0:1" > >/sys/class/led/n900::blue ; default

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

On Wed, Apr 06, 2016 at 11:05:26AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > >> Peter Chen writes: > >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > >> > +

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Peter Chen writes: > On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: >> Peter Chen writes: >> > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: >> > + >> >> +static struct attribute *usb_charger_attrs[] = { >> >> +

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > > + > >> +static struct attribute *usb_charger_attrs[] = { > >> + _attr_sdp_current.attr, > >> + _attr_dcp_current.attr,

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

Peter Chen writes: > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > + >> +static struct attribute *usb_charger_attrs[] = { >> +_attr_sdp_current.attr, >> +_attr_dcp_current.attr, >> +_attr_cdp_current.attr, >> +_attr_aca_current.attr, >> +

Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework

On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: + > +static struct attribute *usb_charger_attrs[] = { > + _attr_sdp_current.attr, > + _attr_dcp_current.attr, > + _attr_cdp_current.attr, > + _attr_aca_current.attr, > + _attr_charger_type.attr, > +

Re: [PATCH v9 2/4] gadget: Support for the usb charger framework

On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote: > For supporting the usb charger, it adds the usb_charger_init() and > usb_charger_exit() functions for usb charger initialization and exit. > > It will report to the usb charger when the gadget state is changed, > then the usb charger

Re: [PATCH v7 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined

On 06/04/16 09:46, Peter Chen wrote: > On Tue, Apr 05, 2016 at 04:48:19PM +0300, Roger Quadros wrote: >> Peter, >> >> On 05/04/16 15:52, Roger Quadros wrote: >>> Peter, >>> >>> On 05/04/16 11:52, Peter Chen wrote: On Thu, Mar 31, 2016 at 12:41:19PM +0300, Roger Quadros wrote: > If

Re: [PATCH v7 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined

On Tue, Apr 05, 2016 at 04:48:19PM +0300, Roger Quadros wrote: > Peter, > > On 05/04/16 15:52, Roger Quadros wrote: > > Peter, > > > > On 05/04/16 11:52, Peter Chen wrote: > >> On Thu, Mar 31, 2016 at 12:41:19PM +0300, Roger Quadros wrote: > >>> If usb/otg-fsm.h and usb/composite.h are included

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; +

Re: [PATCH v6 12/12] usb: host: xhci-plat: Add otg device to platform data

Hi, On 06/04/16 06:23, Yoshihiro Shimoda wrote: > Hi, > >> Sent: Tuesday, April 05, 2016 11:05 PM >> >> Host controllers that are part of an OTG/dual-role instance >> need to somehow pass the OTG controller device information >> to the HCD core. >> >> We use platform data to pass the OTG

Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0

Hi, Roger Quadros writes: > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c > index 2ca2cef..6b1930d 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd, > int retval; > struct