Re: kernel panic in sg_complete

2013-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2013 at 01:00:41AM +0200, Marcin Ślusarz wrote: If you want me to test some patches, just shout ;) Interesting patch, it makes sense to have this applied. Can you resend it with a Signed-off-by: line so that I can add it to the tree? thanks, greg k-h -- To unsubscribe from

Re: [PATCH v2 5/5] staging: ozwpan: Rename Kbuild to Makefile

2013-07-22 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2013 at 06:43:18PM +0100, Rupesh Gujare wrote: Greg, Can I expect to merge following patch series with your tree ? http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-July/039354.html Or do you want me to rework on it as per your suggestions here :-

Re: [Pull Request] xhci: Features for 3.12

2013-07-23 Thread Greg Kroah-Hartman
On Tue, Jul 23, 2013 at 03:01:32PM -0700, Sarah Sharp wrote: The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git

Re: [PATCH] usb: fix build warning in pci-quirks.h when CONFIG_PCI is not enabled

2013-07-23 Thread Greg Kroah-Hartman
/host/pci-quirks.h Sarah Sharp sarah.a.sh...@linux.intel.com (supporter:USB XHCI DRIVER) Greg Kroah-Hartman gre...@linuxfoundation.org (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:USB XHCI DRIVER) linux-ker...@vger.kernel.org (open list) Sarah should get this patch, thanks. greg

Re: [Pull Request] xhci: Features for 3.12

2013-07-24 Thread Greg Kroah-Hartman
On Wed, Jul 24, 2013 at 08:13:49AM -0700, Sarah Sharp wrote: On Tue, Jul 23, 2013 at 03:19:47PM -0700, Greg Kroah-Hartman wrote: On Tue, Jul 23, 2013 at 03:01:32PM -0700, Sarah Sharp wrote: The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11

Re: [Pull Request] xhci: Features for 3.12

2013-07-24 Thread Greg Kroah-Hartman
On Wed, Jul 24, 2013 at 09:46:10AM -0700, Sarah Sharp wrote: On Wed, Jul 24, 2013 at 09:09:32AM -0700, Greg Kroah-Hartman wrote: On Wed, Jul 24, 2013 at 08:13:49AM -0700, Sarah Sharp wrote: On Tue, Jul 23, 2013 at 03:19:47PM -0700, Greg Kroah-Hartman wrote: On Tue, Jul 23, 2013 at 03:01

Re: [PATCH V2] usb: serial: option: Add support for ONYX 3G device (ALFANETWORK)

2013-07-24 Thread Greg Kroah-Hartman
On Fri, Jun 28, 2013 at 02:29:23PM +0200, Enrico Mioso wrote: This patch, adds support for the ONYX 3G device by ALFA NETWRORK, based on a MSM90 chip from Qualcomm. Signed-off-by: Enrico Mioso mrkiko...@gmail.com I have two different patches (well 4 in reality) from you for this device, and

Re: [Pull Request] xhci: Bug fixes, now with more tags!

2013-07-25 Thread Greg Kroah-Hartman
On Thu, Jul 25, 2013 at 08:16:03AM -0700, Sarah Sharp wrote: The following changes since commit 94190301ffa059c2d127b3a67ec5d161d5c62681: usb: option: add TP-LINK MA260 (2013-07-23 16:07:51 -0700) are available in the git repository at:

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: The patch does the below improvement: - think QH_STATE_COMPLETING as unlinking state since all URBs on the endpoint should be in unlinking or unlinked when doing endpoint_disable() - add WARN_ON(!list_empty(qh-qtd_list)); if

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2013 at 04:52:36AM +0800, Ming Lei wrote: Hi Greg, On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: The patch does the below improvement

[PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-25 Thread Greg Kroah-Hartman
Steinar, I've tested the driver below with my device and it seems to work. If you have any problems with it, please let me know, otherwise I'll queue it up to get into the 3.11 kernel release soon. thanks, greg k-h - From: Greg Kroah-Hartman gre

Re: [PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-26 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2013 at 10:27:51AM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org This adds a driver for the Suunto ANT+ USB device, exposing it as a usb serial device. This lets the userspace gant program

Re: [PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-26 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2013 at 02:00:42PM +0200, Steinar H. Gunderson wrote: On Thu, Jul 25, 2013 at 09:52:29PM -0700, Greg Kroah-Hartman wrote: Steinar, I've tested the driver below with my device and it seems to work. If you have any problems with it, please let me know, otherwise I'll queue

Re: [PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-26 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2013 at 10:55:19AM +0200, Daniele Forsi wrote: 2013/7/26 Greg Kroah-Hartman: + Say Y here if you want to usb the Suunto ANT+ USB device. I think there might be a thinko: s/to usb/to use/ Thanks, now fixed, too much USB on the brain... greg k-h -- To unsubscribe

Re: [PATCH 4/4] USBNET: ax88179_178a: enable tso if host supports sg dma

2013-07-31 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 06:51:49PM +0800, Ming Lei wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so both frame header and skb data buffers can be passed to usb stack

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: 1), for drivers, they don't care if the complete() is called in hard irq context or softirq context What about those 50+ patches you had that changed the locking for urb callbacks? Aren't they needed before this patch can go in? ---

Re: [PATCH v5 1/5] USB: HCD: support giveback of URB in tasklet context

2013-08-01 Thread Greg Kroah-Hartman
On Fri, Aug 02, 2013 at 11:30:54AM +0800, Ming Lei wrote: On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote: 1), for drivers, they don't care if the complete() is called in hard irq context

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: When building the htmldocs (in verbose mode), scripts/kernel-doc reports the following type of warnings: Warning(drivers/usb/core/usb.c:76): No description found for return value of 'usb_find_alt_setting' Fix them by: -

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-04 Thread Greg Kroah-Hartman
On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: When building the htmldocs (in verbose mode), scripts/kernel-doc reports the following type of warnings

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-04 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: From: Julius Werner jwer...@chromium.org The USB hub driver's event handler contains a check to catch SuperSpeed devices that transitioned into the SS.Inactive state and tries to fix them with a reset. It decides whether to do a

Re: [Pull Request] xhci: Misc bug fixes for 3.11.

2013-08-04 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 11:30:27AM -0700, Sarah Sharp wrote: The following changes since commit fed1f1ed90bce42ea010e2904cbc04e7b8304940: USB: serial: ftdi_sio: add more RT Systems ftdi devices (2013-07-29 13:38:38 -0700) are available in the git repository at:

[PATCH] USB: serial: move the simple drivers into usb-serial-simple.c

2013-08-05 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: René Bürgel rene.buer...@sohard.de Cc: Wei Shuai cpuw...@gmail.com Cc: Josh

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: On Mon, Aug 05, 2013 at 01:29:12PM +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: From: Julius Werner jwer...@chromium.org The USB hub driver's event handler contains a check

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2013 at 08:36:39PM +0200, Yacine Belkadi wrote: On 08/04/2013 11:29 PM, Greg Kroah-Hartman wrote: On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:47:24PM +0300, Jussi Kivilinna wrote: On 06.08.2013 15:26, Oliver Neukum wrote: On Tue, 2013-08-06 at 15:03 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. You

Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c

2013-08-07 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2013 at 09:36:23AM -0500, Dan Williams wrote: On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: +/* All of the above structures mushed into two lists */ +static struct usb_serial_driver * const serial_drivers[] = { + zio_device, + funsoft_device

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-11 Thread Greg Kroah-Hartman
On Sun, Aug 11, 2013 at 08:08:26PM +0100, Mark Brown wrote: Looking at the enumerable buses in the kernel I don't see any which have real support for any kind of registration of devices prior to their enumeration. Similarly currently all the DT bindings in the kernel I've been able to notice

Re: [PATCH 1/1] USB-Serial: Fix error handling of usb_wwan

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 10:11:39AM -0700, Matt Burtch wrote: This fixes an issue where the bulk-in urb used for incoming data transfer is not resubmitted if the packet recieved contains an error status. This results in the driver locking until the port is closed and re-opened. Tested on a

Re: [PATCH v3] usb: rh_call_control tbuf potential future overflow fix

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 11:09:25AM -0700, Sean O. Stalley wrote: rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the URB is dynamically defined and is always large

Re: [RFC 0/2] USB port power off bug fixes

2013-08-12 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 01:16:50PM -0700, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote: On Tue, 6 Aug 2013, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: Patch 1 has been rendered out of date by intervening changes

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 12:23:44PM +0100, Mark Brown wrote: On Sun, Aug 11, 2013 at 07:02:57PM -0700, Greg Kroah-Hartman wrote: On Sun, Aug 11, 2013 at 08:08:26PM +0100, Mark Brown wrote: I know there's been some discussion of this topic but do we have any general consensus on how

Re: [PATCH v3] usb: rh_call_control tbuf potential future overflow fix

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 11:16:24PM +, Stalley, Sean wrote: -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, August 12, 2013 1:32 PM To: Stalley, Sean Cc: linux-usb@vger.kernel.org; Sarah Sharp; Ismail, Abdul R; Alan Stern

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-12 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 08:40:56PM -0700, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 06:04:36AM +0800, Greg Kroah-Hartman wrote: On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: I wanted to test it for a kernel release to make sure it didn't cause any issues before sending

Re: [PATCH 0/7] USB: fixes for v3.11 (and v3.12)

2013-08-14 Thread Greg Kroah-Hartman
On Tue, Aug 13, 2013 at 01:27:33PM +0200, Johan Hovold wrote: Greg, Here's a bunch of fixes for v3.11 and (possibly) v3.12. The first two I think should go into v3.11 whereas the remaining patches could wait for v3.12, unless you think otherwise. No, that makes sense, I've split the

Re: [Pull Request] xhci: Platform updates, 64-bit DMA, and trace events for 3.12.

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 09:12:57AM -0700, Sarah Sharp wrote: The following changes since commit 5b146f7e016a8727a98b3d48e4f4e128d3624cd5: Merge 3.11-rc4 into usb-next (2013-08-05 08:36:14 +0800) are available in the git repository at:

Re: [RFC 0/2] USB port power off bug fixes

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:35:49PM -0700, Sarah Sharp wrote: On Tue, Aug 13, 2013 at 03:42:11PM -0700, Sarah Sharp wrote: On Mon, Aug 12, 2013 at 01:44:16PM -0700, Greg Kroah-Hartman wrote: I tried to cherry pick this patch from my usb-next branch to my usb-linus branch, but it fails

Re: [RFC 0/2] USB port power off bug fixes

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:35:49PM -0700, Sarah Sharp wrote: On Tue, Aug 13, 2013 at 03:42:11PM -0700, Sarah Sharp wrote: On Mon, Aug 12, 2013 at 01:44:16PM -0700, Greg Kroah-Hartman wrote: I tried to cherry pick this patch from my usb-next branch to my usb-linus branch, but it fails

Re: [Pull Request] xhci: Step 1 to fix usb-linus and usb-next.

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:43:55PM -0700, Sarah Sharp wrote: The following changes since commit ff8a43c10f1440f07a5faca0c1556921259f7f76: USB: keyspan: fix null-deref at disconnect and release (2013-08-14 12:49:27 -0700) are available in the git repository at:

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: From: Lan Tianyu tianyu@intel.com The pm qos NO_POWER_OFF flag is checked twice during usb device suspend to see if the usb port power off condition is met. This is redundant and also will prevent the port from being powered

Re: [PATCH 3/4] usb: Don't fail port power resume on device disconnect.

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:43:58PM -0700, Sarah Sharp wrote: Userspace can tell the kernel to power off any USB port, including ones that are visible and connectible to users. When an attached USB device goes into suspend, the port will be powered off if the pm_qos_no_port_poweroff file for

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device. It does not want the xHCI generic driver to register an interrupt for it at all. The original code did that by setting the XHCI_BROKEN_MSI

Re: [Pull Request] xhci: Step 1 to fix usb-linus and usb-next.

2013-08-15 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2013 at 07:09:57PM -0700, Greg Kroah-Hartman wrote: On Thu, Aug 15, 2013 at 06:43:55PM -0700, Sarah Sharp wrote: The following changes since commit ff8a43c10f1440f07a5faca0c1556921259f7f76: USB: keyspan: fix null-deref at disconnect and release (2013-08-14 12:49:27

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 02:22:43AM +, Wang, Yu Y wrote: On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device. It does not want the xHCI generic driver to register an interrupt for it

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 04:01:50AM +, Wang, Yu Y wrote: On Fri, Aug 16, 2013 at 02:22:43AM +, Wang, Yu Y wrote: On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device. It does

Re: [patch] USB: mos7720: use GFP_ATOMIC under spinlock

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 12:12:10PM +0200, Johan Hovold wrote: On Fri, Aug 16, 2013 at 10:16:59AM +0300, Dan Carpenter wrote: The write_parport_reg_nonblock() function shouldn't sleep because it's called with spinlocks held. Ouch. Thanks for catching this. Signed-off-by: Dan Carpenter

Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: Some drivers implementing NCM-like protocols, may re-use those functions, as is the case in the huawei_cdc_ncm driver. Where is that driver at, I don't see it in the kernel tree. Export them via EXPORT_SYMBOL_GPL. Normally we

Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 06:49:07AM -0700, Greg Kroah-Hartman wrote: On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: Some drivers implementing NCM-like protocols, may re-use those functions, as is the case in the huawei_cdc_ncm driver. Where is that driver at, I don't see

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 09:58:25AM -0500, Felipe Balbi wrote: Hi, On Thu, Aug 15, 2013 at 09:28:20PM -0700, Greg Kroah-Hartman wrote: But should be also met for ARM SOC which use dwc3 controller as xHCI controller. Because DWC3 driver register xHCI as platform driver by default. So

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 09:35:57AM -0700, Sarah Sharp wrote: On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: From: Lan Tianyu tianyu@intel.com The pm qos NO_POWER_OFF flag is checked twice during usb

Re: [PATCH v1 26/49] input: cm109: prepare for enabling irq in complete()

2013-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 18, 2013 at 10:10:15PM +0800, Ming Lei wrote: Hi Dmitry, On Sun, Aug 18, 2013 at 11:37 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Ming, On Sun, Aug 18, 2013 at 12:24:51AM +0800, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to

Re: [PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 18, 2013 at 09:29:00PM +0200, Yann Droneaud wrote: From: Yann Droneaud ydrone...@opteya.com usb-serial-simple uses an unknown stringify macro that make all drivers being named stringify(vendor). This can be a problem when two drivers have the same (wrong) name: kernel:

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 07:04:18PM +0800, Ming Lei wrote: Because usb_hcd_submit_urb is in the hotest path of usb core, so use percpu counter to count URB instead of using atomic variable because atomic operations are much slower than percpu operations. Cc: Oliver Neukum oli...@neukum.org

Re: [PATCH 3/3] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 07:04:20PM +0800, Ming Lei wrote: This patch introduces ehci_disable_event(), which is applied on IAA_WATCHDOG and START_UNLINK_INTR events in case that the two events needn't to be handled, so that we may avoid unnecessary CPU wakeup. Why would those events not need

Re: [RFC PATCH 2/3] USB: kill urb-use_count atomic variable

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 07:04:19PM +0800, Ming Lei wrote: This patch kills atomic_inc/atomic_dec operations on urb-use_count in URB submit/complete path. Any reason only this patch was RFC? And you didn't kill them all, please look closer, this should have no affect on speed, did you measure

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 11:06:31PM +0800, Ming Lei wrote: On Mon, Aug 19, 2013 at 10:00 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Aug 19, 2013 at 07:04:18PM +0800, Ming Lei wrote: Because usb_hcd_submit_urb is in the hotest path of usb core, so use percpu counter

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 11:40:50PM +0800, Ming Lei wrote: On Mon, Aug 19, 2013 at 11:14 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Aug 19, 2013 at 11:06:31PM +0800, Ming Lei wrote: On Mon, Aug 19, 2013 at 10:00 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote

Re: [PATCH 1/3] USB: use percpu counter to count submitted URBs per device

2013-08-19 Thread Greg Kroah-Hartman
On Mon, Aug 19, 2013 at 10:14:57AM -0700, Greg Kroah-Hartman wrote: On Mon, Aug 19, 2013 at 11:40:50PM +0800, Ming Lei wrote: On Mon, Aug 19, 2013 at 11:14 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Aug 19, 2013 at 11:06:31PM +0800, Ming Lei wrote: On Mon, Aug 19

Re: [PATCH] Fix stack corruption on some architectures

2013-08-19 Thread Greg Kroah-Hartman
Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 05:45:14PM -0700, Sarah Sharp wrote: On Wed, Aug 21, 2013 at 02:43:55PM -0700, Julius Werner wrote: Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-23 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 04:10:12PM +0800, Ming Lei wrote: This patch introduces ehci_disable_event(), which is applied on IAA_WATCHDOG and START_UNLINK_INTR timeouts if the two corresponding events(IAA and intr URB submission) happened, so that we may avoid unnecessary CPU wakeup by canceling

[PATCH] USB: usbtmc: fix up attribute permissions

2013-08-23 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org In auditing the usbtmc sysfs files, a bunch of them were being created as read only, yet they have logic to handle writing to. So fix them up by setting the permissions properly. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH] USB: serial: clean up attribute permissions

2013-08-23 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org Clean up the DEVICE_ATTR usage in the USB serial drivers, making them more obvious as to the permissions that the sysfs files should be. Note: ftdi_sio.c still has a DEVICE_ATTR() used, that will have to wait until after 3.12-rc1 comes out when

[PATCH] USB: gadget: audit sysfs attribute permissions

2013-08-23 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org Convert all USB gadget sysfs attributes to use the _RO or _RW variants, to make them easier to audit and ensure that the permissions are correct. Note, two are left using the DEVICE_ATTR() macro, as there is no DEVICE_ATTR_WO() in Linus's tree

Re: [PATCH] USB: usbtmc: fix up attribute permissions

2013-08-23 Thread Greg Kroah-Hartman
On Sat, Aug 24, 2013 at 04:10:17AM +0400, Sergei Shtylyov wrote: Hello. On 08/24/2013 03:09 AM, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org In auditing the usbtmc sysfs files, a bunch of them were being created as read only, yet they have logic

Re: 3.11-rc7: compile failure in ohci

2013-08-26 Thread Greg Kroah-Hartman
On Mon, Aug 26, 2013 at 12:46:03PM +0300, Meelis Roos wrote: Tried 3.11-rc7 and got this compile failure on a couple of hosts where -rc6 worked. config is below. This commit seems to break it:

Re: [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume

2013-08-26 Thread Greg Kroah-Hartman
On Mon, Aug 26, 2013 at 09:06:27AM -0700, Guenter Roeck wrote: On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote: On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote: Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to ohci-pci.c) added missing

Re: [PATCH] USB: gadget: audit sysfs attribute permissions

2013-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2013 at 01:28:41PM -0500, Felipe Balbi wrote: On Fri, Aug 23, 2013 at 04:34:43PM -0700, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Convert all USB gadget sysfs attributes to use the _RO or _RW variants, to make them easier to audit

Re: [Pull Request] xhci: Bug fixes for 3.12.

2013-08-27 Thread Greg Kroah-Hartman
On Tue, Aug 27, 2013 at 11:26:55AM -0700, Sarah Sharp wrote: The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) are available in the git repository at:

Re: [Pull Request] xhci: Remove warnings introduced by host quirks patch.

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 09:51:18AM -0700, Sarah Sharp wrote: The following changes since commit 752e69555d107853043cb9405250c9387b26e708: Merge tag 'usb-for-v3.12-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2013-08-27 14:07:31 -0700) are available

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: Please trim your replies. On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: That change seems to cause the problems: commit 0730d52a86919300a39a2be37f6c140997dfb82f xhci:prevent callbacks suppressed when

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 01:13:46PM -0400, Alan Stern wrote: On Wed, 28 Aug 2013, Greg Kroah-Hartman wrote: [Q] Why the special devices are only mice? Would high speed devices such as 3G modem or USB Bluetooth adapter trigger this issue? - Current this sensitivity is only confined

Re: [patch] dma: cppi41: off by one in desc_to_chan()

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 01:48:44PM +0300, Dan Carpenter wrote: The test here should be = instead of . The cdd-chan_busy[] array has ALLOC_DECS_NUM elements. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Vinod Koul vinod.k...@intel.com --- Resending to Greg and the USB

Set SEL for device-initiated U1 failed. errors

2013-08-29 Thread Greg Kroah-Hartman
Hi Sarah, I'm getting the following warnings from the 3.10.9 kernel all the time when I unplug a USB 3 storage device from my laptop: [203282.987687] usb 4-1: USB disconnect, device number 21 [203282.992904] usb 4-1: Set SEL for device-initiated U1 failed. [203282.992909]

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-30 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 04:36:14PM -0700, Graham Williams wrote: The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham Williams gwi...@broadcom.com Yeah, this finally worked! :)

Re: [PATCH V2 00/13] staging: dwc2: Register-related cleanups

2013-08-30 Thread Greg Kroah-Hartman
On Fri, Aug 30, 2013 at 06:45:10PM +0200, Matthijs Kooijman wrote: Hi folks, here's a resend of my previous patches, with some comments from Paul included, as well as rebased on top of a few patches from Paul which have since been included in staging-next. All of these patches, except

Re: [PATCH v3 4/4] usb: ohci: add AMD remote wakeup quirk into ohci driver

2013-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2013 at 06:24:44PM +0800, Huang Rui wrote: static void dl_done_list (struct ohci_hcd *); static void finish_unlinks (struct ohci_hcd *, u16); +static inline int root_port_reset (struct ohci_hcd *, unsigned); How can a definition of a function be inline? :) Can't you just

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-09 Thread Greg Kroah-Hartman
On Mon, Sep 09, 2013 at 07:33:31AM +0200, Andreas Larsson wrote: On 2013-08-28 11:02, Andreas Larsson wrote: On 2013-08-12 16:05, Andreas Larsson wrote: This adds an UDC driver for GRUSBDC USB Device Controller cores available in the GRLIB VHDL IP core library. The driver only supports

Re: [PATCH v3 2/4] usb: pci-quirks: add remote wakeup quirk for AMD platforms

2013-09-10 Thread Greg Kroah-Hartman
On Tue, Sep 10, 2013 at 11:37:44PM +0800, Huang Rui wrote: +EXPORT_SYMBOL_GPL(usb_amd_remote_wakeup_quirk); Nothing calls this function, so why have you added it here? The way you have broken up the patches is a bit odd. You are creating functions that aren't called yet, but do not

Re: [PATCH 1/2][usbutils] lsusb: port to hwdb

2013-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 04, 2013 at 02:47:07PM +0200, Tom Gundersen wrote: Most of the information in usb.ids is now contained in udev's hwdb. Read the information from the hwdb instead of usb.ids. This would allow distributions to no longer ship (most of) usb.ids by default, but rather keep all the usb

Re: [PATCH 1/2][usbutils] lsusb: port to hwdb

2013-09-12 Thread Greg Kroah-Hartman
device information in the hwdb. This patch introduces a dependency on libusb = 196. v2: drop support from reading data from usb.ids which is already in hwdb Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- Makefile.am | 5 +- configure.ac | 2 + names.c | 361

Re: [PATCH 2/2][usbutils] drop dependency on usb.ids

2013-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 04, 2013 at 02:47:08PM +0200, Tom Gundersen wrote: Also remove usb.ids from the repository. [Note that these were probably never used by distributions regarless, as most distros ship the usb.ids directly from upstream.] Hardcode the usb-spec information that used to be in

Re: [Pull Request] xhci: Bug fixes for 3.12.

2013-09-25 Thread Greg Kroah-Hartman
On Mon, Sep 23, 2013 at 05:58:56PM -0700, Sarah Sharp wrote: The following changes since commit 9d23108df359e572a0dca0b631bfee9f5e0fa9ea: Merge tag 'staging-3.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging (2013-09-23 12:53:07 -0700) are available in the git

Re: [PATCH v2 2/2] USB: unexport usb_bus_list_lock and update comments

2013-09-26 Thread Greg Kroah-Hartman
On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote: usb_bus_list_lock is used by usbfs, but that's in the same module as hcd.c, so there's no need to export it. Update the comment to show that it protects the set of root hubs as well as the list of buses. usbmon also uses this, so

[PATCH] USB: serial: option: add support for Inovia SEW858 device

2013-10-06 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org This patch adds the device id for the Inovia SEW858 device to the option driver. Reported-by: Pavel Parkhomenko ra85...@gmail.com Cc: stable sta...@vger.kernel.org Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/usb

[PATCH 05/11] uwb: convert bus code to use dev_groups

2013-10-07 Thread Greg Kroah-Hartman
The dev_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the uwb bus code to use the correct field. Cc: Bruno Morelli br...@evidence.eu.com Cc: linux-usb@vger.kernel.org Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers

Re: [PATCH 4/5] usb: xhci: Staticize xhci_del_comp_mod_timer

2013-10-09 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2013 at 12:53:51PM -0700, Sarah Sharp wrote: From: Sachin Kamat sachin.ka...@linaro.org 'xhci_del_comp_mod_timer' is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com ---

Re: [PATCH 4/5] usb: xhci: Staticize xhci_del_comp_mod_timer

2013-10-09 Thread Greg Kroah-Hartman
On Wed, Oct 09, 2013 at 03:15:31PM -0700, Sarah Sharp wrote: On Wed, Oct 09, 2013 at 01:10:47PM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 09, 2013 at 12:53:51PM -0700, Sarah Sharp wrote: From: Sachin Kamat sachin.ka...@linaro.org 'xhci_del_comp_mod_timer' is local to this file

Re: [Pull Request v2] xhci: Bug fixes and quirks for 3.12

2013-10-11 Thread Greg Kroah-Hartman
On Fri, Oct 11, 2013 at 11:36:57AM -0700, Sarah Sharp wrote: Ping. Have a couple more patches to send you for 3.12, can you pull this? Now pulled, I was on a plane from Korea, so patience please, I have no idea what day it is anymore (two days of flying for 2 days of meetings, not a good

Re: [PATCH V2 4/5] USB: ohci-exynos: Add missing usb_put_hcd()

2013-10-11 Thread 'Greg Kroah-Hartman'
On Thu, Oct 10, 2013 at 04:42:22PM +0900, Jingoo Han wrote: When devm_usb_get_phy() fails, usb_put_hcd() should be called to prevent memory leak. Signed-off-by: Jingoo Han jg1@samsung.com Already applied this one, thanks. greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH V2 3/5] USB: ohci-exynos: Remove non-DT support

2013-10-11 Thread 'Greg Kroah-Hartman'
On Thu, Oct 10, 2013 at 04:41:49PM +0900, Jingoo Han wrote: The non-DT for EXYNOS SoCs is not supported from v3.11. Thus, there is no need to support non-DT for Exynos OHCI driver. The 'include/linux/platform_data/usb-ohci-exynos.h' file has been used for non-DT support. Thus, the

Re: usb_control_msg and non-dma buffers

2013-10-14 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 08:47:36AM -0700, Guenter Roeck wrote: Hi all, I am getting the following smatch error in drivers/watchdog/pcwd_usb.c: drivers/watchdog/pcwd_usb.c:257 usb_pcwd_send_command() error: doing dma on the stack (buf) This is from a call to usb_control_msg(). Is

Re: USB regression in v3.12-rc4

2013-10-14 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 02:05:39PM -0500, Felipe Balbi wrote: Hi, On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote: On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: Hi, With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB (peripheral

Re: [Pull Request] xHCI bug fixes for 3.12 (Link PM and misc)

2013-10-15 Thread Greg Kroah-Hartman
On Mon, Oct 14, 2013 at 05:24:10PM -0700, Sarah Sharp wrote: The following changes since commit f4c19b8e165cff1a6607c21f8809441d61cab7ec: USB: serial: option: add support for Inovia SEW858 device (2013-10-11 16:17:51 -0700) are available in the git repository at:

Re: [Pull Request] xHCI bug fixes for 3.12 (Link PM and misc)

2013-10-15 Thread Greg Kroah-Hartman
On Tue, Oct 15, 2013 at 12:44:08PM -0700, Sarah Sharp wrote: So I'd like to take these for 3.13-rc1, and if they are fixes, take them into the 3.12-stable tree (and older ones) when they hit Linus's tree then. Ok, fine with me. Just to be clear though: are you asking me to delay these

Re: [PATCH] usb: fix misc/usb3503.c build error

2013-10-17 Thread Greg Kroah-Hartman
On Thu, Oct 17, 2013 at 10:09:00AM -0700, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix usb3503 build error - it uses an interface that is provided by REGMAP_I2C, so it needs to select that symbol. drivers/built-in.o: In function `usb3503_i2c_probe':

Re: [Pull Request] xhci: Final patches for 3.13

2013-10-19 Thread Greg Kroah-Hartman
On Thu, Oct 17, 2013 at 05:29:15PM -0700, Sarah Sharp wrote: The following changes since commit c00809d330cfe42469fcd1cfd63f0690b47ea9bb: USB: ohci-exynos: Remove non-DT support (2013-10-14 11:09:13 -0700) are available in the git repository at:

[PATCH] UWB: clean up attribute use by using ATTRIBUTE_GROUPS()

2013-10-20 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman gre...@linuxfoundation.org The ATTRIBUTE_GROUPS() macro can be used in the uwb code to reduce the number of lines of code. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/uwb/lc-dev.c | 16 +++- 1 file changed, 3 insertions(+), 13

Re: [PATCH][bugfix] usb/gadget: f_mass_storage: use string literal as format in dev_set_name

2013-10-25 Thread Greg Kroah-Hartman
On Fri, Oct 25, 2013 at 07:16:24AM -0500, Felipe Balbi wrote: On Fri, Oct 25, 2013 at 09:09:27AM +0200, Andrzej Pietrasiewicz wrote: Fix commit b27c08c953e994f792a03d9b7cbc5cf3f9844135 where dev_set_name() is used without a string literal as format. Reported-by: Fengguang Wu

Re: usbatm: printk_ratelimit() always called in the atm_rldbg()

2013-10-26 Thread Greg Kroah-Hartman
On Sat, Oct 26, 2013 at 03:29:56PM +0200, Krzysztof Mazur wrote: Hi, commit 2d6401cf4ca3861692a4779745e0049cac769d10 (USB: usbatm: move the atm_dbg() call to use dynamic debug) changed the atm_rldbg() to: #define atm_rldbg(instance, format, arg...) \ if

  1   2   3   4   5   6   7   8   9   10   >