Re: xhci driver problem

2013-07-18 Thread Sarah Sharp
to the system? If you unplug them, and re-plug in the camera, does it work? Please send me the output of `sudo lsusb -v` with only the camera plugged in, if it still doesn't work. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-18 Thread Sarah Sharp
On Thu, Jul 18, 2013 at 04:28:01PM -0400, Peter Hurley wrote: [ +cc Sarah Sharp, linux-usb ] On 07/18/2013 09:21 AM, Nestor Lopez Casado wrote: This reverts commit 8af6c08830b1ae114d1a8b548b1f8b056e068887. This patch re-adds the workaround introduced by 596264082f10dd4 which was reverted

Re: xhci driver problem

2013-07-18 Thread Sarah Sharp
On Thu, Jul 18, 2013 at 01:49:04PM -0700, Gene Kopan wrote: Hi Sarah, thanks for helping. I answer your questions below. On 07/18/2013 12:55 PM, Sarah Sharp wrote: On Thu, Jul 18, 2013 at 11:03:32AM -0700, Gene Kopan wrote: Hello Sarah, I am having an xhci_hcd problem on my ASUS U47A

Re: [PATCH] usb: Add Device Tree support to XHCI Platform driver

2013-07-18 Thread Sarah Sharp
, .remove = xhci_plat_remove, .driver = { .name = xhci-hcd, + .of_match_table = of_match_ptr(usb_xhci_of_match), }, }; MODULE_ALIAS(platform:xhci-hcd); -- 1.7.6 Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH] usb: xhci: add the suspend/resume functionality

2013-07-18 Thread Sarah Sharp
Hi Felipe, My bad, this patch got dropped. I've refreshed it against Greg's usb-next branch. Do you still want me to push this? Again, my apologies for dropping this. Sarah Sharp On Tue, Feb 12, 2013 at 11:07:30PM +0200, Felipe Balbi wrote: Hi, On Tue, Feb 12, 2013 at 12:47:23PM -0800

[RFC 1/2] xhci: Refactor port status into a new function.

2013-07-18 Thread Sarah Sharp
The hub control function is *way* too long. Refactor it into a new function, and document the side effects of calling that function. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 210 --- 1 files changed, 119

[RFC 0/2] xhci: Show USB 2.0 Link PM status

2013-07-18 Thread Sarah Sharp
Greetings! Alex has been working on some lsusb patches to show the USB 2.0 link status on xHCI hosts. In order to see whether an xHCI rootport is in the lower power link state L1, there needs to be some xHCI driver changes to show the USB 2.0 link status. Please review. Thanks, Sarah Sharp

[RFC 2/2] xhci: Report USB 2.1 link status for L1

2013-07-18 Thread Sarah Sharp
is active (in L0). Translate the xHCI USB 2.1 link status into the format external hubs use, and pass the L1 status up to the USB core and tools like lsusb. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 15 --- 1 files changed, 12 insertions

Re: [PATCH] usb: Add Device Tree support to XHCI Platform driver

2013-07-19 Thread Sarah Sharp
. :) Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB_QUIRK_RESET_RESUME not working with xhci

2013-07-22 Thread Sarah Sharp
after the device is reset. That will let me see if the xHCI host is allowing the device to be reset. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: xhci driver problem

2013-07-22 Thread Sarah Sharp
is asking for. Sarah Sharp On Sat, Jul 20, 2013 at 02:21:21PM -0700, Gene Kopan wrote: Hi Sarah, I did manage to unbind the internal camera in in my ASUS u47a laptop, but I still have the same problem and the same syslog bandwidth messages when plugging the ASUS Xtion rgbd camera

[PATCH 4/5] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Sarah Sharp
, but it's enough to do it in xHCI only because the hub driver doesn't start running again until after both hosts are resumed. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/ehci-pci.c | 42

[PATCH 5/5] xhci: Correct misplaced newlines

2013-07-23 Thread Sarah Sharp
From: Joe Perches j...@perches.com Logging messages end in newlines, not have them put in the middle of messages. Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci.c | 10 +- 1 files changed, 5 insertions

[Pull Request] xhci: Features for 3.12

2013-07-23 Thread Sarah Sharp
. They include a patch for suspend/resume support for xhci platform hosts, two patches to support showing USB 2.1 link status, and a patch to future-proof the Intel EHCI to xHCI port switchover. Sarah Sharp Joe Perches (1): xhci

[PATCH 2/5] xhci: Refactor port status into a new function.

2013-07-23 Thread Sarah Sharp
The hub control function is *way* too long. Refactor it into a new function, and document the side effects of calling that function. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 210 --- 1 files changed, 119

[PATCH 1/5] usb: xhci: add the suspend/resume functionality

2013-07-23 Thread Sarah Sharp
-by: Vikas C Sajjan vikas.saj...@linaro.org CC: Doug Anderson diand...@chromium.org Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-plat.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff

[PATCH 3/5] xhci: Report USB 2.1 link status for L1

2013-07-23 Thread Sarah Sharp
is active (in L0). Translate the xHCI USB 2.1 link status into the format external hubs use, and pass the L1 status up to the USB core and tools like lsusb. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 15 --- 1 files changed, 12 insertions

Re: [Pull Request] xhci: Features for 3.12

2013-07-24 Thread Sarah Sharp
On Tue, Jul 23, 2013 at 03:19:47PM -0700, Greg Kroah-Hartman wrote: On Tue, Jul 23, 2013 at 03:01:32PM -0700, Sarah Sharp wrote: The following changes since commit 3b2f64d00c46e1e4e9bd0bb9bb12619adac27a4b: Linux 3.11-rc2 (2013-07-21 12:05:29 -0700) are available in the git

Re: Nexus 4 causes system hang (xhci_hcd)

2013-07-24 Thread Sarah Sharp
. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Nexus 4 causes system hang (xhci_hcd)

2013-07-24 Thread Sarah Sharp
On Wed, Jul 24, 2013 at 08:25:18AM -0700, Sarah Sharp wrote: On Wed, Jul 24, 2013 at 03:39:01PM +0200, Vincent Thiele wrote: Nexus 4 causes system hang (xhci_hcd): It helps if you Cc the xHCI driver maintainer (me) on bug reports. Otherwise you run the risk of getting lost in my inbox

Re: [PATCH v2] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-07-24 Thread Sarah Sharp
and CONFIG_USB_XHCI_HCD_DEBUGGING turned on? Please send me the log from just before you start your script to when the device disconnects. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Enable xhci_hcd

2013-07-24 Thread Sarah Sharp
. Perhaps the BIOS is hiding the xHCI PCI device from the OS? Have you tried going into the BIOS and seeing if there is a way to enable the xHCI host? Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [Pull Request] xhci: Features for 3.12

2013-07-24 Thread Sarah Sharp
On Wed, Jul 24, 2013 at 09:09:32AM -0700, Greg Kroah-Hartman wrote: On Wed, Jul 24, 2013 at 08:13:49AM -0700, Sarah Sharp wrote: On Tue, Jul 23, 2013 at 03:19:47PM -0700, Greg Kroah-Hartman wrote: On Tue, Jul 23, 2013 at 03:01:32PM -0700, Sarah Sharp wrote: The following changes since

Re: [PATCH 1/5] usb: xhci: add the suspend/resume functionality

2013-07-24 Thread Sarah Sharp
On Wed, Jul 24, 2013 at 11:55:57AM -0400, Alan Stern wrote: On Tue, 23 Jul 2013, Sarah Sharp wrote: From: Vikas Sajjan vikas.saj...@linaro.org Adds power management support to xHCI platform driver. This patch facilitates the transition of xHCI host controller between S0 and S3/S4

Re: Nexus 4 causes system hang (xhci_hcd)

2013-07-24 Thread Sarah Sharp
. Once you've done that, I will send you a patch to apply on top of Linus' kernel, and I'll have you re-test. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/5] usb: xhci: add the suspend/resume functionality

2013-07-24 Thread Sarah Sharp
On Wed, Jul 24, 2013 at 01:02:31PM -0400, Alan Stern wrote: On Wed, 24 Jul 2013, Sarah Sharp wrote: +#ifdef CONFIG_PM +static int xhci_plat_suspend(struct device *dev) +{ + struct usb_hcd *hcd = dev_get_drvdata(dev); + struct xhci_hcd *xhci = hcd_to_xhci(hcd

Re: [PATCH] usb: xhci: Mark two functions __maybe_unused

2013-07-24 Thread Sarah Sharp
, I will queue this up shortly. Sarah Sharp Thanks, -Olof drivers/usb/host/xhci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 2c49f00..87ae8cd 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb

Re: xhci driver problem

2013-07-24 Thread Sarah Sharp
? Nope, the units are magic. I'd have to look at the code, but it's not really important to this discussion. Sarah Sharp --- (below is sudo su) whiz7u devices # cat

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-24 Thread Sarah Sharp
It looks like all the feedback has been addressed, but I'm no device tree expert. Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to my xhci tree. Sarah Sharp On Tue, Jul 23, 2013 at 06:35:33PM -0400, Al Cooper wrote: Add Device Tree match table to xhci-plat.c. Add DT

[RFC] xhci: Avoid NULL pointer deref when host dies.

2013-07-24 Thread Sarah Sharp
`, recompiling, and reinstalling. Please let me know if you need help doing this. Sarah Sharp 8-8 When the host controller fails to respond to an Enable Slot command, and the host fails to respond to the register write to abort the command ring

[RFC v2] xhci: Avoid NULL pointer deref when host dies.

2013-07-24 Thread Sarah Sharp
Bah, I made a mistake in my first patch, try this one instead. Sarah Sharp 8--8 When the host controller fails to respond to an Enable Slot command, and the host fails to respond to the register write to abort the command ring

[Pull Request] xhci: Bug fixes, now with more tags!

2013-07-25 Thread Sarah Sharp
. The three patches are marked for stable. Two fix NULL pointer dereferences. The third marked for stable suppresses some serious log spam from unnecessary xHCI driver warnings, whenever an isochronous short packet happens on an xHCI 1.0 host. The other two patches fix build warnings. Sarah Sharp

[PATCH 5/5] xhci: fix null pointer dereference on ring_doorbell_for_active_rings

2013-07-25 Thread Sarah Sharp
be backported to kernels as old as 2.6.35, that contain the commit e9df17eb1408cfafa3d1844bfc7f22c7237b31b8 USB: xhci: Correct assumptions about number of rings per endpoint Signed-off-by: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta

[PATCH 2/5] usb: xhci: Mark two functions __maybe_unused

2013-07-25 Thread Sarah Sharp
maze of ifdefs in this code, I've just marked both with __maybe_unused. Signed-off-by: Olof Johansson o...@lixom.net Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c

[PATCH 3/5] usb: fix build warning in pci-quirks.h when CONFIG_PCI is not enabled

2013-07-25 Thread Sarah Sharp
-off-by: Randy Dunlap rdun...@infradead.org Reported-by: Geert Uytterhoeven ge...@linux-m68k.org Cc: Moiz Sonasath m-sonas...@ti.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/pci-quirks.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/pci

[PATCH 1/5] xhci: Avoid NULL pointer deref when host dies.

2013-07-25 Thread Sarah Sharp
to halted hosts. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Reported-by: Vincent Thiele vincentthi...@gmail.com Cc: sta...@vger.kernel.org --- drivers/usb/host/xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host

[PATCH 4/5] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-07-25 Thread Sarah Sharp
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta...@vger.kernel.org --- drivers/usb/host/xhci-pci.c | 1 - drivers/usb/host/xhci.c | 7 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index cc24e39

Re: [RFC] xhci: add trace for debug messages related to changing contexts

2013-07-29 Thread Sarah Sharp
, trace_xhci_dbg_context_change, + Set up evaluate context for LPM MEL change.\n); xhci_dbg(xhci, Slot %u Input Context:\n, udev-slot_id); xhci_dbg_ctx(xhci, command-in_ctx, 0); -- 1.8.3.2 Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [RFC] xhci: add trace for debug messages related to changing contexts

2013-07-29 Thread Sarah Sharp
(). Bonus points if you can refactor that case statement into a separate static function called handle_configure_endpoint(). :) Sarah Sharp On Tue, Jul 23, 2013 at 06:14:55AM +0300, Xenia Ragiadakou wrote: This patch defines a new trace event, which is called xhci_dbg_context_change and belongs

Re: External HDD does not work with 3.11-rc2

2013-07-30 Thread Sarah Sharp
with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING might help me understand what's going on. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] usb: xhci: add missing dma-mapping.h includes

2013-07-30 Thread Sarah Sharp
Thanks for the patch James! I'll send it off to Greg in a couple days. Sarah Sharp On Fri, Jul 26, 2013 at 01:34:43PM +0100, James Hogan wrote: A randconfig build hit the following build errors because xhci.c and xhci-mem.c use dma mapping functions but don't include linux/dma-mapping.h. Add

Re: [PATCH] usb: core: don't try to reset_device() a port that got just disconnected

2013-07-31 Thread Sarah Sharp
that simply times out? Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-07-31 Thread Sarah Sharp
On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Ming Lei ming@canonical.com Acked-by: Sarah Sharp

Re: [PATCH v2] usb: core: don't try to reset_device() a port that got just disconnected

2013-07-31 Thread Sarah Sharp
to Greg shortly. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] usb: xhci: add missing dma-mapping.h includes

2013-07-31 Thread Sarah Sharp
: linux-usb@vger.kernel.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 1 + drivers/usb/host/xhci.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index df6978a..6f8c2fd 100644

[PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-07-31 Thread Sarah Sharp
reset if both are valid. Signed-off-by: Julius Werner jwer...@chromium.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/core/hub.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 4a8a1d6

Re: [PATCH V5] usb: Add Device Tree support to XHCI Platform driver

2013-07-31 Thread Sarah Sharp
On Thu, Jul 25, 2013 at 07:04:44PM -0400, Al Cooper wrote: Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper alcoop...@gmail.com --- Al, in the future, please add a description of your changes since the last revision here, after the --- line. It

Re: [PATCH 2/4] USB: XHCI: mark no_sg_limit

2013-08-01 Thread Sarah Sharp
On Thu, Aug 01, 2013 at 10:15:51AM +0200, Oliver Neukum wrote: On Thu, 2013-08-01 at 15:30 +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 09:40:26AM -0700, Sarah Sharp wrote: On Wed, Jul 31, 2013 at 06:51:47PM +0800, Ming Lei wrote: This patch marks all xHCI controllers

Re: [PATCH V5] usb: Add Device Tree support to XHCI Platform driver

2013-08-01 Thread Sarah Sharp
On Wed, Jul 31, 2013 at 11:45:48PM +0400, Sergei Shtylyov wrote: Hello. On 07/31/2013 10:48 PM, Sarah Sharp wrote: Sergei, Felipe, do you have a strong preference on this name? Or should I take the patch as is? I've already said I don't have a strong preference. Ok, I will take

Re: Possible issues on Intel USB 3.0 ports switchover mechnism.

2013-08-05 Thread Sarah Sharp
, thank you for the time you put into this patch and testing it. I appreciate the effort. Let me know if you have been running into the case where the xHCI host is dying, so that I can attempt to reproduce it and fix it. Sarah Sharp root@test-hsw-ult:~# lsusb -t /: Bus 03.Port 1: Dev 1, Class

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-05 Thread Sarah Sharp
On Mon, Aug 05, 2013 at 01:29:12PM +0800, Greg Kroah-Hartman wrote: On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: From: Julius Werner jwer...@chromium.org The USB hub driver's event handler contains a check to catch SuperSpeed devices that transitioned into the SS.Inactive

Re: [RFC] usb: rh_call_control tbuf overflow fix

2013-08-05 Thread Sarah Sharp
to changing the code to dynamically allocate tbuf? Is there a reason why we would need to avoid memory allocation failing here? Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

[RFC] xhci: Don't enable/disable RWE on bus suspend/resume.

2013-08-05 Thread Sarah Sharp
9574323c39d1f8359a04843075d89c9f32d8b7e6 xHCI: test USB2 software LPM. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta...@vger.kernel.org --- drivers/usb/host/xhci-hub.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b

[RFC 0/2] USB port power off bug fixes

2013-08-05 Thread Sarah Sharp
off seems to work as expected. Sarah Sharp The following changes since commit 444ce9d44d00969479aa1d2675f305a779369194: MAINTAINERS: Add separate section for USB NETWORKING DRIVERS (2013-08-05 13:42:46 +0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel

[RFC 2/2] usb: Don't fail port power resume on device disconnect.

2013-08-05 Thread Sarah Sharp
usb port auto power off mechanism Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Lan Tianyu tianyu@intel.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Cc: sta...@vger.kernel.org --- drivers/usb/core/port.c | 17 + 1

[RFC 1/2] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-05 Thread Sarah Sharp
-by: Lan Tianyu tianyu@intel.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta...@vger.kernel.org --- drivers/usb/core/hub.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 558313d..8a9379c 100644 --- a/drivers/usb

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: On Mon, 5 Aug 2013, Sarah Sharp wrote: Please review these two bug fixes for the USB port power off mechanism. I especially need review for the second patch, since it involves issues with the runtime status of the USB port

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote: On Tue, 6 Aug 2013, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: Patch 1 has been rendered out of date by intervening changes (commit 4fae6f0fa86f in Greg's usb-next tree). Greg

Re: ar5523 Gigaset USB Adapter 108 issue

2013-08-06 Thread Sarah Sharp
Please recompile your kernel with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING turned on, and email dmesg from when you first plug in the device, to when it fails. Thanks, Sarah Sharp On Thu, Aug 01, 2013 at 07:41:27PM +0200, Yannik Völker wrote: -BEGIN PGP SIGNED MESSAGE- Hash

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 06:04:36AM +0800, Greg Kroah-Hartman wrote: On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: I wanted to test it for a kernel release to make sure it didn't cause any issues before sending it off to stable. I'm sure it fixes Julius' issues on his Intel

Re: xHCI ISR be registered twice

2013-08-07 Thread Sarah Sharp
comments that need to be addressed in the next version of your patch. First, please use this email address to send me patches: Sarah Sharp sarah.a.sh...@linux.intel.com I use the linux.intel.com email address to handle all patches and traffic to the Linux mailing lists. My intel.com email address

Re: ar5523 Gigaset USB Adapter 108 issue

2013-08-07 Thread Sarah Sharp
, since he's the EHCI maintainer. Yannik, you don't need to recompile your kernel in that case. Alan, can you debug this issue with Yannik since it doesn't seem to be an xHCI issue? Sarah Sharp Am 07.08.2013 05:39, schrieb Sarah Sharp: Please recompile your kernel with CONFIG_USB_DEBUG

Re: Linux USB power delivery

2013-08-08 Thread Sarah Sharp
I've heard there's little to do at the software level, but I haven't been following the spec closely. Are you volunteering to add support? Sarah Sharp On Thu, Aug 08, 2013 at 06:16:54PM +0530, Rajaram R wrote: Hi All Can someone share thoughts if there is a work in progress or plan on USB

[RFT] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-08 Thread Sarah Sharp
Hi Yu, Please test this patch, and make sure that interrupts aren't registered twice. I think this approach is better, since it creates a new quirk specifically for xhci platform devices, so we can tell them apart from PCI devices. Sarah Sharp 8

Re: [RFC V3] usb: rh_call_control tbuf overflow fix

2013-08-09 Thread Sarah Sharp
explaining the norm? SubmittingPatches is no help here. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Sarah Sharp
USB 2.0 roothubs. Sarah Sharp On Fri, Aug 09, 2013 at 12:20:49PM -0700, Alexandra Yates wrote: Modified the xHCI roothub descriptor to return USB2.0 extension descriptor Best Effort Service Latency (BESL) and Deep Best Effort Service Latency (DBESL) values when set on the xHCI host. On link

Re: Linux USB power delivery

2013-08-09 Thread Sarah Sharp
On Fri, Aug 09, 2013 at 04:31:25PM +0300, Felipe Balbi wrote: On Thu, Aug 08, 2013 at 07:25:47AM -0700, Sarah Sharp wrote: I've heard there's little to do at the software level, but I haven't you've heard ? IIRC your name is in the spec :-) /me checks. Huh, yes, you're right

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-09 Thread Sarah Sharp
: code indent should use tabs where possible #57: FILE: drivers/usb/host/xhci-hub.c:732: + * usb2_bos_descriptor */$ total: 3 errors, 0 warnings, 82 lines checked Please fix these and resend. Sarah Sharp On Fri, Aug 09, 2013 at 08:32:32PM +, Yates, Alexandra wrote

Re: [RFC v3] xhci-hub: Roothub USB2.0 descriptor for BESL DBESL

2013-08-13 Thread Sarah Sharp
; + buf[8] |= USB_BESL_BASELINE_VALID; + buf[9] = xhci-besl; + } Does that make sense? If you have any questions, you can get me on IRC. I may not be in the office tomorrow, but I will definitely be in the office on Thursday. Sarah Sharp

URBs active during clear endpoint halt?

2013-08-13 Thread Sarah Sharp
the endpoint doorbell? Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 0/2] USB port power off bug fixes

2013-08-13 Thread Sarah Sharp
On Mon, Aug 12, 2013 at 01:44:16PM -0700, Greg Kroah-Hartman wrote: On Tue, Aug 06, 2013 at 01:16:50PM -0700, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote: On Tue, 6 Aug 2013, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern

Re: Linux USB power delivery

2013-08-13 Thread Sarah Sharp
On Mon, Aug 12, 2013 at 12:17:43PM +0530, Rajaram R wrote: On Thu, Aug 8, 2013 at 7:55 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: I've heard there's little to do at the software level, but I haven't been following the spec closely. As I see it at least there has to be some

Re: [PATCH] Bug 60699 - Stalled state of endpoint will not be cleared

2013-08-13 Thread Sarah Sharp
for your patience! Sarah Sharp On Tue, Aug 13, 2013 at 08:16:28PM +0200, Florian Wolter wrote: On Tuesday 13 August 2013 19:27:52 Sergei Shtylyov wrote: Hello. On 08/13/2013 08:52 PM, Florian Wolter wrote: Patch to Fix Problem with not cleared halted endpoint. See Bugtracker Bug 60699

Re: [RFC v5] xhci: fix dma mask setup in xhci.c

2013-08-13 Thread Sarah Sharp
menuconfig` and double check that all the dependencies for CONFIG_XHCI_PLATFORM are met, so that you're compiling xhci-plat.ko. Please fix this and resubmit. Sarah Sharp On Mon, Aug 05, 2013 at 10:50:20PM +0300, Xenia Ragiadakou wrote: The function dma_set_mask() tests internally whether

Re: [RFC 2/3] xhci: trace debug messages related to driver initialization and unload

2013-08-13 Thread Sarah Sharp
I've tried several ways to apply this patch, and I can't get it to apply with `git am`. Can you rebase this series against my for-usb-next-queue branch and resend it? Thanks, Sarah Sharp On Tue, Aug 13, 2013 at 12:38:44AM +0300, Xenia Ragiadakou wrote: This patch defines a new trace event

Re: Dynamic debug on by default?

2013-08-14 Thread Sarah Sharp
On Wed, Aug 14, 2013 at 10:04:10AM -0700, Greg KH wrote: On Wed, Aug 14, 2013 at 09:51:54AM -0700, Joe Perches wrote: On Wed, 2013-08-14 at 09:40 -0700, Sarah Sharp wrote: Hi Xenia, I'm a bit confused. I thought that debugging messages would be turned off by default for a module

Re: [PATCH 2/5] usb-core: Track if an endpoint has streams

2013-08-15 Thread Sarah Sharp
On Wed, Aug 14, 2013 at 02:32:03PM +0200, Hans de Goede wrote: - /* Streams only apply to bulk endpoints. */ - for (i = 0; i num_eps; i++) + for (i = 0; i num_eps; i++) { + /* Streams only apply to bulk endpoints. */ if

[Pull Request] xhci: Platform updates, 64-bit DMA, and trace events for 3.12.

2013-08-15 Thread Sarah Sharp
that Xenia has made, and I look forward to her future contributions to the Linux kernel. Sarah Sharp Al Cooper (1): usb: Add Device Tree support to XHCI Platform driver Xenia Ragiadakou (13): xhci: replace xhci_info

[PATCH 02/14] xhci: replace xhci_info() with xhci_dbg()

2013-08-15 Thread Sarah Sharp
that their output can be dynamically controlled via the dynamic debugging mechanism. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci.c | 4 ++-- drivers/usb/host/xhci.h | 2 -- 2 files changed, 2 insertions(+), 4

[PATCH 01/14] usb: Add Device Tree support to XHCI Platform driver

2013-08-15 Thread Sarah Sharp
From: Al Cooper alcoop...@gmail.com Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper alcoop...@gmail.com Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Cc: Felipe Balbi ba...@ti.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com

[PATCH 10/14] xhci: add xhci_cmd_completion trace event

2013-08-15 Thread Sarah Sharp
, in a human readable way, the completion status and flags as well as the command's type and fields using the trace-cmd tool and the appropriate plugin. Also, a tracepoint is added in handle_cmd_completion(). Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh

[PATCH 11/14] xhci: trace debug statements for urb cancellation

2013-08-15 Thread Sarah Sharp
. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 64 +++ drivers/usb/host/xhci-trace.h | 5 drivers/usb/host/xhci.c | 13 + 3 files changed, 54

[PATCH 14/14] xhci: fix dma mask setup in xhci.c

2013-08-15 Thread Sarah Sharp
-hccparams. - hcd-self.controller was replaced with the dev variable since it is already available. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-plat.c | 10 ++ drivers/usb/host/xhci.c | 19

[PATCH 07/14] xhci: add trace for debug messages related to quirks

2013-08-15 Thread Sarah Sharp
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 7 +++-- drivers/usb/host/xhci-pci.c | 14 + drivers/usb/host/xhci-ring.c | 11 --- drivers/usb/host/xhci-trace.h | 5 drivers/usb/host/xhci.c | 67

[PATCH 05/14] xhci: add traces for debug messages in xhci_address_device()

2013-08-15 Thread Sarah Sharp
Command is issued to xHC. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/Makefile | 4 drivers/usb/host/xhci-dbg.c | 14 + drivers/usb/host/xhci-trace.c | 15 + drivers/usb/host

[PATCH 06/14] xhci: add trace for debug messages related to changing contexts

2013-08-15 Thread Sarah Sharp
Context commands. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 4 +++- drivers/usb/host/xhci-ring.c | 4 +++- drivers/usb/host/xhci-trace.h | 5 + drivers/usb/host/xhci.c | 24

[PATCH 13/14] xhci: trace debug statements related to ring expansion

2013-08-15 Thread Sarah Sharp
allocated to hold all pending TRBs. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 3 ++- drivers/usb/host/xhci-ring.c | 4 ++-- drivers/usb/host/xhci-trace.h | 5 + 3 files changed, 9

[PATCH 08/14] xhci: add trace for debug messages related to endpoint reset

2013-08-15 Thread Sarah Sharp
-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 3 ++- drivers/usb/host/xhci-trace.h | 5 + drivers/usb/host/xhci.c | 17 +++-- 3 files changed, 18 insertions(+), 7 deletions

[PATCH 04/14] xhci: remove CONFIG_USB_XHCI_HCD_DEBUGGING and unused code

2013-08-15 Thread Sarah Sharp
() and xhci_event_ring_work() that are not useful anymore. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/Kconfig| 9 -- drivers/usb/host/xhci-mem.c | 70 -- drivers/usb/host/xhci.c

[PATCH 12/14] xhci: trace debug messages related to driver initialization and unload

2013-08-15 Thread Sarah Sharp
an unnecessary cast of variable val to unsigned int in xhci_mem_init(), since val is already declared as unsigned int. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 110

[PATCH 09/14] xhci: add xhci_address_ctx trace event

2013-08-15 Thread Sarah Sharp
and adds the associated tracepoints in xhci_address_device(). Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-trace.h | 42 ++ drivers/usb/host/xhci.c | 7 +++ 2

Re: [RFC 0/2] USB port power off bug fixes

2013-08-15 Thread Sarah Sharp
On Tue, Aug 13, 2013 at 03:42:11PM -0700, Sarah Sharp wrote: On Mon, Aug 12, 2013 at 01:44:16PM -0700, Greg Kroah-Hartman wrote: I tried to cherry pick this patch from my usb-next branch to my usb-linus branch, but it fails :( So, could you port it, add a cc: stable line, and then resend

[PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-15 Thread Sarah Sharp
-by: Lan Tianyu tianyu@intel.com Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta...@vger.kernel.org --- drivers/usb/core/hub.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 8287953

[Pull Request] xhci: Step 2 to fix usb-linus and usb-next.

2013-08-15 Thread Sarah Sharp
. This pull request is step two. Sarah Sharp Aaro Koskinen (1): cpufreq: loongson2: fix regression related to clock management Aaron Lu (1): drm/i915: avoid brightness overflow when doing scale Afzal Mohammed (2): ARM

[Pull Request] xhci: Step 1 to fix usb-linus and usb-next.

2013-08-15 Thread Sarah Sharp
of commit 4fae6f0fa86f92e6bc7429371b1e177ad0aaac66, the two port power off fixes, and an unrelated xhci-plat bug fix. Sarah Sharp Alan Stern (1): USB: handle LPM errors during device suspend correctly Lan Tianyu (1): usb

[PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Sarah Sharp
may be useful in the future, in case other corner cases like this arise. This patch should be backported to kernels as old as 3.9, that contain the commit 00eed9c814cb8f281be6f0f5d8f45025dc0a97eb USB: xhci: correctly enable interrupts. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com

[PATCH 3/4] usb: Don't fail port power resume on device disconnect.

2013-08-15 Thread Sarah Sharp
usb port auto power off mechanism Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Lan Tianyu tianyu@intel.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Cc: sta...@vger.kernel.org Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com

[PATCH 1/4] USB: handle LPM errors during device suspend correctly

2013-08-15 Thread Sarah Sharp
. Signed-off-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: sta...@vger.kernel.org --- drivers/usb/core/hub.c | 71 +++--- 1 file changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/usb/core

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-16 Thread Sarah Sharp
On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: From: Lan Tianyu tianyu@intel.com The pm qos NO_POWER_OFF flag is checked twice during usb device suspend to see if the usb port power off condition is met

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Sarah Sharp
? not really, as of today we need out of tree patches to get that board booting anyway :-( Ok, I'll queue this patch for usb-next and 3.12 as well. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

  1   2   3   4   5   6   7   8   9   10   >