Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-18 Thread Stephen Warren
On 07/18/2013 10:45 AM, Paul Zimmerman wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Gordon Hollingworth Sent: Wednesday, July 17, 2013 11:00 PM I'd suggest just adding a Raspberry Pi Foundation copyright. Is that OK or do you need names

Re: [PATCH] staging: dwc2: add driver parameter to set AHB config register value

2013-07-18 Thread Stephen Warren
parameter, since that bit can now be set using 'ahbcfg'. This patch does not add DT support to platform.c, I will leave that to whoever owns the first platform that needs a non-default value. (Stephen?) Tested-by: Stephen Warren swar...@wwwdotorg.org -- To unsubscribe from this list: send

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-19 Thread Stephen Warren
On 07/17/2013 02:07 PM, Paul Zimmerman wrote: ... With the two additional patches I sent out yesterday and today, the driver is working really well for me on the Pi with your mainline- based kernel. I was able to run an overnight test copying data to/from a thumb drive (not to the root fs due

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Stephen Warren
On 07/19/2013 12:36 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-19 Thread Stephen Warren
On 07/19/2013 01:55 PM, Paul Zimmerman wrote: From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Thursday, July 18, 2013 11:01 PM ... I then wanted to try WiFi, so I plugged in a USB mouse/keyboard, and started X, trying to use GUI tools. Then I saw some issues. With just the USB

Re: [PATCH 0/9] Tegra USB cleanup series

2013-07-24 Thread Stephen Warren
On 07/24/2013 05:32 AM, Felipe Balbi wrote: Hi, On Mon, Jul 01, 2013 at 04:03:41PM -0600, Stephen Warren wrote: On 06/28/2013 03:36 PM, Tuomas Tynkkynen wrote: Hi, Here's a few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals

Re: [PATCH v2 2/3] Documentation: devicetree: phy-tegra-usb: Add vbus-supply property for host mode PHYs

2013-07-29 Thread Stephen Warren
On 06/28/2013 06:33 AM, Mikko Perttunen wrote: Add vbus-supply as an optional property for host mode phy-tegra-usb PHYs. Felipe, I see that you didn't merge this one patch from this series. Was there a reason for that? At this stage, I would consider it reasonable for DT binding documentation

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-07-31 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Peter, Prashant, I think you said that the lock bits should

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Stephen Warren
On 07/31/2013 01:53 PM, Sergei Shtylyov wrote: Hello. On 07/31/2013 11:31 PM, Tuomas Tynkkynen wrote: Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. diff --git a/arch/arm/boot/dts/tegra114.dtsi

Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-07-31 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. That much is correct. Also, a third GPIO is required to

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Stephen Warren
On 07/31/2013 04:20 PM, Sergei Shtylyov wrote: On 08/01/2013 02:06 AM, Stephen Warren wrote: ... That's really horrible design. Yup. Both USB PHY and EHCI controller registers really are interleaved in one range. But the standard EHCI register space has no holes IIRC, so they can't

Re: [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-07-31 Thread Stephen Warren
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Hi all, Here are the patches for the USB tree to enable USB Host support on Tegra30 and Tegra114. These are based on my and Mikko's cleanup patches that just got merged to Felipe's tree. This series works fine for me on Dalmore. However, on

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode -

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control. - UTMIP_HSSQUELCH_LEVEL: HS squelch detector

Re: [PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-01 Thread Stephen Warren
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: Document the new device tree parameters for Tegra30 USB PHY. Very minor nit: It would make sense to move this patch before the previous patch (or squash them together) so that the documentation is updated first. But, it makes no difference to the

Re: [PATCH 6/6] usb: host: tegra: Tegra30 support

2013-08-01 Thread Stephen Warren
. The new tegra_ehci_soc_config structure is added to describe the differences between the SoCs. Aside from the minor issues I already pointed out, the series briefly, Reviewed-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-06 Thread Stephen Warren
-by: Stephen Warren swar...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com (Tested on all of Tegra20/paz00, Tegra30/Beaver, Tegra114/Dalmore, all with a USB NIC only) -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Stephen Warren
On 08/12/2013 05:07 AM, Mark Rutland wrote: [Adding Olof] On Mon, Aug 12, 2013 at 10:51:36AM +0100, Mark Brown wrote: On Sun, Aug 11, 2013 at 09:53:01PM -0400, Alan Stern wrote: On Sun, 11 Aug 2013, Mark Brown wrote: One example that's bugging me right now is that on the Insignal Arndale

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-13 Thread Stephen Warren
On 08/09/2013 03:53 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) and HS, SS PHY's controll and configuration registers. s/controll/control/ It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS).

Re: [PATCH RESEND] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-16 Thread Stephen Warren
On 08/14/2013 02:09 PM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Tested-by: Stephen Warren swar...@nvidia.com Acked

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-16 Thread Stephen Warren
On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). diff

Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

2013-08-16 Thread Stephen Warren
On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote: This prefix is currently used for the musb driver. diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt +mg Mentor Graphics It's slightly short; I would have

Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

2013-08-19 Thread Stephen Warren
On 08/17/2013 03:27 AM, Sebastian Andrzej Siewior wrote: On 08/17/2013 12:52 AM, Stephen Warren wrote: On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote: This prefix is currently used for the musb driver. diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-19 Thread Stephen Warren
On 08/19/2013 06:27 AM, Ivan T. Ivanov wrote: Hi, On Fri, 2013-08-16 at 16:44 -0600, Stephen Warren wrote: On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-19 Thread Stephen Warren
On 08/16/2013 04:13 AM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. diff --git a/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt b/Documentation/devicetree/bindings/extcon/extcon-dra7xx.txt +EXTCON FOR DRA7xx

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-20 Thread Stephen Warren
On 08/20/2013 12:55 AM, George Cherian wrote: Hi Stephen, Thanks for your review. On 8/20/2013 1:01 AM, Stephen Warren wrote: On 08/16/2013 04:13 AM, George Cherian wrote: Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. diff --git

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread Stephen Warren
On 08/21/2013 07:06 AM, George Cherian wrote: Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change. In that case

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Stephen Warren
On 08/29/2013 05:48 AM, George Cherian wrote: On 8/29/2013 4:07 PM, Chanwoo Choi wrote: ... I tested various development board based on Samsung Exynos series SoC. Although some gpio of Exynos series SoC set high state(non zero, 1) as default value, this gpio state could mean off state,

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-29 Thread Stephen Warren
On 08/28/2013 11:33 AM, George Cherian wrote: Add a generic USB VBUS/ID detection EXTCON driver. This driver expects the ID/VBUS pin are connected via GPIOs. This driver is tested on DRA7x board were the ID pin is routed via GPIOs. The driver supports both VBUS and ID pin configuration and ID

Re: [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-29 Thread Stephen Warren
On 08/28/2013 11:33 AM, George Cherian wrote: Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts dwc3_1 { - dr_mode = otg; + dr_mode =

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Stephen Warren
with it? Aside from that, the binding, Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: EHCI: tegra: drop clk_put for devm_clk_get in tegra_ehci_probe()

2013-09-30 Thread Stephen Warren
On 09/27/2013 02:22 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn devm_clk_get() is used so there is no reason to explicitly call clk_put() in probe or remove functions. Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line

Re: [PATCH] USB: host: tegra: CONFIG_USB_EHCI_TEGRA requires ULPI and ULPI viewport support

2013-10-04 Thread Stephen Warren
On 10/04/2013 12:02 AM, Paul Walmsley wrote: Selecting CONFIG_USB_EHCI_TEGRA requires CONFIG_USB_ULPI_VIEWPORT. Otherwise the build can break with: drivers/usb/phy/phy-tegra-usb.c: In function 'ulpi_open': drivers/usb/phy/phy-tegra-usb.c:689:31: error: 'ulpi_viewport_access_ops'

Re: [PATCH RESEND 2/2] usb: host: tegra: Resetting PORT0 based on information received via DT.

2013-01-11 Thread Stephen Warren
On 01/11/2013 05:14 PM, Greg KH wrote: On Thu, Jan 03, 2013 at 01:29:32PM -0700, Stephen Warren wrote: On 01/03/2013 12:29 AM, Venu Byravarasu wrote: Tegra USB host driver is using port instance number, to handle some of the hardware issues on SOC e.g. reset PORT0 twice etc. As instance

Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

2013-01-11 Thread Stephen Warren
On 01/11/2013 05:14 PM, Greg KH wrote: On Fri, Dec 21, 2012 at 01:54:55PM -0700, Stephen Warren wrote: On 12/20/2012 11:34 PM, Venu Byravarasu wrote: Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy. This ensures that all function pointers in member u_phy are initialized

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

2013-01-15 Thread Stephen Warren
On 01/15/2013 03:19 AM, Venu Byravarasu wrote: As tegra_usb_phy_clk_disable/enable() are not being used, removing them. Greg, Felipe, Again if I may, I'll take this through the Tegra tree. I think the next set of patches that Venu posts should actually expose the dependencies between his USB

Re: [PATCH] usb: phy: remove unused APIs from Tegra PHY.

2013-01-16 Thread Stephen Warren
On 01/16/2013 12:12 AM, Felipe Balbi wrote: Hi, On Tue, Jan 15, 2013 at 11:04:51AM -0700, Stephen Warren wrote: On 01/15/2013 03:19 AM, Venu Byravarasu wrote: As tegra_usb_phy_clk_disable/enable() are not being used, removing them. Greg, Felipe, Again if I may, I'll take this through

Re: [PATCH 1/4] arm: tegra: Add DT nodes for Tegra USB PHY

2013-01-16 Thread Stephen Warren
On 01/16/2013 06:30 AM, Venu Byravarasu wrote: Add DT nodes for Tegra USB PHY along with related documentation. Also added a phandle property to controller DT node, for referring to connected PHY instance. Just a quick reminder to Greg, Felipe, Alan: Once this series passes review, I'll need

Re: [PATCH 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-16 Thread Stephen Warren
On 01/16/2013 08:08 AM, Alan Stern wrote: On Wed, 16 Jan 2013, Venu Byravarasu wrote: As Tegra PHY driver needs to access one of the Host registers, added few APIs. --- a/drivers/usb/host/ehci-tegra.c +++ b/drivers/usb/host/ehci-tegra.c +void tegra_ehci_set_wakeon_events(struct usb_phy

Re: [PATCH 3/4] USB: PHY: Tegra: Get rid of instance number to differentiate PHY type

2013-01-18 Thread Stephen Warren
On 01/16/2013 06:30 AM, Venu Byravarasu wrote: Tegra20 USB has 3 PHY instances: Instance 1 and 3 are UTMI. Instance 2 is ULPI. As instance number was used to differentiate ULPI from UTMI, used DT param to get this info and processed accordingly. diff --git

Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-18 Thread Stephen Warren
On 01/18/2013 08:30 AM, Alan Stern wrote: On Fri, 18 Jan 2013, Venu Byravarasu wrote: As Tegra PHY driver needs to access one of the Host registers, added few APIs. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- delta from v2: Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1. Removed

Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-18 Thread Stephen Warren
On 01/18/2013 10:58 AM, Felipe Balbi wrote: On Fri, Jan 18, 2013 at 10:28:38AM -0700, Stephen Warren wrote: On 01/18/2013 08:30 AM, Alan Stern wrote: On Fri, 18 Jan 2013, Venu Byravarasu wrote: As Tegra PHY driver needs to access one of the Host registers, added few APIs. Signed-off

Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-18 Thread Stephen Warren
On 01/17/2013 11:15 PM, Venu Byravarasu wrote: As Tegra PHY driver needs to access one of the Host registers, added few APIs. I have applied patches 1-3 (v1) and patch 4 (v3) to Tegra's for-3.9/usb branch. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a

[PATCH 1/2] usb: host: tegra: don't touch EMC clock

2013-01-22 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com Clock emc is for the External Memory Controller. The USB driver has no business touching this clock directly. Remove the code that does so. Signed-off-by: Stephen Warren swar...@nvidia.com --- Greg, Alan, I'd like to take this patch through the Tegra tree

[PATCH 2/2] ARM: tegra: add clocks properties to USB PHY nodes

2013-01-22 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com The patch to add USB PHY nodes to device tree was written before Tegra supported the clocks property in device tree. Now that it does, add the required clocks properties to these nodes. This will allow all clk_get_sys() calls in tegra_usb_phy.c

Re: [PATCH 2/2] ARM: tegra: add clocks properties to USB PHY nodes

2013-01-22 Thread Stephen Warren
On 01/22/2013 05:28 PM, Stephen Warren wrote: The patch to add USB PHY nodes to device tree was written before Tegra supported the clocks property in device tree. Now that it does, add the required clocks properties to these nodes. This will allow all clk_get_sys() calls in tegra_usb_phy.c

Re: [PATCH 1/2] usb: host: tegra: don't touch EMC clock

2013-01-23 Thread Stephen Warren
On 01/23/2013 02:45 AM, Lucas Stach wrote: Am Mittwoch, den 23.01.2013, 12:25 +0530 schrieb Venu Byravarasu: -Original Message- From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra- ow...@vger.kernel.org] On Behalf Of Stephen Warren Sent: Wednesday, January 23, 2013 5:58 AM

Re: [PATCH 2/2] ARM: tegra: add clocks properties to USB PHY nodes

2013-01-23 Thread Stephen Warren
On 01/22/2013 11:43 PM, Venu Byravarasu wrote: Stephen Warren wrote at Wednesday, January 23, 2013 6:03 AM: On 01/22/2013 05:28 PM, Stephen Warren wrote: The patch to add USB PHY nodes to device tree was written before Tegra supported the clocks property in device tree. Now that it does, add

Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD

2013-01-24 Thread Stephen Warren
On 01/24/2013 06:05 AM, Felipe Balbi wrote: Hi, On Thu, Jan 24, 2013 at 03:57:03PM +0530, Venu Byravarasu wrote: As pointer to PHY structure can be stored in struct usb_hcd making use of it, to call Tegra PHY APIs. Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(), so that

Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-24 Thread Stephen Warren
On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act in host mode or in device mode. Writing to control module registers

Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD

2013-01-28 Thread Stephen Warren
On 01/24/2013 03:27 AM, Venu Byravarasu wrote: As pointer to PHY structure can be stored in struct usb_hcd making use of it, to call Tegra PHY APIs. Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(), so that to avoid dereferencing of hcd after its freed up. I have applied this

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Stephen Warren
On 01/29/2013 06:44 AM, kishon wrote: Hi, On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the

Re: [PATCH, RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Stephen Warren
On 01/29/2013 04:22 AM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik

Re: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy directory

2013-02-07 Thread Stephen Warren
On 02/07/2013 06:38 AM, kishon wrote: On Thursday 07 February 2013 05:02 PM, Venu Byravarasu wrote: As drivers/usb/otg/otg.c contains most of the PHY related APIs which are not OTG specific, moving them to more logical place under drivers/usb/phy. diff --git a/drivers/usb/phy/Makefile

Re: [PATCH 09/10] USB: EHCI: make ehci-msm a separate driver

2013-02-07 Thread Stephen Warren
On 02/07/2013 10:34 AM, manjunath.gou...@linaro.org wrote: Separate the Qualcomm On-Chip host controller driver from ehci-hcd host code into its own driver module. diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig @@ -209,7 +210,7 @@ config USB_EHCI_TEGRA boolean

Re: [PATCH 06/10] USB: EHCI: make ehci-s5p a separate driver

2013-02-07 Thread Stephen Warren
On 02/07/2013 10:34 AM, manjunath.gou...@linaro.org wrote: Separate the s5p host controller driver from ehci-hcd host code into its own driver module. diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c @@ -1297,11 +1297,6 @@ MODULE_LICENSE (GPL); #define

Re: [PATCH 3/8] USB: EHCI: make ehci-s5p a separate driver

2013-02-11 Thread Stephen Warren
On 02/10/2013 11:58 AM, manjunath.gou...@linaro.org wrote: From: Manjunath Goudar manjunath.gou...@linaro.org Separate the s5p host controller driver from ehci-hcd host code into its own driver module. diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c -#ifdef

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 08:09 AM, Alan Stern wrote: On Thu, 28 Feb 2013, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- When U-Boot configures a Tegra USB controller

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c @@ -691,6 +692,10 @@ static int tegra_ehci_probe(struct platform_device

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 11:52 AM, Alan Stern wrote: On Thu, 28 Feb 2013, Stephen Warren wrote: I think this patch might cause unintended consequences. When the Tegra PHY code is converted to a driver (i.e. has its own probe), the initial order of execution of the PHY and EHCI driver probes

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Stephen Warren
On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: On 02/27/2013 11:36 PM, Venu Byravarasu wrote: To clear any configurations made by U-Boot on Tegra USB controller, reset it before init in probe. diff --git a/drivers/usb/host/ehci

Re: [PATCH 3/4] USB: Palmas OTG Transceiver Driver

2013-03-05 Thread Stephen Warren
On 03/05/2013 07:21 AM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable diff --git

Re: [PATCH 09/10] usb: ehci: tegra: check against CONFIG_USB_PHY

2013-03-07 Thread Stephen Warren
On 03/07/2013 02:36 AM, Felipe Balbi wrote: CONFIG_USB_OTG_UTILS will be removed very soon, so we should check CONFIG_USB_PHY instead. The Tegra EHCI driver isn't very useful without the Tegra PHY driver. Perhaps its Kconfig should simply select USB_PHY, and the ifdefs be removed rather than

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-07 Thread Stephen Warren
On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed otg_state_string() to usb_otg_state_string(), moved it to usb-common, then moved all phy drivers to drivers/usb/phy/

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired by Paul's DWC2 patchset which added usb_otg_state_string() (a copy of otg_state_string()) I have now renamed

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-08 Thread Stephen Warren
On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure that we have sensible names for all phy drivers. Current situation was already quite bad with too generic names being

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 11:26 AM, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren wrote: On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: On 03/07/2013 02:35 AM, Felipe Balbi wrote: Hi folks, inspired

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 04:08 PM, Arnd Bergmann wrote: On Friday 08 March 2013, Stephen Warren wrote: Yes, I think it should instead work like: ARCH_TEGRA* selects nothing in particular related to USB. The Tegra EHCI controller Kconfig depends on ARCH_TEGRA so it doesn't show up for other builds

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Stephen Warren
On 03/08/2013 04:56 PM, Arnd Bergmann wrote: On Friday 08 March 2013, Stephen Warren wrote: config USB_ULPI_VIEWPORT def_bool y depends on USB_EHCI_TEGRA If USB_ULPI_VIEWPORT has any other dependencies, the best solution in the above scenario is to make USB_EHCI_TEGRA depend

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Stephen Warren
On 03/11/2013 12:59 AM, Felipe Balbi wrote: Hi, On Fri, Mar 08, 2013 at 10:26:45AM -0700, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-11 Thread Stephen Warren
On 03/11/2013 12:49 PM, Felipe Balbi wrote: Hi, On Mon, Mar 11, 2013 at 11:02:43AM -0600, Stephen Warren wrote: On 03/08/2013 12:08 AM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 01:37:17PM -0700, Stephen Warren wrote: On 03/07/2013 08:45 AM, Felipe Balbi wrote: this will make sure

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-15 Thread Stephen Warren
On 03/14/2013 05:01 AM, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 11:37:17AM -0700, Stephen Warren wrote: On 03/08/2013 11:26 AM, Felipe Balbi wrote: On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren wrote: On 03/08/2013 12:14 AM, Felipe Balbi wrote: Hi, On Thu, Mar 07, 2013

Re: [PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-15 Thread Stephen Warren
On 03/15/2013 03:12 AM, Felipe Balbi wrote: PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). This change will definitely conflict with some Tegra EHCI/USB-PHY changes that Venu plans to submit very soon, for 3.10. This is relevant since we'd previously

Re: [PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-18 Thread Stephen Warren
On 03/18/2013 02:02 AM, Felipe Balbi wrote: Hi, On Fri, Mar 15, 2013 at 03:12:08PM -0600, Stephen Warren wrote: On 03/15/2013 03:12 AM, Felipe Balbi wrote: PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). This change will definitely conflict with some

Reboot/shutdown failure due to USB: EHCI: work around silicon bug in Intel's EHCI

2013-03-18 Thread Stephen Warren
Alan, In v3.9-rc3, I find that reboot and shutdown hang on Tegra. I bisected it to commit 6402c79 USB: EHCI: work around silicon bug in Intel's EHCI controllers, and confirmed that running v3.9-rc3 with just that one patch reverted does solve the problem. Do you have any idea what the problem

USB-related build errors on Tegra in next-20130319

2013-03-19 Thread Stephen Warren
Felipe, I see the following Kconfig warnings in next-20130319: warning: (ARCH_TEGRA_2x_SOC ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT USB_PHY ARM) warning: (ARCH_TEGRA_2x_SOC ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct

Re: Reboot/shutdown failure due to USB: EHCI: work around silicon bug in Intel's EHCI

2013-03-19 Thread Stephen Warren
On 03/19/2013 12:34 PM, Alan Stern wrote: On Mon, 18 Mar 2013, Stephen Warren wrote: Alan, In v3.9-rc3, I find that reboot and shutdown hang on Tegra. I bisected it to commit 6402c79 USB: EHCI: work around silicon bug in Intel's EHCI controllers, and confirmed that running v3.9-rc3

Re: [PATCH 6/7] usb: phy: tegra: Add error handling clean up.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: Check return values from all GPIO APIs and handle errors accordingly. Remove clk_disable_unprepare which is no more needed. Patches 6 and 7 each fail checkpatch with WARNING: line over 80 characters. -- To unsubscribe from this list: send the line

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: As part of this series, apart from patch containing changes to register TEGRA USB PHY driver as platform driver, prepared below patches: 1. Re-arranging adding new DT properties. 2. Getting various params from DT properties added. 3. code clean

Re: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: Added a new PHY mode to support OTG. Obtained Tegra USB PHY mode using DT property. diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c @@ -713,6 +712,16 @@ struct tegra_usb_phy *tegra_usb_phy_open(struct device

Re: Reboot/shutdown failure due to USB: EHCI: work around silicon bug in Intel's EHCI

2013-03-19 Thread Stephen Warren
On 03/19/2013 02:07 PM, Alan Stern wrote: On Tue, 19 Mar 2013, Stephen Warren wrote: Yes, sysrq seems to work over the serial console:-) * Will now restart *** break sent *** [ 180.765213] SysRq : Show Blocked State [ 180.768963] taskPC stack pid father

Re: Reboot/shutdown failure due to USB: EHCI: work around silicon bug in Intel's EHCI

2013-03-19 Thread Stephen Warren
On 03/19/2013 04:48 PM, Stephen Warren wrote: On 03/19/2013 02:07 PM, Alan Stern wrote: ... A dmesg log with CONFIG_USB_DEBUG enabled would be helpful. We ought to be able to tell where khubd is getting stuck. Hmmm. Enabling CONFIG_USB_DEBUG appears to mask the problem. I assume

Re: [Regression] process hangs due to USB: EHCI: work around silicon bug in Intels EHCI controllers

2013-03-19 Thread Stephen Warren
On 03/19/2013 06:03 PM, Andreas Bombe wrote: The named commit (6402c796d3) causes a process to hang indefinitely in usb_kill_urb(). Reverting it fixes the problem. The bug also prevents suspend/shutdown/reboot from completing, presumably due to the hanging process. (Cc'ing Stephen Warren

Re: USB-related build errors on Tegra in next-20130319

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote: Hi, On Tue, Mar 19, 2013 at 10:29:05AM -0600, Stephen Warren wrote: I see the following Kconfig warnings in next-20130319: warning: (ARCH_TEGRA_2x_SOC ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT

Re: USB-related build errors on Tegra in next-20130319

2013-03-20 Thread Stephen Warren
On 03/20/2013 10:45 AM, Felipe Balbi wrote: Hi, On Wed, Mar 20, 2013 at 10:39:11AM -0600, Stephen Warren wrote: On 03/20/2013 06:20 AM, Felipe Balbi wrote: ... The patch you gave fixes the Kconfig warnings, but not the build failure. ... For now, I think the correct solution is to have

[PATCH] USB: EHCI: have USB_EHCI_TEGRA select USB_PHY

2013-03-20 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com ehci-tegra.c calls functions in phy-usb-tegra.c. Hence, that file must be built if ehci-tegra.c is. To ensure this, drivers/usb/phy/Makefile always builds phy-usb-tegra.c under the same Kconfig option that builds ehci-tegra.c. However, after the following

Re: Reboot/shutdown failure due to USB: EHCI: work around silicon bug in Intel's EHCI

2013-03-20 Thread Stephen Warren
On 03/20/2013 08:40 AM, Alan Stern wrote: On Tue, 19 Mar 2013, Stephen Warren wrote: On 03/19/2013 04:48 PM, Stephen Warren wrote: On 03/19/2013 02:07 PM, Alan Stern wrote: ... A dmesg log with CONFIG_USB_DEBUG enabled would be helpful. We ought to be able to tell where khubd is getting

Re: USB-related build errors on Tegra in next-20130319

2013-03-20 Thread Stephen Warren
On 03/20/2013 11:11 AM, Felipe Balbi wrote: Hi, On Wed, Mar 20, 2013 at 10:51:49AM -0600, Stephen Warren wrote: On 03/20/2013 10:45 AM, Felipe Balbi wrote: Hi, On Wed, Mar 20, 2013 at 10:39:11AM -0600, Stephen Warren wrote: On 03/20/2013 06:20 AM, Felipe Balbi wrote: ... The patch you

Re: [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:15 AM, Venu Byravarasu wrote: -Original Message- From: kishon [mailto:kis...@ti.com] Sent: Wednesday, March 20, 2013 4:49 PM To: Venu Byravarasu Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; ba...@ti.com; linux-usb@vger.kernel.org;

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-20 Thread Stephen Warren
On 03/20/2013 05:23 AM, kishon wrote: Hi, On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote: This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:12 AM, Venu Byravarasu wrote: -Original Message- From: Venu Byravarasu Sent: Wednesday, March 20, 2013 11:30 AM To: 'Stephen Warren' Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org

Re: USB-related build errors on Tegra in next-20130319

2013-03-20 Thread Stephen Warren
On 03/20/2013 11:30 AM, Felipe Balbi wrote: On Wed, Mar 20, 2013 at 11:26:50AM -0600, Stephen Warren wrote: On 03/20/2013 11:11 AM, Felipe Balbi wrote: Hi, On Wed, Mar 20, 2013 at 10:51:49AM -0600, Stephen Warren wrote: On 03/20/2013 10:45 AM, Felipe Balbi wrote: Hi, On Wed, Mar 20

Re: [PATCH 7/7] usb: phy: registering tegra USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:43 AM, Venu Byravarasu wrote: Stephen Warren wrote at Wednesday, March 20, 2013 1:51 AM: On 03/18/2013 06:29 AM, Venu Byravarasu wrote: Registered tegra USB PHY as a separate platform driver. diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 11:36 AM, Stephen Warren wrote: On 03/20/2013 06:12 AM, Venu Byravarasu wrote: Venu Byravarasu wrote at Wednesday, March 20, 2013 11:30 AM: Stephen Warren wrote at Wednesday, March 20, 2013 1:22 AM: On 03/18/2013 06:29 AM, Venu Byravarasu wrote: As part of this series, apart

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-20 Thread Stephen Warren
On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. diff --git

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-21 Thread Stephen Warren
On 03/21/2013 12:23 AM, kishon wrote: Hi, On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote: On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-03-21 Thread Stephen Warren
On 03/21/2013 06:23 AM, Felipe Balbi wrote: PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). The patches that I'll put into my topic branch are not yet complete; Venu first posted them a couple days back and there are a number of issues that will require a

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-03-21 Thread Stephen Warren
On 03/21/2013 11:31 AM, Felipe Balbi wrote: On Thu, Mar 21, 2013 at 11:19:51AM -0600, Stephen Warren wrote: On 03/21/2013 06:23 AM, Felipe Balbi wrote: PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). The patches that I'll put into my topic branch

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Stephen Warren
On 03/26/2013 04:28 AM, Laxman Dewangan wrote: On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote: On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote: ... + return regmap_read(palmas-regmap[slave], addr, dest); Please use the generic api for palmas_read()/palmas_write(0

  1   2   3   4   >