Re: [PATCH net-next v2 0/2] of: mdio: Fall back to mdiobus_register() with NULL device_node

2018-05-16 Thread David Miller
From: Florian Fainelli Date: Tue, 15 May 2018 16:56:17 -0700 > This patch series updates of_mdiobus_register() such that when the device_node > argument is NULL, it calls mdiobus_register() directly. This is consistent > with > the behavior of of_mdiobus_register() when

Re: [PATCH net,stable] qmi_wwan: do not steal interfaces from class drivers

2018-05-03 Thread David Miller
From: Bjørn Mork Date: Wed, 2 May 2018 22:22:54 +0200 > The USB_DEVICE_INTERFACE_NUMBER matching macro assumes that > the { vendorid, productid, interfacenumber } set uniquely > identifies one specific function. This has proven to fail > for some configurable devices. One

Re: [PATCH] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2

2018-04-27 Thread David Miller
From: SZ Lin (林上智) Date: Thu, 26 Apr 2018 14:30:13 +0800 > This patch adds support for PID 0x90b2 of ublox R410M. > > qmicli -d /dev/cdc-wdm0 --dms-get-manufacturer > [/dev/cdc-wdm0] Device manufacturer retrieved: > Manufacturer: 'u-blox' > > qmicli -d /dev/cdc-wdm0

Re: [PATCH v4 0/3] lan78xx: Read configuration from Device Tree

2018-04-20 Thread David Miller
From: Phil Elwell Date: Thu, 19 Apr 2018 17:59:37 +0100 > The Microchip LAN78XX family of devices are Ethernet controllers with > a USB interface. Despite being discoverable devices it can be useful to > be able to configure them from Device Tree, particularly in low-cost >

Re: [PATCH] net: qmi_wwan: add Wistron Neweb D19Q1

2018-04-19 Thread David Miller
From: Pawel Dembicki Date: Wed, 18 Apr 2018 16:03:24 +0200 > This modem is embedded on dlink dwr-960 router. > The oem configuration states: ... > Tested on openwrt distribution > > Signed-off-by: Pawel Dembicki Applied and queued up for

Re: [PATCH] lan78xx: Don't reset the interface on open

2018-04-11 Thread David Miller
From: Phil Elwell Date: Tue, 10 Apr 2018 13:18:25 +0100 > Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY > initialisation into lan78xx_probe, but lan78xx_open subsequently calls > lan78xx_reset. As well as forcing a second round of link negotiation, > this

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

2018-04-11 Thread David Miller
From: Oliver Neukum Date: Wed, 11 Apr 2018 13:25:38 +0200 > Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >>     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >>     using cdc_ether as a driver. >> >>     The modem is  controlled via AT

Re: [PATCH] lan78xx: Avoid spurious kevent 4 "error"

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 12:02:47 +0100 > lan78xx_defer_event generates an error message whenever the work item > is already scheduled. lan78xx_open defers three events - > EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware > of the

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 10:59:17 +0100 > lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP > content, but the value gets overwritten before it is returned and the > read goes ahead anyway. Make the read conditional as it should be > and

Re: [PATCH v2] lan78xx: Connect phy early

2018-04-04 Thread David Miller
From: Alexander Graf Date: Wed, 4 Apr 2018 00:19:35 +0200 > When using wicked with a lan78xx device attached to the system, we > end up with ethtool commands issued on the device before an ifup > got issued. That lead to the following crash: > ... > The culprit is quite simple:

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread David Miller
From: Marc Zyngier Date: Mon, 02 Apr 2018 10:45:40 +0100 > What has changed between this patch and the previous one? Having a bit > of a change-log would certainly help. Also, I would have appreciated a > reply to the questions I had on v2 before you posted a third version.

Re: [PATCH v2 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-01 Thread David Miller
From: Marc Zyngier Date: Sat, 31 Mar 2018 12:16:05 + > I'd suggest that this patch is reverted until we understand what is > actually going on here. Yep, makes sense, reverted. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCHv2] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

2018-03-26 Thread David Miller
From: Torsten Hilbrich Date: Mon, 26 Mar 2018 07:19:57 +0200 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich Applied, thank you. -- To unsubscribe from this list: send the line

Re: [PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

2018-03-26 Thread David Miller
From: Pawel Dembicki Date: Sat, 24 Mar 2018 22:08:14 +0100 > BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. > Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. > The USB id is added to qmi_wwan.c to allow QMI communication with > the BM806U. > >

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-26 Thread David Miller
From: Joe Perches Date: Fri, 23 Mar 2018 15:54:39 -0700 > Prefer the direct use of octal for permissions. > > Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace > and some typing. > > Miscellanea: > > o Whitespace neatening around these conversions. > >

Re: [PATCH] net/usb/qmi_wwan.c: Add USB id for lt4120 modem

2018-03-25 Thread David Miller
From: Torsten Hilbrich Date: Fri, 23 Mar 2018 14:26:18 +0100 > This is needed to support the modem found in HP EliteBook 820 G3. > > Signed-off-by: Torsten Hilbrich This patch was corrupted by your email client, it transformed TAB

Re: [PATCH] net: drivers/net: Remove unnecessary skb_copy_expand OOM messages

2018-03-15 Thread David Miller
From: Joe Perches Date: Mon, 12 Mar 2018 08:07:12 -0700 > skb_copy_expand without __GFP_NOWARN already does a dump_stack > on OOM so these messages are redundant. > > Signed-off-by: Joe Perches Ok, applied to net-next, thanks. -- To unsubscribe from this

Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path

2018-03-07 Thread David Miller
From: Johan Hovold Date: Wed, 7 Mar 2018 10:46:57 +0100 > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface()

Re: [PATCH net-next 2/2] net: cdc_eem: clean up bind error path

2018-03-07 Thread David Miller
From: Johan Hovold Date: Wed, 7 Mar 2018 10:46:58 +0100 > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface()

Re: [PATCH net] net: usbnet: fix potential deadlock on 32bit hosts

2018-03-07 Thread David Miller
From: Eric Dumazet Date: Mon, 05 Mar 2018 11:41:13 -0800 > From: Eric Dumazet > > Marek reported a LOCKDEP issue occurring on 32bit host, > that we tracked down to the fact that usbnet could either > run from soft or hard irqs. > > This patch adds

Re: [PATCH 2/2] net: usb: asix88179_178a: de-duplicate code

2018-03-04 Thread David Miller
From: Alexander Kurz Date: Wed, 28 Feb 2018 21:27:39 + > -static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) > +static int ax88179_link_bind_or_reset(struct usbnet *dev, int do_reset) "do_reset" is a boolean, therefore please use type 'bool' and

Re: [PATCH] net/usb/kalmia: use ARRAY_SIZE for various array sizing calculations

2018-03-02 Thread David Miller
From: Colin King Date: Fri, 2 Mar 2018 13:42:39 + > From: Colin Ian King > > Use the ARRAY_SIZE macro on a couple of arrays to determine > size of the arrays. Also fix up alignment to clean up a checkpatch > warning. Improvement

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

2018-02-27 Thread David Miller
From: Bassem Boubaker Date: Tue, 27 Feb 2018 14:04:44 +0100 > The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. > > The modem is controlled via AT commands through the exposed TTYs. > > AT^SWWAN write command can be used to activate or

Re: [PATCH net 0/2] r8152: fix rx issues

2018-02-02 Thread David Miller
From: Hayes Wang Date: Fri, 2 Feb 2018 16:43:34 +0800 > The two patched are used to fix rx issues. Series applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] sparc,leon: Select USB_UHCI_BIG_ENDIAN_{MMIO,DESC}

2018-01-31 Thread David Miller
From: James Hogan Date: Wed, 31 Jan 2018 22:24:46 + > Now that USB_UHCI_BIG_ENDIAN_MMIO and USB_UHCI_BIG_ENDIAN_DESC are moved > outside of the USB_SUPPORT conditional, simply select them from > SPARC_LEON rather than by the symbol's defaults in drivers/usb/Kconfig, >

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread David Miller
From: Hayes Wang Date: Thu, 18 Jan 2018 03:04:08 + > [...] >> > r8153 on Dell TB15/16 dock corrupts rx packets. >> > >> > This change is suggested by Realtek. They guess that the XHCI >> > controller doesn't have enough buffer, and their guesswork is correct, >> > once

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-17 Thread David Miller
From: Kai-Heng Feng Date: Tue, 16 Jan 2018 16:46:27 +0800 > r8153 on Dell TB15/16 dock corrupts rx packets. > > This change is suggested by Realtek. They guess that the XHCI controller > doesn't have enough buffer, and their guesswork is correct, once the RX >

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

2018-01-02 Thread David Miller
From: SZ Lin (林上智) Date: Fri, 29 Dec 2017 17:02:17 +0800 > This patch adds support for PID 0x9625 of YUGA CLM920-NC5. > > YUGA CLM920-NC5 needs to enable QMI_WWAN_QUIRK_DTR before QMI operation. > > qmicli -d /dev/cdc-wdm0 -p --dms-get-revision > [/dev/cdc-wdm0] Device

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-15 Thread David Miller
From: Bjørn Mork Date: Thu, 14 Dec 2017 19:55:50 +0100 > It has been reported that the dummy byte we add to avoid > ZLPs can be forwarded by the modem to the PGW/GGSN, and that > some operators will drop the connection if this happens. > > In theory, QMI devices are based on CDC

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-13 Thread David Miller
From: ssjoh...@mac.com Date: Mon, 11 Dec 2017 21:51:14 +0100 > From: Sebastian Sjoholm > > Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. > The USB id is added to qmi_wwan.c to allow QMI communication > with the EM7565. > > Signed-off-by: Sebastian Sjoholm

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-07 Thread David Miller
From: Bjørn Mork <bj...@mork.no> Date: Thu, 07 Dec 2017 20:01:16 +0100 > David Miller <da...@davemloft.net> writes: > >> From: Bjørn Mork <bj...@mork.no> >> Date: Wed, 6 Dec 2017 20:21:24 +0100 >> >>> The qmi_wwan minidriver support a 'raw

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

2017-12-06 Thread David Miller
From: Bjørn Mork Date: Wed, 6 Dec 2017 20:21:24 +0100 > The qmi_wwan minidriver support a 'raw-ip' mode where frames are > received without any ethernet header. This causes alignment issues > because the skbs allocated by usbnet are "IP aligned". > > Fix by allowing minidrivers

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-11-21 Thread David Miller
From: Sebastian Sjoholm Date: Mon, 20 Nov 2017 19:05:17 +0100 > Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both > CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development > board (EVB). The USB id is added to qmi_wwan.c to allow QMI >

Re: [PATCH] usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set

2017-11-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 17 Nov 2017 14:02:09 -0600 > _dev_ is being dereferenced before it is null checked, hence there > is a potential null pointer dereference. > > Fix this by moving the pointer dereference after _dev_ has been null > checked. > >

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread David Miller
From: Greg Kroah-Hartman Date: Fri, 17 Nov 2017 15:19:39 +0100 > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source >

Re: [PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

2017-11-15 Thread David Miller
From: Bjørn Mork Date: Wed, 15 Nov 2017 09:35:02 +0100 > The GetNtbFormat and SetNtbFormat requests operate on 16 bit little > endian values. We get away with ignoring this most of the time, because > we only care about USB_CDC_NCM_NTB16_FORMAT which is 0x. This > fails for

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

2017-11-07 Thread David Miller
From: Kristian Evensen Date: Tue, 7 Nov 2017 13:47:56 +0100 > When we receive a packet on a QMI device in raw IP mode, we should call > skb_reset_mac_header() to ensure that skb->mac_header contains a valid > offset in the packet. While it shouldn't really matter,

Re: [PATCH net,stable] net: cdc_ether: fix divide by 0 on bad descriptors

2017-11-07 Thread David Miller
From: Bjørn Mork Date: Mon, 6 Nov 2017 15:37:22 +0100 > Setting dev->hard_mtu to 0 will cause a divide error in > usbnet_probe. Protect against devices with bogus CDC Ethernet > functional descriptors by ignoring a zero wMaxSegmentSize. > > Signed-off-by: Bjørn Mork

Re: [PATCH net,stable] net: qmi_wwan: fix divide by 0 on bad descriptors

2017-11-07 Thread David Miller
From: Bjørn Mork Date: Mon, 6 Nov 2017 15:32:18 +0100 > A CDC Ethernet functional descriptor with wMaxSegmentSize = 0 will > cause a divide error in usbnet_probe: > > divide error: [#1] PREEMPT SMP KASAN ... > Fix by simply ignoring the bogus descriptor, as it is optional

Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-04 Thread David Miller
From: Andrey Konovalov Date: Thu, 2 Nov 2017 21:26:59 +0100 > When asix_suspend() is called dev->driver_priv might not have been > assigned a value, so we need to check that it's not NULL. > > Found by syzkaller. ... > Signed-off-by: Andrey Konovalov

Re: [PATCH] net: hso: remove redundant unused variable dev

2017-11-01 Thread David Miller
From: Colin King Date: Tue, 31 Oct 2017 12:01:47 + > From: Colin Ian King > > The pointer dev is being assigned but is never used, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/net/usb/hso.c:2280:2:

Re: [PATCH] cdc_ether: flag the Huawei ME906/ME909 as WWAN

2017-10-24 Thread David Miller
From: Aleksander Morgado Date: Mon, 23 Oct 2017 17:16:41 +0200 > The Huawei ME906 (12d1:15c1) comes with a standard ECM interface that > requires management via AT commands sent over one of the control TTYs > (e.g. connected with AT^NDISDUP). > > Signed-off-by:

Re: [PATCH] drivers/net/usb: add device id for TP-LINK UE300 USB 3.0 Ethernet

2017-10-24 Thread David Miller
From: Ran Wang Date: Mon, 23 Oct 2017 18:10:23 +0800 > This product is named 'TP-LINK USB 3.0 Gigabit Ethernet Network > Adapter (Model No.is UE300)'. It uses chip RTL8153 and works with > driver drivers/net/usb/r8152.c > > Signed-off-by: Ran Wang

Re: [PATCH] cdc_ether: flag the u-blox TOBY-L2 and SARA-U2 as wwan

2017-10-09 Thread David Miller
From: Aleksander Morgado Date: Mon, 9 Oct 2017 14:05:12 +0200 > The u-blox TOBY-L2 is a LTE Cat 4 module with HSPA+ and 2G fallback. > This module allows switching to different USB profiles with the > 'AT+UUSBCONF' command, and provides a ECM network interface when the

Re: [PATCH] rndis_host: support Novatel Verizon USB730L

2017-10-03 Thread David Miller
From: Bjørn Mork Date: Tue, 03 Oct 2017 16:01:15 +0200 > We can pretty much ignore the USB-IF and any specs, since that is what > the vendors appear to do. They provide device specific drivers for > Windows, so all they care about is that their device "works" with their > driver.

Re: [PATCH] rndis_host: support Novatel Verizon USB730L

2017-10-02 Thread David Miller
From: Aleksander Morgado Date: Wed, 27 Sep 2017 23:31:03 +0200 > I'm not sure if binding this logic to a specific vid:pid (1410:9030) > would be more appropriate here, or if it's ok to just bind > class/subclass/protocol (as in the activesync case). Let me know > what

Re: [PATCH V4] r8152: add Linksys USB3GIGV1 id

2017-10-01 Thread David Miller
From: Grant Grundler Date: Thu, 28 Sep 2017 11:35:00 -0700 > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler

Re: [PATCH 1/1] net: usb: catc: use setup_timer() helper

2017-09-21 Thread David Miller
From: Allen Pais Date: Thu, 21 Sep 2017 18:24:15 +0530 > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais Applied. -- To unsubscribe from this list: send the line

Re: [PATCH v2] cdc_ncm: flag the u-blox TOBY-L4 as wwan

2017-08-28 Thread David Miller
From: Aleksander Morgado Date: Fri, 25 Aug 2017 15:39:16 +0200 > The u-blox TOBY-L4 is a LTE Advanced (Cat 6) module with HSPA+ and 2G > fallback. > > Unlike the TOBY-L2, this module has one single USB layout and exposes > several TTYs for control and a NCM interface

Re: [PATCH net,stable] qmi_wwan: fix NULL deref on disconnect

2017-08-08 Thread David Miller
From: Bjørn Mork Date: Tue, 8 Aug 2017 18:02:11 +0200 > qmi_wwan_disconnect is called twice when disconnecting devices with > separate control and data interfaces. The first invocation will set > the interface data to NULL for both interfaces to flag that the > disconnect has

Re: [PATCH V1 0/3] asix: Improve robustness

2017-08-07 Thread David Miller
From: Dean Jenkins Date: Mon, 7 Aug 2017 09:50:13 +0100 > Please consider taking these patches to improve the robustness of the ASIX USB > to Ethernet driver. I applied these to 'net' since they are bug fixes. Please target bug fixes to 'net' instead of 'net-next' in

Re: [PATCH 2/2] usb: qmi_wwan: add D-Link DWM-222 device ID

2017-08-02 Thread David Miller
From: Hector Martin Date: Wed, 2 Aug 2017 00:45:44 +0900 > Signed-off-by: Hector Martin Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 00/10] constify net attribute_group structures.

2017-07-18 Thread David Miller
From: Arvind Yadav Date: Tue, 18 Jul 2017 15:13:44 +0530 > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with const > attribute_group. So mark the non-const structs as const. Series applied,

Re: [PATCH] smsc95xx: use ethtool_op_get_ts_info()

2017-07-14 Thread David Miller
From: Petr Kulhavy Date: Thu, 13 Jul 2017 19:40:57 +0200 > This change enables the use of SW timestamping on Raspberry PI. > > smsc95xx uses the usbnet transmit function usbnet_start_xmit(), which > implements software timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE >

Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

2017-07-14 Thread David Miller
From: Enrico Mioso Date: Tue, 11 Jul 2017 17:21:52 +0200 > Some firmwares in Huawei E3372H devices have been observed to switch back > to NTB 32-bit format after altsetting switch. > This patch implements a driver flag to check for the device settings and > set NTB format to

Re: [PATCH v2 00/10] Constify attribute_group structures

2017-07-11 Thread David Miller
From: Arvind Yadav Date: Tue, 11 Jul 2017 12:52:41 +0530 > attribute_groups are not supposed to change at runtime. So mark the > non-const structs as const. Please resubmit this when net-next is open again: http://vger.kernel.org/~davem/net-next.html Thank

Re: [PATCH] net: cdc_mbim: apply "NDP to end" quirk to HP lt4132

2017-07-03 Thread David Miller
From: Tore Anderson Date: Sat, 1 Jul 2017 15:20:02 +0200 > The HP lt4132 LTE/HSPA+ 4G Module (03f0:a31d) is a rebranded Huawei > ME906s-158 device. It, like the ME906s-158, requires the "NDP to end" > quirk for correct operation. > > Signed-off-by: Tore Anderson

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-07-03 Thread David Miller
From: Jim Baxter Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-06-30 Thread David Miller
From: Jim Baxter Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources

Re: [PATCH] net: usb: asix88179_178a: Add support for the Belkin B2B128

2017-06-27 Thread David Miller
From: "Andrew F. Davis" Date: Mon, 26 Jun 2017 12:41:20 -0500 > The Belkin B2B128 is a USB 3.0 Hub + Gigabit Ethernet Adapter, the > Ethernet adapter uses the ASIX AX88179 USB 3.0 to Gigabit Ethernet > chip supported by this driver, add the USB ID for the same. > > This patch is

Re: [PATCH net-next] r8152: correct the definition

2017-06-21 Thread David Miller
From: Hayes Wang Date: Wed, 21 Jun 2017 11:25:18 +0800 > Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH net-next v2 0/2] r8152: adjust runtime suspend/resume

2017-06-16 Thread David Miller
From: Hayes Wang <hayesw...@realtek.com> Date: Fri, 16 Jun 2017 03:29:01 +0000 > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, June 14, 2017 1:02 AM >> > v2: >> > For #1, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). >> > &g

Re: [PATCH net-next 0/3] r8152: support new chips

2017-06-15 Thread David Miller
From: Hayes Wang Date: Thu, 15 Jun 2017 14:44:01 +0800 > These patches are used to support new chips. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net,stable] qmi_wwan: new Telewell and Sierra device IDs

2017-06-13 Thread David Miller
From: Bjørn Mork Date: Tue, 13 Jun 2017 19:10:18 +0200 > A new Sierra Wireless EM7305 device ID used in a Toshiba laptop, > and two Longcheer device IDs entries used by Telewell TW-3G HSPA+ > branded modems. > > Reported-by: Petr Kloc > Reported-by: Teemu

Re: [PATCH net-next v2 0/2] r8152: adjust runtime suspend/resume

2017-06-13 Thread David Miller
From: Hayes Wang Date: Tue, 13 Jun 2017 15:14:38 +0800 > v2: > For #1, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). > > v1: > Improve the flow about runtime suspend/resume and make the code > easy to read. Series applied. -- To unsubscribe from this list: send

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: David Miller <da...@davemloft.net> Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT) > From: Yuval Shaia <yuval.sh...@oracle.com> > Date: Mon, 12 Jun 2017 17:15:08 +0300 > >> Make return value void since function never return meaningfull value >> >&g

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 17:15:08 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > v0 ->v1: >

Re: [PATCH v1] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 10:42:33 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > Re-sending

Re: [PATCH net-next 00/11] r8152: minor adjustment

2017-06-09 Thread David Miller
From: Hayes Wang Date: Fri, 9 Jun 2017 17:11:37 +0800 > Adjust some code to make it reasonable or satisfy the suggestion from > the engineers. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] net/{mii,smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void

2017-06-05 Thread David Miller
From: Yuval Shaia Date: Sun, 4 Jun 2017 20:22:00 +0300 > Make return value void since functions never returns meaningfull value. > > Signed-off-by: Yuval Shaia Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v9 06/15] mlx5: Replace PCI pool old API

2017-05-23 Thread David Miller
From: Romain Perier Date: Tue, 23 May 2017 10:53:36 +0200 > Hello, > > > Le 23/05/2017 à 09:27, Leon Romanovsky a écrit : >> On Mon, May 22, 2017 at 06:48:58PM +0200, Romain Perier wrote: >>> The PCI pool API is deprecated. This commit replaces the PCI pool old >>>

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-05-23 Thread David Miller
From: Oliver Neukum <oneu...@suse.com> Date: Tue, 23 May 2017 10:42:48 +0200 > Am Montag, den 22.05.2017, 11:54 -0400 schrieb David Miller: >> >> Unfortunately without a real notifier of some sort (there isn't one, and >> it isn't actually easy to come up with a

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-05-22 Thread David Miller
From: "Baxter, Jim" Date: Mon, 22 May 2017 16:45:42 +0100 > From: David S. Miller (da...@davemloft.net) > Sent: Wed, 17 May 2017 14:18:19 -0400 > >> >> When there isn't memory pressure this will hurt performance of >> course. >> >> It is a quite common paradigm to back

Re: [PATCH] net1080: Remove unused function nc_dump_ttl()

2017-05-18 Thread David Miller
From: Matthias Kaehlcke Date: Thu, 18 May 2017 10:57:19 -0700 > The function is not used, removing it fixes the following warning when > building with clang: > > drivers/net/usb/net1080.c:271:20: error: unused function > 'nc_dump_ttl' [-Werror,-Wunused-function] > > Also

Re: [PATCH] r8152: Remove unused function usb_ocp_read()

2017-05-18 Thread David Miller
From: Matthias Kaehlcke Date: Thu, 18 May 2017 10:45:33 -0700 > The function is not used, removing it fixes the following warning when > building with clang: > > drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' > [-Werror,-Wunused-function] > >

Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

2017-05-18 Thread David Miller
From: Matthias Kaehlcke Date: Wed, 17 May 2017 15:17:08 -0700 > The function is not used, but it looks useful for debugging. Adding the > attribute fixes the following clang warning: > > drivers/net/usb/net1080.c:271:20: error: unused function > 'nc_dump_ttl'

Re: [PATCH net,stable] qmi_wwan: add another Lenovo EM74xx device ID

2017-05-18 Thread David Miller
From: Bjørn Mork Date: Wed, 17 May 2017 16:31:41 +0200 > In their infinite wisdom, and never ending quest for end user frustration, > Lenovo has decided to use a new USB device ID for the wwan modules in > their 2017 laptops. The actual hardware is still the Sierra Wireless >

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-05-17 Thread David Miller
From: Bjørn Mork Date: Tue, 16 May 2017 20:24:10 +0200 > Jim Baxter writes: > >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the memory becomes fragmented. >> >> This especially affects embedded

Re: [PATCH] net: ch9200: add missing USB-descriptor endianness conversions

2017-05-12 Thread David Miller
From: Johan Hovold Date: Fri, 12 May 2017 12:13:26 +0200 > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor idVendor and idProduct fields during probe. > > Signed-off-by: Johan Hovold Applied. -- To

Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread David Miller
From: Jim Baxter Date: Mon, 8 May 2017 13:49:57 +0100 > The zero padding that is added to NTB's does > not zero the memory correctly. > This is because the skb_put modifies the value > of skb_out->len which results in the memset > command not setting any memory to zero as

Re: [PATCH] net: hso: register netdev later to avoid a race condition

2017-04-28 Thread David Miller
From: Andreas Kemnade Date: Wed, 26 Apr 2017 19:26:40 +0200 > If the netdev is accessed before the urbs are initialized, > there will be NULL pointer dereferences. That is avoided by > registering it when it is fully initialized. > > This case occurs e.g. if dhcpcd is

Re: [PATCH] net: hso: fix module unloading

2017-04-25 Thread David Miller
From: Andreas Kemnade Date: Mon, 24 Apr 2017 21:18:39 +0200 > keep tty driver until usb driver is unregistered > rmmod hso > produces traces like this without that: ... > Signed-off-by: Andreas Kemnade Applied, thank you. -- To unsubscribe from this

Re: [PATCH] usb: plusb: Add support for PL-27A1

2017-04-25 Thread David Miller
From: Roman Spychała Date: Thu, 20 Apr 2017 12:04:10 +0200 > From: Roman Spychała > > This patch adds support for the PL-27A1 by adding the appropriate > USB ID's. This chip is used in the goobay Active USB 3.0 Data Link > and Unitek Y-3501 cables. > >

Re: [PATCH v4] smsc95xx: Add comments to the registers definition

2017-04-17 Thread David Miller
l.net> > Cc: Microchip Linux Driver Support <unglinuxdri...@microchip.com> > CC: David Miller <da...@davemloft.net> > Signed-off-by: Martin Wetterwald <mar...@wetterwald.eu> > Reviewed-by: Andrew Lunn <and...@lunn.ch> > Acked-by: Steve Glendinning <steve

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

2017-04-13 Thread David Miller
From: Daniele Palmas Date: Mon, 10 Apr 2017 17:34:23 +0200 > Telit LE920A4 uses the same pid 0x1201 of LE920, but modem > implementation is different, since it requires DTR to be set for > answering to qmi messages. > > This patch replaces QMI_FIXED_INTF with

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread David Miller
l.net> > Cc: Microchip Linux Driver Support <unglinuxdri...@microchip.com> > CC: David Miller <da...@davemloft.net> > Signed-off-by: Martin Wetterwald <mar...@wetterwald.eu> > --- > Changes in v3: > * Restore previous name for TX_CMD_B_CSUM_ENABLE Please fix th

Re: [PATCH] smsc95xx: Add comments to the registers definition

2017-04-11 Thread David Miller
From: Andrew Lunn Date: Mon, 10 Apr 2017 15:52:51 +0200 > Hi Martin > >> @@ -2032,7 +2032,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet >> *dev, >> skb_push(skb, 4); >> tx_cmd_b = (u32)(skb->len - 4); >> if (csum) >> -tx_cmd_b |=

Re: [PATCH net-next] net: usbnet: Remove unused driver_name variable

2017-04-06 Thread David Miller
From: Florian Fainelli Date: Tue, 4 Apr 2017 18:16:57 -0700 > With GCC 6.3, we can get the following warning: > > drivers/net/usb/usbnet.c:85:19: warning: 'driver_name' defined but not > used [-Wunused-const-variable=] > static const char driver_name [] = "usbnet"; >

Re: [PATCHv4] net: usbnet: support 64bit stats

2017-04-03 Thread David Miller
From: Greg Ungerer Date: Mon, 3 Apr 2017 15:50:03 +1000 > Add support for the net stats64 counters to the usbnet core. With that > in place put the hooks into every usbnet driver to use it. > > This is a strait forward addition of 64bit counters for RX and TX packet > and

Re: [PATCH 0/2] net: usb: qmi_wwan: add qmap mux protocol support

2017-03-25 Thread David Miller
From: Daniele Palmas Date: Fri, 24 Mar 2017 14:22:44 +0100 > This patch adds support for qmap mux protocol available in recent > Qualcomm based modems. > > The qmap mux protocol can be used for multiplexing data packets in > order to have multiple ip streams through the same

Re: [PATCH net] r8152: prevent the driver from transmitting packets with carrier off

2017-03-24 Thread David Miller
From: Hayes Wang Date: Thu, 23 Mar 2017 19:14:19 +0800 > The linking status may be changed when autosuspend. And, after > autoresume, the driver may try to transmit packets when the device > is carrier off, because the interrupt transfer doesn't update the > linking

Re: [PATCH net-next 0/7] Clean up PHY MMD accessors

2017-03-22 Thread David Miller
From: Russell King - ARM Linux Date: Tue, 21 Mar 2017 16:35:55 + > This series cleans up phylib's MMD accessors, so that we have a common > way of accessing the Clause 45 register set. > > The current situation is far from ideal - we have phy_(read|write)_mmd() >

Re: [PATCH net 0/2] r8152: fix the rx settings of RTL8153

2017-03-22 Thread David Miller
From: Hayes Wang Date: Mon, 20 Mar 2017 16:13:43 +0800 > The RMS and the rx early size should base on the same rx size. However, > the RMS is set to 9K bytes now and the rx early depends on mtu. For using > the rx buffer effectively, sync the two settings according to the

Re: [PATCH net,stable] qmi_wwan: add Dell DW5811e

2017-03-21 Thread David Miller
From: Bjørn Mork Date: Fri, 17 Mar 2017 17:20:48 +0100 > This is a Dell branded Sierra Wireless EM7455. It is operating in > MBIM mode by default, but can be configured to provide two QMI/RMNET > functions. > > Signed-off-by: Bjørn Mork > --- > Note regarding

Re: [PATCH net-next] r8152: check hw version first

2017-03-21 Thread David Miller
From: Hayes Wang Date: Fri, 17 Mar 2017 11:20:13 +0800 > Check hw version first in probe(). Do nothing if the driver doesn't > support the chip. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH 01/11] net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Oliver Neukum Date: Tue, 21 Mar 2017 12:33:03 +0100 > Am Donnerstag, den 16.03.2017, 23:18 +0100 schrieb Philippe Reynes: >> The ethtool api {get|set}_settings is deprecated. >> We add the new api {get|set}_link_ksettings to this driver. >> >> As I don't have the

Re: [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Mar 2017 23:18:46 +0100 > The ethtool api {get|set}_settings is deprecated. On usbnet, it > was often implemented with usbnet_{get|set}_settings. > > In this serie, I add usbnet_{get|set}_link_ksettings > in the first patch, then I update

Re: [PATCH net] r8152: fix the list rx_done may be used without initialization

2017-03-21 Thread David Miller
From: Hayes Wang Date: Tue, 14 Mar 2017 14:15:20 +0800 > The list rx_done would be initialized when the linking on occurs. > Therefore, if a napi is scheduled without any linking on before, > the following kernel panic would happen. > > BUG: unable to handle kernel

Re: [PATCH v2 net-next] r8152: simply the arguments

2017-03-16 Thread David Miller
From: Hayes Wang Date: Thu, 16 Mar 2017 14:32:22 +0800 > Replace >napi with napi and tp->netdev with netdev. > > Signed-off-by: Hayes Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

2017-03-13 Thread David Miller
From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 > An insert/remove stress test generated the following log message sequence. ... > Use netdev_dbg() instead of netdev_warn() for the repeating messages > to reduce logging noise. > > Signed-off-by: Guenter Roeck

  1   2   3   4   5   6   7   >