Re: [GIT PULL] USB-serial fix for v4.20-rc6

On Thu, Dec 06, 2018 at 05:33:46PM +0100, Johan Hovold wrote: > The following changes since commit 2595646791c319cadfdbf271563aac97d0843dc7: > > Linux 4.20-rc5 (2018-12-02 15:07:55 -0800) > > are available in the Git repository at: > >

Re: [PATCH 0/3] Small improvements to the appledisplay driver

On Tue, Dec 04, 2018 at 11:43:34PM +0100, alex.theis...@me.com wrote: > With the exception of the first patch I am not entirely sure if my changes are > correct and justified. This is my first contribution and I am equally > satisfied > if someone could point out why my changes are not correct. >

Re: [PATCH v2 1/3] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name

On Mon, Dec 03, 2018 at 09:23:44PM +0200, Andy Shevchenko wrote: > On Thu, Nov 15, 2018 at 04:53:03PM +0200, Heikki Krogerus wrote: > > On Thu, Nov 15, 2018 at 03:16:19PM +0200, Andy Shevchenko wrote: > > > Since we are going to use the same in Designware USB 3 driver, > > > rename the property to

Re: [GIT PULL] USB fixes for v4.20-rc4

On Thu, Nov 29, 2018 at 12:26:29PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's my second pull request for the current -rc cycle. Looks like > things are really calm this merge window. > > Let me know if you want anything to be changed. > > cheers > > The following changes since commit

Re: [GIT PULL] usb fixes for v4.20-rc2

On Wed, Nov 14, 2018 at 01:33:10PM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's the first set of fixes for v4.20-rc cycle. Nothing really major, > actually. > > Let me now if you want anything to be changed Now pulled, thanks. greg k-h

Re: [PATCH] usb: dwc3: debugfs: Dump internal states

On Wed, Nov 07, 2018 at 12:45:50PM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> Thinh Nguyen writes: > >> >>>>> +static ssize_t dwc3_internal_states_write(struct file *file, > >> >>>>> +

Re: [PATCH] usb: dwc3: debugfs: Dump internal states

On Wed, Nov 07, 2018 at 08:39:41AM +0200, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: > > +static ssize_t dwc3_internal_states_write(struct file *file, > > + const char __user *ubuf, size_t count, loff_t *ppos) > why is this necessary? Seems like it would be

Re: [GIT PULL] USB-serial updates for v4.20-rc1

On Thu, Oct 18, 2018 at 12:55:42PM +0200, Johan Hovold wrote: > The following changes since commit 7876320f88802b22d4e2daf7eb027dd14175a0f8: > > Linux 4.19-rc4 (2018-09-16 11:52:37 -0700) > > are available in the Git repository at: > >

Re: [GIT PULL] usb: chipidea: changes for v4.20-rc1

On Mon, Oct 08, 2018 at 01:58:00AM +, Peter Chen wrote: > The following changes since commit 1652a83fa494b12e20fc02a2cc3ddbcd75d53170: > > Merge 4.19-rc4 into usb-next (2018-09-16 22:44:14 +0200) > > are available in the git repository at: > >

Re: [GIT PULL] USB for v4.20 merge window

On Fri, Oct 05, 2018 at 11:07:31AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v4.20 merge window. Most of the changes are > on the UVC gadget driver. Seems like we'll have a calm merge window for > USB folks this time around. Now pulled and pushed out, thanks. greg

Re: [GIT PULL] USB-serial fixes for v4.19-rc7

On Sun, Sep 30, 2018 at 06:27:17PM +0200, Johan Hovold wrote: > Hi Greg, > > Here are some device-id patches for 4.19-rc7 (unless you prefer to hold them > off for 4.20). > > The option patches are a bit more intrusive than the usual device-id patches, > but allows us to support a particular

Re: fixes for ioctl() of usbtmc in testing tree

On Fri, Sep 28, 2018 at 08:30:41AM +, gu...@kiener-muenchen.de wrote: > > Zitat von Greg Kroah-Hartman : > > > On Mon, Sep 24, 2018 at 12:20:42PM +, gu...@kiener-muenchen.de wrote: > > > > > > Zitat von Oliver Neukum : > > > > > &g

Re: [PATCH -next] USB: core: remove set but not used variable 'udev'

On Sat, Sep 22, 2018 at 06:31:26AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': > drivers/usb/core/driver.c:513:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > >

Re: fixes for ioctl() of usbtmc in testing tree

On Mon, Sep 24, 2018 at 12:20:42PM +, gu...@kiener-muenchen.de wrote: > > Zitat von Oliver Neukum : > > > On Mo, 2018-09-24 at 10:56 +, gu...@kiener-muenchen.de wrote: > > > Zitat von Greg Kroah-Hartman : > > > > > > > On Mon, Sep 24,

Re: fixes for ioctl() of usbtmc in testing tree

On Mon, Sep 24, 2018 at 11:24:10AM +0200, Oliver Neukum wrote: > Hi, > > how should I mark fixes intended for the testing branch? > I got one for the usbtmc driver. Just send it like normal. You can do a "Fixes:" tag with the sha1, that should be fine. I need to push out my testing branch now,

Re: [PATCH v4 00/10] usb: typec: A few more improvements for Intel CHT

On Wed, Sep 12, 2018 at 11:00:55AM +0300, Heikki Krogerus wrote: > Hi, > > On Tue, Sep 11, 2018 at 07:36:34PM +0200, Hans de Goede wrote: > > On 11-09-18 12:10, Heikki Krogerus wrote: > > > This is fourth version of this series. There was one bug in patch 2/10 > > > that Hans noticed. It should

Re: [PATCHv2] usb: typec: Group all TCPCI/TCPM code together

On Tue, Sep 11, 2018 at 05:51:36PM +0300, Heikki Krogerus wrote: > On Mon, Sep 10, 2018 at 06:21:04AM -0700, Guenter Roeck wrote: > > On 09/10/2018 04:58 AM, Heikki Krogerus wrote: > > > Moving all the drivers that depend on the Port Controller > > > Manager under a new directory

Re: [GIT PULL] USB: fixes for v4.19-rc2

On Thu, Sep 06, 2018 at 11:07:57AM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my first pull request for the current -rc cycle. Not much has > been going on when it comes to fixes. Hopefully we won't have a lot of > late fixes. > > Let me know if you want anything to be changed. Looks

Re: [GIT PULL] USB-serial fixes for v4.19-rc3

On Wed, Sep 05, 2018 at 04:02:23PM +0200, Johan Hovold wrote: > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > are available in the Git repository at: > >

Re: [PATCH 2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries

On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote: > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote: > > Because USB_STORAGE build symbol strictly depends on SCSI build > > symbol, there is no need to specify it again for USB_UAS and > > USB_STORAGE_ENE_UB6250 build

Re: [PATCH 1/2] usb storage: group dependent USB storage Kconfig entries together

On Thu, Aug 09, 2018 at 01:01:54AM +0300, Vladimir Zapolskiy wrote: > Instead of explicit setting of USB_STORAGE dependency for every > underlying build entries, exploit if USB_STORAGE / endif block. Why change this? What benifit does this provide? thanks, greg k-h -- To unsubscribe from this

Re: [PATCH] usb: ehci-sh: convert to SPDX identifiers

On Thu, Aug 02, 2018 at 01:46:40AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Signed-off-by: Kuninori Morimoto > --- > include/linux/platform_data/ehci-sh.h | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) I can not take patches without any

Re: [GIT PULL] USB changes for v4.19

On Mon, Jul 30, 2018 at 10:53:52AM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for v4.19. It's not very large this time around > with only 37 commits. Patches have been soaking for a while without any > reported incidents. > > Let me know if you want anything to be

Re: [GIT PULL] USB-serial updates for v4.19-rc1

On Fri, Jul 20, 2018 at 06:56:11PM +0200, Johan Hovold wrote: > The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: > > Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) > > are available in the Git repository at: > >

Re: [PATCH] usb: gadget: f_fs: Only return delayed status when len is 0

On Thu, Jul 19, 2018 at 08:48:32AM +0300, Felipe Balbi wrote: > > Hi, > > Jerry Zhang writes: > > Commit 1b9ba000 ("Allow function drivers to pause control > > transfers") states that USB_GADGET_DELAYED_STATUS is only > > supported if data phase is 0 bytes. > > > > It seems that when the length

Re: [PATCH 5/5] USB: serial: cp210x: improve line-speed handling for CP2104 and CP2105

ppears to be > incorrect as it introduces larger errors). > > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/cp210x.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 3/5] USB: serial: cp210x: improve baudrate support for CP2102N

s ] > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/cp210x.c | 39 - > 1 file changed, 34 insertions(+), 5 deletions(-) Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body o

Re: [PATCH 4/5] USB: serial: cp210x: generalise CP2102N line-speed handling

f-by: Johan Hovold > --- > drivers/usb/serial/cp210x.c | 50 - > 1 file changed, 27 insertions(+), 23 deletions(-) Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [PATCH 2/5] USB: serial: cp210x: honour device-type maximum line speed

types in order to > avoid any regressions. > > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/cp210x.c | 41 ++++++++++--- > 1 file changed, 38 insertions(+), 3 deletions(-) Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line &quo

Re: [PATCH 1/5] USB: serial: cp210x: make line-speed quantisation data driven

--- > drivers/usb/serial/cp210x.c | 99 + > 1 file changed, 56 insertions(+), 43 deletions(-) Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kerne

Re: [GIT PULL] USB fixes for v4.18-rc5

On Tue, Jul 17, 2018 at 10:20:33AM +0300, Felipe Balbi wrote: > > Hi Greg, > > after a couple weeks break, here's another pull request for the current > rc. I've rebase on top of your usb-linus branch this time to make sure I > don't pick any patches you have already picked. > > Let me know if

Re: [GIT PULL] usb: chipidea: fixes for usb-linus

On Tue, Jul 10, 2018 at 06:21:35AM +, Peter Chen wrote: > The following changes since commit 90f26cc6bb90b35040f4da0347f480ea9df6e2fc: > > usb: chipidea: host: fix disconnection detect issue (2018-06-26 09:59:34 > +0800) > > are available in the git repository at: > >

Re: [GIT PULL] USB-serial fixes for v4.18-rc4

On Fri, Jul 06, 2018 at 02:01:34PM +0200, Johan Hovold wrote: > The following changes since commit 021c91791a5e7e85c567452f1be3e4c2c6cb6063: > > Linux 4.18-rc3 (2018-07-01 16:04:53 -0700) > > are available in the Git repository at: > >

Re: [PATCH 3/3] Documentation: usb: Add docs for configfs control requests

On Mon, Jul 02, 2018 at 03:01:03PM -0700, Jerry Zhang wrote: > Signed-off-by: Jerry Zhang > --- > Documentation/usb/gadget_configfs.txt | 34 +++ > 1 file changed, 34 insertions(+) I can't take patches without any changelog text at all, sorry. greg k-h -- To unsubscribe

Re: [usb:usb-next 36/38] drivers/usb/typec/tcpci.c:549: undefined reference to `__devm_regmap_init_i2c'

On Fri, Jun 29, 2018 at 03:42:02PM -0700, Guenter Roeck wrote: > On Fri, Jun 29, 2018 at 12:52:34PM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-next > > head: aaf3f4e925dc2bdc4715142103660285632a245c > > commit:

Re: [GIT PULL] USB-serial fixes for v4.18-rc3

On Wed, Jun 27, 2018 at 01:43:53PM +0200, Johan Hovold wrote: > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) > > are available in the Git repository at: > >

Re: [PATCH] USB: serial: digi_acceleport: rename tty flag variable

On Tue, Jun 26, 2018 at 03:43:13PM +0200, Johan Hovold wrote: > Add a "tty_" prefix to the tty "flag" variable to avoid any future > mixups with the recently added irq-mask "flags" one. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartm

Re: [GIT PULL] usb: chipidea: fixes for v4.18-rc

On Tue, Jun 26, 2018 at 02:26:02AM +, Peter Chen wrote: > The following changes since commit d5a4f93511b7000183c0d528739b824752139f79: > > usb: typec: tcpm: fix logbuffer index is wrong if _tcpm_log is re-entered > (2018-06-25 21:43:35 +0800) > > are available in the git repository at: >

Re: [PATCH 3/3] usb: typec: ucsi: Fix for incorrect status data issue

On Mon, Jun 25, 2018 at 05:48:05PM +0300, Heikki Krogerus wrote: > On Mon, Jun 25, 2018 at 08:37:25PM +0800, Greg Kroah-Hartman wrote: > > On Thu, Jun 21, 2018 at 04:43:19PM +0300, Heikki Krogerus wrote: > > > According to UCSI Specification, Connector Change Event only &g

Re: [GIT PULL] USB fixes for v4.18-rc1

On Wed, Jun 20, 2018 at 02:14:57PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first set of fixes for current -rc cycle. Patches have been > soaking for a while and I've also tested on some of our platforms from > the lab. > > Let me know if you want anything to be changed. Pulled

Re: [PATCH 3/3] usb: typec: ucsi: Fix for incorrect status data issue

On Thu, Jun 21, 2018 at 04:43:19PM +0300, Heikki Krogerus wrote: > According to UCSI Specification, Connector Change Event only > means a change in the Connector Status and Operation Mode > fields of the STATUS data structure. So any other change > should create another event. > > Unfortunately

Re: [RFC PATCH v4 1/8] usb: pd: include kernel.h

On Fri, Jun 08, 2018 at 02:29:34PM +0300, Heikki Krogerus wrote: > Some of the macros use le16_to_cpu(). What macros? Is this causing build errors today? If so, why should it not be included now? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: [PATCH 02/22 v2] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

On Thu, May 31, 2018 at 06:16:27AM -0700, Guenter Roeck wrote: > On 05/31/2018 04:08 AM, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never d

[PATCH 02/22 v2] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

way. Cc: Heikki Krogerus Cc: Guenter Roeck Cc: Hans de Goede Cc: Andy Shevchenko Cc: Adam Thomson Signed-off-by: Greg Kroah-Hartman --- v2: changes based on review from Guenter, we still need to keep chip->dentry and the removal of the rootdir is properly reference counted, mak

Re: [PATCH 01/22] USB: typec: tcpm: no need to check return value of debugfs_create_dir()

On Wed, May 30, 2018 at 06:42:49AM -0700, Guenter Roeck wrote: > On 05/30/2018 03:36 AM, Greg Kroah-Hartman wrote: > > On Wed, May 30, 2018 at 01:30:20PM +0300, Heikki Krogerus wrote: > > > +Guenter > > > > > > On Tue, May 29, 2018 at 05:30:46PM +0200, Gr

Re: [PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

On Wed, May 30, 2018 at 08:20:50PM +0200, Alexandre Belloni wrote: > On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > &g

Re: [PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

based on this. > > > > Cc: Peter Chen > > Signed-off-by: Greg Kroah-Hartman > > Tested on imx6sx-sdb board. > > Acked-by: Peter Chen Thanks for testing! -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a mess

Re: [PATCH 21/22] USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions

On Wed, May 30, 2018 at 07:38:24AM +, Yoshihiro Shimoda wrote: > > From: Greg Kroah-Hartman, Sent: Wednesday, May 30, 2018 12:31 AM > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the cod

Re: [GIT PULL] USB-serial updates for v4.18-rc1

On Thu, May 31, 2018 at 11:24:13AM +0200, Johan Hovold wrote: > The following changes since commit 6da6c0db5316275015e8cc2959f12a17584aeb64: > > Linux v4.17-rc3 (2018-04-29 14:17:42 -0700) > > are available in the Git repository at: > >

Re: [PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

On Wed, May 30, 2018 at 07:31:13PM +0200, Alexandre Belloni wrote: > Hi, > > On 29/05/2018 17:31:02+0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logi

Re: [PATCH 01/22] USB: typec: tcpm: no need to check return value of debugfs_create_dir()

On Wed, May 30, 2018 at 01:30:20PM +0300, Heikki Krogerus wrote: > +Guenter > > On Tue, May 29, 2018 at 05:30:46PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but

Re: [PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

On Tue, May 29, 2018 at 11:34:34AM -0500, Pete Zaitcev wrote: > On Tue, 29 May 2018 17:30:50 +0200 > Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logi

Re: [PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

On Tue, May 29, 2018 at 09:15:30AM -0700, Guenter Roeck wrote: > On Tue, May 29, 2018 at 05:30:47PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic shou

[PATCH 14/22] USB: core: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Johan Hovold Cc: Kai-Heng Feng Cc: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/usb.c

[PATCH 04/22] USB: mtu3: no need to check return value of debugfs_create_dir()

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Chunfeng Yun Signed-off-by: Greg Kroah-Hartman --- drivers/usb/mtu3/mtu3_dr.c | 4 1 file changed, 4

[PATCH 11/22] USB: fhci-hcd: no need to check return value of debugfs_create functions

structure. Cc: Felipe Balbi Cc: Andy Shevchenko Cc: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/fhci-dbg.c | 23 +-- drivers/usb/host/fhci.h | 2 -- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/usb/host/fhci-dbg.c b

[PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/chipidea/ci.h| 2 +- drivers/usb/chipidea

[PATCH 16/22] USB: dwc3: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/debugfs.c | 43

[PATCH 18/22] USB: gadget: udc: bcm63xx_udc: no need to check return value of debugfs_create functions

. Cc: Kevin Cernekee Cc: Felipe Balbi Cc: Florian Fainelli Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/bcm63xx_udc.c | 37 1 file changed, 5 insertions(+), 32 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc

[PATCH 07/22] USB: ohci: no need to check return value of debugfs_create functions

structure. Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ohci-dbg.c | 45 - drivers/usb/host/ohci-hcd.c | 5 - drivers/usb/host/ohci.h | 3 --- 3 files changed, 9 insertions(+), 44 deletions(-) diff --git a/drivers/usb/host

[PATCH 15/22] USB: dwc2: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Minas Harutyunyan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/debugfs.c | 78

[PATCH 22/22] USB: gadget: udc: s3c2410_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Li Yang Cc: Nicolas Ferre Cc: Robert Jarzmik Signed-off-by: Greg Kroah-Hartman

[PATCH 19/22] USB: gadget: udc: gr_udc: no need to check return value of debugfs_create functions

. Cc: Felipe Balbi Cc: Andy Shevchenko Cc: "Paul E. McKenney" Cc: Mark Rutland Cc: Jaejoong Kim Cc: Li Yang Cc: Johan Hovold Cc: Robert Jarzmik Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/gr_udc.c | 7 ++- drivers/usb/gadget/udc/gr_udc.h | 1 - 2 files

[PATCH 03/22] USB: musb: clean up debugfs file and directory creation

handling code that never could have triggered in the past. Cc: Bin Liu Signed-off-by: Greg Kroah-Hartman --- drivers/usb/musb/musb_core.c| 5 +--- drivers/usb/musb/musb_debug.h | 5 ++-- drivers/usb/musb/musb_debugfs.c | 44 ++--- drivers/usb/musb/musb_dsps.c

[PATCH 06/22] USB: uhci: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/uhci-hcd.c | 15 --- 1 file

[PATCH 09/22] USB: imx21-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Johan Hovold Cc: Andy Shevchenko Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host

[PATCH 08/22] USB: isp116x-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Olav Kongas Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/isp116x-hcd.c | 17 - 1

[PATCH 10/22] USB: fotg210-hcd: no need to check return value of debugfs_create functions

: Mariusz Skamra Cc: "Gustavo A. R. Silva" Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/fotg210-hcd.c | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index d8

[PATCH 01/22] USB: typec: tcpm: no need to check return value of debugfs_create_dir()

of this function, so it didn't matter. Note, I do not think this code can be removed in a running system, as the debugfs root directory will stick around, that should be fixed someday... Cc: Heikki Krogerus Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/tcpm.c | 11 +++ 1 file changed, 3

[PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

is removed. Cc: Heikki Krogerus Cc: Guenter Roeck Cc: Hans de Goede Cc: Andy Shevchenko Cc: Adam Thomson Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/fusb302/fusb302.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/usb/typec/fusb302

[PATCH 20/22] USB: gadget: udc: pxa27x_udc: no need to check return value of debugfs_create functions

. Cc: Daniel Mack Cc: Haojian Zhuang Cc: Robert Jarzmik Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/pxa27x_udc.c | 43 - drivers/usb/gadget/udc/pxa27x_udc.h | 3 -- 2 files changed, 6 insertions(+), 40 deletions(-) diff --git

[PATCH 12/22] USB: ehci-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ehci-dbg.c | 30

[PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

. Cc: Nicolas Ferre Cc: Felipe Balbi Cc: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/atmel_usba_udc.c | 71 - drivers/usb/gadget/udc/atmel_usba_udc.h | 4 -- 2 files changed, 11 insertions(+), 64 deletions(-) diff --git a/drivers/usb

[PATCH 21/22] USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Yoshihiro Shimoda Cc: Simon Horman Cc: Geert Uytterhoeven Signed-off-by: Greg Kroah

[PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

valid" or not, as the code works just as well either way. Cc: Pete Zaitcev Cc: Philippe Ombredanne Cc: Fredrik Noring Cc: Kate Stewart Signed-off-by: Greg Kroah-Hartman --- drivers/usb/mon/mon_text.c | 37 +++-- 1 file changed, 7 insertions(+), 30 deletions(-)

Re: [usb:debugfs_cleanup 109/109] drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function returning void

On Tue, May 29, 2018 at 05:32:48PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > debugfs_cleanup > head: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 > commit: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 [109/109] usb: debugfs > cleanup >

Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

On Sun, May 27, 2018 at 07:48:47AM +0200, Marcus Folkesson wrote: > On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote: > > On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote: > > > Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com&g

Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote: > Signed-off-by: Marcus Folkesson I can't take patches without any changelog text. And why would you submit a patch over 1000 lines without any? Please fix. thanks, greg k-h -- To unsubscribe from

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Wed, May 23, 2018 at 10:16:56AM +0800, Nicolas Boichat wrote: > The "old" enumeration scheme is considerably faster (it takes > ~294ms instead of ~439ms to get the descriptor). > > It is currently only possible to use the old scheme globally > (/sys/module/usbcore/parameters/old_scheme_first),

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Fri, May 25, 2018 at 06:05:16AM +0800, Nicolas Boichat wrote: > On Fri, May 25, 2018 at 12:21 AM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: > >> On Thu, May 24, 2018 at 12:39 AM, G

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: > On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: > >> On Wed, 23 May 2018, Nicolas Boichat

Re: [GIT PULL] USB for v4.18 merge window

On Mon, May 21, 2018 at 11:25:09AM +0300, Felipe Balbi wrote: > > Hi Greg, > > Here's my pull request for v4.18 merge window. Let me know if you want > anything to be changed. > > For the rest of the week I'll have very scarce access to email, so > replies may be delayed. > > Cheers > > The

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: > On Wed, 23 May 2018, Nicolas Boichat wrote: > > > The "old" enumeration scheme is considerably faster (it takes > > ~294ms instead of ~439ms to get the descriptor). > > > > It is currently only possible to use the old scheme globally

Re: [PATCH 01/33] usb: phy: use match_string() helper

On Tue, May 22, 2018 at 01:20:01AM +0300, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > > which can be used intead of open coded variant. > > > - int err, i; > >

Re: [PATCH] tty: add missing const to termios hw-change helper

t; Note that this helper is only used by a few USB serial drivers and that > the pl2303 bits depend on a new patch targeted for -next. Your tree is fine: Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscrib

[PATCH v4] NFC: pn533: don't send USB data off of the stack

Samuel Ortiz <sa...@linux.intel.com> Cc: Stephen Hemminger <step...@networkplumber.org> Cc: stable <sta...@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- v4: don't use urb transfer buffer flags as the memory is tied to the urb (thanks to Johan)

Re: [PATCH v3] NFC: pn533: don't send USB data off of the stack

On Fri, May 18, 2018 at 05:48:47PM +0200, Johan Hovold wrote: > On Fri, May 18, 2018 at 12:38:11PM +0200, Greg Kroah-Hartman wrote: > > It's amazing that this driver ever worked, but now that x86 doesn't > > allow USB data to be sent off of the stack, it really does not work a

Re: [PATCH 03/12] usb: usbtmc: Add ioctls to set/get usb timeout

On Fri, May 18, 2018 at 10:48:30PM +0300, Andy Shevchenko wrote: > On Thu, May 17, 2018 at 8:03 PM, Guido Kiener > wrote: > > Add ioctls USBTMC_IOCTL_GET_TIMEOUT / USBTMC_IOCTL_SET_TIMEOUT to > > get/set I/O timeout for specific file handle. > > > > > > +static int

Re: [PATCH v2] usbip: vhci_sysfs: fix potential Spectre v1

On Fri, May 18, 2018 at 05:27:22PM -0500, Gustavo A. R. Silva wrote: > > > On 05/18/2018 11:06 AM, Shuah Khan wrote: > > On 05/18/2018 07:47 AM, Greg Kroah-Hartman wrote: > > > On Thu, May 17, 2018 at 03:16:28PM -0500, Gustavo A. R. Silva wrote: > > > >

Re: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9360/9370

On Fri, May 18, 2018 at 06:08:24PM +0300, Heikki Krogerus wrote: > > Rafael, the problem here with these Dell laptops is that a memory page > that is used as a mailbox for special communication between EC FW and > OS (called UCSI mailbox) should be in uncached memory, but the memory > is marked

Re: [PATCH 1/4] USB: serial: ftdi_sio: fix IXON/IXOFF mixup

On Fri, May 18, 2018 at 04:33:50PM +0200, Johan Hovold wrote: > On Fri, May 18, 2018 at 03:53:54PM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 18, 2018 at 03:25:47PM +0200, Johan Hovold wrote: > > > Since forever this driver has had IXON and IXOFF mixed up, and has use

Re: [PATCH 4/4] USB: serial: ftdi_sio: clean up flow control management

v_err(ddev, "urb failed to clear flow > control\n"); > - } > - } > + dev_dbg(>dev, "disabling flow control\n"); > + index = FTDI_SIO_DISABLE_FLOW_CTRL; > } > + > + index |= priv->interface; >

Re: [PATCH 3/4] USB: serial: ftdi_sio: drop unnecessary urb_ variable prefixes

-- > 1 file changed, 41 insertions(+), 42 deletions(-) Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] USB: serial: ftdi_sio: fix IXON/IXOFF mixup

dev_dbg(ddev, "%s Turning off hardware flow control\n", > __func__); > if (usb_control_msg(dev, Ugh, that's a huge sign that no one actually uses IXON/IXOFF anymore :( Anyway, thanks for fixing this up, should also probably be backported to the

Re: [PATCH 2/4] USB: serial: ftdi_sio: use non-underscore fixed types

b/serial/ftdi_sio.c | 50 +-- > 1 file changed, 25 insertions(+), 25 deletions(-) Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@v

Re: [PATCH v2] usbip: vhci_sysfs: fix potential Spectre v1

On Thu, May 17, 2018 at 03:16:28PM -0500, Gustavo A. R. Silva wrote: > pdev_nr and rhport can be controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > drivers/usb/usbip/vhci_sysfs.c:238

[PATCH v3] NFC: pn533: don't send USB data off of the stack

e data has been transmitted, that is why there is no kfree() to mirror the call to kmalloc(). Reported-by: Carlos Manuel Santos <cmmpsan...@gmail.com> Cc: Samuel Ortiz <sa...@linux.intel.com> Cc: Stephen Hemminger <step...@networkplumber.org> Cc: stable <sta...@vger.kernel

Re: [PATCH] usbip: vhci_sysfs: fix potential Spectre v1

On Thu, May 17, 2018 at 12:57:49PM -0500, Gustavo A. R. Silva wrote: > Hi Greg, > > On 05/17/2018 01:51 AM, Greg Kroah-Hartman wrote: > > On Wed, May 16, 2018 at 05:22:00PM -0500, Gustavo A. R. Silva wrote: > > > pdev_nr and rhport can be controlled by u

Re: [PATCH] usbip: vhci_sysfs: fix potential Spectre v1

On Wed, May 16, 2018 at 05:22:00PM -0500, Gustavo A. R. Silva wrote: > pdev_nr and rhport can be controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > drivers/usb/usbip/vhci_sysfs.c:238

Re: [PATCH] USB: serial: use tty_port_register_device()

-serial (but we need to > determine how to handle hotplugging first). > > Signed-off-by: Johan Hovold <jo...@kernel.org> Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

  1   2   3   4   5   6   7   8   9   10   >