Re: [PATCH 2/2] usb: dwc2: gadget: Accept LPM token when TxFIFO is not empty

Hello! On 10/30/2018 03:26 PM, Artur Petrosyan wrote: > To accept LPM token during ISOC transfers when TxFIFO > is not empty. > > Signed-off-by: Artur Petrosyan > Signed-off-by: Minas Harutyunyan > --- > drivers/usb/dwc2/gadget.c | 1 + > drivers/usb/dwc2/hw.h | 3 +++ > 2 files changed,

Re: [PATCH 2/3] net: ethernet: Remove dummy runtime PM callbacks from Renesas drivers

runtime pm callbacks") > 543f2503a956 ("PM / platform_bus: Allow runtime PM by default") > 8b313a38ecff ("PM / Platform: Use generic runtime PM callbacks directly") Wow, these are old! :-) > Signed-off-by: Jarkko Nikula > --- > Only build tested. Seem

Re: [PATCH v2 -next] usb: typec: remove set but not used variables 'snk_ma, flags'

Hello! On 9/29/2018 9:58 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/typec/tcpm/tcpm.c: In function 'tcpm_pd_select_pps_apdo': drivers/usb/typec/tcpm/tcpm.c:2212:39: warning: variable 'snk_ma' set but not used [-Wunused-but-set-variable]

Re: [PATCH] ALSA: usb-audio: ensure that cluster header size is enough

Hello! On 09/22/2018 04:38 PM, Dan Carpenter wrote: > I think we need a check to make sure that "hc_header.wLength" is large > enough for a struct struct uac3_cluster_header_descriptor. struct struct? :-) > Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") >

Re: [PATCH 2/3] usb: host: xhci: return -ESHUTDOWN when removing hcd

On 9/21/2018 4:48 AM, Peter Chen wrote: When we are removing HCD, the xhci_configure_endpoint may be timeout. To get rid of timeout, we'd better return before issue command. The related log message when removing HCD like below: [66.736633] usb 3-1: USB disconnect, device number 2 [66.737003]

Re: [PATCH 3/3] usb: host: xhci: return early for xhci_urb_dequeue when removing hcd

On 9/21/2018 4:48 AM, Peter Chen wrote: When we are removing hcd, the stop endpoint command may be timeout. To eliminate the timeout, we'd better return early. The related log for this timeout like below: [31.208933] hub 3-1:1.0: hub_ext_port_status failed (err = -71) [31.214972] usb

Re: [PATCH] usb: musb: dsps: do not disable CPPI41 irq in driver teardown

Hello! On 08/21/2018 09:55 PM, Bin Liu wrote: > TI AM335x CPPI41 module uses a single register bit for CPPI interrupts in It's CPPI 4.1. :-) > both musb controllers. So disabling the CPPI irq in one musb driver breaks > the other musb module. > > Since musb is already disabled before

Re: [PATCH 4/9] ALSA: usb-audio: use usb_fill_int_urb()

Hello! On 6/20/2018 12:55 AM, Sebastian Andrzej Siewior wrote: Using usb_fill_int_urb() helps to find code which initializes an URB. A grep for members of the struct (like ->complete) reveal lots of other things, too. data_ep_set_params() additionally sets urb->transfer_buffer_length which

Re: [PATCH 3/3] usb: gadget: storage: Remove EXPORT_SYMBOL_GPL for kref_{put, get}

Hello! On 06/14/2018 12:23 PM, Jaejoong Kim wrote: > Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used I thought you removed the exports from the real kref_{get|put}(). :-) Your patch subject and description are simply misleading the way they are written. > only in

Re: [PATCH 2/3] usb: dwc3: pci: Enable ULPI Refclk on platforms where the firmware doesnot

Hello! On 06/07/2018 01:38 PM, Hans de Goede wrote: > On some Bay Trail (BYT) systems the firmware does not enable the > ULPI Refclk. > > This commit adds a helper which checks and if necessary enabled the Refclk > and calls this helper for BYT machines. > > Signed-off-by: Hans de Goede > ---

Re: [PATCH v2 1/3] usb: roles: intel_xhci: Always allow user control

On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Trying to determine the USB port type with this mux is very > difficult. To simplify the situation, always allowing user s/allowing/allow/? Else the statement doesn't parse for me. :-) > control, even if the port is USB Type-C port. > >

Re: [PATCH v2 3/3] usb: typec: fusb302: Fix debugfs issue

Hello! On 05/23/2018 05:37 PM, Heikki Krogerus wrote: > Removing the "fusb302" debugfs directory when unloading > the driver. That allows the driver to be loaded more then > ones. The directory will not get actually removed until it s/ones/once/? > is empty, so only after the last instance

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

ret = mdiobus_register(mdp->mii_bus); > - } > + if (pd->phy_irq > 0) > + mdp->mii_bus->irq[pd->phy] = pd->phy_irq; > > + ret = of_mdiobus_register(mdp->mii_bus, dev->of_node); > if (ret) > goto out_free_b

Re: [PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes

Hello! On 5/7/2018 6:18 PM, Icenowy Zheng wrote: Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and a custom PHY. Add device tree nodes for them. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38

Re: [PATCH v5 08/14] staging: typec: tcpci: register port before request irq

On 5/3/2018 11:29 AM, Sergei Shtylyov wrote: From: Peter Chen <peter.c...@nxp.com> With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen <peter.c...@nxp.com> Signed-off-by:

Re: [PATCH v5 08/14] staging: typec: tcpci: register port before request irq

Hello! On 5/3/2018 3:24 AM, Li Jun wrote: From: Peter Chen With that we can clear any pending events and the port is registered so driver can be ready to handle typec events once we request irq. Signed-off-by: Peter Chen Signed-off-by: Li Jun

Re: [PATCH 2/2] usb: dwc2: fix isoc split in transfer with no data

Hello! On 4/24/2018 5:43 AM, William Wu wrote: If isoc split in transfer with no data (the length of DATA0 packet is 0), we can't simply return immediately. Because the DATA0 can be the first transaction or the second transaction for the isoc split in transaction. If the DATA0 packet with on

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

Hello! s/optrion/option/ in the subject. And please add spaces after each colon. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 1/1] usb: core: Add quirk for HP v222w 16GB Mini

Hello! On 4/13/2018 8:40 PM, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kamil Lulko Add DELAY_INIT quirk to fix the following problem with HP v222w 16GB Mini: usb 1-3: unable to read config index 0 descriptor/start: -110 usb 1-3: can't read

Re: [PATCH] usbip: vhci_hcd: check rhport before using in vhci_hub_control()

Hello! On 4/6/2018 1:31 AM, Shuah Khan wrote: Validate !rhport < 0 before using it to access port_status array. Why '!'? Signed-off-by: Shuah Khan --- drivers/usb/usbip/vhci_hcd.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH v2 1/1] usb: musb: gadget: misplaced out of bounds check

Hello! On 3/20/2018 5:27 AM, Heinrich Schuchardt wrote: musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- v2 Only the 4 low bits of epnum are relevant

Re: [PATCH] usb: Don't disable Latency tolerance Messaging (LTM) before port reset

Hello! On 03/01/2018 02:15 PM, Mathias Nyman wrote: > Disabing Latency Tolerance Messaging before port reset is unnecessary. > LTM is automatically disabled at port reset. > > If host can't communicate with the device the LTM message will fail, and > the hub driver will unnecessarily do a

Re: [RFC PATCH] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

Hello! On 2/24/2018 11:51 PM, Merlijn Wajer wrote: Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 pgd = b333e822 [fa0ab060] *pgd=48011452(bad) []

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

On 01/22/2018 06:44 PM, Ladislav Michl wrote: >>> As devm_ioremap_resource() checks for valid resource, >>> make use of it instead of testing ourselves. As a bonus >>> memory region is requested. >>> >>> Signed-off-by: Ladislav Michl >>> --- >>>

Re: [PATCH 1/2] usb: gadget: udc: atmel: Use devm_ioremap_resource()

Hello! On 01/22/2018 06:21 PM, Ladislav Michl wrote: > As devm_ioremap_resource() checks for valid resource, > make use of it instead of testing ourselves. As a bonus > memory region is requested. > > Signed-off-by: Ladislav Michl > --- >

Re: [PATCH v4] usb: uhci: Add clk support to uhci-platform

Hello! On 1/16/2018 12:53 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to

Re: [PATCH v4] usb: uhci: Add clk support to uhci-platform

Hello! On 1/15/2018 1:59 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to

Re: [PATCH] usb: uhci: Add clk support to uhci-platform

Hello! On 1/12/2018 8:51 AM, Benjamin Herrenschmidt wrote: The Aspeed SoCs use uhci-platform. With the new dynamic clock control framework, the corresponding IP block clock must be properly enabled. This is a simplified variant of what ehci-platform does, it looks for *one* clock attached to

Re: [PATCH 13/15] usb: dwc3: Track DWC_usb31 VERSIONTYPE

Hello! On 1/5/2018 11:16 PM, Thinh Nguyen wrote: Add a new variable to dwc3 structure to track VERSIONTYPE. The That's called field, not variable. VERSIONTYPE is represented in ASCII in the 32-bit VERSIONTYPE register. In DWC_usb31, sub releases for each version are tracked with

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Hello! On 1/4/2018 11:01 PM, Chris Brandt wrote: Add USB device support. Signed-off-by: Chris Brandt --- arch/arm/boot/dts/r7s72100.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi

Re: [PATCH] usb: quirks: Add reset-resume quirk for QCA6174 Rome Bluetooth

Hello! On 12/31/2017 8:13 PM, Leif Liddy wrote: This is a rework of reverted commit fd865802c66bc451dc515ed89360f84376ce1a56 You need to also specify the commit summry enclosed in (""). Alos, 12 digits of SHA1 is enough. The issue is that some QCA Rome bluetooth controllers stop

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

Hello! On 10/20/2017 12:54 PM, Uwe Kleine-König wrote: ehci_hub_control does the following related to overcurrent handling (simplified): temp = ehci_readl(ehci, status_reg); if (temp & PORT_OCC) { status |= USB_PORT_STAT_C_OVERCURRENT << 16;

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

On 10/17/2017 12:22 AM, Jules Maselbas wrote: Thanks Sergei, Is it better if the documentation say: " Optional property: - interrupt-parent: the phandle of the associated interrupt controller. " That should be enough. or should I also add that "it may be inherited from the parent

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

On 10/16/2017 12:04 PM, Sergei Shtylyov wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas <jules.masel...@grenoble-inp.org> --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+)

Re: [PATCH v2 2/2] dt-bindings: max3421: Add bindings documentation

Hello! On 10/16/2017 2:43 AM, Jules Maselbas wrote: Adds bindings documentation for the max3421 driver. Signed-off-by: Jules Maselbas --- .../devicetree/bindings/usb/maxim,max3421.txt | 24 ++ 1 file changed, 24 insertions(+)

Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init()

Hello! On 9/28/2017 3:17 AM, Chunfeng Yun wrote: When fail to get irq number, platform_get_irq() may return Failing. IRQ. :-) -EPROBE_DEFER, but we ignore it and always return -ENODEV, so fix it. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_core.c

Re: [PATCH] USB: gadgetfs: fix copy_to_user while holding spinlock

Hello! On 09/21/2017 11:12 PM, Alan Stern wrote: The gadgetfs driver as a long-outstanding FIXME, regarding a call of s/as/has/? copy_to_user() made while holding a spinlock. This patch fixes the issue by dropping the spinlock and using the dev->udc_usage mechanism introduced by

Re: [PATCH v2 3/4] usb: musb: musb_cppi41: Configure the number of channels for DA8xx

Hello! On 9/20/2017 10:35 AM, Alexandre Bailon wrote: Currently, the number of channels is set to 15 but in the case of DA8xx, the number of channels is 4. Update the driver to configure the number of channels at runtime. Signed-off-by: Alexandre Bailon ---

Re: [PATCH 7/8] xhci: set missing SuperSpeedPlus Link Protocol bit in roothub descriptor

Hello! Only some grammar nits, could prolly be fixed when applying... On 09/18/2017 05:39 PM, Mathias Nyman wrote: A SuperSpeedPlus roothub needs to have the Link Protocol (LP) bit set in the bmSublinkSpeedAttr[] entry of a SuperSpeedPlus descriptor. If the xhci controller has an optional

Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message

Hello. On 9/10/2017 11:37 PM, Guenter Roeck wrote: struct pd_message is the format of a PD message as seen on the wire. Signed-off-by: Guenter Roeck --- drivers/staging/typec/pd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/typec/pd.h

Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file

Hello! On 8/29/2017 12:20 PM, Chunfeng Yun wrote: The mt8173-mtu3.txt actually holds the bindings for all mediatek SoCs with usb3 DRD IP, so add a generic compatible and change the name to mediatek,mtu3.txt. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring

[PATCH] usb: common: use of_property_read_bool()

Use more compact of_property_read_bool() calls for the boolean properties instead of of_find_property() calls in of_usb_host_tpl_support() and of_usb_update_otg_caps(). Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- The patch is against the 'usb-next' branch o

Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

Hello! On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git

Re: [PATCH 2/2] usb: musb: musb_cppi41: Fix cppi41_set_dma_mode() for DA8xx

On 8/13/2017 3:04 PM, Alexandre Bailon wrote: The way to configure the DMA mode on DA8xx is different from DSPS. Add a new function to configure DMA mode on DA8xx and use a callback to call the right function based on the platform. Signed-off-by: Alexandre Bailon ---

Re: [PATCH 1/2] usb: musb: musb_cppi41: Fix the address of teardown and autoreq registers

Hello! On 8/13/2017 3:04 PM, Alexandre Bailon wrote: The DA8xx and DSPS platforms don't use the same address for few registers. On Da8xx, this is causing some issues (e.g. teardown that doesn't work). Configure the address of the register during the init and use them instead of constants.

Re: [PATCH] uas: Add US_FL_IGNORE_RESIDUE for Initio Copropration INIC-3069

Hello! On 7/26/2017 12:46 AM, Alan Swanson wrote: Similar to commit d595259fbb7a7afed241b1afb2c4fe4b47de47fa for INIC-3169 in That's not how you cite a commit -- you should also specify the commit summary line enclosed in ("") (and 12-digit SHA1 would be enough). unusual_devs.h but

Re: [PATCH 1/4] usb: musb: add helper function musb_ep_xfertype_string

Hello! On 07/18/2017 06:13 PM, Bin Liu wrote: Add helper function musb_ep_xfertype_string() to return the ep transfer type string. Signed-off-by: Bin Liu Doesn't this belong to USB core? What's MUSB specific about it? --- drivers/usb/musb/musb_core.h | 24

Re: [PATCH 1/4] usb: Add Aspeed SoC USB controllers to device-tree

On 06/26/2017 05:46 PM, Benjamin Herrenschmidt wrote: arch/arm/boot/dts/aspeed-g4.dtsi | 15 +++ arch/arm/boot/dts/aspeed-g5.dtsi | 22 ++ 2 files changed, 37 insertions(+) If the patch only changes .dtsi files, the subject needs to be smth like "ARM:

Re: [PATCH 1/4] usb: Add Aspeed SoC USB controllers to device-tree

Hello. On 6/25/2017 11:18 PM, Benjamin Herrenschmidt wrote: Now that the necessary tweaks for the Aspeed variant of UHCI are supported, this adds the USB controllers to the DT template of the AST24xx and AST25xx SoCs. The EHCI works with the current unmodified driver. This patch doesn't

Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for

Re: [PATCH v2] usb:host:xhci AMD Promontory USB disable port support

Hello! On 5/26/2017 12:35 PM, Jiahau Chang wrote: There is some limitation for AMD Promontory xHCI host to disable USB port function. It will enable USB wake-up function then cause USB disable port feature to fail. Workaround this issue on Promontory xHCI host is clear PORT_WAKE_BITS.

Re: [PATCH v4 1/4] usb: usbip tool: Check the return of get_nports()

Hello! On 5/22/2017 11:41 AM, Yuyang Du wrote: If we get nonpositive number of ports, there is no sense to continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver") introduced configurable numbers of controllers and

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

Hello! On 05/18/2017 12:50 PM, Yuyang Du wrote: From: Yuyang Du If we get nonpositive number of ports, there is no sense to Negative? continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver")

Re: [PATCH] usb: musb: musb_cppi41: Update an error message

On 05/02/2017 07:50 PM, Alexandre Bailon wrote: If dma_request_slave_channel() failed to return a channel, then the driver will print an error and request to defer probe. Update the error message to explain we are defrering probe. Signed-off-by: Alexandre Bailon ---

Re: [PATCH v2] usb: gadget: gserial: check if console kthread exists

Hello! On 4/29/2017 4:26 PM, Bogdan Mirea wrote: Check for bad pointer that may result because of kthread_create failure. This check is needed since the gserial setup callback function (gs_console_setup()) is only freeing the info->con_buf in case of kthread_create failure which will result

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

On 04/19/2017 01:24 PM, Peter Senna Tschudin wrote: We need the SMSC USB3315 clock and regulator to always be initialized. We also need the PHY driver to take the PHY out of reset. This patch extends the existing USB generic nop phy driver to include a new initialization path. A new compatible

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

Hello! On 4/19/2017 9:14 AM, Peter Senna Tschudin wrote: We need the SMSC USB3315 clock and regulator to always be initialized. We also need the PHY driver to take the PHY out of reset. This patch extends the existing USB generic nop phy driver to include a new initialization path. A new

Re: [PATCH] xhci: use correct flags for spin_lock_irqrestore() when setting port power

Hello. On 4/13/2017 9:48 AM, Mathias Nyman wrote: commit a6ff6cbf1fab ("usb: xhci: Add helper function xhci_set_power_on().") created a helper to control port power that needs to be called with xhci->lock held and interrupts disabled. It relased the lock with spin_unlock_irqerstore using a new

Re: [PATCH] usb: dwc3: make macros safe to expression arguments

Hello. On 4/6/2017 1:17 PM, Felipe Balbi wrote: From: Roger Quadros We must make sure that our macros are safe against expressions passed as arguments. We have see one problem where GTXFIFOSIZ(n) was failling "Seen" and "failing". when passed the expression (epnum >> 1)

Re: [PATCH] usb: dwc3: debugfs: downcase OTG on 'mode' file

Hello. On 03/31/2017 02:12 PM, Felipe Balbi wrote: When writing, we expect the "otg" string. When showing, we return "OTG". Let's downcase that word to avoid confusion. Lowercase, maybe? Signed-off-by: Felipe Balbi [...] MBR, Sergei -- To unsubscribe

Re: [PATCH] ARM: davinci: Add the clock for the CPPI 4.1 DMA engine

Hello! On 03/29/2017 07:09 PM, Alexandre Bailon wrote: The CPPI 4.1 DMA is sharing its clock with the USB OTG, and most of the time, the clock will be enabled by USB. But during the init of the DMA, USB is not enabled (waiting for DMA), and then we must enable the clock before to do anything.

Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's'

Hello! On 3/28/2017 1:34 AM, Colin King wrote: From: Colin Ian King The initial setting of pointer s to the driver name or to the literal string "(none)" is redundant as later it is always set to point to a different literal string before it is printed log. Remove

Re: [PATCH 2/2] Documentation: ABI: testing: sysfs-class-net-qmi: add new qmap mux files description

Hello! On 03/24/2017 04:22 PM, Daniele Palmas wrote: This patch updates the documentation related to the new files added for qmap mux support. Signed-off-by: Daniele Palmas --- Documentation/ABI/testing/sysfs-class-net-qmi | 27 +++ 1 file changed,

Re: [PATCH] usb: gadget: dummy_hcd: Fix wrong port status macros in dummy_hub_control()

Hello! On 3/19/2017 11:23 PM, Yuyang Du wrote: This fixes the commit: 1cd8fd2887e162ad3d06715 (usb: gadget: dummy_hcd: add SuperSpeed support). It should be quoted as commit 1cd8fd2887e1 ("usb: gadget: dummy_hcd: > add SuperSpeed support"). See

Re: [PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification

On 3/18/2017 9:52 PM, Tobias Herzog wrote: Notifications may only be 8 bytes so long. Accessing the 9th and s/so//. "So long and thanks for all the fish!" :-) 10th byte of unimplemented/unknown notifications may be insecure. Also check the length of known notifications before

Re: [PATCH v2] usb: xhci: bInterval quirk for TI TUSB73x0

Hello! On 3/13/2017 11:11 AM, Roger Quadros wrote: As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for

Re: [PATCH] usb: xhci: bInterval quirk for TI TUSB73x0

Hello! On 3/9/2017 11:47 AM, Roger Quadros wrote: As per [1] issue #4, "The periodic EP scheduler always tries to schedule the EPs that have large intervals (interval equal to or greater than 128 microframes) into different microframes. So it maintains an internal counter and increments for

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. Appropriate perhaps? Signed-off-by: Romain Perier Acked-by: Peter Senna

Re: [PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

Hello! On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. It also updates Appropriate perhaps? the name of some variables and the content of comments,

Re: [PATCH] usb: dwc2: Make sure we disconnect the gadget state

Hello! On 3/3/2017 2:36 AM, John Stultz wrote: I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would Plugged. Perhaps could be fixed while applying...

Re: [PATCH] usb: musb: cppi41: don't check early-TX-interrupt for Isoch transfer

Hello! On 3/2/2017 5:52 AM, Bin Liu wrote: The CPPI41 driver polls register to workaround the pre-mature TX It's CPPI 4.1. And "premature". interrupt issue, but it causes audio playback underrun when triggered in Isoch transfers. Isoch doesn't do back-to-back transfers, the TX should

Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

On 2/22/2017 11:55 AM, Chunfeng Yun wrote: there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs is not. it is flexible to move it into port ... but on some SoCs does not? node.

Re: [PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

Hello! On 2/22/2017 11:55 AM, Chunfeng Yun wrote: the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for ... but on some SoCs does not?

Re: [PATCH] lvs: fix race condition in disconnect handling

On 02/20/2017 05:38 PM, Oliver Neukum wrote: There is a small window during which the an URB may So the or an? remain active after disconnect has returned. If in that case already freed memory may be accessed and executed. The fix is to poison the URB befotre the work is flushed.

Re: [PATCH v7 1/5] x86: add simple udelay calibration

Hello! On 2/14/2017 5:27 AM, Lu Baolu wrote: Add a simple udelay calibration in x86 architecture-specific boot-time initializations. This will get a workable estimate for loops_per_jiffy. Hence, udelay() could be used after this initialization. Cc: Ingo Molnar Cc:

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

Hello! On 02/06/2017 05:03 PM, Richard Leitner wrote: For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner

Re: [PATCH v4 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

Hello. On 1/24/2017 1:11 PM, Alexandre Bailon wrote: The DMA may hung up if a teardown is initiated while an endpoint is still Hang up. active (Advisory 2.3.27 of DA8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by: Alexandre Bailon

Re: [PATCH 25/37] xhci: Introduce helper to turn one TRB into a no-op

On 01/20/2017 05:47 PM, Mathias Nyman wrote: Useful for turning both transfer and command trbs into no-ops Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 32 1 file changed, 20 insertions(+), 12 deletions(-)

Re: [PATCH 32/37] usb: host: xhci: remove newline from tracer

Hello! On 01/20/2017 05:47 PM, Mathias Nyman wrote: From: Felipe Balbi If we add that newline, the output will like like the following: Look like. :-) kworker/2:1-42[002] 169.811435: xhci_address_ctx: ctx_64=0, ctx_type=2,

Re: [PATCH v3 2/3] dmaengine: cppi41: Add support of DA8xx to CPPI 4.1

On 01/19/2017 02:13 PM, Alexandre Bailon wrote: The DA8xx has a CPPI 4.1 DMA controller. This is add the glue layer required to make it work on DA8xx. Signed-off-by: Alexandre Bailon --- drivers/dma/Kconfig | 6 +++--- drivers/dma/cppi41.c | 24

Re: [PATCH v3 5/5] usb: musb: da8xx: Add a primary support of PM runtime

On 01/19/2017 05:08 PM, Alexandre Bailon wrote: Currently, DA8xx doesn't support PM runtime. In addition, the glue driver is managing the clock itself. But the CPPI DMA needs to manage this clock too. Add support to PM runtime and use the callback to enable / disable the clock. I think

Re: [PATCH v3 3/5] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

On 01/19/2017 05:08 PM, Alexandre Bailon wrote: Currently, only the PIO mode is supported. This add support of CPPI 4.1 to DA8xx. As the In DA8xx the CPPI 4.1 DMA is a part of the USB. Create the CPPI 4.1 device as a child of USB. Signed-off-by: Alexandre Bailon ---

Re: [PATCH v3 4/4] dmaengine: cppi41: init_sched(): Get number of channels from DT

On 1/19/2017 1:37 PM, Alexandre Bailon wrote: Despite the driver is already using DT to get the number of channels, init_sched() is using an hardcoded value to get it. Use DT to get the number of channels. Signed-off-by: Alexandre Bailon --- drivers/dma/cppi41.c | 26

Re: [PATCH v3 1/3] usb: musb: dma: Add a DMA completion platform callback

Hello! On 1/19/2017 1:06 PM, Alexandre Bailon wrote: Currently, the CPPI 4.1 driver is not completely generic and only work on dsps. This is because of IRQ management. Works. DSPS. Add a callback to dma_controller that could be invoked on DMA completion to acknodlege the IRQ.

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

support") Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Bin Liu <b-...@ti.com> Cc: Grygorii Strashko <grygorii.stras...@ti.com> Cc: Kevin Hilman <khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembed

Re: [PATCH 09/11] dmaengine: cppi41: Fix a race between PM runtime and channel abort

On 01/09/2017 07:06 PM, Alexandre Bailon wrote: cppi41_dma_issue_pending() may be called while the device is runtime suspended. In that case, the descritpor will be push to the pending "Descriptor" and "pushed". list and then be queued to hardware queue. But if cppi41_stop_chan() is

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

On 01/09/2017 07:06 PM, Alexandre Bailon wrote: The da8xx has a cppi41 dma controller. It's called CPPI 4.1. :-) This is add the glue layer required to make it work on da8xx, as well some changes in driver (e.g to manage clock). Signed-off-by: Alexandre Bailon ---

Re: [PATCH 02/11] dmaengine: cppi41: Split out the interrupt handler

Hello. On 01/09/2017 07:06 PM, Alexandre Bailon wrote: The current interrupt handler do some actions specifics to am335x. These actions should be made by the platform interrupt handler. Split out the interrupt handler in two: one for the am335x platform and a generic one. Signed-off-by:

Re: [PATCH 01/11] dmaengine: cppi41: rename platform variables

Hello! On 01/09/2017 07:06 PM, Alexandre Bailon wrote: Currently, only the am335x is supported by the driver. Though the driver has a glue layer to support different platforms, some platform variable names are not prefixed with the platform name. To facilitate the addition of a new platform,

Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

On 01/10/2017 07:15 PM, David Lechner wrote: This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850.dtsi | 16 1 file changed, 16

Re: [PATCH 13/21] usb: dwc2: Update parameter types

On 01/10/2017 05:24 AM, John Youn wrote: Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

On 01/09/2017 09:43 PM, Tony Lindgren wrote: da8xx driver is registering and using the cppi dma controller but actually, the da8xx has a cppi41 dma controller. Update the driver to register and use the cppi41 dma controller. Signed-off-by: Alexandre Bailon ---

Re: [PATCH 11/11] dmaengine: cppi41: Fix teardown warnings

On 01/09/2017 07:06 PM, Alexandre Bailon wrote: During the teardown of a RX channel, because there is only one completion queue available for RX channel, descriptor of another channel may be popped which will cause 2 warnings: - the first one because we popped a wrong descriptor (neither the

Re: [PATCH 4/4] usb: musb: musb_cppi41: Workaround dma stall issue during teardown

Hello! On 01/09/2017 07:39 PM, Alexandre Bailon wrote: The dma may hung up if a teardown is initiated while an endpoint is still The DMA may hang up... active (Advisory 2.3.27 of da8xx errata). To workaround this issue, add a delay before to initiate the teardown. Signed-off-by:

Re: [PATCH 07/11] dt/bindings: da8xx-usb: Add binding for the cppi41 dma controller

Hello! On 01/09/2017 07:06 PM, Alexandre Bailon wrote: DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller. It's called CPPI 4.1, not cppi41. Let me introduce myself: I was the author of the 1st CPPI 4.1 drivers (never merged). Signed-off-by: Alexandre Bailon

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

Hello! On 01/09/2017 07:38 PM, Alexandre Bailon wrote: da8xx driver is registering and using the cppi dma controller but actually, the da8xx has a cppi41 dma controller. Update the driver to register and use the cppi41 dma controller. Signed-off-by: Alexandre Bailon ---

  1   2   3   4   5   6   7   8   9   10   >