Re: [PATCH] xmon consistency clean up

2007-07-27 Thread Ishizaki Kou
Michael Ellerman [EMAIL PROTECTED] wrote: On Wed, 2007-07-25 at 16:21 +1000, Benjamin Herrenschmidt wrote: On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote: This patch cleans up xmon to keep consistency. In xmon, we should use console I/O functions that are named the same as

Re: [spi-devel-general] [PATCH 0/4] Few spi_mpc83xx.c fixes and improvements

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 9:58 PM, David Brownell wrote: On Thursday 26 July 2007, Anton Vorontsov wrote: Hi all, These patches based on Linus' tree, as of today. I don't know mpc83xx ... are there any PPC folk who can see any reason not to just merge these patches? They look OK to me, but in

Decermenter overflow interrupt atfer the init.d launch.

2007-07-27 Thread Nicolas Mederle
Hi, I want to know how the kernel switch the task. Because my kernel start very well, and it launch the init.d. With the log, i can see that the kernel launch the getty task. But after, there is a decrementer overflow interrupt ( vector at adress 900 ). Is it the task switch? Or is

Re: Decermenter overflow interrupt atfer the init.d launch.

2007-07-27 Thread Kumar Gala
On Jul 27, 2007, at 1:36 AM, Nicolas Mederle wrote: Hi, I want to know how the kernel switch the task. Because my kernel start very well, and it launch the init.d. With the log, i can see that the kernel launch the getty task. But after, there is a decrementer overflow

Re: [spi-devel-general] [PATCH 1/4] [POWERPC][SPI] spi_mpc83xx.c: should turn off SPI unit while switching any mode.

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 8:13 AM, Anton Vorontsov wrote: Documentation clearly states, that mode should not be changed till SPMODE_ENABLE bit set. I've seen hangs w/o this patch. Out of interest what board/part do you see the hang on? - k ___

Re: Decermenter overflow interrupt atfer the init.d launch.

2007-07-27 Thread Benjamin Herrenschmidt
On Fri, 2007-07-27 at 01:46 -0500, Kumar Gala wrote: On Jul 27, 2007, at 1:36 AM, Nicolas Mederle wrote: Hi, I want to know how the kernel switch the task. Because my kernel start very well, and it launch the init.d. With the log, i can see that the kernel launch the

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-27 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 21:22 -0700, Andrew Morton wrote: Merged a fixed version: f5d834fc34e61f1a40435981062000e5d2b2baa8 (In linus tree as of now) I hope so. Alan's patch looks rather different from what you have now: fall back to of_find_node_by_name() if

Re: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

2007-07-27 Thread Stephen Rothwell
On Thu, 26 Jul 2007 16:42:50 +0800 Zhang Wei [EMAIL PROTECTED] wrote: +#include asm/of_device.h +#include asm/of_platform.h These should now be linux/of_device.h and linux/of_platform.h -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 12:05 PM, Vitaly Bordug wrote: On Thu, 26 Jul 2007 11:45:08 -0500 Scott Wood [EMAIL PROTECTED] wrote: On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote: +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL; +EXPORT_SYMBOL(fsl_spi_activate_cs); +void

Re: [PATCH 0/5 v3] Porting RapidIO driver from ppc to powerpc architecture and adding memory mapped RapidIO driver.

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote: These patches are the version 3 patches for RapidIO with dts update and some minor fixups. These patches are used for supporting RapidIO controllers of Freescale. I ported them from ppc architecture to powerpc architecture and added some

Re: [PATCH 4/5 v3] Add RapidIO support to powerpc architecture.

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote: This patch adds the RapidIO support to the powerpc architecture. Some files are moved from ppc. OF-tree and OF-device supports are added. New silicons such as MPC8548, MPC8641 with serial RapidIO controller are all supported. Memory driver

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote: mmc_spi already tested to work. When it will hit mainline the only change that would be needed is replacing spidev by mmc_spi, and adding trivial platform data to mmc_spi driver. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] ---

Re: [PATCH 1/5 v3] Add the explanation and a sample of RapidIO OF node to the document of booting-without-of.txt file.

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote: Add the explanation and a sample of RapidIO OF node to the document of booting-without-of.txt file. Signed-off-by: Zhang Wei [EMAIL PROTECTED] --- Documentation/powerpc/booting-without-of.txt | 37 +++ +++ 1 files

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 8:56 AM, Anton Vorontsov wrote: Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/sysdev/fsl_soc.c | 76 ++ +++ arch/powerpc/sysdev/fsl_soc.h |3 ++ 2 files changed, 79 insertions(+), 0 deletions(-) There

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jan-Bernd Themann
Hi Drew, thanks a lot for your good feedback. See comments below. I'll try to provide an updated version next week. It would be nice if you could post a patch for your driver once we have addressed the issues you mentioned. Then we would have the eHEA driver for the SKB interface, and your driver

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jeff Garzik
Just to chime in... In general, I like where this LRO effort is going, and I really appreciate you guys working on it. Jeff ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [spi-devel-general] [PATCH 2/3] [SPI] Add new mode: SPI_LOOP

2007-07-27 Thread Anton Vorontsov
On Thu, Jul 26, 2007 at 08:07:07PM -0700, David Brownell wrote: On Thursday 26 July 2007, Anton Vorontsov wrote: Loopback mode is supported by various controllers, this mode is useful for testing, especially in conjunction with spidev driver. ISTR that Stephen Street provided a loopback

Re: [PATCH] fix ppc kernels after build-id addition

2007-07-27 Thread Meelis Roos
This patch fixes arch/ppc kernels, at least for prep subarch, after build-id addition. Without the patch, kernels were 3 times the size and bootloader refused to load them. Now they are back to normal again. I just built an ARCH=ppc kernel for the prep subarch and the vmlinux size was

pq2fads support...

2007-07-27 Thread Alexandros Kostopoulos
Hello Scott and all, In your patch for the pq2fads support, the device tree seems to be missing a memory node, for which dtc complains loudly. Is this board tested to boot with these patches (because I'm now using this as a template for my board - with your patchset applied to Paul's git)

[PATCH 0/2] ehca: remove WARNING: externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
Hello Roland! This small patch set fixes some coding-style related issues for ehca: [1/2] remove checkpatch.pl's warnings externs should be avoided in .c files [2/2] correction include order according kernel coding style Thanks Nam ___ Linuxppc-dev

Re: [PATCH] mpc832x_rdb.c: prevent using uninitialized variable

2007-07-27 Thread Anton Vorontsov
On Thu, Jul 26, 2007 at 11:48:33AM -0500, Scott Wood wrote: On Thu, Jul 26, 2007 at 06:01:39PM +0400, Anton Vorontsov wrote: If CONFIG_PCI undefined, np will be used uninitialized, thereby find_node_by_name(np, par_io) will fail. This is the wrong fix -- you should be passing NULL to the

RE: [PATCH 4/5 v3] Add RapidIO support to powerpc architecture.

2007-07-27 Thread Zhang Wei-r63237
Hi, Kumar, -Original Message- From: Kumar Gala [mailto:[EMAIL PROTECTED] On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote: This patch adds the RapidIO support to the powerpc architecture. Some files are moved from ppc. OF-tree and OF-device supports are added. New silicons

[PATCH 1/2] ehca: remove checkpatch.pl's warnings externs should be avoided in .c files

2007-07-27 Thread Hoang-Nam Nguyen
From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings externs should be avoided in .c files Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] ---

[PATCH 2/2] ehca: correction include order according kernel coding style

2007-07-27 Thread Hoang-Nam Nguyen
From a2794450cbee597cefd7b6e159257583c459d358 Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 27 Jul 2007 10:26:40 +0200 Subject: [PATCH] correction include order according kernel coding style Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] ---

Re: [PATCH 1/2] ehca: remove checkpatch.pl's warnings externs should be avoided in .c files

2007-07-27 Thread Sam Ravnborg
On Fri, Jul 27, 2007 at 12:54:50PM +0200, Hoang-Nam Nguyen wrote: From b5d0336089b5ebe5b18acb94b2c94c2026cb95ee Mon Sep 17 00:00:00 2001 From: Hoang-Nam Nguyen hnguyen at de.ibm.com Date: Fri, 27 Jul 2007 10:24:49 +0200 Subject: [PATCH] remove checkpatch.pl's warnings externs should be avoided

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Anton Vorontsov
On Fri, Jul 27, 2007 at 03:14:06AM -0500, Kumar Gala wrote: On Jul 26, 2007, at 8:57 AM, Anton Vorontsov wrote: [...] @@ -207,20 +222,36 @@ [EMAIL PROTECTED] { device_type = spi; +device-id = 1; Can we just use the reg value for

[PATCH 12/68] 0 - NULL, for arch/powerpc

2007-07-27 Thread Yoann Padioleau
When comparing a pointer, it's clearer to compare it to NULL than to 0. Here is an excerpt of the semantic patch: @@ expression *E; @@ E == - 0 + NULL @@ expression *E; @@ E != - 0 + NULL Signed-off-by: Yoann Padioleau [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: linuxppc-dev@ozlabs.org

Re: [RFC][PATCH] MPC832x_RDB: update dts to use spi, register mmc_spi stub

2007-07-27 Thread Scott Wood
On Fri, Jul 27, 2007 at 03:45:59PM +0400, Anton Vorontsov wrote: Sure, technically nothing prevents this. But, QE specs names SPIs by these ids. Plus, from the kernel side spi name will be not pretty, it will be spi1216.1. Reg value making little sense to the userspace (or kernel-side SPI

Re: pq2fads support...

2007-07-27 Thread Scott Wood
On Fri, Jul 27, 2007 at 03:24:08PM +0300, Alexandros Kostopoulos wrote: In your patch for the pq2fads support, the device tree seems to be missing a memory node, for which dtc complains loudly. Is this board tested to boot with these patches (because I'm now using this as a template for my

Re: pq2fads support...

2007-07-27 Thread Alexandros Kostopoulos
Thanks for your reply, Scott, one question though: I am NOT using the bootwrapper, I'm instead feeding dtb and uImage directly to u-boot. This probably means that I should fill in lots of stuff manually into dts, right? But, (and please forgive my ignorance) who does actually fill in stuff

Re: pq2fads support...

2007-07-27 Thread Scott Wood
Alexandros Kostopoulos wrote: Thanks for your reply, Scott, one question though: I am NOT using the bootwrapper, I'm instead feeding dtb and uImage directly to u-boot. This probably means that I should fill in lots of stuff manually into dts, right? No, u-boot should fill in the same

[PATCH 4/5] 8xx: Remove unnecessary loops_per_jiffy initialization code.

2007-07-27 Thread Jon Loeliger
Signed-off-by: Jon Loeliger [EMAIL PROTECTED] --- arch/powerpc/platforms/8xx/mpc86xads_setup.c | 14 -- arch/powerpc/platforms/8xx/mpc885ads_setup.c | 14 -- 2 files changed, 0 insertions(+), 28 deletions(-) diff --git a/arch/powerpc/platforms/8xx/mpc86xads_setup.c

[PATCH 0/5] Remove unnecessary loops_per_jiffy initialization code

2007-07-27 Thread Jon Loeliger
This patch series removes lingering jiffies initialization code from several platforms. Note that the first patch in this series for the 86xx has been rebased to current top of Paul's repository and replaces an earlier version. arch/powerpc/platforms/52xx/lite5200.c | 13

[PATCH 1/5] 86xx: Remove unnecessary loops_per_jiffy initialization code.

2007-07-27 Thread Jon Loeliger
Signed-off-by: Jon Loeliger [EMAIL PROTECTED] --- Note -- This is a rebased version of an earlier patch from July 17. That one can be dropped. arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH 3/5] 52xx: Remove unnecessary loops_per_jiffy initialization code.

2007-07-27 Thread Jon Loeliger
Signed-off-by: Jon Loeliger [EMAIL PROTECTED] --- arch/powerpc/platforms/52xx/lite5200.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/platforms/52xx/lite5200.c b/arch/powerpc/platforms/52xx/lite5200.c index 5c46e89..84bd3da 100644 ---

Re: help with ppc sections?

2007-07-27 Thread Chris Friesen
Grant Likely wrote: Mild question; What the [EMAIL PROTECTED] are you doing trying to backport to a 2 year old kernel?!? :-) That's what happens in the embedded space. It's the current version from our distro vendor. It's also the version that all our different board suppliers could

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Andrew Gallatin
Jan-Bernd Themann wrote: On Wednesday 25 July 2007 19:17, Andrew Gallatin wrote: 3) Padded frames. I may be missing something, but I don't see where you either strip padding from frames or reject padded frames. (see the pskb_trim_rcsum() in net/ipv4/ip_input.c:ip_rcv() I think I

Re: [PATCH] Re: 2.6.22-git hangs during PCMCIA on PowerBook G3 in 0.0 seconds

2007-07-27 Thread Rutger Nijlunsing
Kim p.s. should the stable team be notified to fix 2.6.22 for Lombard-nvram-style machines? Logically, yes. Practically it does not matter that much it seems. I've got the feeling the Lombard-users-group-size is about one person which is going to drop to zero if he doesn't get any further

Re: [PATCH 5/5] embedded6xx: Remove unnecessary loops_per_jiffy initialization code.

2007-07-27 Thread Mark A. Greer
On Fri, Jul 27, 2007 at 01:25:09PM -0500, Jon Loeliger wrote: Signed-off-by: Jon Loeliger [EMAIL PROTECTED] FWIW for the prpmc2800 part... Acked-by: Mark A. Greer [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH] Re: 2.6.22-git hangs during PCMCIA on PowerBook G3 in 0.0 seconds

2007-07-27 Thread Benjamin Herrenschmidt
On Sat, 2007-07-28 at 00:11 +0200, Rutger Nijlunsing wrote: Kim p.s. should the stable team be notified to fix 2.6.22 for Lombard-nvram-style machines? Logically, yes. Practically it does not matter that much it seems. I've got the feeling the Lombard-users-group-size is about one

Re: [PATCH] Re: 2.6.22-git hangs during PCMCIA on PowerBook G3 in 0.0 seconds

2007-07-27 Thread Kim Phillips
On Sat, 28 Jul 2007 08:26:47 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Sat, 2007-07-28 at 00:11 +0200, Rutger Nijlunsing wrote: Kim p.s. should the stable team be notified to fix 2.6.22 for Lombard-nvram-style machines? Logically, yes. Two ! Paulus has one

Re: [PATCH 12/68] 0 - NULL, for arch/powerpc

2007-07-27 Thread Paul Mackerras
Yoann Padioleau writes: When comparing a pointer, it's clearer to compare it to NULL than to 0. As other people have said, if you're going to spend time on this, testing (!buf) is more idiomatic in the kernel than (buf == NULL). Paul. ___