Re: [PATCH v9 06/10] arm64: dts: ls1046a: Add serdes bindings

2023-01-26 Thread Shawn Guo
On Thu, Jan 26, 2023 at 11:43:26AM -0500, Sean Anderson wrote: > On 1/25/23 18:46, Shawn Guo wrote: > > On Thu, Dec 29, 2022 at 07:01:35PM -0500, Sean Anderson wrote: > >> This adds bindings for the SerDes devices. They are disabled by default > > > > s/bindings/descriptions? > > > > The term

Re: [PATCH v9 07/10] arm64: dts: ls1046ardb: Add serdes bindings

2023-01-26 Thread Shawn Guo
On Thu, Jan 26, 2023 at 11:48:53AM -0500, Sean Anderson wrote: > On 1/25/23 18:43, Shawn Guo wrote: > > On Thu, Dec 29, 2022 at 07:01:36PM -0500, Sean Anderson wrote: > >> This adds appropriate bindings for the macs which use the SerDes. The > >> 156.25MHz fixed clock is a crystal. The 100MHz

[PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-01-26 Thread Randy Dunlap
Correct many spelling errors in Documentation/ as reported by codespell. Maintainers of specific kernel subsystems are only Cc-ed on their respective patches, not the entire series. [if all goes well] These patches are based on linux-next-20230125. [PATCH 01/35] Documentation: arm64: correct

[PATCH 21/35] Documentation: powerpc: correct spelling

2023-01-26 Thread Randy Dunlap
Correct spelling problems for Documentation/powerpc/ as reported by codespell. Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/powerpc/kasan.txt |2 +-

Re: [PATCH] powerpc/tlb: Remove BUILD_BUG for book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-26 Thread Christophe Leroy
Le 26/01/2023 à 23:30, Benjamin Gray a écrit : > On Wed, 2023-01-25 at 09:43 +, Christophe Leroy wrote: > >> By the way, are you should the problem is really BUILD_BUG() ? >> Looking >> at your patch I would think that the problem is because it is "static >> inline". Have you tried 'static

Re: [PATCH] powerpc/kexec_file: account hot-pluggable memory while estimating FDT size

2023-01-26 Thread Sourabh Jain
Gentle reminder, any comments and suggestions on this fix. - Sourabh On 15/12/22 14:08, Sourabh Jain wrote: On Systems where online memory is lesser compared to max memory, the kexec_file_load system call may fail to load the kdump kernel with the below errors: "Failed to update fdt with

Re: [PATCH] kasan: Fix Oops due to missing calls to kasan_arch_is_ready()

2023-01-26 Thread Michael Ellerman
Andrew Morton writes: > On Thu, 26 Jan 2023 08:04:47 +0100 Christophe Leroy > wrote: > >> On powerpc64, you can build a kernel with KASAN as soon as you build it >> with RADIX MMU support. However if the CPU doesn't have RADIX MMU, >> KASAN isn't enabled at init and the following Oops is

Re: [PATCH v4 02/24] powerpc/pseries: Fix alignment of PLPKS structures and buffers

2023-01-26 Thread Andrew Donnellan
On Thu, 2023-01-26 at 17:31 +, David Laight wrote: > Changing the size to kzalloc() doesn't help. > The alignment depends on the allocator and is only required to have > a relatively small alignment (ARCH_MINALIGN?) regardless of the size. > > IIRC one of the allocators adds a small header to

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Sebastian Reichel
Hi, On Wed, Jan 25, 2023 at 12:38:48AM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > --- > [...] >

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox wrote: > > On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > > +/* Use when VMA is not

[PATCH] scripts/spelling.txt: add "exsits" pattern and fix typo instances

2023-01-26 Thread Luca Ceresoli
Fix typos and add the following to the scripts/spelling.txt: exsits||exists Signed-off-by: Luca Ceresoli --- drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +- net/openvswitch/flow_table.c | 2 +- scripts/spelling.txt | 1 + sound/soc/fsl/fsl-asoc-card.c

[PATCH] ASoC: fsl-asoc-card: constify fsl_asoc_card_dai

2023-01-26 Thread Luca Ceresoli
This is never modified and can be made const. Signed-off-by: Luca Ceresoli --- sound/soc/fsl/fsl-asoc-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 2f25358196ee..00118a75d126 100644 ---

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Matthew Wilcox
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > > +static inline

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Mike Rapoport
On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking

Re: [PATCH v2 6/6] mm: export dump_mm()

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:51AM -0800, Suren Baghdasaryan wrote: > mmap_assert_write_locked() is used in vm_flags modifiers. Because > mmap_assert_write_locked() uses dump_mm() and vm_flags are sometimes > modified from from inside a module, it's necessary to export > dump_mm() function. > >

Re: [PATCH 3/3] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-01-26 Thread Guo Ren
On Thu, Jan 26, 2023 at 3:08 AM Mike Rapoport wrote: > > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline as a

Re: [PATCH] scripts/spelling.txt: add "exsits" pattern and fix typo instances

2023-01-26 Thread Jakub Kicinski
On Thu, 26 Jan 2023 16:22:05 +0100 Luca Ceresoli wrote: > Fix typos and add the following to the scripts/spelling.txt: > > exsits||exists > > Signed-off-by: Luca Ceresoli You need to split this up per subsystem, I reckon :(

[PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time

2023-01-26 Thread Ian Rogers
Add a target that generates a log file for running metric_test.py and make this a dependency on generating pmu-events.c. The log output is displayed if the test fails like (the test was modified to make it fail): ``` TEST/tmp/perf/pmu-events/metric_test.log F..

[PATCH v5 14/15] tools build: Add test echo-cmd

2023-01-26 Thread Ian Rogers
Add quiet_cmd_test so that: $(Q)$(call echo-cmd,test) will print: TEST This is useful for executing compile-time tests similar to what happens for fortify tests in the kernel's lib directory. --- tools/build/Makefile.build | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 13/15] perf jevents: Correct bad character encoding

2023-01-26 Thread Ian Rogers
A character encoding issue added a "3D" character that breaks the metrics test. Fixes: 40769665b63d ("perf jevents: Parse metrics during conversion") --- tools/perf/pmu-events/metric_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v5 12/15] perf pmu-events: Fix testing with JEVENTS_ARCH=all

2023-01-26 Thread Ian Rogers
The #slots literal will return NAN when not on ARM64 which causes a perf test failure when not on an ARM64 for a JEVENTS_ARCH=all build: .. 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED! .. Add an is_test boolean so that the failure can be avoided when running as a

[PATCH v5 11/15] perf jevents: Add model list option

2023-01-26 Thread Ian Rogers
This allows the set of generated jevents events and metrics be limited to a subset of the model names. Appropriate if trying to minimize the binary size where only a set of models are possible. --- tools/perf/pmu-events/Build | 3 ++- tools/perf/pmu-events/jevents.py | 14 ++ 2

[PATCH v5 10/15] perf jevents: Generate metrics and events as separate tables

2023-01-26 Thread Ian Rogers
Turn a perf json event into an event, metric or both. This reduces the number of events needed to scan to find an event or metric. As events no longer need the relatively seldom used metric fields, 4 bytes is saved per event. This reduces the big C string's size by 335kb (14.8%) on x86. Note, for

[PATCH v5 09/15] perf pmu-events: Introduce pmu_metrics_table

2023-01-26 Thread Ian Rogers
Add a metrics table that is just a cast from pmu_events_table. This changes the APIs so that event and metric usage of the underlying table is different. For the no jevents case the tables are already separate, later changes will separate the tables for the jevents case. ---

[PATCH v5 08/15] perf jevents: Combine table prefix and suffix writing

2023-01-26 Thread Ian Rogers
Combine into a single function to simplify, in a later change, writing metrics separately. --- tools/perf/pmu-events/jevents.py | 36 +--- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/tools/perf/pmu-events/jevents.py

[PATCH v5 07/15] perf stat: Remove evsel metric_name/expr

2023-01-26 Thread Ian Rogers
Metrics are their own unit and these variables held broken metrics previously and now just hold the value NULL. Remove code that used these variables. Reviewed-by: John Garry --- tools/perf/builtin-stat.c | 1 - tools/perf/util/cgroup.c | 1 - tools/perf/util/evsel.c | 2 -

[PATCH v5 06/15] perf pmu-events: Remove now unused event and metric variables

2023-01-26 Thread Ian Rogers
Previous changes separated the uses of pmu_event and pmu_metric, however, both structures contained all the variables of event and metric. This change removes the event variables from metric and the metric variables from event. Note, this change removes the setting of evsel's metric_name/expr as

[PATCH v5 05/15] perf pmu-events: Separate the metrics from events for no jevents

2023-01-26 Thread Ian Rogers
Separate the event and metric table when building without jevents. Add find_core_metrics_table and perf_pmu__find_metrics_table while renaming existing utilities to be event specific, so that users can find the right table for their need. Reviewed-by: John Garry ---

[PATCH v5 04/15] perf pmu-events: Add separate metric from pmu_event

2023-01-26 Thread Ian Rogers
Create a new pmu_metric for the metric related variables from pmu_event but that is initially just a clone of pmu_event. Add iterators for pmu_metric and use in places that metrics are desired rather than events. Make the event iterator skip metric only events, and the metric iterator skip event

[PATCH v5 03/15] perf jevents: Rewrite metrics in the same file with each other

2023-01-26 Thread Ian Rogers
Rewrite metrics within the same file in terms of each other. For example, on Power8 other_stall_cpi is rewritten from: "PM_CMPLU_STALL / PM_RUN_INST_CMPL - PM_CMPLU_STALL_BRU_CRU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_FXU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_VSU / PM_RUN_INST_CMPL -

[PATCH v5 02/15] perf jevents metric: Add ability to rewrite metrics in terms of others

2023-01-26 Thread Ian Rogers
Add RewriteMetricsInTermsOfOthers that iterates over pairs of names and expressions trying to replace an expression, within the current expression, with its name. --- tools/perf/pmu-events/metric.py | 73 +++- tools/perf/pmu-events/metric_test.py | 10 2 files

[PATCH v5 01/15] perf jevents metric: Correct Function equality

2023-01-26 Thread Ian Rogers
rhs may not be defined, say for source_count, so add a guard. Reviewed-by: Kajol Jain --- tools/perf/pmu-events/metric.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric.py index 4797ed4fd817..2f2fd220e843

[PATCH v5 00/15] jevents/pmu-events improvements

2023-01-26 Thread Ian Rogers
Add an optimization to jevents using the metric code, rewrite metrics in terms of each other in order to minimize size and improve readability. For example, on Power8 other_stall_cpi is rewritten from: "PM_CMPLU_STALL / PM_RUN_INST_CMPL - PM_CMPLU_STALL_BRU_CRU / PM_RUN_INST_CMPL -

Re: [PATCH] kasan: Fix Oops due to missing calls to kasan_arch_is_ready()

2023-01-26 Thread Andrey Konovalov
On Thu, Jan 26, 2023 at 8:08 AM Christophe Leroy wrote: > > On powerpc64, you can build a kernel with KASAN as soon as you build it > with RADIX MMU support. However if the CPU doesn't have RADIX MMU, > KASAN isn't enabled at init and the following Oops is encountered. > > [0.00][

Re: [PATCH] kasan: Fix Oops due to missing calls to kasan_arch_is_ready()

2023-01-26 Thread Andrew Morton
On Thu, 26 Jan 2023 08:04:47 +0100 Christophe Leroy wrote: > On powerpc64, you can build a kernel with KASAN as soon as you build it > with RADIX MMU support. However if the CPU doesn't have RADIX MMU, > KASAN isn't enabled at init and the following Oops is encountered. Should we backport to

Re: [PATCH v4 5/7] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Michael Ellerman
Suren Baghdasaryan writes: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko > Acked-by: Mel Gorman > Acked-by: Mike

Re: [PATCH] powerpc/tlb: Remove BUILD_BUG for book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-26 Thread Benjamin Gray
On Wed, 2023-01-25 at 09:43 +, Christophe Leroy wrote: > By the way, are you should the problem is really BUILD_BUG() ? > Looking > at your patch I would think that the problem is because it is "static > inline". Have you tried 'static __always_inline' instead ? I did not try it, so I just

Re: [PATCH] powerpc/tlb: Remove BUILD_BUG for book3s/32/tlbflush.h local_flush_tlb_page_psize

2023-01-26 Thread Benjamin Gray
On Wed, 2023-01-25 at 22:35 +1100, Michael Ellerman wrote: > Can't we just fall back to flush_tlb_page(vma, vmaddr)? > > I'd guess those CPUs can't flush based on page size anyway. > > cheers Probably. Do they have a fixed page size? It's not a BUILD_BUG/WARN because it _should_ be

Re: [PATCH RESEND 0/8] Resend LED patches

2023-01-26 Thread Linus Walleij
On Fri, Jan 20, 2023 at 6:15 PM Lee Jones wrote: > If everyone is convinced that applying these drivers is the correct > thing to do, I'd be happy to (rather) take them via LEDs. Oh you are co-maintainer of the LED subsystem since a month! Sadly this series stalled way before that, so that's

Re: [PATCH v4 6/7] mm: introduce __vm_flags_mod and use it in untrack_pfn

2023-01-26 Thread Mike Rapoport
On Thu, Jan 26, 2023 at 11:37:51AM -0800, Suren Baghdasaryan wrote: > There are scenarios when vm_flags can be modified without exclusive > mmap_lock, such as: > - after VMA was isolated and mmap_lock was downgraded or dropped > - in exit_mmap when there are no other mm users and locking is

Re: [PATCH v4 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Mike Rapoport
On Thu, Jan 26, 2023 at 11:37:47AM -0800, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such >

Re: [PATCH v4 1/7] kernel/fork: convert vma assignment to a memcpy

2023-01-26 Thread Mike Rapoport
On Thu, Jan 26, 2023 at 11:37:46AM -0800, Suren Baghdasaryan wrote: > Convert vma assignment in vm_area_dup() to a memcpy() to prevent compiler > errors when we add a const modifier to vma->vm_flags. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Mel Gorman Acked-by: Mike Rapoport (IBM) >

[PATCH v4 7/7] mm: export dump_mm()

2023-01-26 Thread Suren Baghdasaryan
mmap_assert_write_locked() is used in vm_flags modifiers. Because mmap_assert_write_locked() uses dump_mm() and vm_flags are sometimes modified from inside a module, it's necessary to export dump_mm() function. Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Mike Rapoport

[PATCH v4 6/7] mm: introduce __vm_flags_mod and use it in untrack_pfn

2023-01-26 Thread Suren Baghdasaryan
There are scenarios when vm_flags can be modified without exclusive mmap_lock, such as: - after VMA was isolated and mmap_lock was downgraded or dropped - in exit_mmap when there are no other mm users and locking is unnecessary Introduce __vm_flags_mod to avoid assertions when the caller takes

[PATCH v4 5/7] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Suren Baghdasaryan
Replace indirect modifications to vma->vm_flags with calls to modifier functions to be able to track flag changes and to keep vma locking correctness. Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Mel Gorman Acked-by: Mike Rapoport (IBM) ---

[PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Suren Baghdasaryan
Replace direct modifications to vma->vm_flags with calls to modifier functions to be able to track flag changes and to keep vma locking correctness. Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Mel Gorman Acked-by: Mike Rapoport (IBM) Acked-by: Sebastian Reichel ---

[PATCH v4 3/7] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK

2023-01-26 Thread Suren Baghdasaryan
To simplify the usage of VM_LOCKED_CLEAR_MASK in vm_flags_clear(), replace it with VM_LOCKED_MASK bitmask and convert all users. Signed-off-by: Suren Baghdasaryan Acked-by: Michal Hocko Acked-by: Mel Gorman Acked-by: Mike Rapoport (IBM) --- include/linux/mm.h | 4 ++-- kernel/fork.c | 2

[PATCH v4 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Suren Baghdasaryan
vm_flags are among VMA attributes which affect decisions like VMA merging and splitting. Therefore all vm_flags modifications are performed after taking exclusive mmap_lock to prevent vm_flags updates racing with such operations. Introduce modifier functions for vm_flags to be used whenever flags

[PATCH v4 0/7] introduce vm_flags modifier functions

2023-01-26 Thread Suren Baghdasaryan
This patchset was originally published as a part of per-VMA locking [1] and was split after suggestion that it's viable on its own and to facilitate the review process. It is now a preprequisite for the next version of per-VMA lock patchset, which reuses vm_flags modifier functions to lock the VMA

[PATCH v4 1/7] kernel/fork: convert vma assignment to a memcpy

2023-01-26 Thread Suren Baghdasaryan
Convert vma assignment in vm_area_dup() to a memcpy() to prevent compiler errors when we add a const modifier to vma->vm_flags. Signed-off-by: Suren Baghdasaryan Acked-by: Mel Gorman --- kernel/fork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/fork.c

Re: [PATCH v4 02/12] perf jevents metric: Add ability to rewrite metrics in terms of others

2023-01-26 Thread Ian Rogers
On Thu, Jan 26, 2023 at 7:59 AM John Garry wrote: > > On 26/01/2023 01:18, Ian Rogers wrote: > > Add RewriteMetricsInTermsOfOthers that iterates over pairs of names > > and expressions trying to replace an expression, within the current > > expression, with its name. > > > > Signed-off-by: Ian

Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Davidlohr Bueso
On Wed, 25 Jan 2023, Andrew Morton wrote: On Wed, 25 Jan 2023 15:35:49 -0800 Suren Baghdasaryan wrote: vm_flags are among VMA attributes which affect decisions like VMA merging and splitting. Therefore all vm_flags modifications are performed after taking exclusive mmap_lock to prevent

Re: arch/powerpc/kernel/head_85xx.o: warning: objtool: .head.text+0x1a6c: unannotated intra-function call

2023-01-26 Thread Segher Boessenkool
Hi! On Wed, Jan 25, 2023 at 12:57:35PM +0530, Naveen N. Rao wrote: > Sathvika Vasireddy wrote: > >--- a/arch/powerpc/kvm/booke.c > >+++ b/arch/powerpc/kvm/booke.c > >@@ -917,7 +917,9 @@ static void kvmppc_fill_pt_regs(struct pt_regs *regs) > >     asm("mr %0, 1" : "=r"(r1)); > >    

Re: [PATCH v9 08/10] arm64: dts: ls1088a: Add serdes bindings

2023-01-26 Thread Sean Anderson
On 1/25/23 18:48, Shawn Guo wrote: > On Thu, Dec 29, 2022 at 07:01:37PM -0500, Sean Anderson wrote: >> This adds bindings for the SerDes devices. They are disabled by default >> to prevent any breakage on existing boards. >> >> Signed-off-by: Sean Anderson >> --- >> >> (no changes since v4) >>

Re: [PATCH v3 6/7] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 9:32 AM Mel Gorman wrote: > > On Thu, Jan 26, 2023 at 08:18:31AM -0800, Suren Baghdasaryan wrote: > > On Thu, Jan 26, 2023 at 7:47 AM Mel Gorman > > wrote: > > > > > > On Wed, Jan 25, 2023 at 03:35:53PM -0800, Suren Baghdasaryan wrote: > > > > In cases when VMA flags are

Re: [PATCH v3 6/7] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Mel Gorman
On Thu, Jan 26, 2023 at 08:18:31AM -0800, Suren Baghdasaryan wrote: > On Thu, Jan 26, 2023 at 7:47 AM Mel Gorman > wrote: > > > > On Wed, Jan 25, 2023 at 03:35:53PM -0800, Suren Baghdasaryan wrote: > > > In cases when VMA flags are modified after VMA was isolated and mmap_lock > > > was

RE: [PATCH v4 02/24] powerpc/pseries: Fix alignment of PLPKS structures and buffers

2023-01-26 Thread David Laight
From: Segher Boessenkool > Sent: 26 January 2023 17:19 > > On Thu, Jan 26, 2023 at 12:09:53AM +1100, Michael Ellerman wrote: > > Andrew Donnellan writes: > > > A number of structures and buffers passed to PKS hcalls have alignment > > > requirements, which could on occasion cause problems: > > >

Re: [PATCH v3 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 9:27 AM Mel Gorman wrote: > > On Thu, Jan 26, 2023 at 08:10:26AM -0800, Suren Baghdasaryan wrote: > > On Thu, Jan 26, 2023 at 7:10 AM Mel Gorman > > wrote: > > > > > > On Wed, Jan 25, 2023 at 03:35:51PM -0800, Suren Baghdasaryan wrote: > > > > Replace direct

Re: [PATCH v3 1/7] kernel/fork: convert vma assignment to a memcpy

2023-01-26 Thread Paul E. McKenney
On Wed, Jan 25, 2023 at 05:34:49PM -0800, Andrew Morton wrote: > On Wed, 25 Jan 2023 16:50:01 -0800 Suren Baghdasaryan > wrote: > > > On Wed, Jan 25, 2023 at 4:22 PM Andrew Morton > > wrote: > > > > > > On Wed, 25 Jan 2023 15:35:48 -0800 Suren Baghdasaryan > > > wrote: > > > > > > > Convert

Re: [PATCH v3 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Mel Gorman
On Thu, Jan 26, 2023 at 08:10:26AM -0800, Suren Baghdasaryan wrote: > On Thu, Jan 26, 2023 at 7:10 AM Mel Gorman > wrote: > > > > On Wed, Jan 25, 2023 at 03:35:51PM -0800, Suren Baghdasaryan wrote: > > > Replace direct modifications to vma->vm_flags with calls to modifier > > > functions to be

Re: [PATCH v4 02/24] powerpc/pseries: Fix alignment of PLPKS structures and buffers

2023-01-26 Thread Segher Boessenkool
On Thu, Jan 26, 2023 at 12:09:53AM +1100, Michael Ellerman wrote: > Andrew Donnellan writes: > > A number of structures and buffers passed to PKS hcalls have alignment > > requirements, which could on occasion cause problems: > > > > - Authorisation structures must be 16-byte aligned and must not

Re: [PATCH v9 07/10] arm64: dts: ls1046ardb: Add serdes bindings

2023-01-26 Thread Sean Anderson
On 1/25/23 18:43, Shawn Guo wrote: > On Thu, Dec 29, 2022 at 07:01:36PM -0500, Sean Anderson wrote: >> This adds appropriate bindings for the macs which use the SerDes. The >> 156.25MHz fixed clock is a crystal. The 100MHz clocks (there are >> actually 3) come from a Renesas 6V49205B at address 69

Re: [PATCH v9 06/10] arm64: dts: ls1046a: Add serdes bindings

2023-01-26 Thread Sean Anderson
On 1/25/23 18:46, Shawn Guo wrote: > On Thu, Dec 29, 2022 at 07:01:35PM -0500, Sean Anderson wrote: >> This adds bindings for the SerDes devices. They are disabled by default > > s/bindings/descriptions? > > The term "bindings" generally means the schema/doc in >

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-26 Thread Lee Jones
On Thu, 26 Jan 2023, Sam Ravnborg wrote: > Hi Lee, > On Thu, Jan 26, 2023 at 02:27:26PM +, Lee Jones wrote: > > On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > > > > > From: Sam Ravnborg > > > > > > With all users gone remove the deprecated fb_blank member in > > >

Re: [PATCH v3 6/7] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 7:47 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 03:35:53PM -0800, Suren Baghdasaryan wrote: > > In cases when VMA flags are modified after VMA was isolated and mmap_lock > > was downgraded, flags modifications would result in an assertion because > > mmap write lock

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-26 Thread Sam Ravnborg
Hi Lee, On Thu, Jan 26, 2023 at 02:27:26PM +, Lee Jones wrote: > On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > > > From: Sam Ravnborg > > > > With all users gone remove the deprecated fb_blank member in > > backlight_properties. > > > > Signed-off-by: Sam Ravnborg

Re: [PATCH v3 5/7] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 7:19 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 03:35:52PM -0800, Suren Baghdasaryan wrote: > > Replace indirect modifications to vma->vm_flags with calls to modifier > > functions to be able to track flag changes and to keep vma locking > > correctness. > > > >

Re: [PATCH v3 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 7:10 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 03:35:51PM -0800, Suren Baghdasaryan wrote: > > Replace direct modifications to vma->vm_flags with calls to modifier > > functions to be able to track flag changes and to keep vma locking > > correctness. > > > >

Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 5:58 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 03:35:49PM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking exclusive

Re: [PATCH v4 02/12] perf jevents metric: Add ability to rewrite metrics in terms of others

2023-01-26 Thread John Garry
On 26/01/2023 01:18, Ian Rogers wrote: Add RewriteMetricsInTermsOfOthers that iterates over pairs of names and expressions trying to replace an expression, within the current expression, with its name. Signed-off-by: Ian Rogers hmmm ... did you test this for many python versions? Maybe this

Re: [PATCH v3 1/7] kernel/fork: convert vma assignment to a memcpy

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 3:52 AM Mel Gorman wrote: > > On Wed, Jan 25, 2023 at 05:34:49PM -0800, Andrew Morton wrote: > > On Wed, 25 Jan 2023 16:50:01 -0800 Suren Baghdasaryan > > wrote: > > > > > On Wed, Jan 25, 2023 at 4:22 PM Andrew Morton > > > wrote: > > > > > > > > On Wed, 25 Jan 2023

Re: [PATCH v3 5/7] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 03:35:52PM -0800, Suren Baghdasaryan wrote: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko > --- >

Re: [PATCH v3 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 03:35:51PM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-26 Thread Lee Jones
On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > With all users gone remove the deprecated fb_blank member in > backlight_properties. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- >

Re: [PATCH v4 11/12] perf jevents: Add model list option

2023-01-26 Thread John Garry
On 26/01/2023 14:20, Arnaldo Carvalho de Melo wrote: Em Thu, Jan 26, 2023 at 01:44:39PM +, John Garry escreveu: On 26/01/2023 01:18, Ian Rogers wrote: This allows the set of generated jevents events and metrics be limited to a subset of the model names. Appropriate if trying to minimize

Re: [PATCH v3 3/7] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 03:35:50PM -0800, Suren Baghdasaryan wrote: > To simplify the usage of VM_LOCKED_CLEAR_MASK in clear_vm_flags(), > replace it with VM_LOCKED_MASK bitmask and convert all users. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko Acked-by: Mel Gorman -- Mel

Re: [PATCH v4 11/12] perf jevents: Add model list option

2023-01-26 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 26, 2023 at 01:44:39PM +, John Garry escreveu: > On 26/01/2023 01:18, Ian Rogers wrote: > > This allows the set of generated jevents events and metrics be limited > > to a subset of the model names. Appropriate if trying to minimize the > > binary size where only a set of models

Re: [PATCH v3 3/7] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 03:35:50PM -0800, Suren Baghdasaryan wrote: > To simplify the usage of VM_LOCKED_CLEAR_MASK in clear_vm_flags(), > replace it with VM_LOCKED_MASK bitmask and convert all users. > > Signed-off-by: Suren Baghdasaryan > Acked-by: Michal Hocko Acked-by: Mel Gorman -- Mel

Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 03:35:49PM -0800, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such >

Re: [PATCH v2 02/10] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree

2023-01-26 Thread Alexander Stein
Hi Shawn, thanks for your feedback. Am Donnerstag, 26. Januar 2023, 10:44:21 CET schrieb Shawn Guo: > On Fri, Jan 20, 2023 at 02:34:47PM +0100, Alexander Stein wrote: > > Add device tree for the MBLS102xA mainboard with TQMLS1021A SoM. > > > > Signed-off-by: Alexander Stein > > --- > > Changes

Re: [PATCH v4 11/12] perf jevents: Add model list option

2023-01-26 Thread John Garry
On 26/01/2023 01:18, Ian Rogers wrote: This allows the set of generated jevents events and metrics be limited to a subset of the model names. Appropriate if trying to minimize the binary size where only a set of models are possible. Signed-off-by: Ian Rogers Thanks for this: Reviewed-by:

Re: [PATCH v3 1/7] kernel/fork: convert vma assignment to a memcpy

2023-01-26 Thread Mel Gorman
On Wed, Jan 25, 2023 at 05:34:49PM -0800, Andrew Morton wrote: > On Wed, 25 Jan 2023 16:50:01 -0800 Suren Baghdasaryan > wrote: > > > On Wed, Jan 25, 2023 at 4:22 PM Andrew Morton > > wrote: > > > > > > On Wed, 25 Jan 2023 15:35:48 -0800 Suren Baghdasaryan > > > wrote: > > > > > > > Convert

Re: [PATCH 1/2] powerpc/pci: Allow to disable filling deprecated pci-OF-bus-map

2023-01-26 Thread Michael Ellerman
Pali Rohár writes: > PING? It is more than 5 months since this patch series is there and it > still has not received any comment. There was some related discussion in another thread. I planned to pick it up last merge window, but it breaks the pmac32_defconfig build when

Re: [PATCH v2 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

2023-01-26 Thread Michael Ellerman
Masahiro Yamada writes: > On Thu, Jan 26, 2023 at 11:07 AM Nathan Chancellor wrote: >> >> On Thu, Jan 26, 2023 at 10:29:54AM +0900, Masahiro Yamada wrote: >> > On Wed, Jan 25, 2023 at 1:11 PM Michael Ellerman >> > wrote: >> > > >> > > Nathan Chancellor writes: >> > > > When clang's

Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:50AM -0800, Suren Baghdasaryan wrote: > In cases when VMA flags are modified after VMA was isolated and mmap_lock > was downgraded, flags modifications would result in an assertion because > mmap write lock is not held. > Introduce mod_vm_flags_nolock to be used in

Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:49AM -0800, Suren Baghdasaryan wrote: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. Add a BUG_ON check in ksm_madvise() to catch indirect > vm_flags

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:48AM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan Acked-by: Mike Rapoport (IBM) >

Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:47AM -0800, Suren Baghdasaryan wrote: > To simplify the usage of VM_LOCKED_CLEAR_MASK in clear_vm_flags(), > replace it with VM_LOCKED_MASK bitmask and convert all users. > > Signed-off-by: Suren Baghdasaryan Acked-by: Mike Rapoport (IBM) > --- >

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such >

Re: [PATCH v4 04/10] powerpc/8xx: Use a larger CPM1 command check mask

2023-01-26 Thread Michael Ellerman
Herve Codina writes: > The CPM1 command mask is defined for use with the standard > CPM1 command register as described in the user's manual: > 0 |13|47|8 11|12 14| 15| > RST|- |OPCODE|CH_NUM| -|FLG| > > In the QMC extension the CPM1 command register is

Re: [PATCH v2 02/10] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree

2023-01-26 Thread Shawn Guo
On Fri, Jan 20, 2023 at 02:34:47PM +0100, Alexander Stein wrote: > Add device tree for the MBLS102xA mainboard with TQMLS1021A SoM. > > Signed-off-by: Alexander Stein > --- > Changes in v2: > * Remove unnecessary status = "okay" > * Remove underscore from node names > * Move reg direct below

Re: [PATCH v3 6/7] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Michal Hocko
On Wed 25-01-23 15:35:53, Suren Baghdasaryan wrote: > In cases when VMA flags are modified after VMA was isolated and mmap_lock > was downgraded, flags modifications would result in an assertion because > mmap write lock is not held. > Introduce mod_vm_flags_nolock to be used in such situation,

Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions

2023-01-26 Thread Michal Hocko
On Wed 25-01-23 15:35:49, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such > operations.

[PATCH v4 10/10] MAINTAINERS: add the Freescale QMC audio entry

2023-01-26 Thread Herve Codina
After contributing the component, add myself as the maintainer for the Freescale QMC audio ASoC component. Signed-off-by: Herve Codina --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a574892b9b1..9dcfadec5aa3 100644 --- a/MAINTAINERS

[PATCH v4 09/10] ASoC: fsl: Add support for QMC audio

2023-01-26 Thread Herve Codina
The QMC audio is an ASoC component which provides DAIs that use the QMC (QUICC Multichannel Controller) to transfer the audio data. It provides as many DAIs as the number of QMC channels it references. Signed-off-by: Herve Codina --- sound/soc/fsl/Kconfig | 9 +

[PATCH v4 08/10] dt-bindings: sound: Add support for QMC audio

2023-01-26 Thread Herve Codina
The QMC (QUICC mutichannel controller) is a controller present in some PowerQUICC SoC such as MPC885. The QMC audio is an ASoC component that uses the QMC controller to transfer the audio data. Signed-off-by: Herve Codina Reviewed-by: Krzysztof Kozlowski ---

[PATCH v4 07/10] MAINTAINERS: add the Freescale QMC controller entry

2023-01-26 Thread Herve Codina
After contributing the driver, add myself as the maintainer for the Freescale QMC controller. Signed-off-by: Herve Codina --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6a0605ebf8a0..9a574892b9b1 100644 --- a/MAINTAINERS +++

[PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

2023-01-26 Thread Herve Codina
The QMC (QUICC Multichannel Controller) emulates up to 64 channels within one serial controller using the same TDM physical interface routed from the TSA. It is available in some PowerQUICC SoC such as the MPC885 or MPC866. It is also available on some Quicc Engine SoCs. This current version

[PATCH v4 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller

2023-01-26 Thread Herve Codina
Add support for the QMC (QUICC Multichannel Controller) available in some PowerQUICC SoC such as MPC885 or MPC866. Signed-off-by: Herve Codina --- .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 167 ++ 1 file changed, 167 insertions(+) create mode 100644

[PATCH v4 04/10] powerpc/8xx: Use a larger CPM1 command check mask

2023-01-26 Thread Herve Codina
The CPM1 command mask is defined for use with the standard CPM1 command register as described in the user's manual: 0 |13|47|8 11|12 14| 15| RST|- |OPCODE|CH_NUM| -|FLG| In the QMC extension the CPM1 command register is redefined (QMC supplement user's

  1   2   >