Re: [RFC PATCH] asm-generic: Unify uapi bitsperlong.h

2023-06-10 Thread Xi Ruoyao
On Fri, 2023-06-09 at 14:50 +0800, Tiezhu Yang wrote: /* snip */ > > > > In musl, the documentation states that at least gcc-3.4 or > > > > clang-3.2 are required, which probably predate the > > > > __SIZEOF_LONG__ macro. Indeed, I've digged some history and __SIZEOF_LONG__ was added into GCC-

Re: [PATCH 5/9] cpu/SMT: Create topology_smt_thread_allowed()

2023-06-10 Thread Thomas Gleixner
On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > A subsequent patch will enable partial SMT states, ie. when not all SMT > threads are brought online. Nitpick. I stumbled over this 'subsequent patch' theme a couple of times now because it's very similar to the 'This patch does' phrase.

Re: [PATCH v14 00/15] phy: Add support for Lynx 10G SerDes

2023-06-10 Thread Vladimir Oltean
Hello Sean, On Fri, Jun 09, 2023 at 03:19:22PM -0400, Sean Anderson wrote: > On 5/22/23 11:00, Vladimir Oltean wrote: > > On Mon, May 22, 2023 at 10:42:04AM -0400, Sean Anderson wrote: > >> Have you had a chance to review this driver? > > > > Partially / too little (and no, I don't have an

Re: [PATCH 4/9] cpu/SMT: Create topology_smt_threads_supported()

2023-06-10 Thread Thomas Gleixner
On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > +/** > + * topology_smt_threads_supported - Check if the given number of SMT threads > + * is supported. > + * > + * @threads: The number of SMT threads. > + */ > +bool topology_smt_threads_supported(unsigned int

Re: [PATCH 3/9] cpu/SMT: Store the current/max number of threads

2023-06-10 Thread Thomas Gleixner
On Sat, Jun 10 2023 at 23:26, Thomas Gleixner wrote: > On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > /* > * The decision whether SMT is supported can only be done after the full > * CPU identification. Called from architecture code. > */ > -void __init cpu_smt_check_topology(void)

Re: [PATCH 3/9] cpu/SMT: Store the current/max number of threads

2023-06-10 Thread Thomas Gleixner
On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > #ifdef CONFIG_HOTPLUG_SMT > enum cpuhp_smt_control cpu_smt_control __read_mostly = CPU_SMT_ENABLED; > +static unsigned int cpu_smt_max_threads __ro_after_init; > +unsigned int cpu_smt_num_threads; Why needs this to be global?

Re: [PATCH 8/9] powerpc: Add HOTPLUG_SMT support

2023-06-10 Thread Thomas Gleixner
On Thu, Jun 01 2023 at 18:19, Laurent Dufour wrote: > @@ -435,12 +435,17 @@ void __init cpu_smt_disable(bool force) > * The decision whether SMT is supported can only be done after the full > * CPU identification. Called from architecture code. > */ > -void __init

Re: [PATCH 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs

2023-06-10 Thread Thomas Gleixner
On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: > There is a hook which allows arch code to control how many threads per Can you please write out architecture in changelogs and comments? I know 'arch' is commonly used but while my brain parser tolerates 'arch_' prefixes it raises an

Re: [PATCH 6/9] cpu/SMT: Allow enabling partial SMT states via sysfs

2023-06-10 Thread Thomas Gleixner
On Sat, Jun 10 2023 at 22:09, Thomas Gleixner wrote: > On Thu, May 25 2023 at 01:56, Michael Ellerman wrote: >> There is a hook which allows arch code to control how many threads per > > Can you please write out architecture in changelogs and comments? > > I know 'arch' is commonly used but while

Re: [PATCH v3 23/25] iommu: Add ops->domain_alloc_paging()

2023-06-10 Thread Jason Gunthorpe
On Sat, Jun 10, 2023 at 05:08:31PM +0800, Baolu Lu wrote: > > @@ -1992,8 +1993,13 @@ static struct iommu_domain > > *__iommu_domain_alloc(const struct iommu_ops *ops, > > if (alloc_type == IOMMU_DOMAIN_IDENTITY && ops->identity_domain) > > return ops->identity_domain; > > + else

Re: [PATCH v9 2/4] tpm: of: Make of-tree specific function commonly available

2023-06-10 Thread Jarkko Sakkinen
On Fri Jun 9, 2023 at 9:49 PM EEST, Stefan Berger wrote: > > > On 6/9/23 14:18, Jarkko Sakkinen wrote: > > On Thu May 25, 2023 at 1:56 AM EEST, Jerry Snitselaar wrote: > >> On Tue, Apr 18, 2023 at 09:44:07AM -0400, Stefan Berger wrote: > >>> Simplify tpm_read_log_of() by moving reusable parts of

Re: [PATCH v3 23/25] iommu: Add ops->domain_alloc_paging()

2023-06-10 Thread Baolu Lu
On 6/10/23 3:56 AM, Jason Gunthorpe wrote: This callback requests the driver to create only a __IOMMU_DOMAIN_PAGING domain, so it saves a few lines in a lot of drivers needlessly checking the type. More critically, this allows us to sweep out all the IOMMU_DOMAIN_UNMANAGED and IOMMU_DOMAIN_DMA

Re: [PATCH] powerpc: dts: turris1x.dts: Fix PCIe MEM size for pci2 node

2023-06-10 Thread Pali Rohár
On Friday 05 May 2023 19:28:18 Pali Rohár wrote: > Freescale PCIe controllers on their PCIe Root Ports do not have any > mappable PCI BAR allocate from PCIe MEM. > > Information about 1MB window on BAR0 of PCIe Root Port was misleading > because Freescale PCIe controllers have at BAR0 position