Re: [PATCH] powerpc/mm: Update set_ptes to call pte_filter for all the ptes

2023-10-17 Thread Christophe Leroy
Le 18/10/2023 à 06:55, Aneesh Kumar K.V a écrit : > With commit 9fee28baa601 ("powerpc: implement the new page table range > API") we added set_ptes to powerpc architecture but the implementation > missed calling the pte filter for all the ptes we are setting in the > range. set_pte_filter can

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2023-10-17 Thread Michael Ellerman
Erhard Furtner writes: > On Tue, 17 Oct 2023 14:40:49 +1100 > Michael Ellerman wrote: > >> I think I've reproduced the crash on my Quad G5 by using your config >> with some things tweaked, but I don't get any output on the screen :/ > > You could try PPC_EARLY_DEBUG=y with PPC_EARLY_DEBUG_BOOTX

[PATCH] powerpc/mm: Update set_ptes to call pte_filter for all the ptes

2023-10-17 Thread Aneesh Kumar K.V
With commit 9fee28baa601 ("powerpc: implement the new page table range API") we added set_ptes to powerpc architecture but the implementation missed calling the pte filter for all the ptes we are setting in the range. set_pte_filter can be used for filter pte values and on some platforms which

[PATCH] powerpc/vas: Limit open window failure messages in log bufffer

2023-10-17 Thread Haren Myneni
The VAS open window call prints error message and returns -EBUSY after the migration suspend event initiated and until the resume event completed on the destination system. It can cause the log buffer filled with these error messages if the user space issues continuous open window calls. Similar

[PATCH v2] powerpc/pseries/vas: Migration suspend waits for no in-progress open windows

2023-10-17 Thread Haren Myneni
The hypervisor returns migration failure if all VAS windows are not closed. During pre-migration stage, vas_migration_handler() sets migration_in_progress flag and closes all windows from the list. The allocate VAS window routine checks the migration flag, setup the window and then add it to the

Re: [RFC PATCH v6 09/11] media: uapi: Add audio rate controls support

2023-10-17 Thread Shengjiu Wang
On Tue, Oct 17, 2023 at 9:37 PM Hans Verkuil wrote: > > On 17/10/2023 15:11, Shengjiu Wang wrote: > > On Mon, Oct 16, 2023 at 9:16 PM Hans Verkuil wrote: > >> > >> Hi Shengjiu, > >> > >> On 13/10/2023 10:31, Shengjiu Wang wrote: > >>> Fixed point controls are used by the user to configure > >>>

[PATCH] hvc/xen: fix event channel handling for secondary consoles

2023-10-17 Thread David Woodhouse
From: David Woodhouse The xencons_connect_backend() function allocates a local interdomain event channel with xenbus_alloc_evtchn(), then calls bind_interdomain_evtchn_to_irq_lateeoi() to bind to that port# on the *remote* domain. That doesn't work very well: (qemu) device_add

[PING][PATCH] uapi/auxvec: Define AT_HWCAP3 and AT_HWCAP4 aux vector, entries

2023-10-17 Thread Peter Bergner
CCing linux-kernel for more exposure. PING. I'm waiting on a reply from anyone on the kernel side of things to see whether they have an issue with reserving values for AT_HWCAP3 and AT_HWCAP4. I'll note reviews from the GLIBC camp did not have an issue with the below patch. Thanks. Peter

Re: [PATCH 0/2] Allow nesting of lazy MMU mode

2023-10-17 Thread Erhard Furtner
On Tue, 17 Oct 2023 11:34:23 +0530 "Aneesh Kumar K.V" wrote: > ie, we can do something like below. The change also make sure we call > set_pte_filter on all the ptes we are setting via set_ptes(). I haven't > sent this as a proper patch because we still are not able to fix the > issue Erhard

Re: [PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds

2023-10-17 Thread Nicolas Schier
On Tue, Oct 17, 2023 at 07:37:39PM +0900, Masahiro Yamada wrote: > The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the > 'true' command. > > Remove the meaningless code. > > Signed-off-by: Masahiro Yamada > --- > > arch/mips/Makefile.postlink| 3 --- >

Re: [PATCH 1/4] add generic builtin command line

2023-10-17 Thread Pratyush Brahma
Hi Daniel We have a usecase which requires this patch necessarily. For android usecases, we have two different build variants differentiated by defconfigs - production and debug. However, we only have a single dts for both these variants. We want to enable certain features like page owner

[PATCH 2/6] usb: gadget: fsl-udc: Convert to use module_platform_driver()

2023-10-17 Thread Uwe Kleine-König
module_platform_driver_probe() has the advantage that the .probe() and .remove() calls can live in .init.text and .exit.text respectively and so some memory is saved. The downside is that dynamic bind and unbind are impossible. As the driver doesn't benefit from the advantages (both .probe and

[PATCH 0/6] usb: gadget: Convert to use module_platform_driver()

2023-10-17 Thread Uwe Kleine-König
Hello, module_platform_driver_probe() is an alternative to module_platform_driver(). Comparing the two the former has the advantage that the probe and remove callbacks can live in .init.text and .exit.text respectively. The latter has the advantage that it's a bit easier to use correctly and you

Re: [PATCH] tools/perf/arch/powerpc: Fix the CPU ID const char* value by adding 0x prefix

2023-10-17 Thread Namhyung Kim
On Mon, 9 Oct 2023 10:30:52 +0530, Athira Rajeev wrote: > Simple expression parser test fails in powerpc as below: > > 4: Simple expression parser > test child forked, pid 170385 > Using CPUID 004e2102 > division by zero > syntax error > syntax error > FAILED

Re: [PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell

2023-10-17 Thread Namhyung Kim
On Fri, 13 Oct 2023 13:00:18 +0530, Athira Rajeev wrote: > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting

[PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a

2023-10-17 Thread Frank Li
ls1043a add suspend/resume support. Implement ls1043a_pcie_send_turnoff_msg() to send PME_Turn_Off message. Implement ls1043a_pcie_exit_from_l2() to exit from L2 state. Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - Remove ls_pcie_lut_readl(writel) function Change

[PATCH v3 3/4] PCI: layerscape: Rename pf_* as pf_lut_*

2023-10-17 Thread Frank Li
'pf' and 'lut' is just difference name in difference chips, but basic it is a MMIO base address plus an offset. Rename it to avoid duplicate pf_* and lut_* in driver. Signed-off-by: Frank Li --- Notes: change from v1 to v3 - new patch at v3 drivers/pci/controller/dwc/pci-layerscape.c

[PATCH v3 2/4] PCI: layerscape: Add suspend/resume for ls1021a

2023-10-17 Thread Frank Li
ls1021a add suspend/resume support. Implement callback ls1021a_pcie_send_turnoff_msg(), which write scfg's SCFG_PEXPMWRCR to issue PME_Turn_off message. Implement ls1021a_pcie_exit_from_l2() to let controller exit L2 state. Signed-off-by: Frank Li --- Notes: Change from v2 to v3 -

[PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2()

2023-10-17 Thread Frank Li
Since difference SoCs require different sequence for exiting L2, let's add a separate "exit_from_l2()" callback. This callback can be used to execute SoC specific sequence. Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - fixed according to mani's feedback 1. update

[PATCH v3 0/4] PCI: layerscape: Add suspend/resume support for ls1043 and ls1021

2023-10-17 Thread Frank Li
Add suspend/resume support for ls1043 and ls1021. Change log see each patch Frank Li (4): PCI: layerscape: Add function pointer for exit_from_l2() PCI: layerscape: Add suspend/resume for ls1021a PCI: layerscape: Rename pf_* as pf_lut_* PCI: layerscape: Add suspend/resume for ls1043a

Re: [powerpc] kernel BUG fs/xfs/xfs_message.c:102! [4k block]

2023-10-17 Thread Sachin Sant
> On 13-Oct-2023, at 2:49 AM, Dave Chinner wrote: > > On Thu, Oct 12, 2023 at 03:51:04PM +0530, Sachin Sant wrote: >> While running xfstests on a IBM Power10 server having xfs file system with >> 4k block size following crash was seen >> >> [ 1609.771548] run fstests xfs/238 at 2023-10-11

Re: [PATCH] powerpc/64s/radix: Don't warn on copros in radix__tlb_flush()

2023-10-17 Thread Sachin Sant
> On 17-Oct-2023, at 5:45 PM, Michael Ellerman wrote: > > Sachin reported a warning when running the inject-ra-err selftest: > > # selftests: powerpc/mce: inject-ra-err > Disabling lock debugging due to kernel taint > MCE: CPU19: machine check (Severe) Real address Load/Store

Re: [PATCH v8 0/3] generic and PowerPC SED Opal keystore

2023-10-17 Thread Jens Axboe
On Wed, 04 Oct 2023 15:19:54 -0500, gjo...@linux.vnet.ibm.com wrote: > This patchset has gone through numerous rounds of review and > all comments/suggetions have been addressed. The reviews have > covered all relevant areas including reviews by block and keyring > developers as well as the SED

Re: [PATCH v8 0/3] generic and PowerPC SED Opal keystore

2023-10-17 Thread Jens Axboe
On 10/17/23 9:09 AM, Greg Joyce wrote: > > Hi Jens, > > I've addressed all the comments/issues on v7 of the patchset and > haven't received any feedback on v8. Is there anything else that you'd > like to see before this can be included? Let's give it another shot! -- Jens Axboe

Re: [PATCH v8 0/3] generic and PowerPC SED Opal keystore

2023-10-17 Thread Greg Joyce
Hi Jens, I've addressed all the comments/issues on v7 of the patchset and haven't received any feedback on v8. Is there anything else that you'd like to see before this can be included? Thanks, Greg On Wed, 2023-10-04 at 15:19 -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > >

Re: [PATCH 1/4] add generic builtin command line

2023-10-17 Thread Daniel Walker (danielwa)
On Tue, Oct 17, 2023 at 04:10:42PM +0530, Pratyush Brahma wrote: > For such a usecase, the CONFIG_CMDLINE_PREPEND seems to be quite useful as > it would help to stitch bootloader > and the desired build variant's configs together. Can you please help to > merge this patch? Yes, your at least the

Re: [powerpc] Kernel crash while running LTP (bisected)

2023-10-17 Thread Sachin Sant
> On 17-Oct-2023, at 4:35 PM, Lorenzo Stoakes wrote: > > On Tue, Oct 17, 2023 at 02:46:07PM +0530, Sachin Sant wrote: >> While running LTP tests (getpid02) on a Power10 server booted with >> 6.6.0-rc6-next-20231016 following crash was seen: >> >> [ 76.386628] Kernel attempted to read user

Re: [RFC PATCH v6 09/11] media: uapi: Add audio rate controls support

2023-10-17 Thread Hans Verkuil
On 17/10/2023 15:11, Shengjiu Wang wrote: > On Mon, Oct 16, 2023 at 9:16 PM Hans Verkuil wrote: >> >> Hi Shengjiu, >> >> On 13/10/2023 10:31, Shengjiu Wang wrote: >>> Fixed point controls are used by the user to configure >>> the audio sample rate to driver. >>> >>> Add V4L2_CID_ASRC_SOURCE_RATE

Re: [RFC PATCH v6 09/11] media: uapi: Add audio rate controls support

2023-10-17 Thread Shengjiu Wang
On Mon, Oct 16, 2023 at 9:16 PM Hans Verkuil wrote: > > Hi Shengjiu, > > On 13/10/2023 10:31, Shengjiu Wang wrote: > > Fixed point controls are used by the user to configure > > the audio sample rate to driver. > > > > Add V4L2_CID_ASRC_SOURCE_RATE and V4L2_CID_ASRC_DEST_RATE > > new IDs for ASRC

Re: [PATCH] powerpc/paravirt: Improve vcpu_is_preempted

2023-10-17 Thread Aboorva Devarajan
On Mon, 2023-10-09 at 10:47 +0530, Srikar Dronamraju wrote: Hi Srikar, Benchmarked this patch on baremetal POWER9 node by launching KVM to observe the improvements achieved in KVM with the patched kernel. Below, you can find the schbench latency result comparision. System was running on SMT4

[PATCH] powerpc/64s/radix: Don't warn on copros in radix__tlb_flush()

2023-10-17 Thread Michael Ellerman
Sachin reported a warning when running the inject-ra-err selftest: # selftests: powerpc/mce: inject-ra-err Disabling lock debugging due to kernel taint MCE: CPU19: machine check (Severe) Real address Load/Store (foreign/control memory) [Not recovered] MCE: CPU19: PID: 5254 Comm:

Re: [powerpc] Kernel crash while running LTP (bisected)

2023-10-17 Thread Lorenzo Stoakes
On Tue, Oct 17, 2023 at 02:46:07PM +0530, Sachin Sant wrote: > While running LTP tests (getpid02) on a Power10 server booted with > 6.6.0-rc6-next-20231016 following crash was seen: > > [ 76.386628] Kernel attempted to read user page (d8) - exploit attempt? > (uid: 0) > [ 76.386649] BUG:

Re: [PATCHv9 2/2] powerpc/setup: Loosen the mapping between cpu logical id and its seq in dt

2023-10-17 Thread Hari Bathini
On 17/10/23 7:58 am, Pingfan Liu wrote: *** Idea *** For kexec -p, the boot cpu can be not the cpu0, this causes the problem of allocating memory for paca_ptrs[]. However, in theory, there is no requirement to assign cpu's logical id as its present sequence in the device tree. But there is

[PATCH 1/4] kbuild: remove ARCH_POSTLINK from module builds

2023-10-17 Thread Masahiro Yamada
The '%.ko' rule in arch/*/Makefile.postlink does nothing but call the 'true' command. Remove the meaningless code. Signed-off-by: Masahiro Yamada --- arch/mips/Makefile.postlink| 3 --- arch/powerpc/Makefile.postlink | 3 --- arch/riscv/Makefile.postlink | 3 ---

Re: [PATCHv9 1/2] powerpc/setup : Enable boot_cpu_hwid for PPC32

2023-10-17 Thread Hari Bathini
On 17/10/23 7:58 am, Pingfan Liu wrote: In order to identify the boot cpu, its intserv[] should be recorded and checked in smp_setup_cpu_maps(). smp_setup_cpu_maps() is shared between PPC64 and PPC32. Since PPC64 has already used boot_cpu_hwid to carry that information, enabling this

[powerpc] Kernel crash while running LTP (bisected)

2023-10-17 Thread Sachin Sant
While running LTP tests (getpid02) on a Power10 server booted with 6.6.0-rc6-next-20231016 following crash was seen: [ 76.386628] Kernel attempted to read user page (d8) - exploit attempt? (uid: 0) [ 76.386649] BUG: Kernel NULL pointer dereference on read at 0x00d8 [ 76.386653]

Re: [PATCH 2/3] PCI: layerscape: add suspend/resume for ls1021a

2023-10-17 Thread Manivannan Sadhasivam
On Mon, Oct 16, 2023 at 04:18:36PM -0400, Frank Li wrote: > On Mon, Oct 16, 2023 at 10:28:24PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote: > > > ls1021a add suspend/resume support. > > > > > > > Please add what the driver is doing during

Re: [PATCH v2 0/3] Add generic data patching functions

2023-10-17 Thread Benjamin Gray
On 17/10/23 5:39 pm, Christophe Leroy wrote: Le 16/10/2023 à 07:01, Benjamin Gray a écrit : Currently patch_instruction() bases the write length on the value being written. If the value looks like a prefixed instruction it writes 8 bytes, otherwise it writes 4 bytes. This makes it potentially

Re: [PATCH v2 0/3] Add generic data patching functions

2023-10-17 Thread Christophe Leroy
Le 16/10/2023 à 07:01, Benjamin Gray a écrit : > Currently patch_instruction() bases the write length on the value being > written. If the value looks like a prefixed instruction it writes 8 bytes, > otherwise it writes 4 bytes. This makes it potentially buggy to use for > writing arbitrary

Re: [PATCH v6 0/5] powerpc/bpf: use BPF prog pack allocator

2023-10-17 Thread Hari Bathini
On 16/10/23 5:37 pm, Daniel Borkmann wrote: On 10/12/23 10:03 PM, Hari Bathini wrote: Most BPF programs are small, but they consume a page each. For systems with busy traffic and many BPF programs, this may also add significant pressure on instruction TLB. High iTLB pressure usually slows

Re: [PATCH 0/2] Allow nesting of lazy MMU mode

2023-10-17 Thread Aneesh Kumar K.V
Erhard Furtner writes: > On Thu, 12 Oct 2023 20:54:13 +0100 > "Matthew Wilcox (Oracle)" wrote: > >> Dave Woodhouse reported that we now nest calls to >> arch_enter_lazy_mmu_mode(). That was inadvertent, but in principle we >> should allow it. On further investigation, Juergen already fixed it