Re: [PATCH 4/4] powerpc/Makefile: Auto detect cross compiler

2023-12-06 Thread Michael Ellerman
Segher Boessenkool writes: > On Wed, Dec 06, 2023 at 10:55:48PM +1100, Michael Ellerman wrote: >> Look for various combinations, matching: >> powerpc(64(le)?)?(-unknown)?-linux(-gnu)?- >> >> There are more possibilities, but the above is known to find a compiler >> on Fedora and Ubuntu (which

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Waiman Long
On 12/6/23 19:37, George Stark wrote: Hello Waiman Thanks for the review. On 12/7/23 00:02, Waiman Long wrote: On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, ...

Re: [PATCH] ocxl: fix driver function comment typo

2023-12-06 Thread jiangyunshui
> Date: Tue, 5 Dec 2023 11:00:16 + [thread overview] > Message-ID: <2f2aca95-f5a6-45fa-9e3b-37aecf657...@csgroup.eu> (raw) > In-Reply-To: <20231205094319.32114-1-jiangyuns...@kylinos.cn> > Please add a description explaining why you want to do that change. > When I grep I see cxlflash

[PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()

2023-12-06 Thread Jim Mattson
kvm_vcpu_check_block() is called while not in TASK_RUNNING, and therefore it cannot sleep. Writing to guest memory is therefore forbidden, but it can happen on AMD processors if kvm_check_nested_events() causes a vmexit. Fortunately, all events that are caught by kvm_check_nested_events() are

Re: [PATCH v4 05/13] powerpc/rtas: Facilitate high-level call sequences

2023-12-06 Thread Michael Ellerman
Nathan Lynch writes: > Nathan Lynch writes: >> Michael Ellerman writes: >>> Nathan Lynch writes: Michael Ellerman writes: > Nathan Lynch writes: >> Michael Ellerman writes: >>> Nathan Lynch via B4 Relay >>> writes: From: Nathan Lynch On RTAS

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Waiman Thanks for the review. On 12/7/23 00:02, Waiman Long wrote: On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, ... mutex_destroy() only actually does anything

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Christophe On 12/7/23 01:37, Christophe Leroy wrote: Le 06/12/2023 à 23:14, Christophe Leroy a écrit : Le 06/12/2023 à 19:58, George Stark a écrit : [Vous ne recevez pas souvent de courriers de gnst...@salutedevices.com. Découvrez pourquoi ceci est important à

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Baoquan He
On 12/06/23 at 04:54pm, Conor Dooley wrote: > On Wed, Dec 06, 2023 at 11:37:52PM +0800, Baoquan He wrote: > > On 12/04/23 at 04:14pm, Conor Dooley wrote: > > > On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > > > > On 12/01/23 at 10:38am, Conor Dooley wrote: > > > > > On Thu, Nov 30,

[PATCH 3/3] PCI/AER: Use explicit register sizes for struct members

2023-12-06 Thread Bjorn Helgaas
From: Bjorn Helgaas aer_irq() reads the AER Root Error Status and Error Source Identification (PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into struct aer_err_source. Both registers are 32 bits, so declare the members explicitly as "u32" instead of "unsigned int".

[PATCH 2/3] PCI/AER: Decode Requester ID when no error info found

2023-12-06 Thread Bjorn Helgaas
From: Bjorn Helgaas When a device with AER detects an error, it logs error information in its own AER Error Status registers. It may send an Error Message to the Root Port (RCEC in the case of an RCiEP), which logs the fact that an Error Message was received (Root Error Status) and the

[PATCH 1/3] PCI/AER: Use 'Correctable' and 'Uncorrectable' spec terms for errors

2023-12-06 Thread Bjorn Helgaas
From: Bjorn Helgaas The PCIe spec classifies errors as either "Correctable" or "Uncorrectable". Previously we printed these as "Corrected" or "Uncorrected". To avoid confusion, use the same terms as the spec. One confusing situation is when one agent detects an error, but another agent is

[PATCH 0/3] PCI/AER: Clean up logging

2023-12-06 Thread Bjorn Helgaas
From: Bjorn Helgaas Clean up some minor AER logging issues: - Log as "Correctable errors", not "Corrected errors" - Decode the Requester ID when we couldn't find detail error info Bjorn Helgaas (3): PCI/AER: Use 'Correctable' and 'Uncorrectable' spec terms for errors PCI/AER: Decode

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 23:14, Christophe Leroy a écrit : > > > Le 06/12/2023 à 19:58, George Stark a écrit : >> [Vous ne recevez pas souvent de courriers de >> gnst...@salutedevices.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> Hello Hans >>

[PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32

2023-12-06 Thread Christophe Leroy
sparse reports an error on some data that gets converted from be32. That's because that data is typed u32 instead of __be32. The type is correct, the be32_to_cpu() conversion is not. Remove the conversion. Reported-by: kernel test robot Closes:

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 19:58, George Stark a écrit : > [Vous ne recevez pas souvent de courriers de gnst...@salutedevices.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Hello Hans > > Thanks for the review. > > On 12/6/23 18:01, Hans de Goede

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi, On 12/6/23 19:58, George Stark wrote: > > Hello Hans > > Thanks for the review. > > On 12/6/23 18:01, Hans de Goede wrote: >> Hi George, >> >> On 12/4/23 19:05, George Stark wrote: >>> Using of devm API leads to certain order of releasing resources. >>> So all dependent resources which are

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi George, On 12/4/23 19:05, George Stark wrote: > Using of devm API leads to certain order of releasing resources. > So all dependent resources which are not devm-wrapped should be deleted > with respect to devm-release order. Mutex is one of such objects that > often is bound to other resources

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Hans de Goede
Hi, On 12/6/23 08:56, George Stark wrote: > Hello Andy > > Thanks for the review. > > On 12/4/23 21:11, Andy Shevchenko wrote: >> On Mon, Dec 4, 2023 at 8:07 PM George Stark >> wrote: >>> >>> Using of devm API leads to certain order of releasing resources. >>> So all dependent resources which

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread Waiman Long
On 12/6/23 14:55, Hans de Goede wrote: Hi, On 12/6/23 19:58, George Stark wrote: Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, On 12/4/23 19:05, George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent

Re: [PATCH v2 01/10] devm-helpers: introduce devm_mutex_init

2023-12-06 Thread George Stark
Hello Hans Thanks for the review. On 12/6/23 18:01, Hans de Goede wrote: Hi George, On 12/4/23 19:05, George Stark wrote: Using of devm API leads to certain order of releasing resources. So all dependent resources which are not devm-wrapped should be deleted with respect to devm-release

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 11:37:52PM +0800, Baoquan He wrote: > On 12/04/23 at 04:14pm, Conor Dooley wrote: > > On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > > > On 12/01/23 at 10:38am, Conor Dooley wrote: > > > > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: > > > > >

Re: [PATCH 4/4] powerpc/Makefile: Auto detect cross compiler

2023-12-06 Thread Segher Boessenkool
On Wed, Dec 06, 2023 at 10:55:48PM +1100, Michael Ellerman wrote: > Look for various combinations, matching: > powerpc(64(le)?)?(-unknown)?-linux(-gnu)?- > > There are more possibilities, but the above is known to find a compiler > on Fedora and Ubuntu (which use linux-gnu-), and also detects

Re: [PATCH 2/4] powerpc/vdso: No need to undef powerpc for 64-bit build

2023-12-06 Thread Segher Boessenkool
On Wed, Dec 06, 2023 at 10:55:46PM +1100, Michael Ellerman wrote: > But the 64-bit compiler doesn't define powerpc in the first place, Yes, only __powerpc__ (and __powerpc64__) :-) Segher

[PATCH v1 4/4] powerpc: Stop using of_root

2023-12-06 Thread Christophe Leroy
Replace all usages of of_root by of_find_node_by_path("/") Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/secure_boot.c| 8 ++-- arch/powerpc/kexec/ranges.c | 8 +--- arch/powerpc/mm/drmem.c | 10 +- arch/powerpc/mm/numa.c

[PATCH v1 3/4] powerpc/machdep: Define 'compatibles' property in ppc_md and use it

2023-12-06 Thread Christophe Leroy
Most probe functions that do not use the 'compatible' string do nothing else than checking whether the machine is compatible with one of the strings in a NULL terminated table of strings. Define that table of strings in ppc_md structure and check it directly from probe_machine() instead of using

[PATCH v1 2/4] of: Reimplement of_machine_is_compatible() using of_machine_compatible_match()

2023-12-06 Thread Christophe Leroy
of_machine_compatible_match() works with a table of strings. of_machine_is_compatible() is a simplier version with only one string. Re-implement of_machine_is_compatible() by setting a table of strings with a single string then using of_machine_compatible_match(). Suggested-by: Rob Herring

[PATCH v1 1/4] of: Add of_machine_compatible_match()

2023-12-06 Thread Christophe Leroy
From: Michael Ellerman We have of_machine_is_compatible() to check if a machine is compatible with a single compatible string. However some code is able to support multiple compatible boards, and so wants to check for one of many compatible strings. So add of_machine_compatible_match() which

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Baoquan He
On 12/04/23 at 04:14pm, Conor Dooley wrote: > On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > > On 12/01/23 at 10:38am, Conor Dooley wrote: > > > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: > > > > > > $subject has a typo in the arch bit :) > > > > Indeed, will fix

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-12-06 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 06, 2023 at 10:15:06AM +0530, Athira Rajeev escreveu: > > > > On 06-Dec-2023, at 3:20 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > >> On 23/11/2023 16:02, Athira Rajeev wrote: > >>> --- a/tools/perf/Makefile.perf

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-12-06 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 05, 2023 at 02:09:01PM -0800, Ian Rogers escreveu: > On Tue, Dec 5, 2023 at 1:50 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > > > On 23/11/2023 16:02, Athira Rajeev wrote: > > > > --- a/tools/perf/Makefile.perf > > > >

[PATCH 4/4] powerpc/Makefile: Auto detect cross compiler

2023-12-06 Thread Michael Ellerman
If no cross compiler is specified, try to auto detect one. Look for various combinations, matching: powerpc(64(le)?)?(-unknown)?-linux(-gnu)?- There are more possibilities, but the above is known to find a compiler on Fedora and Ubuntu (which use linux-gnu-), and also detects the kernel.org

[PATCH 3/4] powerpc/Makefile: Default to ppc64le_defconfig when cross building

2023-12-06 Thread Michael Ellerman
If the kernel is being cross compiled, there is no information from uname on which defconfig is most appropriate, so the Makefile defaults to ppc64. However these days almost all distros that support powerpc are little endian, so it's more likely that defaulting to ppc64le_defconfig will produce

[PATCH 2/4] powerpc/vdso: No need to undef powerpc for 64-bit build

2023-12-06 Thread Michael Ellerman
The vdso Makefile adds -U$(ARCH) to CPPFLAGS for the vdso64.lds linker script. ARCH is always powerpc, so it becomes -Upowerpc, which means undefine the "powerpc" symbol. But the 64-bit compiler doesn't define powerpc in the first place, compare: $

[PATCH 1/4] powerpc/Makefile: Don't use $(ARCH) unnecessarily

2023-12-06 Thread Michael Ellerman
There's no need to use $(ARCH) for references to the arch directory in the source tree, it is always arch/powerpc. Signed-off-by: Michael Ellerman --- arch/powerpc/Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/Makefile

Re: [PATCH v11 00/15] Add audio support in v4l2 framework

2023-12-06 Thread Shengjiu Wang
On Wed, Dec 6, 2023 at 4:09 PM Hans Verkuil wrote: > > Hi Shengjiu, > > On 22/11/2023 08:23, Shengjiu Wang wrote: > > Audio signal processing also has the requirement for memory to > > memory similar as Video. > > > > This asrc memory to memory (memory ->asrc->memory) case is a non > > real time

Re: [PATCH 12/27] tty: hvc: convert to u8 and size_t

2023-12-06 Thread Christophe Leroy
Le 06/12/2023 à 08:36, Jiri Slaby (SUSE) a écrit : > Switch character types to u8 and sizes to size_t. To conform to > characters/sizes in the rest of the tty layer. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Amit Shah >

Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

2023-12-06 Thread George Stark
Hello Christophe Thanks for the review On 12/5/23 02:09, Christophe Leroy wrote: Le 04/12/2023 à 19:05, George Stark a écrit : In the probe() callback in case of error mutex is destroyed being locked which is not allowed so unlock the mute before destroying. Should there be a fixes: tag ?

Re: [PATCH v11 00/15] Add audio support in v4l2 framework

2023-12-06 Thread Hans Verkuil
Hi Shengjiu, On 22/11/2023 08:23, Shengjiu Wang wrote: > Audio signal processing also has the requirement for memory to > memory similar as Video. > > This asrc memory to memory (memory ->asrc->memory) case is a non > real time use case. > > User fills the input buffer to the asrc module, after