On 25/3/19 4:34 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The term 'link' is ambiguous (especially when the struct is used for a
list), so rename it for clarity.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c
On 4/4/19 12:02 am, Christopher M Riedl wrote:
On March 29, 2019 at 12:49 AM Andrew Donnellan
wrote:
On 29/3/19 3:21 pm, cmr wrote:
Operations which write to memory should be restricted on secure systems
and optionally to avoid self-destructive behaviors.
For reference:
-
https
:6: warning: variable 'lpid' set but not used
[-Wunused-but-set-variable]
They are never used and can be removed.
Signed-off-by: YueHaibing
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/link.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/ocxl
xmon_ro = 1;
} else if (strncmp(p, "off", 3) == 0)
xmon_on = 0;
else
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 13/3/19 3:06 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The term 'link' is ambiguous (especially when the struct is used for a
list), so rename it for clarity.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
(In future please include
On 15/3/19 3:49 pm, Andrew Donnellan wrote:
On 13/3/19 3:07 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Remove some unused exported symbols.
Signed-off-by: Alastair D'Silva
See comments on v1
Also a couple of sparse warnings at
https://openpower.xyz/job/snowpatch/job/snowpatch
ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid);
-
/*
* Remove a Process Element from the Shared Process Area for a link
*/
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 13/3/19 3:15 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
External drivers that communicate via OpenCAPI will need to make
MMIO calls to interact with the devices.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl
On 13/3/19 3:15 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
This data is already available in a struct
Signed-off-by: Alastair D'Silva
This is a good idea.
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/core.c | 38 +-
1 file changed, 21
On 15/3/19 3:10 am, David Howells wrote:
Signed-off-by: David Howells
cc: Frederic Barrat
cc: Andrew Donnellan
cc: linuxppc-dev@lists.ozlabs.org
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/api.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
On 13/3/19 3:07 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The 'extern' keyword adds no value here.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 54 +++
include/misc/ocxl.h | 36
On 13/3/19 3:06 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
No need for a return value in read_pasid as it only returns 0.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 9 ++---
1 file changed, 2
On 13/3/19 3:06 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Use %# instead of using a literal '0x'
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 6 +++---
drivers/misc/ocxl/context.c | 2 +-
drivers/misc/ocxl/trace.h | 10
declaration to the OPAL_CALL macro to shut sparse up.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/opal-call.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal-call.c
b/arch/powerpc/platforms/powernv/opal-call.c
index 578757d403ab
... well ... inconsistent, but all right-thinking people know that
(a) K are **right** and (b) K are right. Besides, functions are
special anyway (you can't nest them in C).
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
tid);
+
This isn't actually exported, so if you spin a v2 do that separately
from this patch or document the change.
Otherwise
Acked-by: Andrew Donnellan
struct ocxl_context *ocxl_context_alloc(void);
int ocxl_context_init(struct ocxl_context *ctx, struct ocxl_afu *
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
The 'extern' keyword adds no value here.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/ocxl_internal.h | 54 +++
include/misc/ocxl.h | 36
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
No need for a return value in read_pasid as it only returns 0.
Signed-off-by: Alastair D'Silva
Reviewed-by: Greg Kurz
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 9 ++---
1 file changed, 2
On 27/2/19 3:57 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
Use %# instead of using a literal '0x'
Signed-off-by: Alastair D'Silva
Not hugely fussed either way, but today I learned about %#...
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/config.c | 6 +++---
drivers
On 27/2/19 7:04 pm, Alastair D'Silva wrote:
-Original Message-
From: Andrew Donnellan
Sent: Wednesday, 27 February 2019 6:55 PM
To: Alastair D'Silva ; 'Alastair D'Silva'
Cc: 'Greg Kurz' ; 'Frederic Barrat'
; 'Arnd Bergmann' ; 'Greg Kroah-
Hartman' ; linuxppc-dev@lists.ozlabs.org;
linux
date the function signature for ocxl_link_update_pe()
as well.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
link *link = (struct link *) link_handle;
+ struct ocxl_link *link = (struct ocxl_link *) link_handle;
pnv_ocxl_free_xive_irq(hw_irq);
atomic_inc(>irq_available);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Jordan Niethe
Guess I'll have to get used to typing sudo more often. :(
Makes sense also given that we do the same thing for exports afaict.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia
message]
Signed-off-by: Andrew Donnellan
---
arch/powerpc/kernel/dt_cpu_ftrs.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c
b/arch/powerpc/kernel/dt_cpu_ftrs.c
index 8be3721d9302..e49bd5efcfe6 100644
--- a/arch/powerpc/
machines.
Signed-off-by: Andrew Donnellan
Acked-by: Dmitry Vyukov
Tested-by: Daniel Axtens # e6500
---
v2->v3:
- Add additional exclusions required to boot on book3e (dja)
---
arch/powerpc/Kconfig| 1 +
arch/powerpc/kernel/Makefile| 12 +++-
arch/powerpc/ker
g interesting, for example), but certainly this is a great start.
I think syzkaller (as the main kcov consumer) can probably cope...
With those changes,
Tested-by: Daniel Axtens # e6500
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
/kasan/kasan_init_32.c
similarity index 100%
rename from arch/powerpc/mm/kasan_init.c
rename to arch/powerpc/mm/kasan/kasan_init_32.c
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
to override the layout
of the shadow mapping.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
---
mm/kasan/generic.c | 3 +--
mm/kasan/tags.c| 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c
index ccb6207276e3
message]
Signed-off-by: Andrew Donnellan
---
v1->v2:
- fix the other logic errors in this function (segher, mpe)
---
arch/powerpc/kernel/dt_cpu_ftrs.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/kernel/dt_cpu_ftrs.c
b/arch/powerpc/ker
kcov provides kernel coverage data that's useful for fuzzing tools like
syzkaller.
Wire up kcov support on powerpc. Disable kcov instrumentation on the same
files where we currently disable gcov and UBSan instrumentation.
Signed-off-by: Andrew Donnellan
Acked-by: Dmitry Vyukov
---
arch
s if "known", afaics.
I've got a v2 ready to send which fixes both things.
Segher
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
kernel)\n",
+ f->name);
+ return false;
}
if (m->cpu_ftr_bit_mask)
Sure, I can send a v2 with this fix and your signoff?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
(+ Nick)
On 7/2/19 6:49 pm, Segher Boessenkool wrote:
On Thu, Feb 07, 2019 at 05:59:48PM +1100, Andrew Donnellan wrote:
On 7/2/19 5:37 pm, Segher Boessenkool wrote:
On Thu, Feb 07, 2019 at 04:33:23PM +1100, Andrew Donnellan wrote:
Some older gccs (cpu_ftr_bit_mask)
It seems to me
On 7/2/19 5:37 pm, Segher Boessenkool wrote:
On Thu, Feb 07, 2019 at 04:33:23PM +1100, Andrew Donnellan wrote:
Some older gccs (cpu_ftr_bit_mask)
It seems to me the warning is correct? If enable_unknown is false and no
cpu_feature is found, it will in
if (m->cpu_ftr_bit_m
kcov provides kernel coverage data that's useful for fuzzing tools like
syzkaller.
Wire up kcov support on powerpc. Disable kcov instrumentation on the same
files where we currently disable gcov and UBSan instrumentation.
Signed-off-by: Andrew Donnellan
Acked-by: Dmitry Vyukov
---
arch
Some older gccs (cpu_ftr_bit_mask)
An upcoming patch will enable support for kcov, which requires
-fsanitize-coverage=trace-pc.
Work around this by explicitly initialising m to NULL.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/kernel/dt_cpu_ftrs.c | 2 +-
1 file changed, 1 insertion
ock
'adapter->afu_list_lock'.
Signed-off-by: Vaibhav Jain
Does this need to go to stable? (I'm guessing we've been hitting actual
Oopses?)
Acked-by: Andrew Donnellan
---
Changelog:
v3:
* Updated a slice loop in cxl_pci_error_detectected() to ignore NULL
slices [Fred]
* Added a
protocol respectively - many of which will be FPGA boards
flashed with customer-designed accelerator cores for specific workloads,
some will be accelerators using ASICs or using FPGA images supplied by
vendors, some will be driven from userspace, others using the cxl/ocxl
kernel API, etc.
--
Andrew
On 15/1/19 6:26 pm, Mathieu Malaterre wrote:
[Sorry to hijack this thread. ]
On Tue, Jan 15, 2019 at 5:22 AM Andrew Donnellan
wrote:
kcov provides kernel coverage data that's useful for fuzzing tools like
syzkaller.
Wire up kcov support on powerpc. Disable kcov instrumentation on the same
On 15/1/19 5:40 pm, Dmitry Vyukov wrote:
On Tue, Jan 15, 2019 at 5:20 AM Andrew Donnellan
wrote:
kcov provides kernel coverage data that's useful for fuzzing tools like
syzkaller.
Wire up kcov support on powerpc. Disable kcov instrumentation on the same
files where we currently disable gcov
kcov provides kernel coverage data that's useful for fuzzing tools like
syzkaller.
Wire up kcov support on powerpc. Disable kcov instrumentation on the same
files where we currently disable gcov and UBSan instrumentation.
Signed-off-by: Andrew Donnellan
---
kcov looks like it's working okay
U groups")
Signed-off-by: Frederic Barrat
Reviewed-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index
kernel.org # v4.18
Signed-off-by: Greg Kurz
If only we read our sparse warnings which would have told us this. One
warning down :)
Thanks for finding this!
Acked-by: Andrew Donnellan
---
This bug remained unnoticed so far because the current OCXL test suite
happe
On 17/12/18 4:19 am, Christoph Hellwig wrote:
The CXL code never even looks at the dma mask, so there is no good
reason for this sanity check. Remove it because it gets in the way
of the dma ops refactoring.
Signed-off-by: Christoph Hellwig
Acked-by: Andrew Donnellan
---
drivers/misc
with le32_to_cpu().
Cc: sta...@vger.kernel.org # v4.16
Signed-off-by: Greg Kurz
Acked-by: Frederic Barrat
Acked-by: Andrew Donnellan
---
v2: - silence sparse with (__force __le32) cast
- new changelog
---
drivers/misc/ocxl/config.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
hey're
not needed... Should I re-post this as two patches for clarity ?
Ah, that makes much more sense.
If that's the case, then why not go all the way and change the function
signature while you're at it?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Aus
p both.
Signed-off-by: Greg Kurz
I like defensive programming but for this case I don't really care too
much either way
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/link.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/ocxl/link.c b/drivers/mis
On 11/12/18 11:05 am, Andrew Donnellan wrote:
On 11/12/18 2:10 am, Greg Kurz wrote:
The double word returned by read_afu_info(OCXL_DVSEC_TEMPL_NAME) contains
four characters of the AFU name, read from the PCI config space, hence
with a little-endian ordering. When composing the string, a big
-by: Greg Kurz
This is good, thanks.
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/link.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c
index eed92055184d..659977a17405 100644
--- a/drivers
Acked-by: Andrew Donnellan
On 11/12/18 2:13 am, Greg Kurz wrote:
The AFU irq code doesn't need to reach out to the platform.
Signed-off-by: Greg Kurz
---
drivers/misc/ocxl/afu_irq.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/ocxl/afu_irq.c b/drivers/misc/ocxl
turn 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 4/12/18 4:11 pm, Russell Currey wrote:
From what I've seen, every time this warning comes up it's bogus,
so let's ignore it.
Signed-off-by: Russell Currey
Reviewed-by: Andrew Donnellan
---
arch/powerpc/tools/checkpatch.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch
the device_type property
directly.
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring
Apart from that:
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/pci.c | 4 +---
1 file changed, 1 insertion
On 28/9/18 4:38 pm, Alexey Kardashevskiy wrote:
The included opal.h gives a wrong idea that CXL makes PPC OPAL calls
while it does not so let's remote it.
Signed-off-by: Alexey Kardashevskiy
Thanks for catching this
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/pci.c | 1 -
1 file
architectures, compat_ptr()
does not do anything, but using the new generic_compat_ioctl_ptrarg
helper makes it more correct in theory, and simplifies the code.
Signed-off-by: Arnd Bergmann
For cxl:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1
() to handle this cmd-arg
and issues opal_cec_reboot2 with OPAL_REBOOT_FULL_IPL to force a full
IPL reset.
Signed-off-by: Vaibhav Jain
This looks better!
Acked-by: Andrew Donnellan
---
Change-log:
v3 -> Re-factored the code to make it more readable [Andrew]
Handle ret
is the normal case.
But either way:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
);
You might want to check for OPAL_UNSUPPORTED here just in case we're
running on ancient firmware.
+ else
+ rc = opal_cec_reboot();
+
if (rc == OPAL_BUSY_EVENT)
opal_poll_events(NULL);
On 28/08/18 11:52, Rob Herring wrote:
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: linuxppc-dev@lists.ozlabs.org
Signed
but they're several
megs per build.
I've kicked off another build for this series and the links in Patchwork
should update to point to the new job when it's done (probably in the
next couple of hours).
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM
Descriptor Data indexed by the
AFU Info Index field.
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Cc: stable # 4.16
Signed-off-by: Christophe Lombard
Thanks
Acked-by: Andrew Donnellan
---
Changelog[v2]
- Rebase to latest upstream.
- Use pci_write_c
EC_TEMPL_VERSION, );
if (rc)
return rc;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 03/08/18 20:20, Parth Y Shah wrote:
Resolved <"foo* bar" should be "foo *bar"> error
Signed-off-by: Parth Y Shah
Thanks for picking this up.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On 31/07/18 22:08, Michael Ellerman wrote:
The alignment_handler is documented to only work on Power8/Power9, but
we can make it run on older CPUs by guarding more of the tests with
feature checks.
Signed-off-by: Michael Ellerman
Looks good to me.
Reviewed-by: Andrew Donnellan
:
test: test_alignment_handler_vsx_206
tags: git_version:v4.18-rc3-134-gfb21a48904aa
[SKIP] Test skipped on line 291
skip: test_alignment_handler_vsx_206
Signed-off-by: Michael Ellerman
This seems sensible.
Acked-by: Andrew Donnellan
---
.../powerpc/alignment/alignment
arpenter
Signed-off-by: Vaibhav Jain
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 28/06/18 20:05, Frederic Barrat wrote:
Remove a few XSL/CX4 oddities which are no longer needed. A simple
revert of the initial commits was not possible (or not worth it) due
to the history of the code.
Signed-off-by: Frederic Barrat
Acked-by: Andrew Donnellan
---
drivers/misc/cxl
On 28/06/18 20:05, Frederic Barrat wrote:
Remove abandonned capi support for the Mellanox CX4.
This reverts commit a19bd79e31769626d288cc016e21a31b6f47bf6f.
Signed-off-by: Frederic Barrat
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/Makefile | 2 +-
drivers/misc/cxl/base.c | 35
On 28/06/18 20:05, Frederic Barrat wrote:
Remove abandonned capi support for the Mellanox CX4.
This reverts commit 4e56f858bdde5cbfb70f61baddfaa56a8ed851bf.
Signed-off-by: Frederic Barrat
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/pci.c | 37
On 28/06/18 20:05, Frederic Barrat wrote:
From: Alastair D'Silva
Remove abandonned capi support for the Mellanox CX4.
This reverts commit 4361b03430d685610e5feea3ec7846e8b9ae795f.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
arch/powerpc/include/asm/pnv-pci.h
On 28/06/18 20:05, Frederic Barrat wrote:
From: Alastair D'Silva
Remove abandonned capi support for the Mellanox CX4.
This reverts commit 317f5ef1b363417b6f1e93b90dfd2ffd6be6e867.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/pci.c | 3
...
(Hmm, I should go back and see if there's anything we can rip out of
pnv_php now...)
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/Kconfig | 8 --
drivers/misc/cxl/pci.c | 236 +++
include/misc/cxl.h | 25 -
3 files changed, 18 insertions
On 28/06/18 20:05, Frederic Barrat wrote:
From: Alastair D'Silva
Remove abandonned capi support for the Mellanox CX4.
This reverts commit 79384e4b71240abf50c375eea56060b0d79c242a.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/api.c | 27
On 28/06/18 20:05, Frederic Barrat wrote:
From: Alastair D'Silva
Remove abandonned capi support for the Mellanox CX4.
This reverts commit cbce0917e2e47d4bf5aa3b5fd6b1247f33e1a126.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/api.c | 15
On 28/06/18 20:05, Frederic Barrat wrote:
From: Alastair D'Silva
Remove abandonned capi support for the Mellanox CX4.
This reverts commit a2f67d5ee8d950caaa7a6144cf0bfb256500b73e.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/pci-cxl.c
off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/api.c| 19 ---
drivers/misc/cxl/cxl.h| 1 -
drivers/misc/cxl/guest.c | 3 ---
drivers/misc/cxl/native.c | 3 ++-
include/misc/cxl.h| 8
5 files changed, 2 insertions(+), 32 deleti
On 26/06/18 12:31, Andrew Donnellan wrote:
9 of these commits are missing Signed-off-bys.
git revert -s is a thing :)
After mentally preparing myself for the flashbacks from when we had to
implement some of these hacks in the first place, I've read through the
rest of the series and it all
on POWER8 and POWER9
- Mellanox CX5, which uses a different code path, based on cxllib
- cxlflash tests on POWER8
9 of these commits are missing Signed-off-bys.
git revert -s is a thing :)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ptick Joarder
Looks okay to me
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/context.c | 22 +++---
drivers/misc/ocxl/sysfs.c | 5 ++---
2 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
index 909
On 11/05/18 16:13, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 11/05/18 16:13, Alastair D'Silva wrote:
From: Alastair D'Silva
In order for a userspace AFU driver to call the POWER9 specific
OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually
make that call.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew
Acked-by: Andrew Donnellan
Comments below.
+#ifdef CONFIG_PPC64
+static long afu_ioctl_enable_p9_wait(struct ocxl_context *ctx,
+ struct ocxl_ioctl_p9_wait __user *uarg)
+{
+ struct ocxl_ioctl_p9_wait arg;
+
+ memset(, 0, sizeof(arg));
+
+ if (cpu_has_feature
On 11/05/18 16:13, Alastair D'Silva wrote:
From: Alastair D'Silva
The function removes the process element from NPU cache.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
for the clarifying comment. The diff is painful to read but I
think it makes sense :)
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 11/05/18 16:12, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
On 11/05/18 16:12, Alastair D'Silva wrote:
From: Alastair D'Silva
This patch adds a CPU feature bit to show whether the CPU has
the TIDR register available, enabling as_notify/wait in userspace.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
d-off-by: Vaibhav Jain <vaib...@linux.ibm.com>
---
Change-log:
Resend -> Updated the commit description to add more info on the
issue seen [Andrew]
Thanks for redoing the commit message.
This looks good to me.
Acked-by: Andrew Donnellan <andrew.donnel...
Patchwork release, but
in the meantime this restriction should stop us running into any issues
on this list.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
. Alastair has also confirmed with me that truncating the pid to a u16
should be safe, so therefore:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ed-off-by: Alastair D'Silva <alast...@d-silva.org>
nitpicks below
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/misc/ocxl/context.c | 5 +++-
drivers/misc/ocxl/file.c | 53 +++
drivers/misc/ocxl/li
task_pid_nr(t);
mtspr(SPRN_TIDR, t->thread.tidr);
return 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
silva.org>
Looks good to me
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Documentation/accelerators/ocxl.rst | 1 -
drivers/misc/ocxl/file.c| 25 +
include/uapi/misc/ocxl.h| 4
3 files changed, 29 insertions(+), 1
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva <alast...@d-silva.org>
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
This looks better.
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Documentation/accelerators/ocxl.rst | 11 ++
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva <alast...@d-silva.org>
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva <alast...@d-silva.org>
Reviewed-by: Andrew Donnellan &l
my previous email:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.li...@gmail.com>
This looks good to me
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
apper around the OPAL call of a similar name.
But I don't feel strongly about this at all, so:
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com>
LGTM. Does this need to be sent to stable?
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
501 - 600 of 1009 matches
Mail list logo
