ot;hugepage". We also use
"huge page", but "hugepage" is more common. Therefore I wouldn't call it
a spelling error, just an internal term :)
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel..
benh told me that the top bit should be enough - anything above 0x8000*
should be kernel space.
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
)
to see if there's been a hardware error.
Change the nargs/nret check to ensure nargs is <= 15, allowing room for the
status code. Users shouldn't be calling with nret == 0, but there's no real
harm if they do, so we don't stop them.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.i
space access")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Found by Coverity Scan.
Currently, this should only affect cxlflash.
---
drivers/misc/cxl/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/fault.c b/drivers/
you should be looking at the
OPAL firmware log anyway, which would contain details if there was
something "new".
That's fair, would primarily help debugging in the rather corner case of
new skiboot, old kernel, and no access to the OPAL log...
--
Andrew Donnellan Softwar
as unknown.
Signed-off-by: Russell Currey <rus...@russell.cc>
Indeed it looks like there isn't a fallback case.
Would it be useful to print xstop_type in the unknown case?
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engi
On 10/03/16 12:18, Ian Munsie wrote:
On a related matter, we should send a patch to remove some of the
leftover config options that were added to smooth the merging of
cxlflash in the first place (CXL_KERNEL_API, CXL_EEH).
I'm happy to do that after this series is merged.
--
Andrew Donnellan
he cxl PowerVM
series.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Austr
easily
get back to any private data structures they may use.
Signed-off-by: Michael Neuling <mi...@neuling.org>
Signed-off-by: Ian Munsie <imun...@au1.ibm.com>
Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Looks good to me.
Reviewed-by: Andrew Donnellan <a
eneric cxl driver
will never use this event, the ABI of the event is up to each individual
AFU driver.
Signed-off-by: Ian Munsie <imun...@au1.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.don
On 09/02/16 10:57, Andrew Donnellan wrote:
It is a fix - I'm a bit hazy on the details now but IIRC, Daniel Axtens
and I encountered this when doing some cxl debugging, though I think we
decided not to tag this for stable since it was a secondary issue to the
primary bug we were looking
ux.vnet.ibm.com>
Looks good to me.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
, but the cxl
driver is not detecting it. Fix is to use the proper timebase-to-time
conversion.
Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com>
Cc: <sta...@vger.kernel.org> # 4.3+
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan
On 17/02/16 23:41, Michael Ellerman wrote:
I see you've posted a v3 since I merged this, please send an incremental patch
with the changes.
http://patchwork.ozlabs.org/patch/584416/
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development
a14906 ("powerpc/powernv: new function to access OPAL msglog")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/platforms/powernv/opal-msglog.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal-msglog.c
b/
Shan <gws...@linux.vnet.ibm.com>
Reviewed-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874
.vnet.ibm.com>
This looks good to me.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
icit names of the arguments to the callbacks in
"struct pci_controller_ops" so that the code looks consistent.
Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com>
Reviewed-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel..
onably convinced this is an appropriate fix:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
really care.
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
-by: Gavin Shan <gws...@linux.vnet.ibm.com>
eeh_dump_pe_log() isn't called anywhere outside of
eeh_slot_error_detail(), so this should have no functional change.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engi
.
This fixes the issue by correcting the PE's primary bus when it's
oneline at plugging time, in pnv_pci_dma_bus_setup() which is to
be called by pcibios_fixup_bus().
Reported-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Reported-by: Pradipta Ghosh <pradg...@in.ibm.com>
Signed-off-by: Gav
to an arbitrary buffer. Separate the initialisation code into
generic memcons init and sysfs file creation.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Changes V2->V3:
- incorporate comments from Joel Stanley
- opal_msglog_sysfs_init() now bails out if opal_memcons
interface. */
+ opal_msglog_sysfs_init();
This will succeed, leaving you with a sysfs file attached to a broken driver.
V3 on its way...
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Austral
Add the 'do' command to dump the OPAL msglog in xmon.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/xmon/xmon.c | 60
1 file changed, 60 insertions(+)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerp
to an arbitrary buffer. Separate the initialisation code into
generic memcons init and sysfs file creation.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Changes V1->V2:
- Incorporate comments from mpe
- Move the memcons pointer out of the bin_attribute struct
- Decoupl
, because the
structs in question are static and so the private pointer will be NULL, but
that's a bit fragile.
I think the solution is simply to create a:
static struct memcons *opal_memcons;
And use that in opal_msglog_copy() and so on.
Will respin.
--
Andrew Donnellan Software
Add the 'do' command to dump the OPAL msglog in xmon.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/xmon/xmon.c | 60
1 file changed, 60 insertions(+)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerp
that.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
The comment block above pcibios_set_pcie_reset_state() incorrectly refers
to pcibios_set_pcie_slot_reset(). Fix the comment accordingly.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/kernel/eeh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
tely a lot nicer to read and doesn't appear to have any
functional changes.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
irtual instance with KDB enabled.
After the patch, I am able to get the "go" command to work as
expected
Signed-off-by: Balbir Singh <bsinghar...@gmail.com>
Should this be Cc'd to stable?
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Aus
for that
in emulate_step(), raise some kind of nice big warning at the very least)
- make analyse_instr() return -1 on invalid instructions, which
emulate_step() will immediately propagate, then make sure that whoever
calls emulate_step() handles that appropriately
Andrew
--
Andrew Donnellan
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/xmon/xmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 07a8508..d5c8a15 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerp
ame as any other instruction that isn't executed
directly in the analyse_instr() stage.
Is there anywhere else in the sstep code that deals well with malformed
instructions?
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
On 20/01/16 18:02, Andrew Donnellan wrote:
I'm hitting an issue on a ppc64le box running linux-next, which
according to git bisect is caused by this patch.
Whoops, that should be linuxppc*-dev*@lists.ozlabs.org in the Cc.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
to an arbitrary buffer.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/include/asm/opal.h | 2 ++
arch/powerpc/platforms/powernv/opal-msglog.c | 15 +++
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/inclu
Add the 'do' command to dump the OPAL msglog in xmon.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/xmon/xmon.c | 60
1 file changed, 60 insertions(+)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerp
existing drivers (cxlflash)
to start using it.
Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com>
Looks fine to me.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.co
On 14/01/16 02:30, Geliang Tang wrote:
Use kobj_to_dev() instead of open-coding it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
Good simplification.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
a
t
Thanks for the changes.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
unsigned inttotal_pe;
unsigned intreserved_pe;
Given this leaves struct ioda as the only member of the union, do we
want to get rid of the union?
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel
has been updated and its usage in the OPAL kmsg dumper has
been modified to support its new behaviour as an incremental flush.
Signed-off-by: Russell Currey <rus...@russell.cc>
Looks fine to me.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andr
On 06/01/16 11:45, Daniel Axtens wrote:
As sparse suggests, these should be made static.
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...
A few of the config prompts for powerpc self-tests have periods at the
end, which is inconsistent with the rest of the prompts. Remove the
periods.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/Kconfig.debug | 6 +++---
1 file changed, 3 insertions
Fix off-by-one error in opal_mce_check_early_recovery() when checking
whether the NIP falls within OPAL space.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Only very slightly more correct, but I'm fairly sure it's more correct...
---
arch/powerpc/platforms/powernv/
Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing l
om>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Looks reasonable.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
;
I tested this patch as found in linux-next, along with the SANITIZE_ALL
typo fix, on a big-endian BML system, with gcc 5.2.1. It successfully
picked up one of the shift input issues that Daniel found, so therefore...
Tested-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
-
.vnet.ibm.com>
Assuming that the final card won't break in a particularly nasty way in
the absence of later code changes, all looks good.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Austral
ed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Without the card-specific code, how does the driver behave if the new
card is plugged in?
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 620
Finally looking at this patch again for the first time in a couple of
months...
On 04/11/15 17:17, Andrew Donnellan wrote:
On 03/11/15 20:09, Michael Ellerman wrote:
Part of your problem is you're storing afu->crs_len which is not
__iomem in
cfg_data which is, and so that's leading to s
e meantime, revert the commit, especially as it was intended to be a
non-functional change.
Cc: Gavin Shan <gws...@linux.vnet.ibm.com>
Cc: Ian Munsie <imun...@au1.ibm.com>
Cc: Daniel Axtens <d...@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
don't fully understand why this is happening, and we
also haven't tested whether this occurs for other cxl devices. In the
meantime, though, revert the commit, especially as it was intended to be a
non-functional change.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
This
too.)
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
On 27/11/15 16:36, Andrew Donnellan wrote:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
And withdrawing my Reviewed-by: because apparently I'm not capable of
spotting missing semicolons, please move the semicolon from patch 2 to
this patch...
Andrew
--
Andrew Don
mainline kernels.
So, start to remove references to OPALv2.
Signed-off-by: Stewart Smith <stew...@linux.vnet.ibm.com>
Was going to comment that you should've removed the OPAL v1 line in
cpuinfo, but it seems you do that in the next patch.
Reviewed-by: Andrew Donnellan <andrew.donn
exclusively.
Signed-off-by: Stewart Smith <stew...@linux.vnet.ibm.com>
I haven't checked for any outstanding references you've missed here, but
I'm going to assume it compiles...
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Softw
still
miss messages printed in panic() after the dumpers are called, i.e. the
"end kernel panic" message.
Signed-off-by: Russell Currey <rus...@russell.cc>
The code looks reasonable.
With the changes I've mentioned above:
Reviewed-by: Andrew Donnellan <andrew.do
viewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev
On 27/11/15 16:43, Stewart Smith wrote:
Considering you need kernel support for any new POWER processor, and we're not
about to do an OPALv4 on POWER8 or earlier - we're going to be safe :)
Not a huge problem then :)
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel
building a mainline kernel today and expecting
it to boot on such hardware is zero.
Signed-off-by: Stewart Smith <stew...@linux.vnet.ibm.com>
Comment below.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/platforms/powernv/opal.c | 5 +
1 fil
On 19/11/15 14:26, Rashmica Gupta wrote:
This function has been unused since commit 14cf11af6cf6 ("powerpc: Merge enough
to start building in arch/powerpc."), so remove it.
Signed-off-by: Rashmica Gupta <rashm...@gmail.com>
Reviewed-by: Andrew Donnellan <andrew.do
tected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Thanks for picking this up - will remember in my future patches.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, Oz
like to continue with the patch as is, I'm happy to drop the
stable Cc though.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
On 06/11/15 10:05, Daniel Axtens wrote:
Given that there are no current users of this function, does this need
to go to stable? Does it actually fix a real (as opposed to theoretical)
bug?
I tagged it for stable on mpe's request - I'm not fussed either way.
Andrew
--
Andrew Donnellan
bar...@linux.vnet.ibm.com>
Cc: <sta...@vger.kernel.org> # 4.3+
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM
bar...@linux.vnet.ibm.com>
Cc: <sta...@vger.kernel.org> # 3.18+
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM
* 8;
Which hopefully still gives you the right result! :)
Will check.
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
_
c: sta...@vger.kernel.org
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/misc/cxl/vphb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/vphb.c b/drivers
On 31/10/15 00:07, Arnd Bergmann wrote:
On Wednesday 28 October 2015 14:29:39 Andrew Donnellan wrote:
--- a/drivers/misc/cxl/vphb.c
+++ b/drivers/misc/cxl/vphb.c
@@ -128,7 +128,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus,
unsigned int devfn,
return
(). The reference
count is only decremented once on detach, thus the struct pid of the
task attaching is never freed. The fix is to simply remove the call to
get_pid().
Signed-off-by: Frederic Barrat <frederic.bar...@fr.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andr
Axtens <d...@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
This patch is a respin of https://patchwork.ozlabs.org/patch/504976/,
incorporating comments from mpe.
As with the old patch, this patch doesn't make any changes to the return
type of cxl_p
eiy...@linux.vnet.ibm.com>
Acked-by: Gavin Shan <gws...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)
oogle.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
__
}() and exports them so that they
can be used in PCI hotplug during EEH recovery.
[gwshan: changelog]
Signed-off-by: Wei Yang <weiy...@linux.vnet.ibm.com>
Reviewed-by: Gavin Shan <gws...@linux.vnet.ibm.com>
Acked-by: Bjorn Helgaas <bhelg...@google.com>
Reviewed-by: Andrew Donnellan <
.
Fix the check so that a wait_state() return value of 0 won't be considered
successful for the EEH_OPT_THAW_MMIO or EEH_OPT_THAW_DMA cases.
Cc: Gavin Shan <gws...@linux.vnet.ibm.com>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/kernel/eeh.c | 2 +-
() for the tmf_slock during probe.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work
evaluation for an unset bit.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnell
On 22/10/15 07:16, Matthew R. Ochs wrote:
The port selection mask of a LUN can be corrupted when the manage LUN
ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device.
> ...
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew
-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Austr
-by: Daniel Axtens <d...@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
This patch depends on "powerpc/pci: export pcibios_free_controller()" [0].
[0] https://patchwork.ozlabs.org/patch/516142/
---
drivers/misc/cxl/vphb.c | 2 ++
1 file changed,
On 08/10/15 14:58, Gavin Shan wrote:
This simplifies pnv_eeh_set_option() to avoid unnecessary nested
if statements, to improve readability. No functional changes.
Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
"result" to simplify the code.
Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com>
Much easier to follow!
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Developme
com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
to allow this.
Reported-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Signed-off-by: Ian Munsie <imun...@au1.ibm.com>
---
drivers/misc/cxl/a
el API (cxl_release_context()) or the
userspace API (afu_release()).
Reported-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/misc/cxl/context
m.com>
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
drivers/misc/cxl/file.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cx
and return codes.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
See further comments bel
ux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Changes mostly look fine, further comments below.
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -58,8 +58,8 @@ static struct afu_cmd *cmd_checkout(struct afu *afu)
atthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLab
ed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
The commit message could explain the patch a bit better.
Andrew
--
Andrew Donnellan Software Engine
clean.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan S
not require an embedded fops.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.
com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
L
com>
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan
On 25/09/15 05:44, Matthew R. Ochs wrote:
Add stanza for cxlflash SCSI driver.
Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com>
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnel
iewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work)IBM Australia Limited
___
Linuxppc-dev mai
Export pcibios_free_controller(), so it can be used by the cxl module to
free virtual PHBs.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
arch/powerpc/kernel/pci-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/p
901 - 1000 of 1009 matches
Mail list logo
