Re: [PATCH V2 4/9] tools/perf: Add support to capture and parse raw instruction in objdump

2024-05-10 Thread Arnaldo Carvalho de Melo
bin Du Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kan Liang Cc: Peter Zijlstra Link: https://lore.kernel.org/r/20240329215812.537846-5-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo >From a quick look at http://www.capstone-engine.org/compile.html it seems PowerPC is supported

Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in extract_reg_offset function

2024-05-07 Thread Arnaldo Carvalho de Melo
On Mon, May 06, 2024 at 09:40:15PM -0700, Namhyung Kim wrote: > On Mon, May 6, 2024 at 5:19 AM Athira Rajeev > wrote: > > > > Fix a comment in function which explains how multi_regs field gets set > > for an instruction. In the example, "mov %rsi, 8(%rbx,%rcx,4)", the > > comment mistakenly

Re: [PATCH] perf vendor events: Remove UTF-8 characters from cmn.json

2023-12-21 Thread Arnaldo Carvalho de Melo
s/perf/pmu-events/arch/arm64/arm/cmn/sys/cmn.json: text/plain; > charset=us-ascii Thanks, applied! - Arnaldo > Fixes: 0b4de7bdf46c5215 ("perf jevents: Add support for Arm CMN PMU aliasing") > Reported-by: Arnaldo Carvalho de Melo > Signed-off-by: Jing Zhang > --- > t

Re: perf tools arch Arm CMN PMU JSON files build breakage on ubuntu 18.04 cross build

2023-12-15 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 15, 2023 at 11:41:19AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Dec 15, 2023 at 11:39:14AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu: > > > > UnicodeDecodeError: 'ascii' codec can't decode

Re: perf tools arch Arm CMN PMU JSON files build breakage on ubuntu 18.04 cross build

2023-12-15 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 15, 2023 at 11:39:14AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu: > > On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote: > > > Exception processing pmu-events/arch/powerpc/power9/other.json > > >

perf tools arch Arm CMN PMU JSON files build breakage on ubuntu 18.04 cross build

2023-12-15 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 27, 2023 at 09:52:11AM +0530, kajoljain escreveu: > On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote: > > Exception processing pmu-events/arch/powerpc/power9/other.json > > Traceback (most recent call last): > > File "pmu-events/jevents.py", line 997

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-12-06 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 06, 2023 at 10:15:06AM +0530, Athira Rajeev escreveu: > > > > On 06-Dec-2023, at 3:20 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > >> On 23/11/2023 16:02, Athira Rajeev wrot

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-12-06 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 05, 2023 at 02:09:01PM -0800, Ian Rogers escreveu: > On Tue, Dec 5, 2023 at 1:50 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > > > On 23/11/2023 16:02, Athira Rajeev wrote: > > &

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > On 23/11/2023 16:02, Athira Rajeev wrote: > > --- a/tools/perf/Makefile.perf > > @@ -1134,6 +1152,7 @@ bpf-skel-clean: > > $(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS) > > > > clean:: $(LIBAPI)-clean

Re: [PATCH] perf vendor events: Update datasource event name to fix duplicate events

2023-12-04 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 04, 2023 at 05:20:46PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 04, 2023 at 12:12:54PM -0800, Ian Rogers escreveu: > > On Thu, Nov 23, 2023 at 8:01 AM Athira Rajeev > > wrote: > > > > > > Running "perf list" on

Re: [PATCH] perf vendor events: Update datasource event name to fix duplicate events

2023-12-04 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 04, 2023 at 12:12:54PM -0800, Ian Rogers escreveu: > On Thu, Nov 23, 2023 at 8:01 AM Athira Rajeev > wrote: > > > > Running "perf list" on powerpc fails with segfault > > as below: > > > >./perf list > >Segmentation fault (core dumped) > > > > This happens because of duplicate

Re: [PATCH] perf vendor events: Update datasource event name to fix duplicate events

2023-12-04 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 03, 2023 at 09:27:25PM +0530, Athira Rajeev escreveu: > > On 29-Nov-2023, at 10:51 AM, Athira Rajeev > > wrote: > >> On 27-Nov-2023, at 5:32 PM, Disha Goel wrote: > >>> Fixes: fc1435807533 ("perf vendor events power10: Update JSON/events") > >>> Signed-off-by: Athira Rajeev > >> I

Re: [PATCH] perf test record+probe_libc_inet_pton: Fix call chain match on powerpc

2023-11-29 Thread Arnaldo Carvalho de Melo
Em Sun, Nov 26, 2023 at 02:09:14AM -0500, Likhitha Korrapati escreveu: > The perf test "probe libc's inet_pton & backtrace it with ping" fails on > powerpc as below: > > root@xxx perf]# perf test -v "probe libc's inet_pton & backtrace it with > ping" > 85: probe libc's inet_pton & backtrace it

Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-11-27 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu: > On 23/11/2023 16:02, Athira Rajeev wrote: > > Add rule in new Makefile "tests/Makefile.tests" for running > > shellcheck on shell test scripts. This automates below shellcheck > > into the build. > Seems to work really well. I also

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 07, 2023 at 12:08:25PM +0530, Athira Rajeev escreveu: > > On 07-Nov-2023, at 3:14 AM, Arnaldo Carvalho de Melo > > wrote: > >>> Reviewed-by: James Clark > > Some are not applying, even after b4 picking up v2 &

Re: [PATCH 1/3] perf tests test_arm_coresight: Fix the shellcheck warning in latest test_arm_coresight.sh

2023-11-06 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 05, 2023 at 02:24:15PM +0530, Athira Rajeev escreveu: > > On 05-Oct-2023, at 1:50 PM, James Clark wrote: > > On 29/09/2023 05:11, Athira Rajeev wrote: > >> Running shellcheck on tests/shell/test_arm_coresight.sh > >> throws below warnings: > >> > >> In

Re: [PATCH V2] perf test: Fix parse-events tests to skip parametrized events

2023-09-25 Thread Arnaldo Carvalho de Melo
On Wed, Sep 13, 2023, 7:40 AM Athira Rajeev wrote: > > > > On 08-Sep-2023, at 7:48 PM, Athira Rajeev > wrote: > > > > > > > >> On 08-Sep-2023, at 11:04 AM, Sachin Sant wrote: > >> > >> > >> > >>> On 07-Sep-2023, at 10:29 PM, Athira Rajeev < > atraj...@linux.vnet.ibm.com> wrote: > >>> > >>>

Re: [PATCH V3] tools/perf: Add includes for detected configs in Makefile.perf

2023-09-12 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 12, 2023 at 07:00:00AM -0700, Ian Rogers escreveu: > On Mon, Sep 11, 2023 at 11:38 PM Athira Rajeev > wrote: > > > > Makefile.perf uses "CONFIG_*" checks in the code. Example the config > > for libtraceevent is used to set PYTHON_EXT_SRCS > > > > ifeq

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-06 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: > Update JSON/Events list with data-source events for power10 platform. Thanks, applied the series. - Arnaldo > Signed-off-by: Kajol Jain > --- > .../arch/powerpc/power10/datasource.json | 1282 + >

Re: [PATCH v2 2/3] perf vendor events: Update JSON/events for power10 platform

2023-09-06 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 05, 2023 at 05:10:38PM +0530, Kajol Jain escreveu: > Update JSON/Events list with additional data-source events > for power10 platform. I changed the cset title to: "perf vendor events power10: Add extra data-source events" As it was exactly the same as the first, so when someone

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-06 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: > Update JSON/Events list with data-source events for power10 platform. Next time could you please provide some pointer to the document from where these metrics came if it is available online? - Arnaldo > Signed-off-by: Kajol Jain

Re: [PATCH] perf test: Skip perf bench breakpoint run if no breakpoints available

2023-08-23 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 23, 2023 at 01:21:03PM +0530, Kajol Jain escreveu: > Based on commit 7d54a4acd8c1 ("perf test: Skip watchpoint > tests if no watchpoints available"), hardware breakpoints > are not available for power9 platform and because of that > perf bench breakpoint run fails on power9 platform. >

Re: [PATCH 1/2] tools/perf: Add text_end to "struct dso" to save .text section size

2023-08-11 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 11, 2023 at 10:51:27AM +0530, Athira Rajeev escreveu: > Update "struct dso" to include new member "text_end". > This new field will represent the offset for end of text > section for a dso. This value is derived as: > sh_size (Size of section in byes) + sh_offset (Section file > offst)

Re: [PATCH] tools/perf: Fix dso kernel load and symbol process to correctly map dso to its long_name, type and adjust_symbols

2023-08-11 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 11, 2023 at 12:49:35PM +0300, Adrian Hunter escreveu: > On 11/08/23 08:15, Athira Rajeev wrote: > > Test "object cocde reading" fails sometimes for kernel address > > as below: > > > > Reading object code for memory address: 0xc0004c3c > > File is: [kernel.kallsyms] >

Re: [PATCH V2 2/2] tools/perf/tests: perf all metricgroups test fails when perf_event access is restricted

2023-08-07 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 07, 2023 at 08:14:39PM +0530, Disha Goel escreveu: > On 04/08/23 10:30 am, Athira Rajeev wrote: > > Perf all metricgroups test fails as below when perf_event access > > is restricted. > > > > ./perf test -v "perf all metricgroups test" > > Testing Memory_BW > > Error: >

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 25, 2023 at 11:20:37AM +0530, Athira Rajeev escreveu: > > > > On 20-Jul-2023, at 10:48 AM, kajoljain wrote: > > > > > > > > On 7/20/23 10:42, Athira Rajeev wrote: > >> > >> > >>> On 19-Jul-2023, at 11:16 PM, Ian Rogers wrote: > >>> > >>> On Tue, Jul 18, 2023 at 11:17 PM

Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 28, 2023 at 09:01:11AM -0700, Ian Rogers escreveu: > On Fri, Jul 28, 2023 at 7:54 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > > > Currently we depend on output of 'perf record -e "sche

Re: [PATCH 1/1] perf tests task_analyzer: Check perf build options for libtraceevent support

2023-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 25, 2023 at 11:46:49AM +0530, Aditya Gupta escreveu: > Currently we depend on output of 'perf record -e "sched:sched_switch"', to > check whether perf was built with libtraceevent support. > > Instead, a more straightforward approach can be to check the build options, > using 'perf

Re: [PATCH] tools/perf: Fix addr location init during arch_skip_callchain_idx function

2023-07-24 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 24, 2023 at 10:28:15PM +0530, Athira Rajeev escreveu: > perf record with callchain recording fails as below > in powerpc: > > ./perf record -a -gR sleep 10 > ./perf report > perf: Segmentation fault > > gdb trace points to thread__find_map > > 0 0x101df314

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 14, 2023 at 09:59:14AM +0800, Leo Yan escreveu: > On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > > From: Sourabh Jain > > > > > > Scrip

Re: [PATCH 06/17] tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.sh

2023-06-13 Thread Arnaldo Carvalho de Melo
d77e..935eac7efa47 100755 > --- a/tools/perf/tests/shell/trace+probe_vfs_getname.sh > +++ b/tools/perf/tests/shell/trace+probe_vfs_getname.sh > @@ -10,15 +10,15 @@ > # SPDX-License-Identifier: GPL-2.0 > # Arnaldo Carvalho de Melo , 2017 > > -. $(dirname $0)/lib/probe.sh > +. &

Re: [PATCH 00/17] tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:28PM +0530, Athira Rajeev escreveu: > Patchset covers a set of fixes for coding/formatting issues observed while > running shellcheck tool on the perf test shell scripts. Shellcheck is a static > analysis tool that can find semantic/syntax bugs in the shell scripts.

Re: [PATCH 16/17] perf tests task_analyzer: print command on failure

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:44PM +0530, Athira Rajeev escreveu: > From: Aditya Gupta > > Instead of printing "perf command failed" everytime, print the exact > command that run earlier Looks like a nice improvement, added the test authors to the CC list on this message, Thanks, applied. -

Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:43PM +0530, Athira Rajeev escreveu: > From: Aditya Gupta > > ${$1} gives bad substitution error on sh, bash, and zsh. This seems like > a typo, and this patch modifies it to $1, since that is what it's usage > looks like from wherever `check_exec_0` is called.

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > From: Sourabh Jain > > Script doesn't use sys library, so remove it. Please Cc the persons working on that file, I added Leo to the CC list of this message. Thanks, applied. - Arnaldo > Report by pylint: > W0611: Unused

Re: [PATCH] perf vendor events power9: Remove UTF-8 characters from json files

2023-03-29 Thread Arnaldo Carvalho de Melo
ii > > pmu-events/arch/powerpc/power9/other.json: application/json; > > charset=us-ascii > > pmu-events/arch/powerpc/power9/pipeline.json: application/json; > > charset=us-ascii > > pmu-events/arch/powerpc/power9/pmc.json:application/json; >

perf tools power9 JSON files build breakage on ubuntu 18.04 cross build

2023-03-23 Thread Arnaldo Carvalho de Melo
Exception processing pmu-events/arch/powerpc/power9/other.json Traceback (most recent call last): File "pmu-events/jevents.py", line 997, in main() File "pmu-events/jevents.py", line 979, in main ftw(arch_path, [], preprocess_one_file) File "pmu-events/jevents.py", line 935, in ftw

Re: [PATCH v2] tools/perf/tests: Change true workload to sleep workload in all metric test for system wide check

2023-02-17 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 15, 2023 at 08:08:20AM -0800, Ian Rogers escreveu: > On Wed, Feb 15, 2023 at 1:38 AM Kajol Jain wrote: > > > > Testcase stat_all_metrics.sh fails in powerpc: > > > > 98: perf all metrics test : FAILED! > > > > Logs with verbose: > > > > [command]# ./perf test 98 -vv > > 98: perf all

Re: [PATCH] powerpc/perf: Add json metric events to present CPI stall cycles in powerpc

2023-02-17 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 16, 2023 at 10:10:05AM -0800, Ian Rogers escreveu: > On Wed, Feb 15, 2023 at 10:12 PM Athira Rajeev > wrote: > > > > Power10 Performance Monitoring Unit (PMU) provides events > > to understand stall cycles of different pipeline stages. > > These events along with completed

Re: [PATCH 2/2] perf test bpf: Skip test if kernel-debuginfo is not present

2023-02-06 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 06, 2023 at 07:28:49PM +0530, Athira Rajeev escreveu: > > > > On 05-Jan-2023, at 6:24 PM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Thu, Jan 05, 2023 at 05:47:42PM +0530, Athira Rajeev escreveu: > >> Perf BPF filter test fails

Re: [PATCH] tests/bpf: Fix the bpf test to check for libtraceevent support

2023-02-06 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 06, 2023 at 09:27:13AM +0530, Athira Rajeev escreveu: > > On 02-Feb-2023, at 6:27 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Tue, Jan 31, 2023 at 07:20:01PM +0530, Athira Rajeev escreveu: > >> "bpf" tests fails in environment with

Re: [PATCH v5 15/15] perf jevents: Run metric_test.py at compile-time

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 26, 2023 at 03:36:45PM -0800, Ian Rogers escreveu: > Add a target that generates a log file for running metric_test.py and > make this a dependency on generating pmu-events.c. The log output is > displayed if the test fails like (the test was modified to make it > fail): > > ``` >

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 01:02:02PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 12:43:48PM -0300, Arnaldo Carvalho de Melo escreveu: > > I tried bisecting, but at this cset: > > > > acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1 > > d22e569c

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 12:43:48PM -0300, Arnaldo Carvalho de Melo escreveu: > I tried bisecting, but at this cset: > > acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1 > d22e569cd33d (HEAD) perf pmu-events: Separate the metrics from events for no > jevents > acme@roc-rk

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 11:43:23AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Feb 03, 2023 at 11:17:3

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Feb 02, 2023 at 05:41:22PM

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > > > On Thu, Feb 2, 2023 at 5:40 PM

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > > > > > ARM64 overrides a weak function but a previous change

Re: [PATCH v1] perf pmu: Fix aarch64 build

2023-02-03 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > > > ARM64 overrides a weak function but a previous change had broken the > > build. > > > > Fixes: 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") > > As

Re: [PATCH] tests/bpf: Fix the bpf test to check for libtraceevent support

2023-02-01 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 31, 2023 at 07:20:01PM +0530, Athira Rajeev escreveu: > "bpf" tests fails in environment with missing libtraceevent > support as below: > > # ./perf test 36 > 36: BPF filter : > 36.1: Basic BPF filtering

Re: [PATCH] tools/perf: Fix usage of perf probe when libtraceevent is missing

2023-02-01 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 31, 2023 at 07:17:48PM +0530, Athira Rajeev escreveu: > While parsing the tracepoint events in parse_events_add_tracepoint() > function, code checks for HAVE_LIBTRACEEVENT support. This is needed > since libtraceevent is necessary for tracepoint. But while adding > probe points, check

Re: [PATCH 1/2] tests/shell: Add check for perf data file in record+probe_libc_inet_pton test

2023-02-01 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 01, 2023 at 11:34:20PM +0530, Athira Rajeev escreveu: > "probe libc's inet_pton & backtrace it with ping" test > installs a uprobe and uses perf record/script to check > the backtrace. Currently even if the "perf record" fails, > the test reports success. Logs below: > > # ./perf

Re: [PATCH v4 11/12] perf jevents: Add model list option

2023-01-26 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 26, 2023 at 01:44:39PM +, John Garry escreveu: > On 26/01/2023 01:18, Ian Rogers wrote: > > This allows the set of generated jevents events and metrics be limited > > to a subset of the model names. Appropriate if trying to minimize the > > binary size where only a set of models

Re: [PATCH V3] tools/perf/tests: Fix string substitutions in build id test

2023-01-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 20, 2023 at 08:51:59AM +, David Laight escreveu: > From: Arnaldo Carvalho de Melo > > Sent: 19 January 2023 17:00 > > > > Em Thu, Jan 19, 2023 at 03:49:15PM +, David Laight escreveu: > > > From: Athira Rajeev > > > > Sent: 19 Jan

Re: [PATCH] tools/perf: Disable perf probe when libtraceevent is missing

2023-01-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 20, 2023 at 05:32:56PM +0530, Athira Rajeev escreveu: > While parsing the tracepoint events in parse_events_add_tracepoint() > function, code checks for HAVE_LIBTRACEEVENT support. This is needed > since libtraceevent is necessary for tracepoint. But while adding > probe points, check

Re: [PATCH V3] tools/perf/tests: Fix string substitutions in build id test

2023-01-19 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 19, 2023 at 03:49:15PM +, David Laight escreveu: > From: Athira Rajeev > > Sent: 19 January 2023 14:27 > ... > > The test script "tests/shell/buildid.sh" uses some of the > > string substitution ways which are supported in bash, but not in > > "sh" or other shells. Above error on

Re: [PATCH 1/2] tools/perf: Fix the file mode with copyfile while adding file to build-id cache

2023-01-18 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 16, 2023 at 10:31:30AM +0530, Athira Rajeev escreveu: > The test "build id cache operations" fails on powerpc > As below: > > Adding 5a0fd882b53084224ba47b624c55a469 ./tests/shell/../pe-file.exe: Ok > build id: 5a0fd882b53084224ba47b624c55a469 > link:

Re: [PATCH 2/2] perf test bpf: Skip test if kernel-debuginfo is not present

2023-01-05 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 05, 2023 at 05:47:42PM +0530, Athira Rajeev escreveu: > Perf BPF filter test fails in environment where "kernel-debuginfo" > is not installed. I'll apply this to perf/core, for the next merge window, as its more an improvement than a fix, i.e. we know why it fails, we're just

Re: [PATCH] tools/perf: Fix bpf-script-test-prologue test compile issue with clang

2023-01-05 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 05, 2023 at 05:34:36PM +0530, Athira Rajeev escreveu: > While running perf test for bpf, observed that "BPF prologue > generation" test case fails to compile with clang. Logs below > from powerpc: > > :33:2: error: use of undeclared identifier 'fmode_t' > fmode_t f_mode =

Re: [PATCH] perf test bpf: Skip test if kernel-debuginfo is not present

2023-01-02 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 02, 2023 at 07:12:50PM +0530, Athira Rajeev escreveu: > > On 14-Dec-2022, at 9:21 PM, Arnaldo Carvalho de Melo > <mailto:a...@kernel.org>> wrote: > > Em Tue, Dec 13, 2022 at 03:21:03PM +0530, Athira Rajeev escreveu: > >>> On 13-Dec-2022, a

Re: [PATCH] perf test bpf: Skip test if kernel-debuginfo is not present

2022-12-14 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 13, 2022 at 03:21:03PM +0530, Athira Rajeev escreveu: > > On 13-Dec-2022, at 12:27 AM, Arnaldo Carvalho de Melo > > wrote: > > Em Thu, Nov 03, 2022 at 12:27:01PM +0530, Athira Rajeev escreveu: > >>> On 28-Oct-2022, at 9:12 PM, Kajol Jain wrote: >

Re: [PATCH] perf test bpf: Skip test if kernel-debuginfo is not present

2022-12-12 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 03, 2022 at 12:27:01PM +0530, Athira Rajeev escreveu: > > On 28-Oct-2022, at 9:12 PM, Kajol Jain wrote: > > > > Perf BPF filter test fails in environment where "kernel-debuginfo" > > is not installed. > > > > Test failure logs: > > <<>> > > 42: BPF filter

Re: [PATCH] perf test: Update event group check for support of uncore event

2022-12-12 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 09, 2022 at 12:57:34PM +0530, Athira Rajeev escreveu: > > > > On 08-Dec-2022, at 9:48 AM, Ravi Bangoria wrote: > > > > On 07-Dec-22 10:28 PM, Athira Rajeev wrote: > >> Event group test checks group creation for combinations of > >> hw, sw and uncore PMU events. Some of the uncore

Re: [V3] tools/perf: Fix printing field separator in CSV metrics output

2022-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2022 at 09:58:52AM +0530, Athira Rajeev escreveu: > In perf stat with CSV output option, number of fields > in metrics output is not matching with number of fields > in other event output lines. > > Sample output below after applying patch to fix > printing os->prefix. > >

Re: [PATCH] perf test: Skip watchpoint tests if no watchpoints available

2022-11-23 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 22, 2022 at 12:57:05PM -0800, Ian Rogers escreveu: > On Tue, Nov 22, 2022 at 11:19 AM Christophe Leroy > wrote: > > > > > > > > Le 21/11/2022 à 11:27, Naveen N. Rao a écrit : > > > On IBM Power9, perf watchpoint tests fail since no hardware breakpoints > > > are available. Detect this

Re: [PATCH 2/2] tools/perf: Fix printing field separator in CSV metrics output

2022-11-08 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 02, 2022 at 02:07:06PM +0530, Athira Rajeev escreveu: > > > > On 18-Oct-2022, at 2:26 PM, Athira Rajeev > > wrote: > > > > In perf stat with CSV output option, number of fields > > in metrics output is not matching with number of fields > > in other event output lines. > > > >

Re: [PATCH] powerpc/perf: Fix hv-24x7 metric events for power10

2022-10-18 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 18, 2022 at 09:24:44AM +0530, Madhavan Srinivasan escreveu: > > On 10/17/22 7:03 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 14, 2022 at 07:32:20PM +0530, Kajol Jain escreveu: > > > Testcase stat_all_metrics.sh fails in powerpc: > > > > >

Re: [PATCH] powerpc/perf: Fix hv-24x7 metric events for power10

2022-10-17 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 14, 2022 at 07:32:20PM +0530, Kajol Jain escreveu: > Testcase stat_all_metrics.sh fails in powerpc: > > 90: perf all metrics test : FAILED! > > The testcase "stat_all_metrics.sh" verifies perf stat > result for all the metric events present in perf list. > It runs perf metric events

Re: [PATCH 1/2] tools/perf/tests/shell: Update stat+csv_output.sh to include sanity check for topology

2022-10-14 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 06, 2022 at 09:21:48PM +0530, Athira Rajeev escreveu: > Testcase stat+csv_output.sh fails in powerpc: > > 84: perf stat CSV output linter: FAILED! Thanks, applied both patches. - Arnaldo

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-06 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 06, 2022 at 06:16:14PM +0530, Athira Rajeev escreveu: > > > > On 05-Oct-2022, at 6:05 PM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Wed, Oct 05, 2022 at 09:28:52AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Wed, Oct 05, 2022 at 1

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-05 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 05, 2022 at 09:28:52AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu: > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > > index b82844cb0ce7..cf28020798ec 100644 > >

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-05 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu: > > > > On 04-Oct-2022, at 11:44 PM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Tue, Oct 04, 2022 a

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-05 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 05, 2022 at 10:23:39AM +0530, Athira Rajeev escreveu: > > > > On 04-Oct-2022, at 11:44 PM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Tue, Oct 04, 2022 a

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-04 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 04, 2022 at 03:14:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Oct 04, 2022 at 07:49:21AM -0700, Ian Rogers escreveu: > > On Tue, Oct 4, 2022, 12:06 AM Athira Rajeev > > > Thanks for helping with testing. Can I add your Tested-by for the patch ? > &g

Re: [PATCH] tools/perf: Fix aggr_printout to display cpu field irrespective of core value

2022-10-04 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 04, 2022 at 07:49:21AM -0700, Ian Rogers escreveu: > On Tue, Oct 4, 2022, 12:06 AM Athira Rajeev > > Thanks for helping with testing. Can I add your Tested-by for the patch ? > Yep. > Tested-by: Ian Rogers > Thanks, > Ian

Re: [PATCH V2 2/3] tools/perf/tests: Fix branch stack sampling test to include sanity check for branch filter

2022-09-28 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 21, 2022 at 08:22:54PM +0530, Athira Rajeev escreveu: > commit b55878c90ab9 ("perf test: Add test for branch stack sampling") > added test for branch stack sampling. There is a sanity check in the > beginning to skip the test if the hardware doesn't support branch stack > sampling. >

Re: [PATCH] tools/perf/tests: Update is_ignored_symbol function in vmlinux-kallsyms test

2022-09-28 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 28, 2022 at 10:22:18AM +0530, Athira Rajeev escreveu: > The testcase “vmlinux-kallsyms.c” fails in powerpc. > > vmlinux symtab matches kallsyms: FAILED! Thanks, applied. - Arnaldo > This test look at the symbols in the vmlinux DSO > and check if we find all of them in the

Re: [PATCH V2] tools/perf/tests: Fix perf probe error log check in skip_if_no_debuginfo

2022-09-26 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 16, 2022 at 06:35:41PM +0530, kajoljain escreveu: > > > On 9/16/22 16:19, Athira Rajeev wrote: > > The perf probe related tests like probe_vfs_getname.sh which > > is in "tools/perf/tests/shell" directory have dependency on > > debuginfo information in the kernel. Currently debuginfo

Re: [PATCH 1/2] tools/perf/tests: Fix string substitutions in build id test

2022-09-22 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 21, 2022 at 10:38:38PM +0530, Athira Rajeev escreveu: > The perf test named “build id cache operations” skips with below > error on some distros: I wonder if we shouldn't instead state that bash is needed? ⬢[acme@toolbox perf-urgent]$ head -1 tools/perf/tests/shell/*.sh | grep ^#

Re: [PATCH V2 1/2] tools/perf: Fix out of bound access to affinity "sched_cpus"

2022-09-06 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 05, 2022 at 07:49:28PM +0530, Athira Rajeev escreveu: > The affinity code in "affinity_set" function access array > named "sched_cpus". The size for this array is allocated in > affinity_setup function which is nothing but value from > get_cpu_set_size. This is used to contain the

Re: [PATCH] tools/perf/tests: Fix session topology test comparison check

2022-06-14 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 14, 2022 at 07:38:55AM -0700, Ian Rogers escreveu: > On Fri, Jun 10, 2022 at 7:00 AM Athira Rajeev > wrote: > > > > commit cfd7092c31ae ("perf test session topology: Fix test to > > skip the test in guest environment") added check to skip the > > testcase if the socket_id can't be

Re: [PATCH V2] tools/perf/tests: Fix session topology test to skip the test in guest environment

2022-05-21 Thread Arnaldo Carvalho de Melo
Em Sat, May 21, 2022 at 10:16:59AM +0530, Athira Rajeev escreveu: > > On 14-May-2022, at 12:03 AM, Ian Rogers wrote: > > On Thu, May 12, 2022 at 11:18 PM Disha Goel > > wrote: > >> Tested the patch on powerpc and powernv, session topology test works fine > >> with the patch. > >> Tested-by:

Re: [PATCH V2] tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc

2022-05-20 Thread Arnaldo Carvalho de Melo
Em Thu, May 19, 2022 at 11:45:07AM -0700, Ian Rogers escreveu: > On Thu, May 19, 2022 at 8:43 AM Athira Rajeev > wrote: > > > > "perf all PMU test" picks the input events from > > "perf list --raw-dump pmu" list and runs "perf stat -e" > > for each of the event in the list. In case of powerpc,

Re: [PATCH V2 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field

2022-05-10 Thread Arnaldo Carvalho de Melo
Em Tue, May 10, 2022 at 07:08:47PM +0530, Athira Rajeev escreveu: > > > > On 06-May-2022, at 3:03 PM, Athira Rajeev > > wrote: > > > > > > > >> On 05-May-2022, at 10:54 PM, Arnaldo Carvalho de Melo > >> wrote: > >> > &

Re: [PATCH] tools/perf/tests: Skip perf BPF test if clang is not present

2022-05-10 Thread Arnaldo Carvalho de Melo
Em Fri, May 06, 2022 at 03:07:51PM +0530, Athira Rajeev escreveu: > > > > On 05-May-2022, at 10:51 PM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Thu, May 05, 2022 at 03:30:39PM +0530, Athira Rajeev escreveu: > >> Perf BPF filter

Re: [PATCH V2 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field

2022-05-05 Thread Arnaldo Carvalho de Melo
Em Thu, May 05, 2022 at 03:09:59PM +0530, Athira Rajeev escreveu: > /proc/cpuinfo provides information about type of processor, number > of CPU's etc. Reading /proc/cpuinfo file outputs useful information > by field name like cpu, platform, model (depending on architecture) > and its value

Re: [PATCH] tools/perf/tests: Skip perf BPF test if clang is not present

2022-05-05 Thread Arnaldo Carvalho de Melo
Em Thu, May 05, 2022 at 03:30:39PM +0530, Athira Rajeev escreveu: > Perf BPF filter test fails in environment where "clang" > is not installed. > > Test failure logs: > > <<>> > 42: BPF filter: > 42.1: Basic BPF filtering : Skip > 42.2: BPF pinning

Re: [PATCH 0/3] perf tools: Tidy up symbol end fixup (v3)

2022-04-28 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 25, 2022 at 01:59:03PM -0700, Ian Rogers escreveu: > On Fri, Apr 15, 2022 at 5:40 PM Namhyung Kim wrote: > > > > Hello, > > > > This work is a follow-up of Ian's previous one at > > https://lore.kernel.org/all/20220412154817.2728324-1-irog...@google.com/ > > > > Fixing up more

Re: [PATCH V3 0/2] Fix perf bench numa to work with machines having #CPUs > 1K

2022-04-14 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 12, 2022 at 10:10:57PM +0530, Athira Rajeev escreveu: > The perf benchmark for collections: numa hits failure in system > configuration with CPU's more than 1024. These benchmarks uses > "sched_getaffinity" and "sched_setaffinity" in the code to > work with affinity. Thanks, applied.

Re: [PATCH v2 0/4] Fix perf bench numa, futex and epoll to work with machines having #CPUs > 1K

2022-04-09 Thread Arnaldo Carvalho de Melo
Em Sat, Apr 09, 2022 at 12:28:01PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Apr 06, 2022 at 11:21:09PM +0530, Athira Rajeev escreveu: > > The perf benchmark for collections: numa, futex and epoll > > hits failure in system configuration with CPU's more than 1024. >

Re: [PATCH v2 0/4] Fix perf bench numa, futex and epoll to work with machines having #CPUs > 1K

2022-04-09 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 06, 2022 at 11:21:09PM +0530, Athira Rajeev escreveu: > The perf benchmark for collections: numa, futex and epoll > hits failure in system configuration with CPU's more than 1024. > These benchmarks uses "sched_getaffinity" and "sched_setaffinity" > in the code to work with affinity.

Re: [PATCH v2 4/4] tools/perf: Fix perf bench numa testcase to check if CPU used to bind task is online

2022-04-09 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 06, 2022 at 11:21:13PM +0530, Athira Rajeev escreveu: > Perf numa bench test fails with error: > > Testcase: > ./perf bench numa mem -p 2 -t 1 -P 1024 -C 0,8 -M 1,0 -s 20 -zZq > --thp 1 --no-data_rand_walk > > Failure snippet: > <<>> > Running 'numa/mem' benchmark: > > # Running

Re: [PATCH V2 1/2] tools/perf: Include global and local variants for p_stage_cyc sort key

2022-01-06 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 06, 2022 at 04:21:05PM +0530, Athira Rajeev escreveu: > > > > On 08-Dec-2021, at 9:21 AM, Nageswara Sastry wrote: > > > > > > > > On 07/12/21 8:22 pm, Arnaldo Carvalho de Melo wrote: > >> Em Fri, Dec 03, 2021 at 07:50:37AM +0530, Athir

Re: [PATCH 4/4] powerpc/perf: Add data source encodings for power10 platform

2021-12-22 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 06, 2021 at 02:47:49PM +0530, Kajol Jain escreveu: > The code represent memory/cache level data based on PERF_MEM_LVL_* > namespace, which is in the process of deprication in the favour of > newer composite PERF_MEM_{LVLNUM_,REMOTE_,SNOOPX_,HOPS_} fields. > Add data source encodings to

Re: [PATCH 3/4] powerpc/perf: Add encodings to represent data based on newer composite PERF_MEM_LVLNUM* fields

2021-12-22 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 06, 2021 at 02:47:48PM +0530, Kajol Jain escreveu: > The code represent data coming from L1/L2/L3 cache hits based on > PERF_MEM_LVL_* namespace, which is in the process of deprecation in > the favour of newer composite PERF_MEM_{LVLNUM_,REMOTE_,SNOOPX_,HOPS_} > fields. Thanks,

Re: [PATCH 2/4] tools/perf: Add new macros for mem_hops field

2021-12-22 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 06, 2021 at 02:47:47PM +0530, Kajol Jain escreveu: > Add new macros for mem_hops field which can be used to > represent remote-node, socket and board level details. > > Currently the code had macro for HOPS_0 which, corresponds > to data coming from another core but same node. > Add

Re: [PATCH 0/4] perf: Add new macros for mem_hops field

2021-12-09 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 06, 2021 at 02:47:45PM +0530, Kajol Jain escreveu: > Patchset adds new macros for mem_hops field which can be > used to represent remote-node, socket and board level details. > > Currently the code had macro for HOPS_0, which corresponds > to data coming from another core but same

Re: [PATCH V2 1/2] tools/perf: Include global and local variants for p_stage_cyc sort key

2021-12-07 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 03, 2021 at 07:50:37AM +0530, Athira Rajeev escreveu: > Sort key p_stage_cyc is used to present the latency > cycles spend in pipeline stages. perf tool has local > p_stage_cyc sort key to display this info. There is no > global variant available for this sort key. local variant >

Re: [PATCH v3] perf vendor events power10: Add metric events json file for power10 platform

2021-11-11 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 08, 2021 at 08:47:02AM -0600, Paul A. Clarke escreveu: > On Mon, Nov 08, 2021 at 11:30:10AM +0530, Kajol Jain wrote: > > Add pmu metric json file for power10 platform. > > > > Signed-off-by: Kajol Jain > > --- > > Changelog > > v2 -> v3: > > - Did nit changes in BriefDescription as

Re: [V4 0/2] tools/perf: Add instruction and data address registers to extended regs in powerpc

2021-10-19 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 18, 2021 at 05:19:46PM +0530, Athira Rajeev escreveu: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding

  1   2   3   4   >