Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-25 Thread Christian Zigotzky
On 23 August 2022 at 03:50 am, Michael Ellerman wrote: Arminder Singh writes: This is the first time I'm interacting with the Linux mailing lists, so please don't eviscerate me *too much* if I get the formatting wrong. Of course I'm always willing to take criticism and improve my formatting in

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-25 Thread Arnd Bergmann
On Sat, Aug 20, 2022 at 9:45 PM Arminder Singh wrote: > > I also fixed a quick checkpatch warning on line 303. "i ++" is now "i++". In general, anything that is mentioned in the changelog as "also done this" is worth splitting into a separate patch, or dropping from the patch, to make reviewing

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-22 Thread Michael Ellerman
Arminder Singh writes: > This is the first time I'm interacting with the Linux mailing lists, so > please don't eviscerate me *too much* if I get the formatting wrong. > Of course I'm always willing to take criticism and improve my formatting > in the future. > > This patch adds support for

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-22 Thread Dan Carpenter
Hi Arminder, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arminder-Singh/i2c-pasemi-Add-IRQ-support-for-Apple-Silicon/20220821-034703 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-21 Thread Sven Peter
Hi, Thanks for the patch! Some additional comments: On Sat, Aug 20, 2022, at 21:45, Arminder Singh wrote: > This is the first time I'm interacting with the Linux mailing lists, so > please don't eviscerate me *too much* if I get the formatting wrong. > Of course I'm always willing to take

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-21 Thread Christophe Leroy
Le 20/08/2022 à 21:45, Arminder Singh a écrit : > This is the first time I'm interacting with the Linux mailing lists, so > please don't eviscerate me *too much* if I get the formatting wrong. > Of course I'm always willing to take criticism and improve my formatting > in the future. The above

[PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-20 Thread Arminder Singh
This is the first time I'm interacting with the Linux mailing lists, so please don't eviscerate me *too much* if I get the formatting wrong. Of course I'm always willing to take criticism and improve my formatting in the future. This patch adds support for IRQs to the PASemi I2C controller

Re: [PATCH] i2c: pasemi: Add IRQ support for Apple Silicon

2022-08-20 Thread kernel test robot
Hi Arminder, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on linus/master v6.0-rc1 next-20220819] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use