Re: [PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2020-11-20 Thread Fabio Estevam
Hi Michael, On Fri, Nov 20, 2020 at 3:25 AM Michael Ellerman wrote: > I'd rather not have to carry this in arch code just for one driver. Fair enough. > Can't the driver just use ioread/write32be() on all platforms? Yes, this is a better approach. I have just a patch doing that. Thanks

Re: [PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2020-11-19 Thread Michael Ellerman
Fabio Estevam writes: > From: Geert Uytterhoeven > > When compile-testing on m68k or microblaze: > > drivers/media/platform/fsl-viu.c:41:1: warning: "out_be32" redefined > drivers/media/platform/fsl-viu.c:42:1: warning: "in_be32" redefined > > Fix this by replacing the check for PowerPC

[PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2020-11-19 Thread Fabio Estevam
From: Geert Uytterhoeven When compile-testing on m68k or microblaze: drivers/media/platform/fsl-viu.c:41:1: warning: "out_be32" redefined drivers/media/platform/fsl-viu.c:42:1: warning: "in_be32" redefined Fix this by replacing the check for PowerPC by checks for the presence of

[PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2020-11-19 Thread Geert Uytterhoeven
When compile-testing on m68k/randconfig: drivers/media/platform/fsl-viu.c: In function 'viu_start_dma': drivers/media/platform/fsl-viu.c:253:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration] drivers/media/platform/fsl-viu.c: In function

Re: [PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2019-01-18 Thread Geert Uytterhoeven
Hi Hans, On Fri, Jan 18, 2019 at 11:08 AM Hans Verkuil wrote: > This patch is still in my patchwork todo list, and I wonder who will pick > this up, > especially the change to arch/powerpc/include/asm/io.h. I think the powerpc tree makes most sense. > Wouldn't it be easier to just fix this in

Re: [PATCH] media: fsl-viu: Use proper check for presence of {out,in}_be32()

2019-01-18 Thread Hans Verkuil
Hi Geert, This patch is still in my patchwork todo list, and I wonder who will pick this up, especially the change to arch/powerpc/include/asm/io.h. Wouldn't it be easier to just fix this in fsl-viu.c only by doing this: #ifndef CONFIG_PPC #ifndef out_be32 #define out_be32(v, a)

Re: [PATCH] media: fsl-viu: Use proper check for presence of {out,in}_be32()

2018-06-15 Thread Hans Verkuil
On 08/06/18 11:48, Geert Uytterhoeven wrote: > When compile-testing on m68k or microblaze: > > drivers/media/platform/fsl-viu.c:41:1: warning: "out_be32" redefined > drivers/media/platform/fsl-viu.c:42:1: warning: "in_be32" redefined > > Fix this by replacing the check for PowerPC by

[PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2018-06-08 Thread Geert Uytterhoeven
When compile-testing on m68k or microblaze: drivers/media/platform/fsl-viu.c:41:1: warning: "out_be32" redefined drivers/media/platform/fsl-viu.c:42:1: warning: "in_be32" redefined Fix this by replacing the check for PowerPC by checks for the presence of {out,in}_be32(). As PowerPC