Re: [PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread Allen
> > You need to adjust kdoc when you change functions: > > drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Function parameter or > member 't' not described in 'restart_ctrlq' > drivers/net/ethernet/chelsio/cxgb4/sge.c:2664: warning: Excess function > parameter 'data' description in

Re: [PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 13:54:20 +0530 Allen Pais wrote: > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-off-by: Romain Perier

[PATCH 06/20] ethernet: chelsio: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Allen Pais
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais ---