Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-29 Thread Nathan Lynch
Michael Ellerman writes: > Nathan Lynch writes: >> Nathan Lynch writes: >>> >>> aside: does anyone know if the display_status() code is worth keeping? >>> It looks like it is used to drive the 16-character wide physical LCD I >>> remember seeing on P4-era and older machines. Is it a vestige of

Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-29 Thread Michael Ellerman
Nathan Lynch writes: > Nathan Lynch writes: >> >> aside: does anyone know if the display_status() code is worth keeping? >> It looks like it is used to drive the 16-character wide physical LCD I >> remember seeing on P4-era and older machines. Is it a vestige of >> non-LPAR pseries that should

Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-23 Thread Nathan Lynch
Nathan Lynch writes: > > aside: does anyone know if the display_status() code is worth keeping? > It looks like it is used to drive the 16-character wide physical LCD I > remember seeing on P4-era and older machines. Is it a vestige of > non-LPAR pseries that should be dropped, or is it perhaps

Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-23 Thread Nathan Lynch
Andrew Donnellan writes: > On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote: >> From: Nathan Lynch >> >> Any caller of rtas_call_unlocked() must provide an rtas_args >> parameter >> block distinct from the core rtas_args buffer used by the rtas_call() >> path. It's an

Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-22 Thread Andrew Donnellan
On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > Any caller of rtas_call_unlocked() must provide an rtas_args > parameter > block distinct from the core rtas_args buffer used by the rtas_call() > path. It's an unlikely error to make, but the potential

[PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()

2023-03-06 Thread Nathan Lynch via B4 Relay
From: Nathan Lynch Any caller of rtas_call_unlocked() must provide an rtas_args parameter block distinct from the core rtas_args buffer used by the rtas_call() path. It's an unlikely error to make, but the potential consequences are grim, and it's trivial to check. Signed-off-by: Nathan Lynch