Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-10 Thread Shengjiu Wang
On Fri, Mar 8, 2024 at 10:04 PM Hans Verkuil wrote: > > On 08/03/2024 2:52 pm, Shengjiu Wang wrote: > > On Fri, Mar 8, 2024 at 8:06 PM Hans Verkuil wrote: > >> > >> On 08/03/2024 12:52 pm, Shengjiu Wang wrote: > >>> On Fri, Mar 8, 2024 at 3:34 PM Hans Verkuil wrote: > > Hi Shengjiu, >

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-08 Thread Hans Verkuil
On 08/03/2024 2:52 pm, Shengjiu Wang wrote: > On Fri, Mar 8, 2024 at 8:06 PM Hans Verkuil wrote: >> >> On 08/03/2024 12:52 pm, Shengjiu Wang wrote: >>> On Fri, Mar 8, 2024 at 3:34 PM Hans Verkuil wrote: Hi Shengjiu, After thinking it over I think this patch can be improved:

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-08 Thread Shengjiu Wang
On Fri, Mar 8, 2024 at 8:06 PM Hans Verkuil wrote: > > On 08/03/2024 12:52 pm, Shengjiu Wang wrote: > > On Fri, Mar 8, 2024 at 3:34 PM Hans Verkuil wrote: > >> > >> Hi Shengjiu, > >> > >> After thinking it over I think this patch can be improved: > >> > >> On 26/02/2024 9:28 am, Shengjiu Wang

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-08 Thread Hans Verkuil
On 08/03/2024 12:52 pm, Shengjiu Wang wrote: > On Fri, Mar 8, 2024 at 3:34 PM Hans Verkuil wrote: >> >> Hi Shengjiu, >> >> After thinking it over I think this patch can be improved: >> >> On 26/02/2024 9:28 am, Shengjiu Wang wrote: >>> The audio sample format definition is from alsa, >>> the

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-08 Thread Shengjiu Wang
On Fri, Mar 8, 2024 at 3:34 PM Hans Verkuil wrote: > > Hi Shengjiu, > > After thinking it over I think this patch can be improved: > > On 26/02/2024 9:28 am, Shengjiu Wang wrote: > > The audio sample format definition is from alsa, > > the header file is include/uapi/sound/asound.h, but > > don't

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-03-07 Thread Hans Verkuil
Hi Shengjiu, After thinking it over I think this patch can be improved: On 26/02/2024 9:28 am, Shengjiu Wang wrote: > The audio sample format definition is from alsa, > the header file is include/uapi/sound/asound.h, but > don't include this header file directly, because in > user space, there

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-02-27 Thread Hans Verkuil
On 27/02/2024 04:44, Shengjiu Wang wrote: > On Mon, Feb 26, 2024 at 9:55 PM Nicolas Dufresne wrote: >> >> Le lundi 26 février 2024 à 16:28 +0800, Shengjiu Wang a écrit : >>> The audio sample format definition is from alsa, >>> the header file is include/uapi/sound/asound.h, but >>> don't include

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-02-26 Thread Shengjiu Wang
On Mon, Feb 26, 2024 at 9:55 PM Nicolas Dufresne wrote: > > Le lundi 26 février 2024 à 16:28 +0800, Shengjiu Wang a écrit : > > The audio sample format definition is from alsa, > > the header file is include/uapi/sound/asound.h, but > > don't include this header file directly, because in > > user

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-02-26 Thread Shengjiu Wang
On Mon, Feb 26, 2024 at 9:55 PM Nicolas Dufresne wrote: > > Le lundi 26 février 2024 à 16:28 +0800, Shengjiu Wang a écrit : > > The audio sample format definition is from alsa, > > the header file is include/uapi/sound/asound.h, but > > don't include this header file directly, because in > > user

Re: [PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-02-26 Thread Nicolas Dufresne
Le lundi 26 février 2024 à 16:28 +0800, Shengjiu Wang a écrit : > The audio sample format definition is from alsa, > the header file is include/uapi/sound/asound.h, but > don't include this header file directly, because in > user space, there is another copy in alsa-lib. > There will be conflict

[PATCH v13 09/16] media: uapi: Define audio sample format fourcc type

2024-02-26 Thread Shengjiu Wang
The audio sample format definition is from alsa, the header file is include/uapi/sound/asound.h, but don't include this header file directly, because in user space, there is another copy in alsa-lib. There will be conflict in userspace for include videodev2.h & asound.h and asoundlib.h Here still