Re: [RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-22 Thread Shengjiu Wang
On Wed, Sep 20, 2023 at 6:12 PM Hans Verkuil wrote: > > Hi Shengjiu, > > I just noticed you posted a v4, but I expect that my comments below are still > valid... > > On 14/09/2023 07:54, Shengjiu Wang wrote: > > Audio signal processing has the requirement for memory to > > memory similar as

Re: [RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-20 Thread Hans Verkuil
Hi Shengjiu, I just noticed you posted a v4, but I expect that my comments below are still valid... On 14/09/2023 07:54, Shengjiu Wang wrote: > Audio signal processing has the requirement for memory to > memory similar as Video. > > This patch is to add this support in v4l2 framework, defined

Re: [RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-19 Thread Sakari Ailus
Hi Shengjiu, On Tue, Sep 19, 2023 at 06:31:09PM +0800, Shengjiu Wang wrote: ... > > > +* > > > +V4L2_AUDIO_FMT_LPCM ('LPCM') > > > +* Something to fix here, too...? > > > + > > > +Linear Pulse-Code Modulation (LPCM) > > > + > > > + > > >

Re: [RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-19 Thread Shengjiu Wang
On Thu, Sep 14, 2023 at 6:17 PM Sakari Ailus wrote: > > Hi Shenjiu, > > Thanks for the update. > > On Thu, Sep 14, 2023 at 01:54:02PM +0800, Shengjiu Wang wrote: > > Audio signal processing has the requirement for memory to > > memory similar as Video. > > > > This patch is to add this support in

Re: [RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-14 Thread Sakari Ailus
Hi Shenjiu, Thanks for the update. On Thu, Sep 14, 2023 at 01:54:02PM +0800, Shengjiu Wang wrote: > Audio signal processing has the requirement for memory to > memory similar as Video. > > This patch is to add this support in v4l2 framework, defined > new buffer type V4L2_BUF_TYPE_AUDIO_CAPTURE

[RFC PATCH v3 6/9] media: v4l2: Add audio capture and output support

2023-09-14 Thread Shengjiu Wang
Audio signal processing has the requirement for memory to memory similar as Video. This patch is to add this support in v4l2 framework, defined new buffer type V4L2_BUF_TYPE_AUDIO_CAPTURE and V4L2_BUF_TYPE_AUDIO_OUTPUT, defined new format v4l2_audio_format for audio case usage. Defined