Hi Roland! > I applied this, but I agree with checkpatch.pl: > > > WARNING: externs should be avoided in .c files > > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67: > > +extern int ehca_mr_largepage; > > > > WARNING: externs should be avoided in .c files > > #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753: > > + extern int ehca_debug_level; > > if you need to use a variable in more than one .c file, put the extern > declaration in a common header that's included everywhere you use the > variable, including the .c file that it is defined in. That way the > compiler can see if you get confused about the type of the variable. That's true. > When you get a chance, please post a follow-on patch to fix this. Sure thing. Will do that for rc2. Thanks! Nam
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
