Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-13 Thread Christian Zigotzky
On 09 October 2021 at 03:57 pm, Christian Zigotzky wrote: > On 09 October 2021 at 12:10 pm, Wolfram Sang wrote: >>> I still don't have access to any old PASemi hardware but the changes from >>> v1 are pretty small and I expect them to still work. Would still be nice >>> if someone with access

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Hector Martin
On 11/10/2021 17.54, Wolfram Sang wrote: MAINTAINERS. It'll probably apply cleanly to 5.15-rc5 but if that happens again It doesn't because Linus' git doesn't have: Documentation/devicetree/bindings/pci/apple,pcie.yaml Because MAINTAINER dependencies can be a bit nasty, I suggest I drop the

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
On Fri, Oct 08, 2021 at 06:35:21PM +0200, Sven Peter wrote: > Hi, > > v1: > https://lore.kernel.org/linux-i2c/20210926095847.38261-1-s...@svenpeter.dev/ > > Changes for v2: > - Added reviewed-by/acks > - Switched from ioport_map to pci_iomap as suggested by Arnd Bergmann > - Renamed

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
> > Because MAINTAINER dependencies can be a bit nasty, I suggest I drop the > > MAINTAINER additions for now and we add them later. Then, you can add > > the pasemi-core as well. D'accord? > > > > We can just split the MAINTAINERS changes into a separate patch and I can > push that one through

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-11 Thread Wolfram Sang
> MAINTAINERS. It'll probably apply cleanly to 5.15-rc5 but if that happens > again It doesn't because Linus' git doesn't have: Documentation/devicetree/bindings/pci/apple,pcie.yaml Because MAINTAINER dependencies can be a bit nasty, I suggest I drop the MAINTAINER additions for now and we add

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-10 Thread Sven Peter
On Sat, Oct 9, 2021, at 15:57, Christian Zigotzky wrote: > On 09 October 2021 at 12:10 pm, Wolfram Sang wrote: >>> I still don't have access to any old PASemi hardware but the changes from >>> v1 are pretty small and I expect them to still work. Would still be nice >>> if someone with access to

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-09 Thread Sven Peter
On Sat, Oct 9, 2021, at 12:10, Wolfram Sang wrote: >> I still don't have access to any old PASemi hardware but the changes from >> v1 are pretty small and I expect them to still work. Would still be nice >> if someone with access to such hardware could give this a quick test. > > Looks good to me.

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-09 Thread Christian Zigotzky
On 09 October 2021 at 12:10 pm, Wolfram Sang wrote: I still don't have access to any old PASemi hardware but the changes from v1 are pretty small and I expect them to still work. Would still be nice if someone with access to such hardware could give this a quick test. Looks good to me. I will

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-09 Thread Wolfram Sang
> I still don't have access to any old PASemi hardware but the changes from > v1 are pretty small and I expect them to still work. Would still be nice > if someone with access to such hardware could give this a quick test. Looks good to me. I will wait a few more days so that people can report

Re: Add Apple M1 support to PASemi i2c driver

2021-10-09 Thread Christian Zigotzky
Olof, Thank you for the hint. I think I have found them. Link: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=266104 Mbox: https://patchwork.ozlabs.org/series/266104/mbox/ $ wget -O mbox https://patchwork.ozlabs.org/series/266104/mbox/ $ git am mbox Thanks, Christian On 8.

Re: [PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-08 Thread Olof Johansson
Hi, On Fri, Oct 8, 2021 at 9:36 AM Sven Peter wrote: > > Hi, > > v1: > https://lore.kernel.org/linux-i2c/20210926095847.38261-1-s...@svenpeter.dev/ > > Changes for v2: > - Added reviewed-by/acks > - Switched from ioport_map to pci_iomap as suggested by Arnd Bergmann > - Renamed

Re: Add Apple M1 support to PASemi i2c driver

2021-10-08 Thread Olof Johansson
Christian, Self-service available on lore: https://lore.kernel.org/all/20211008163532.75569-1-s...@svenpeter.dev/ There are links on there to download a whole thread as an mbox if needed. -Olof On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky wrote: > > Hi Michael, > > Do you have a mbox

[PATCH v2 00/11] Add Apple M1 support to PASemi i2c driver

2021-10-08 Thread Sven Peter
Hi, v1: https://lore.kernel.org/linux-i2c/20210926095847.38261-1-s...@svenpeter.dev/ Changes for v2: - Added reviewed-by/acks - Switched from ioport_map to pci_iomap as suggested by Arnd Bergmann - Renamed i2c-pasemi-apple.c to i2c-pasemi-platform.c as suggested by Wolfram Sang - Replaced

Re: Add Apple M1 support to PASemi i2c driver

2021-10-08 Thread Christian Zigotzky
Hi Michael, Do you have a mbox link for the v2 changes? I would like to test them on my AmigaOne X1000. Thanks, Christian On 27. Sep 2021, at 09:58, Michael Ellerman wrote: Christian, the whole series is downloadable as a single mbox here: https://patchwork.ozlabs.org/series/264134/mbox/

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Christian Zigotzky
> On 3. Oct 2021, at 16:36, Sven Peter wrote: > > Hi, > > >> On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote: >>> On 27 September 2021 at 07:39 am, Sven Peter wrote: >>> Hi Christian, >>> >>> Thanks already for volunteering to test this! >>> >> Hello Sven, >> >> Damien (Hypex)

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Arnd Bergmann
On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang wrote: > > > > i2c-8 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > > adapter > > i2c-9 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > > adapter > > i2c-10i2c PA Semi SMBus adapter at

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Sven Peter
On Mon, Oct 4, 2021, at 13:20, Arnd Bergmann wrote: > On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang wrote: >> >> >> > i2c-8 i2c PA Semi SMBus adapter at 0x(ptrval) I2C >> > adapter >> > i2c-9 i2c PA Semi SMBus adapter at 0x(ptrval) I2C >> >

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Wolfram Sang
> i2c-8 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > adapter > i2c-9 i2c PA Semi SMBus adapter at 0x(ptrval) I2C > adapter > i2c-10i2c PA Semi SMBus adapter at 0x(ptrval) > I2C adapter As Sven correctly switched

Re: Add Apple M1 support to PASemi i2c driver

2021-10-04 Thread Christian Zigotzky
Hi Sven, Unfortunately Damien has found an issue. [1] Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications: 2c-0i2c Radeon i2c bit bus 0x90 I2C adapter i2c-1 i2c Radeon i2c bit bus 0x91 I2C adapter

Re: Add Apple M1 support to PASemi i2c driver

2021-10-03 Thread Sven Peter
Hi, On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote: > On 27 September 2021 at 07:39 am, Sven Peter wrote: > > Hi Christian, > > > > Thanks already for volunteering to test this! > > > Hello Sven, > > Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your > modified

Re: Add Apple M1 support to PASemi i2c driver

2021-10-03 Thread Christian Zigotzky
On 03 October 2021 at 04:36 pm, Sven Peter wrote: > Hi, > > > On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote: >> On 27 September 2021 at 07:39 am, Sven Peter wrote: >>  > Hi Christian, >>  > >>  > Thanks already for volunteering to test this! >>  > >> Hello Sven, >> >> Damian (Hypex) has

Re: Add Apple M1 support to PASemi i2c driver

2021-09-30 Thread Christian Zigotzky
Typo: Damian Correct: Damien On 01 October 2021 at 06:47 am, Christian Zigotzky wrote: On 27 September 2021 at 07:39 am, Sven Peter wrote: > Hi Christian, > > Thanks already for volunteering to test this! > Hello Sven, Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your

Re: Add Apple M1 support to PASemi i2c driver

2021-09-30 Thread Christian Zigotzky
On 27 September 2021 at 07:39 am, Sven Peter wrote: > Hi Christian, > > Thanks already for volunteering to test this! > Hello Sven, Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your modified i2c driver on his Nemo board yesterday. [1] @Darren Could you also please check

Re: [PATCH 00/10] Add Apple M1 support to PASemi i2c driver

2021-09-29 Thread Wolfram Sang
> This looks all very good to me, I had one very minor comment. > > Whole series > > Reviewed-by: Arnd Bergmann Thanks for the series and the review! Same here, looks good to me and I only had one minor comment. signature.asc Description: PGP signature

Re: Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Christian Zigotzky
On 27 September 2021 at 09:58 am, Michael Ellerman wrote: Wolfram Sang writes: Sure, will do that later as well! But please do it privately. For upstreaming, the patch series you sent is way better than a single patch. Christian, the whole series is downloadable as a single mbox here:

Re: Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Sven Peter
Hi Christian, Thanks already for volunteering to test this! On Sun, Sep 26, 2021, at 22:27, Christian Zigotzky wrote: > Hi Sven, > > I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own > file). [1] That's strange because it should apply cleanly. I'll double check after to work

Re: Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Michael Ellerman
Wolfram Sang writes: >> Sure, will do that later as well! > > But please do it privately. For upstreaming, the patch series you sent > is way better than a single patch. Christian, the whole series is downloadable as a single mbox here: https://patchwork.ozlabs.org/series/264134/mbox/ Save

Re: [PATCH 00/10] Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Arnd Bergmann
On Sun, Sep 26, 2021 at 12:00 PM Sven Peter wrote: > > This series adds support for the I2C controller found on Apple Silicon Macs > which has quite a bit of history: > > Apple bought P.A. Semi in 2008 and it looks like a part of its legacy > continues > to live on in the M1. This controller has

Re: Add Apple M1 support to PASemi i2c driver

2021-09-27 Thread Wolfram Sang
> Sure, will do that later as well! But please do it privately. For upstreaming, the patch series you sent is way better than a single patch. signature.asc Description: PGP signature

Re: Add Apple M1 support to PASemi i2c driver

2021-09-26 Thread Christian Zigotzky
Hi Sven, I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own file). [1] Error message: patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from a/drivers/i2c/busses/i2c-pasemi.c) Hunk #3 FAILED at 344. 1 out of 3 hunks FAILED -- saving rejects to file

[PATCH 00/10] Add Apple M1 support to PASemi i2c driver

2021-09-26 Thread Sven Peter
Hi, This series adds support for the I2C controller found on Apple Silicon Macs which has quite a bit of history: Apple bought P.A. Semi in 2008 and it looks like a part of its legacy continues to live on in the M1. This controller has actually been used since at least the iPhone 4S and hasn't

Add Apple M1 support to PASemi i2c driver

2021-09-26 Thread Christian Zigotzky
Hi Sven, Thanks a lot for your nice explanation of the history of the PASemi i2c driver. We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M CPUs (A-EON AmigaOne X1000). [1] The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2] Could you please post