Re: [PATCH v5 04/15] sparc: simplify module_alloc()

2024-04-23 Thread Sam Ravnborg
, MODULES_VADDR, MODULES_END, ...) > > as with the new defines the allocations becames identical for both 32 > and 64 bits. > > While on it, drop unsed include of > > Suggested-by: Sam Ravnborg > Signed-off-by: Mike Rapoport (IBM) Looks good. Reviewed-by: Sam Ravnborg

Re: [PATCH v4 06/15] mm/execmem, arch: convert simple overrides of module_alloc to execmem

2024-04-11 Thread Sam Ravnborg
Hi Mike. On Thu, Apr 11, 2024 at 07:00:42PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Several architectures override module_alloc() only to define address > range for code allocations different than VMALLOC address space. > > Provide a generic implementation in execmem that

Re: [PATCH v2 3/3] arch: Rename fbdev header and source files

2024-03-28 Thread Sam Ravnborg
Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: "David S. Miller" > Cc: Andreas Larsson > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x...@kernel.org > Cc: "H. Peter Anvin" If the patch is

Re: [PATCH v2 1/3] arch: Select fbdev helpers with CONFIG_VIDEO

2024-03-28 Thread Sam Ravnborg
by: Thomas Zimmermann > Cc: "James E.J. Bottomley" > Cc: Helge Deller > Cc: "David S. Miller" > Cc: Andreas Larsson > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x...@kernel.org > Cc: "H. Peter Anvin" Reviewed-by: Sam Ravnborg

Re: [PATCH v2 2/3] arch: Remove struct fb_info from video helpers

2024-03-28 Thread Sam Ravnborg
olnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x...@kernel.org > Cc: "H. Peter Anvin" Reviewed-by: Sam Ravnborg

Re: [PATCH 09/22] [v2] arch: fix asm-offsets.c building with -Wmissing-prototypes

2023-11-08 Thread Sam Ravnborg
ooks good. I sometimes looks at sparc patches so I looked at this one. Reviewed-by: Sam Ravnborg

Re: [PATCH 4/9] sparc: Remove

2023-08-17 Thread Sam Ravnborg
On Thu, Aug 17, 2023 at 06:07:35PM +0200, Geert Uytterhoeven wrote: > As of commit b7fb14d3ac63117e ("ide: remove the legacy ide driver") in > v5.14, there are no more generic users of . > > Signed-off-by: Geert Uytterhoeven Acked-by: Sam Ravnborg

Re: [PATCH] fbdev/ps3fb: Build without kernel device

2023-07-31 Thread Sam Ravnborg
; > Reported-by: Randy Dunlap > Closes: > https://lore.kernel.org/lkml/ccc63065-2976-88ef-1211-731330bf2...@infradead.org/ > Signed-off-by: Thomas Zimmermann > Fixes: 701d2054fa31 ("fbdev: Make support for userspace interfaces > configurable") > Cc: Mic

Re: [PATCH] powerpc: Use shared font data

2023-07-25 Thread Sam Ravnborg
a boot without FS in qemu. > > Signed-off-by: Dr. David Alan Gilbert Yep, looks very similar to sparc, so Reviewed-by: Sam Ravnborg

Re: [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags

2023-07-11 Thread Sam Ravnborg
Hi Thomas, On Tue, Jul 11, 2023 at 08:24:40AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 10.07.23 um 19:19 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote: > > > Remove the unused flags FB

Re: [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags

2023-07-10 Thread Sam Ravnborg
Hi Thomas, On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote: > Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from > fbdev and drivers, as briefly discussed at [1]. Both flags were maybe > useful when fbdev had special handling for driver modules. With > commit

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-03-19 Thread Sam Ravnborg
On Sun, Mar 19, 2023 at 02:44:08PM +0100, Stephen Kitt wrote: > Hi, > > On Mon, 09 Jan 2023 11:12:02 +0100, Robin van der Gracht > wrote: > > On 2023-01-08 10:29, Sam Ravnborg wrote: > > > On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: > > >

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-26 Thread Sam Ravnborg
Hi Lee, On Thu, Jan 26, 2023 at 02:27:26PM +, Lee Jones wrote: > On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > > > From: Sam Ravnborg > > > > With all users gone remove the deprecated fb_blank member in > > backlight_properties. > &

Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-09 Thread Sam Ravnborg
Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +, Christophe Leroy wrote: > > > Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-09 Thread Sam Ravnborg
Hi Daniel. On Mon, Jan 09, 2023 at 11:06:35AM +, Daniel Thompson wrote: > On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission > Endpoint wrote: > > From: Sam Ravnborg > > > > With all users gone remove the deprecated fb_blank member in

Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-08 Thread Sam Ravnborg
Hi Stephen, On Sun, Jan 08, 2023 at 08:28:17PM +0100, Stephen Kitt wrote: > On Sat, 07 Jan 2023 19:26:23 +0100, Sam Ravnborg via B4 Submission Endpoint > wrote: > > > From: Sam Ravnborg > > > > Avoiding direct access to backlight_properties.props. > &

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Sam Ravnborg
Hi Helge, > > > > Helge - could you pick the reviewed patches from: > > https://lore.kernel.org/all/20220607192335.1137249-1-st...@sk2.org/ > > [This is the same mail as Stephen refer to above - looked up via lore]. > > I just pulled those 7 patches into fbdev/for-next. > If you need more,

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Sam Ravnborg
Hi Stephen. > Here are my pending patches from last June on lore: > All patches are handled I think except this: > * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/ Can I ask you to drop the assignment that is not needed, and resend with the collected acks/r-b. With

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-01-08 Thread Sam Ravnborg
Hi Robin. On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: > On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint > wrote: > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties.

[PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Avoiding direct access to backlight_properties.props. Access to the deprecated props.fb_blank replaced by backlight_is_blank(). Access to props.power is dropped - it was only used for debug. Signed-off-by: Sam Ravnborg Cc: Thomas Zimmermann Cc: Andy Shevchenko Cc: Javier

[PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg With all users gone remove the deprecated fb_blank member in backlight_properties. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 2 -- include/linux/backlight.h | 22

[PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Robin van der Gracht Cc: Miguel Ojeda Cc: Geert Uytterhoeven --- drivers/auxdisplay/ht16k33.c | 7 +-- 1 file changed, 1 insertion

[PATCH 13/15] backlight: omap1: Use backlight helpers

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Rework backlight handling to avoid access to the deprecated backlight_properties.fb_blank member. The rework includes removal of get_brightness() operation, because there was no read back from HW so no use for it. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel

[PATCH 14/15] backlight: tosa: Use backlight helper

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
-off-by: Sam Ravnborg --- drivers/video/backlight/tosa_bl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video/backlight/tosa_bl.c b/drivers/video/backlight/tosa_bl.c index f55b3d616a87..cb07f13dd886 100644 --- a/drivers/video/backlight/tosa_bl.c +++ b/drivers

[PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Benjamin Herrenschmidt Cc: Sam Ravnborg Cc: linuxppc-dev@lists.ozlabs.org --- drivers/macintosh/via-pmu-backlight.c | 7 +-- 1 file

[PATCH 08/15] video: fbdev: omap2: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Allison Randal Cc: Sam Ravnborg Cc: Greg Kroah-Hartman Cc: Kate Stewart Cc: Thomas Gleixner Cc: Enrico Weigelt Cc: Alexios Zavras

[PATCH 06/15] video: fbdev: aty128fb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Paul Mackerras Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/aty/aty128fb.c | 11 ++- 1 file changed, 2 insertions

[PATCH 03/15] video: fbdev: nvidia: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/nvidia/nv_backlight.c | 8 +--- 1 file changed, 1 insertion

[PATCH 00/15] backlight: Drop use of deprecated fb_blank property

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
: linuxppc-dev@lists.ozlabs.org Cc: Stephen Kitt Signed-off-by: Sam Ravnborg --- Sam Ravnborg (14): video: fbdev: atmel_lcdfb: Rework backlight handling video: fbdev: atyfb: Introduce backlight_get_brightness() video: fbdev: nvidia: Introduce backlight_get_brightness() video

[PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg The atmel_lcdfb had code to save/restore power state. This is not needed so drop it. Introduce backlight_is_brightness() to make logic simpler. Signed-off-by: Sam Ravnborg Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-fb...@vger.kernel.org Cc

[PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Souptick Joarder Cc: Maarten Lankhorst Cc: Jason Yan Cc: Jani Nikula

[PATCH 07/15] video: fbdev: mx3fb: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Kate Stewart Cc: Thomas Gleixner Cc: Laurent Pinchart Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Jani Nikula

[PATCH 04/15] video: fbdev: radeon: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Benjamin Herrenschmidt Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/aty/radeon_backlight.c | 10 +++--- 1 file changed, 3

[PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Avoiding direct access to backlight_properties.props. Access to the deprecated props.fb_blank replaced by backlight_is_blank(). Access to props.power is dropped - it was only used for debug. Signed-off-by: Sam Ravnborg Cc: Stephen Kitt Cc: Greg Kroah-Hartman Cc: Daniel

[PATCH 05/15] video: fbdev: riva: Introduce backlight_get_brightness()

2023-01-07 Thread Sam Ravnborg via B4 Submission Endpoint
From: Sam Ravnborg Introduce backlight_get_brightness() to simplify logic and avoid direct access to backlight properties. Signed-off-by: Sam Ravnborg Cc: Antonino Daplas Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/riva/fbdev.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Sam Ravnborg
Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint > wrote: > >From: Sam Ravnborg > > > >The atmel_lcdfb had code to save/restore power state. > >This is not neede

Re: [PATCH V5 04/26] sparc/mm: Move protection_map[] inside the platform

2022-06-27 Thread Sam Ravnborg
t page *page) > __flush_page_to_ram(vaddr); > } > EXPORT_SYMBOL(sparc_flush_page_to_ram); > + > +static pgprot_t protection_map[16] __ro_after_init = { This can be const - like done for powerpc and others. sparc32 and sparc64 uses each their own - and I do

Re: [PATCH v2 15/18] sparc64: remove CONFIG_SET_FS support

2022-02-16 Thread Sam Ravnborg
Hi Arnd. On Wed, Feb 16, 2022 at 02:13:29PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > sparc64 uses address space identifiers to differentiate between kernel > and user space, using ASI_P for kernel threads but ASI_AIUS for normal > user space, with the option of changing between

Re: [PATCH v2 18/18] uaccess: drop maining CONFIG_SET_FS users

2022-02-16 Thread Sam Ravnborg
read(unsigned long clone_flags, unsigned long > sp, unsigned long arg, > } > memcpy(new_stack, (char *)regs - STACKFRAME_SZ, STACKFRAME_SZ + > TRACEREG_SZ); > childregs->u_regs[UREG_FP] = sp; > - p->thread.current_ds = USER_DS; > ti->kpc = (((unsigned long) ret_from_fork) - 0x8); > ti->kpsr = current->thread.fork_kpsr | PSR_PIL; > ti->kwim = current->thread.fork_kwim; Other than the above the sparc32 changes looks fine, and with the Kconf stuff fixed: Acked-by: Sam Ravnborg # for sparc32 changes

Re: [PATCH v2 15/18] sparc64: remove CONFIG_SET_FS support

2022-02-16 Thread Sam Ravnborg
Hi Arnd, On Wed, Feb 16, 2022 at 07:34:59PM +0100, Sam Ravnborg wrote: > Hi Arnd. > > On Wed, Feb 16, 2022 at 02:13:29PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > sparc64 uses address space identifiers to differentiate between kernel > > and u

Re: [PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-17 Thread Sam Ravnborg
Hi Nikita, How about adding the following to tlb.h: #ifndef __tlb_remove_tables static void __tlb_remove_tables(...) { } #endif And then the few archs that want to override __tlb_remove_tables needs to do a #define __tlb_remove_tables __tlb_remove_tables static void

Re: [PATCH] agp: define proper stubs for empty helpers

2021-09-20 Thread Sam Ravnborg
e': > drivers/char/agp/generic.c:1265:28: error: suggest braces around empty body > in an 'if' statement [-Werror=empty-body] > 1265 | unmap_page_from_agp(page); > > Change the definitions to a 'do { } while (0)' construct to > make these more reliable. > > Signed-off-by:

Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option

2020-11-30 Thread Sam Ravnborg
Hi Krzysztof, On Mon, Nov 30, 2020 at 10:25:01PM +0200, Krzysztof Kozlowski wrote: > On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote: > > On Mon, Nov 30, 2020 at 03:21:32PM +, Andrey Zhizhikin wrote: > > > Since the removal of generic_bl driver from the sou

Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option

2020-11-30 Thread Sam Ravnborg
nfig / make savedefconfig / cp defconfig ... run now and then - this will remove all such symbols. If the patches goes in like they are submitted then: Acked-by: Sam Ravnborg > > arch/arm/configs/at91_dt_defconfig | 1 - > arch/arm/configs/cm_x300_defconfig | 1 - > arch/

Re: [PATCH] kbuild: reuse vmlinux.o in vmlinux_link

2020-05-23 Thread Sam Ravnborg
Hi Masahiro. On Sun, May 24, 2020 at 12:12:35AM +0900, Masahiro Yamada wrote: > Hi Nicholas, > (+CC: Sam Ravnborg) > > > On Sat, May 23, 2020 at 7:06 PM Nicholas Piggin wrote: > > > > Excerpts from Masahiro Yamada's message of May 23, 2020 3:44 am:

Re: [PATCH v2 5/6] arch: simplify several early memory allocations

2018-12-06 Thread Sam Ravnborg
On Mon, Dec 03, 2018 at 06:49:21PM +0200, Mike Rapoport wrote: > On Mon, Dec 03, 2018 at 05:29:08PM +0100, Sam Ravnborg wrote: > > Hi Mike. > > > > > index c37955d..2a17665 100644 > > > --- a/arch/sparc/kernel/prom_64.c > > > +++ b/arch/spa

Re: [PATCH v2 5/6] arch: simplify several early memory allocations

2018-12-03 Thread Sam Ravnborg
Hi Mike. > index c37955d..2a17665 100644 > --- a/arch/sparc/kernel/prom_64.c > +++ b/arch/sparc/kernel/prom_64.c > @@ -34,16 +34,13 @@ > > void * __init prom_early_alloc(unsigned long size) > { > - unsigned long paddr = memblock_phys_alloc(size, SMP_CACHE_BYTES); > - void *ret; > +

Re: [PATCH v2 3/6] sh: prefer memblock APIs returning virtual address

2018-12-03 Thread Sam Ravnborg
Hi Mike. On Mon, Dec 03, 2018 at 05:47:12PM +0200, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. > > There is a small

Re: [PATCH 00/25] Change tty_port(standard)_install's return type

2018-09-03 Thread Sam Ravnborg
Hi Jaejoong. > Change return type for tty functions. Patch No.01 > tty: Change return type to void Adding this patch first will generate a lot of warnings until all users are updated. It is usual practice to prepare all users and then apply the infrastructure changes as the last patch. Then

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

2018-02-18 Thread Sam Ravnborg
Hi Masahiro. On Sat, Feb 17, 2018 at 03:38:28AM +0900, Masahiro Yamada wrote: > I brushed up the implementation in this version. > > In the previous RFC, CC_HAS_ was described by using 'option shell=', > like this: > > config CC_HAS_STACKPROTECTOR > bool > option shell="$CC

Re: [PATCH v5 1/8] arch: enable relative relocations for arm64, power, x86, s390 and x86

2017-12-25 Thread Sam Ravnborg
Hi Ard. On Mon, Dec 25, 2017 at 08:54:33PM +, Ard Biesheuvel wrote: > Before updating certain subsystems to use place relative 32-bit > relocations in special sections, to save space and reduce the > number of absolute relocations that need to be processed at runtime > by relocatable

Re: [v5 09/15] sparc64: optimized struct page zeroing

2017-08-03 Thread Sam Ravnborg
Hi Pavel. On Thu, Aug 03, 2017 at 05:23:47PM -0400, Pavel Tatashin wrote: > Add an optimized mm_zero_struct_page(), so struct page's are zeroed without > calling memset(). We do eight regular stores, thus avoid cost of membar. The commit message does no longer reflect the implementation, and

Re: [PATCH 2/5] kbuild: allow archs to select build for link dead code/data elimination

2016-08-07 Thread Sam Ravnborg
On Mon, Aug 08, 2016 at 01:29:03PM +1000, Nicholas Piggin wrote: > On Sat, 6 Aug 2016 22:14:23 +0200 > Sam Ravnborg <s...@ravnborg.org> wrote: > > > On Fri, Aug 05, 2016 at 10:12:00PM +1000, Nicholas Piggin wrote: > > > Introduce LINKER_DCE option for archit

Re: [PATCH 1/5] kbuild: allow architectures to use thin archives instead of ld -r

2016-08-07 Thread Sam Ravnborg
On Mon, Aug 08, 2016 at 01:19:41PM +1000, Nicholas Piggin wrote: > On Sun, 7 Aug 2016 16:40:54 +0200 > Sam Ravnborg <s...@ravnborg.org> wrote: > > > On Sun, Aug 07, 2016 at 11:49:46AM +1000, Stephen Rothwell wrote: > > > Hi Sam, > > > > > > O

Re: [PATCH 1/5] kbuild: allow architectures to use thin archives instead of ld -r

2016-08-07 Thread Sam Ravnborg
On Sun, Aug 07, 2016 at 11:49:46AM +1000, Stephen Rothwell wrote: > Hi Sam, > > On Sat, 6 Aug 2016 22:10:45 +0200 Sam Ravnborg <s...@ravnborg.org> wrote: > > > > Did you by any chance evalue the use of INPUT in linker files. > > Stephen back then (again

Re: [PATCH 1/5] kbuild: allow architectures to use thin archives instead of ld -r

2016-08-06 Thread Sam Ravnborg
Hi Nicholas. On Fri, Aug 05, 2016 at 10:11:59PM +1000, Nicholas Piggin wrote: > From: Stephen Rothwell > > ld -r is an incremental link used to create built-in.o files in build > subdirectories. It produces relocatable object files containing all > its input files, and

Re: [PATCH 2/5] kbuild: allow archs to select build for link dead code/data elimination

2016-08-06 Thread Sam Ravnborg
On Fri, Aug 05, 2016 at 10:12:00PM +1000, Nicholas Piggin wrote: > Introduce LINKER_DCE option for architectures to select if they want > to build with -ffunction-sections, -fdata-sections, and link with > --gc-sections. Can you please try to come up with a less cryptic name. "DCE" may make sense

Re: [PATCH 3/5] kbuild: add arch specific post-module-link pass

2016-08-06 Thread Sam Ravnborg
On Fri, Aug 05, 2016 at 10:12:01PM +1000, Nicholas Piggin wrote: > Add an option for architectures to pass over modules after they are > linked. powerpc will use this to fix up alternate instruction patch > relocations. > > Signed-off-by: Nicholas Piggin > --- >

Re: Build regressions/improvements in v3.16-rc1

2014-06-17 Thread Sam Ravnborg
+ /scratch/kisskb/src/include/asm-generic/atomic-long.h: error: implicit declaration of function 'atomic_add' [-Werror=implicit-function-declaration]: = 176:2 + /scratch/kisskb/src/include/asm-generic/atomic-long.h: error: implicit declaration of function 'atomic_add_negative'

Re: [PATCH v5 00/27] irq_domain generalization and rework

2012-02-17 Thread Sam Ravnborg
/* * Please do not include this file in generic code. There is currently * no requirement for any architecture to implement anything held * within this file. * * Thanks. --rmk */ A quick grep indicates that we've lost this battle ;) Is the comments still true?

Re: [PATCH] powerpc: stop exporting irq_map

2011-04-20 Thread Sam Ravnborg
+ irq_hw_number_t virq_to_hw(unsigned int virq) { return irq_map[virq].hwirq; } EXPORT_SYMBOL_GPL(virq_to_hw); General comment... kernel/irq/* denote the virtual irq numbers irq. powerpc uses virq for the same. Sometimes it is confusing that two different names is used for the

Re: [PATCH 0/3] dt: documentation reorganization

2011-01-31 Thread Sam Ravnborg
On Mon, Jan 31, 2011 at 12:44:41AM -0700, Grant Likely wrote: This series reorganizes and cleans up the device tree documentation to make the directory useful for non-powerpc users. Looks better than first try. But the structure is very flat. Did you consider an arch/* for all arch specific

Re: [PATCH 0/3] dt: documentation reorganization

2011-01-31 Thread Sam Ravnborg
On Mon, Jan 31, 2011 at 02:01:31PM -0700, Grant Likely wrote: On Mon, Jan 31, 2011 at 09:34:49PM +0100, Sam Ravnborg wrote: On Mon, Jan 31, 2011 at 12:44:41AM -0700, Grant Likely wrote: This series reorganizes and cleans up the device tree documentation to make the directory useful

Re: [PATCH] dt: Move device tree documentation out of powerpc directory

2011-01-26 Thread Sam Ravnborg
On Wed, Jan 26, 2011 at 10:20:34AM -0700, Grant Likely wrote: The device tree is used by more than just PowerPC. Make the documentation directory available to all. How does the planned stucture look like for this new directory? I see that in your move the architecture is dropped. But some of

Re: [PATCH 1/4] of: Add support for linking device tree blobs into vmlinux

2010-12-06 Thread Sam Ravnborg
On Mon, Dec 06, 2010 at 09:35:59AM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com This patch adds support for linking device tree blob(s) into vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking .dtb sections into vmlinux. To maintain compatiblity

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread Sam Ravnborg
On Tue, Nov 16, 2010 at 02:41:36PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com This patch adds support for linking device tree blobs into vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking .dtb.init.rodata sections into the .init.data section

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread Sam Ravnborg
+ +DTC = $(objtree)/scripts/dtc/dtc + +quiet_cmd_dtc = DTC $@ Please avoid tabs in the output - all other uses spaces. (There is a tab between DTC and $@) + cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS) $(src)/dts/$*.dts Looks strange. How

Re: [PATCH 2/2] rwsem: Move powerpc atomic-long based implementation to asm-generic

2010-08-20 Thread Sam Ravnborg
diff --git a/include/asm-generic/rwsem-cmpxchg.h b/include/asm-generic/rwsem-cmpxchg.h new file mode 100644 index 000..2b1c859 --- /dev/null +++ b/include/asm-generic/rwsem-cmpxchg.h @@ -0,0 +1,183 @@ +#ifndef _RWSEM_CMPXCHG_H +#define _RWSEM_CMPXCHG_H + +#ifndef _LINUX_RWSEM_H

Re: 64-bit ppc rwsem

2010-08-17 Thread Sam Ravnborg
diff --git a/arch/sparc/lib/Makefile b/arch/sparc/lib/Makefile index c4b5e03..fa4c3ea 100644 --- a/arch/sparc/lib/Makefile +++ b/arch/sparc/lib/Makefile @@ -15,7 +15,7 @@ lib-$(CONFIG_SPARC32) += divdi3.o udivdi3.o lib-$(CONFIG_SPARC32) += copy_user.o locks.o lib-y +=

Re: [PATCH] powerpc: fix typo in uImage target

2010-08-16 Thread Sam Ravnborg
On Mon, Aug 16, 2010 at 10:26:56AM +0200, Anatolij Gustschin wrote: Commit e32e78c5ee8aadef020fbaecbe6fb741ed9029fd (powerpc: fix build with make 3.82) introduced a typo in uImage target and broke building uImage: make: *** No rule to make target `uImage'. Stop. Signed-off-by: Anatolij

[PATCH] powerpc: fix build with make 3.82

2010-08-03 Thread Sam Ravnborg
Tested-by: Thomas Backlund t...@mandriva.org Cc: Michal Marek mma...@suse.cz Cc: stable sta...@kernel.org Signed-off-by: Sam Ravnborg s...@ravnborg.org --- Hi Ben / Paul. This fixes powerc build with latest make version. The patch is on top of 2.6.35. But it is more of a coincidence that we see

Re: make 3.82 fails on powerpc defconfig update [was: Linux 2.6.35]

2010-08-02 Thread Sam Ravnborg
mixing non-wildcard and wildcard targets. Reported-by: Thomas Backlund t...@mandriva.org Cc: Michal Marek mma...@suse.cz Signed-off-by: Sam Ravnborg s...@ravnborg.org --- diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 77cfe7a..ad88b21 100644 --- a/arch/powerpc/Makefile +++ b/arch

Re: make 3.82 fails on powerpc defconfig update [was: Linux 2.6.35]

2010-08-02 Thread Sam Ravnborg
Thanks, this seems to fix the first issue, but then I get the same erro on the following line 190: 190: bootwrapper_install %.dtb: 191:$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) Obviously - dunno how I missed that. Updated patch below. I will do a

Re: [RFC][PATCH] kconfig: implement select with values

2010-07-27 Thread Sam Ravnborg
Cute. I didn't know this was possible. I'll give it a try and see how it works for me. Do override config options also pickup select/depends constraints applied by later definitions? I think that would be necessary to kick out warnings when a defconfig selection isn't actually

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-27 Thread Sam Ravnborg
On Tue, Jul 27, 2010 at 03:34:01PM +0200, Arnd Bergmann wrote: On Tuesday 27 July 2010, Grant Likely wrote: I suggest to go back to v2 of your patch where you use asm-generic/of.h. Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way. I don't mind adding stuff to

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Sam Ravnborg
On Mon, Jul 26, 2010 at 04:04:55PM -0600, Grant Likely wrote: of_node_to_nid() is only relevant in a few architectures. Don't force everyone to implement it anyway. This patch also adds asm-generic/of.h which will be used to contain other overrideable symbols. Signed-off-by: Grant Likely

Re: [RFC][PATCH] kconfig: implement select with values

2010-07-26 Thread Sam Ravnborg
On Tue, Jul 20, 2010 at 04:37:06AM +1000, Stephen Rothwell wrote: This is a fairly brute force approach to allowing a Kconfig select to specify an excplicit value for the selected config sybmol. The syntax of select is changed to: select symbol [expr] [if expr] The approach taken

Re: [PATCH] powerpc: fix .data..init_task output section

2010-07-23 Thread Sam Ravnborg
On Thu, Jul 22, 2010 at 07:50:08PM -0400, Sean MacLennan wrote: On Tue, 13 Jul 2010 11:50:24 +0200 Sam Ravnborg s...@ravnborg.org wrote: From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg s...@ravnborg.org Date: Tue, 13 Jul 2010 11:39:42 +0200

Re: section .data..init_task

2010-07-13 Thread Sam Ravnborg
On Mon, Jul 12, 2010 at 08:34:35PM -0400, Sean MacLennan wrote: On Mon, 28 Jun 2010 00:59:00 -0400 Sean MacLennan smaclen...@pikatech.com wrote: Anybody else seeing these messages? ppc_4xxFP-ld: .tmp_vmlinux1: section .data..init_task lma 0xc0374000 overlaps previous sections

[

2010-07-13 Thread Sam Ravnborg
From 851e645a7eee68380caaf026eb6d3be118876370 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg s...@ravnborg.org Date: Tue, 13 Jul 2010 11:39:42 +0200 Subject: [PATCH] vmlinux.lds: fix .data..init_task output section (fix popwerpc boot) The .data..init_task output section was missing a load offset

Re: section .data..init_task

2010-07-13 Thread Sam Ravnborg
On Tue, Jul 13, 2010 at 11:26:10AM -0400, Sean MacLennan wrote: On Tue, 13 Jul 2010 10:54:19 +0200 Sam Ravnborg s...@ravnborg.org wrote: It looks like a missing AT() in the output section. The following patch should also fix it. Please test and let us know. Thanks, Sam

[PATCH] powerpc: fix userspace build of ptrace.h

2010-05-09 Thread Sam Ravnborg
From ff056c080d2b0b93bac07ad71125fee701919f5e Mon Sep 17 00:00:00 2001 From: Sam Ravnborg s...@ravnborg.org Date: Sun, 9 May 2010 08:52:31 +0200 Subject: [PATCH] powerpc: fix userspace build of ptrace.h Build of ptrace.h failed for assembly because it pulls in stdint.h. Use exportable types

Re: [patch] powerpc: build modules outside the kernel tree fails, if it was built using O=

2009-09-25 Thread Sam Ravnborg
On Thu, Sep 24, 2009 at 03:28:11PM +0400, Yuri Frolov wrote: Hello, here is a corresponding bug: http://bugzilla.kernel.org/show_bug.cgi?id=11143 This patch should correctly export crtsavres.o in order to make O= option working. Please, consider to apply. Hi Yuri. I like the way you do

Re: [patch] powerpc: build modules outside the kernel tree fails, if it was built using O=

2009-09-25 Thread Sam Ravnborg
On Sat, Sep 26, 2009 at 07:57:32AM +1000, Benjamin Herrenschmidt wrote: On Fri, 2009-09-25 at 21:45 +0200, Sam Ravnborg wrote: On Thu, Sep 24, 2009 at 03:28:11PM +0400, Yuri Frolov wrote: Hello, here is a corresponding bug: http://bugzilla.kernel.org/show_bug.cgi?id=11143

Re: [patch] powerpc: build modules outside the kernel tree fails, if it was built using O=

2009-09-24 Thread Sam Ravnborg
On Fri, Sep 25, 2009 at 11:12:21AM +1000, Benjamin Herrenschmidt wrote: On Thu, 2009-09-24 at 15:28 +0400, Yuri Frolov wrote: Hello, here is a corresponding bug: http://bugzilla.kernel.org/show_bug.cgi?id=11143 This patch should correctly export crtsavres.o in order to make O= option

Re: [PATCH] powerpc: Cleanup linker script using new linker script macros.

2009-09-23 Thread Sam Ravnborg
On Tue, Sep 22, 2009 at 11:18:09AM -0400, Tim Abbott wrote: Signed-off-by: Tim Abbott tabb...@ksplice.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@ozlabs.org Cc: Sam Ravnborg s...@ravnborg.org Look good. Acked-by: Sam Ravnborg

Re: [PATCH] powerpc: minor Makefile simplification through use of cc-ifversion

2009-07-23 Thread Sam Ravnborg
On Thu, Jul 23, 2009 at 08:57:18PM +0200, Frans Pop wrote: Signed-off-by: Frans Pop elen...@planet.nl Acked-by: Sam Ravnborg s...@ravnborg.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] fbdev: work around old compiler bug

2009-06-23 Thread Sam Ravnborg
On Tue, Jun 23, 2009 at 12:45:05PM -0400, Kyle McMartin wrote: On Tue, Jun 23, 2009 at 03:44:28PM +1000, Stephen Rothwell wrote: When building with a 4.1.x compiler on powerpc64 (at least) we get this error: drivers/video/logo/logo_linux_mono.c:81: error: logo_linux_mono causes a

Re: [PATCH] fbdev: work around old compiler bug

2009-06-22 Thread Sam Ravnborg
On Mon, Jun 22, 2009 at 06:34:15PM +1000, Stephen Rothwell wrote: On Mon, 22 Jun 2009 18:04:20 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: When building with a 4.1.x compiler on powerpc64 (at least) we get this error: Ignore this, it causes more problems:

kbuild, modpost: fix non-allocatable section warnings

2009-05-04 Thread Sam Ravnborg
It turned out there were at least three sources of the non-allocatable section warning. 1) SUSE specific .comment section 2) endianness issues in elf header 3) additional debug sections I have updated kbuild-fixes.git with patches for all of the above. But as we have seen three independent

[PATCH 1/3] kbuild, modpost: fix unexpected non-allocatable section when cross compiling

2009-05-04 Thread Sam Ravnborg
...@mit.edu Reported-by: Sean MacLennan smaclen...@pikatech.com Tested-by: Sean MacLennan smaclen...@pikatech.com Signed-off-by: Sam Ravnborg s...@ravnborg.org --- scripts/mod/modpost.c | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/scripts/mod

[PATCH 2/3] kbuild, modpost: fix unexpected non-allocatable warning with SUSE gcc

2009-05-04 Thread Sam Ravnborg
From 028ecebdd83cc4a7f8c7e96e28a5537d2ac98dae Mon Sep 17 00:00:00 2001 From: Sam Ravnborg s...@ravnborg.org Date: Sun, 3 May 2009 22:17:37 +0200 Subject: [PATCH 2/3] kbuild, modpost: fix unexpected non-allocatable warning with SUSE gcc Jean reported that he saw one warning for each module like

[PATCH 3/3] kbuild, modpost: fix unexpected non-allocatable warning with mips

2009-05-04 Thread Sam Ravnborg
From 4391ed6aa9a38cdfb48addd7a9b24a2ff099b1a7 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg s...@ravnborg.org Date: Mon, 4 May 2009 13:05:26 +0200 Subject: [PATCH 3/3] kbuild, modpost: fix unexpected non-allocatable warning with mips mips emit the following debug sections: .mdebug* and .pdr

Re: unexpected non-allocatable section

2009-05-03 Thread Sam Ravnborg
-allocatable section warnings when cross-compiling for an architecture with a different endianness. Fix endianness of all the fields in the ELF header and section headers, not just some of them so we are not hit by this anohter time. Signed-off-by: Anders Kaseorg ande...@mit.edu Signed-off-by: Sam

Re: unexpected non-allocatable section

2009-05-03 Thread Sam Ravnborg
I ran the tests on a LE machine: Linux gemini.denx.de 2.6.27.15-170.2.24.fc10.i686 #1 SMP Wed Feb 11 23:58:12 EST 2009 i686 i686 i386 GNU/Linux I will push the patch in a few minutes. For reference it is below: Sam From: Anders Kaseorg ande...@mit.edu Subject:

Re: unexpected non-allocatable section

2009-05-03 Thread Sam Ravnborg
On Sun, May 03, 2009 at 04:32:41PM -0400, Sean MacLennan wrote: On Sun, 3 May 2009 22:07:01 +0200 Sam Ravnborg s...@ravnborg.org wrote: On Sun, May 03, 2009 at 09:33:16PM +0200, Wolfgang Denk wrote: Which exact commands did you use to build the kenrel, and how did you set (and export

Re: [PATCH v2 0/6] macros for section name cleanup

2009-05-01 Thread Sam Ravnborg
; /* -fdata-sections places in .data.nosave */ static void head(); /* -ffunction-sections places in .text.head */ Sam Ravnborg proposed that rather than just renaming all the sections outright, we should start by first getting more control over the section names used in the kernel so that we can

Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.

2009-05-01 Thread Sam Ravnborg
here is to be able to change the kernel's magic section names to those that are compatible with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org Acked

Re: [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro.

2009-05-01 Thread Sam Ravnborg
the kernel's magic section names to those that are compatible with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h

Re: [PATCH 6/6] Add support for __read_mostly to linux/cache.h

2009-05-01 Thread Sam Ravnborg
On Thu, Apr 30, 2009 at 03:32:36PM -0400, Tim Abbott wrote: Signed-off-by: Tim Abbott tabb...@mit.edu --- include/linux/cache.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/cache.h b/include/linux/cache.h index 97e2488..99d8a6f 100644 ---

  1   2   >