[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

brucem requested changes to this revision. brucem added a comment. This revision now requires changes to proceed. The change to `SBDebugger::GetProgressFromEvent` needs to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103391/new/

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

brucem added a comment. It failed because on macOS, the underlying args contains argv0 while on Linux it does not. So my test that checked that `GetNumArguments` is 1 fails on macOS, since there are 2. Ideally, each platform would agree on whether or not the argv0 was included in the args ...

[Lldb-commits] [lldb] 8fb53dc - Improve materializer error messages to include type names.

Author: Adrian Prantl Date: 2021-06-11T17:59:00-07:00 New Revision: 8fb53dca2f61d2d15204ae0046339ee60b7f3b54 URL: https://github.com/llvm/llvm-project/commit/8fb53dca2f61d2d15204ae0046339ee60b7f3b54 DIFF: https://github.com/llvm/llvm-project/commit/8fb53dca2f61d2d15204ae0046339ee60b7f3b54.diff

[Lldb-commits] [PATCH] D104162: NFC Fix the handling of BreakpointOptions - return references to make it clear when you will get a valid object

jingham created this revision. jingham added reviewers: aprantl, shafik. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Many of the API's that returned BreakpointOptions always returned valid ones. However, internally the

[Lldb-commits] [lldb] 4fc93a3 - Allow signposts to take advantage of deferred string substitution

Author: Adrian Prantl Date: 2021-06-11T16:52:34-07:00 New Revision: 4fc93a3a1f95ef5a0a57750fc621f2411ea445a8 URL: https://github.com/llvm/llvm-project/commit/4fc93a3a1f95ef5a0a57750fc621f2411ea445a8 DIFF: https://github.com/llvm/llvm-project/commit/4fc93a3a1f95ef5a0a57750fc621f2411ea445a8.diff

[Lldb-commits] [lldb] b90f9be - Revert "Allow signposts to take advantage of deferred string substitution"

Author: Adrian Prantl Date: 2021-06-11T16:46:34-07:00 New Revision: b90f9bea9673d07f2764006eb15fc4ea5e23be6d URL: https://github.com/llvm/llvm-project/commit/b90f9bea9673d07f2764006eb15fc4ea5e23be6d DIFF: https://github.com/llvm/llvm-project/commit/b90f9bea9673d07f2764006eb15fc4ea5e23be6d.diff

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG541ccd1c1bb2: Allow signposts to take advantage of deferred string substitution (authored by aprantl). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 635b721 - Disambiguate usage of struct mach_header and other MachO definitions.

Author: Adrian Prantl Date: 2021-06-11T16:35:43-07:00 New Revision: 635b72136e95173e74d45ae66eca714d7e4e4f87 URL: https://github.com/llvm/llvm-project/commit/635b72136e95173e74d45ae66eca714d7e4e4f87 DIFF: https://github.com/llvm/llvm-project/commit/635b72136e95173e74d45ae66eca714d7e4e4f87.diff

[Lldb-commits] [lldb] 541ccd1 - Allow signposts to take advantage of deferred string substitution

Author: Adrian Prantl Date: 2021-06-11T16:35:43-07:00 New Revision: 541ccd1c1bb23e1e20a382844b35312c0caffd79 URL: https://github.com/llvm/llvm-project/commit/541ccd1c1bb23e1e20a382844b35312c0caffd79 DIFF: https://github.com/llvm/llvm-project/commit/541ccd1c1bb23e1e20a382844b35312c0caffd79.diff

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

clayborg added a comment. I mostly commented on ThreadTrace.h and we should resolve the questions in there before reviewing the rest of this patch. Comment at: lldb/include/lldb/Target/ThreadTrace.h:44-45 + /// \param[in] start_position + /// The instruction position to

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

vsk added a comment. I think this is moving in the right direction! However, the way ThreadTrace is specified still raises the same scalability concerns (see inline). The "instruction index" concept doesn't seem sufficient. Decoding needs to be done in two stages: a separate "trace index"

[Lldb-commits] [lldb] 60fde95 - [lldb] Remove GCC XFAIL for TestCPPAuto and TestClassTemplateParameterPack

Author: Raphael Isemann Date: 2021-06-11T23:22:26+02:00 New Revision: 60fde9542aac57d4b7b98bed0be746a3a82bd0eb URL: https://github.com/llvm/llvm-project/commit/60fde9542aac57d4b7b98bed0be746a3a82bd0eb DIFF:

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.org/D100243

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 351547. OmarEmaraDev added a comment. - Handle review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.org/D100243 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many minor things, but looking good! I look forward to seeing this get checked in Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1611-1612 virtual

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

shafik added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:104 + // We also return the FunctionNameType of each possible name. + std::vector> GetMethodNameVariants(ConstString method_name) const override; teemperor wrote: >

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103391/new/ https://reviews.llvm.org/D103391

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___ lldb-commits

[Lldb-commits] [lldb] fc71a5c - [lldb] Support new objective-c hash table layout

Author: Jonas Devlieghere Date: 2021-06-11T10:26:16-07:00 New Revision: fc71a5c6e8e8bd28e43cf58faabad6e7e2fcc652 URL: https://github.com/llvm/llvm-project/commit/fc71a5c6e8e8bd28e43cf58faabad6e7e2fcc652 DIFF:

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. And thank you for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list

[Lldb-commits] [lldb] c7dee6a - [lldb] Enable TestRuntimeTypes on Apple Silicon

Author: Jonas Devlieghere Date: 2021-06-11T10:24:41-07:00 New Revision: c7dee6aefd5b5f1d92d279ddd40b81217b496d50 URL: https://github.com/llvm/llvm-project/commit/c7dee6aefd5b5f1d92d279ddd40b81217b496d50 DIFF:

[Lldb-commits] [PATCH] D103675: [LLDB/API] Expose args and env from SBProcessInfo.

teemperor added a comment. In D103675#2800653 , @brucem wrote: > Not sure why this failed. Is it perhaps a difference where some processes > have args including the executable and some do not? Do you have the bot failures around for that? (Or, the

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! (And congrats on your first patch) I'll land this for you next week just to give the others another chance to take a look. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm updated this revision to Diff 351481. asm marked an inline comment as done. asm added a comment. code style fixes, use modern log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 Files:

[Lldb-commits] [PATCH] D103609: [lldb-vscode] Synchronize calls to SendTerminatedEvent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ef5177145b4: [lldb-vscode] Synchronize calls to SendTerminatedEvent (authored by asahay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 5ef5177 - [lldb-vscode] Synchronize calls to SendTerminatedEvent

Author: Ayush Sahay Date: 2021-06-11T21:37:19+05:30 New Revision: 5ef5177145b48e6379fe3a6434d3ff593fe7202a URL: https://github.com/llvm/llvm-project/commit/5ef5177145b48e6379fe3a6434d3ff593fe7202a DIFF: https://github.com/llvm/llvm-project/commit/5ef5177145b48e6379fe3a6434d3ff593fe7202a.diff

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Expression/ExpressionParser.h:45 + virtual ~ExpressionParser() = default; + ; teemperor wrote: > Please drop that when you land it. Dropped. Comment at:

[Lldb-commits] [lldb] ab46490 - [lldb] Remove GCC XFAIL for TestTypedefArray

Author: Raphael Isemann Date: 2021-06-11T16:24:59+02:00 New Revision: ab46490dfc5cded4b2873da75eb47e150d1ad92c URL: https://github.com/llvm/llvm-project/commit/ab46490dfc5cded4b2873da75eb47e150d1ad92c DIFF:

[Lldb-commits] [lldb] b1603cb - [lldb] Fix compilation after removal of APInt::toString

Author: Raphael Isemann Date: 2021-06-11T16:20:57+02:00 New Revision: b1603cb66fc68eb74c21041456c9e36466603244 URL: https://github.com/llvm/llvm-project/commit/b1603cb66fc68eb74c21041456c9e36466603244 DIFF:

[Lldb-commits] [lldb] e2d0798 - [lldb] Unmark TestInlines as XFAIL for gcc

Author: Raphael Isemann Date: 2021-06-11T16:06:39+02:00 New Revision: e2d0798bc3e462738c557270528e8a983df0cf02 URL: https://github.com/llvm/llvm-project/commit/e2d0798bc3e462738c557270528e8a983df0cf02 DIFF:

[Lldb-commits] [lldb] 307cfad - Fix extraneous ')' error.

Author: Simon Pilgrim Date: 2021-06-11T14:50:22+01:00 New Revision: 307cfad0d639b0397033069473e84e6c7f249056 URL: https://github.com/llvm/llvm-project/commit/307cfad0d639b0397033069473e84e6c7f249056 DIFF: https://github.com/llvm/llvm-project/commit/307cfad0d639b0397033069473e84e6c7f249056.diff

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 351432. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 351431. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 351430. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 351429. DavidSpickett added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 351428. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h

[Lldb-commits] [PATCH] D81550: [lldb] Add support for evaluating expressions in static member functions

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Reopen because of the revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81550/new/ https://reviews.llvm.org/D81550

[Lldb-commits] [lldb] 4125b46 - Revert "[lldb] Add support for evaluating expressions in static member functions"

Author: Raphael Isemann Date: 2021-06-11T15:00:38+02:00 New Revision: 4125b46232caf6a558470670f87b56ccb46d61aa URL: https://github.com/llvm/llvm-project/commit/4125b46232caf6a558470670f87b56ccb46d61aa DIFF:

[Lldb-commits] [lldb] cd2e500 - [lldb] DumpDataExtractor.cpp - replace APInt::toString() with llvm::toString(APInt)

Author: Simon Pilgrim Date: 2021-06-11T13:39:14+01:00 New Revision: cd2e500e555e134ffc19d07f26b17d0b0c71efd9 URL: https://github.com/llvm/llvm-project/commit/cd2e500e555e134ffc19d07f26b17d0b0c71efd9 DIFF: https://github.com/llvm/llvm-project/commit/cd2e500e555e134ffc19d07f26b17d0b0c71efd9.diff

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2811834 , @jingham wrote: > This looks pretty good to me. > > It's a little awkward in InitNameIndexes that we look up the

[Lldb-commits] [lldb] f3f9045 - [lldb] Fix leak in test

Author: Vitaly Buka Date: 2021-06-11T00:20:35-07:00 New Revision: f3f904563ec9ce8c7bfda83bbca19790cc4d9afc URL: https://github.com/llvm/llvm-project/commit/f3f904563ec9ce8c7bfda83bbca19790cc4d9afc DIFF: https://github.com/llvm/llvm-project/commit/f3f904563ec9ce8c7bfda83bbca19790cc4d9afc.diff

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3f904563ec9: [lldb] Fix leak in test (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, big thanks for the patch & quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104091/new/

[Lldb-commits] [PATCH] D104091: [lldb] Fix leak in test

vitalybuka updated this revision to Diff 351347. vitalybuka marked 2 inline comments as done. vitalybuka edited the summary of this revision. vitalybuka added a comment. ::Terminate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104091/new/

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632cbcac7906: [lldb] Move once_flags in HostInfoLinux so the internal state struct (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] 632cbca - [lldb] Move once_flags in HostInfoLinux so the internal state struct

Author: Raphael Isemann Date: 2021-06-11T08:53:38+02:00 New Revision: 632cbcac79065a62a306dbda7b3a6e1f315e3260 URL: https://github.com/llvm/llvm-project/commit/632cbcac79065a62a306dbda7b3a6e1f315e3260 DIFF:

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I see comment on the D104091 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104093/new/ https://reviews.llvm.org/D104093

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

vitalybuka added inline comments. Comment at: lldb/source/Host/linux/HostInfoLinux.cpp:41 g_fields = new HostInfoLinuxFields(); } this still does not solve memory leak if HostInfoLinux::Initialize called twice CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

teemperor added inline comments. Comment at: lldb/unittests/Host/HostInfoTest.cpp:64 + +TEST(HostInfoTest2, InitTwice) { + llvm::VersionTuple Version; `HostInfoTestInitialization` maybe? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D104091: [NFC][lldb] Fix leak in test

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think we should instead implement the `Terminate` function that the plugin system provides to tear down our state. I made a patch in D104093

[Lldb-commits] [PATCH] D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct

teemperor created this revision. teemperor added reviewers: vitalybuka, LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. The HostInfoLinuxFields struct is supposed to be set up/torn down on Initialize/Terminate and

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

wallace updated this revision to Diff 351344. wallace edited the summary of this revision. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 Files:

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

clayborg added a comment. Once teemperor's issues are resolved this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing