[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Simon Pilgrim via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit:

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the

Re: [Lldb-commits] [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Stella Stamenova via lldb-commits
I will take care of it today. The bot does have vs2019 installed and it should be picking up latest VS (and it was when I updated it), so there is an easy fix (remove 2017) and then I can investigate why it stopped picking up latest. Get Outlook for iOS

[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

2022-01-29 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG460830a9c664: [LLD][MinGW] Add --heap argument support (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

2022-01-29 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Thanks, I tested it and it seems to work fine. (FWIW the comma-separated form of the option is pretty hard to pass via `-Wl` through the compiler driver, but with `-Xlinker --heap

Re: [Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

2022-01-29 Thread Rachel Lane via lldb-commits
Hi Rachel, Your Facebook account has been logged in to recently using a confirmation code and the email address rr4433lal...@gmail.com on Saturday, 29 January 2022 at 12:40 (UTC). Device: iPhone 5s IP address: 85.255.237.205 Network Provider: Vodafone UK If you did this, you can safely

[Lldb-commits] [lldb] b81b3ac - [lldb] TypeSystemClang - use castAs/cast<> instead of getAs/dyn_cast<> to avoid dereference of nullptr

2022-01-29 Thread Simon Pilgrim via lldb-commits
Author: Simon Pilgrim Date: 2022-01-29T15:34:26Z New Revision: b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7 URL: https://github.com/llvm/llvm-project/commit/b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7 DIFF: https://github.com/llvm/llvm-project/commit/b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7.diff

[Lldb-commits] [lldb] 058c5df - Raise the minimum Visual Studio version to VS2019

2022-01-29 Thread Simon Pilgrim via lldb-commits
Author: Simon Pilgrim Date: 2022-01-29T10:56:41Z New Revision: 058c5dfc78cd1a1a6075bba9799e63f3ec871c0d URL: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d DIFF: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d.diff

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

2022-01-29 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. In D78801#3281504 , @paolosev wrote: > Hi @xujuntwt95329, > Honestly I wasn't thinking to support multithreading with this initial patch > so I am not surprised that it doesn't work. You are right, we should add > thread

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

2022-01-29 Thread Paolo Severini via Phabricator via lldb-commits
paolosev added a comment. Hi @xujuntwt95329, Honestly I wasn't thinking to support multithreading with this initial patch so I am not surprised that it doesn't work. You are right, we should add thread information to the messages. Actually I am a little surprised that the patch still works