[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu added a comment. In D120319#3348268 , @ilya-nozhkin wrote: > In D120319#3348267 , @ChuanqiXu > wrote: > >> What's your name and email address for this patch? > > Ilya Nozhkin > nozhkin...@gmail.com

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Chuanqi Xu via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfd37d489cfef: Set error message if ValueObjectRegister fails to write back to register (authored by ilya-nozhkin, committed by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fd37d48 - Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Chuanqi Xu via lldb-commits
Author: Ilya Nozhkin Date: 2022-02-28T14:29:29+08:00 New Revision: fd37d489cfef3bf7d06b2b43dac2ad1381cdc56b URL: https://github.com/llvm/llvm-project/commit/fd37d489cfef3bf7d06b2b43dac2ad1381cdc56b DIFF: https://github.com/llvm/llvm-project/commit/fd37d489cfef3bf7d06b2b43dac2ad1381cdc56b.diff

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Ilya Nozhkin via Phabricator via lldb-commits
ilya-nozhkin added a comment. In D120319#3348267 , @ChuanqiXu wrote: > What's your name and email address for this patch? Ilya Nozhkin nozhkin...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120319/new/

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Chuanqi Xu via Phabricator via lldb-commits
ChuanqiXu added a comment. In D120319#3348265 , @ilya-nozhkin wrote: > Could someone, please, commit these changes to the main repository? I still > don't have commit access. I'll apply for it right after merging these changes > (LLVM Developer Policy

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Ilya Nozhkin via Phabricator via lldb-commits
ilya-nozhkin added a comment. Could someone, please, commit these changes to the main repository? I still don't have commit access. I'll apply for it right after merging these changes (LLVM Developer Policy states that it'd be better to have several patches already submitted before applying

[Lldb-commits] [PATCH] D113616: [lldb] Hyphenate Objective-C exception breakpoint labels ✍️

2022-02-27 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Very easy change as VS Code IDE displays these strings and no one references these by name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113616/new/ https://reviews.llvm.org/D113616

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

2022-02-27 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Great, thanks for adding the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120319/new/ https://reviews.llvm.org/D120319 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 850bc76 - [lldb] BreakpointOptions::CommandData::CreateFromStructuredData - remove dead code + variable. NFCI.

2022-02-27 Thread Simon Pilgrim via lldb-commits
Author: Simon Pilgrim Date: 2022-02-27T11:33:14Z New Revision: 850bc76a356b050b92851ad5a6a8207da05685cd URL: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd DIFF: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd.diff