[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3884047 , @clayborg wrote: > Looks ok to me. I don't do Android stuff on a daily basis. As long as the old > way of connecting still works I think this is ok. Great! I'd just like to note that I do not have commit

[Lldb-commits] [PATCH] D136650: Add a check for TypeSystem use-after-free problems

aprantl added inline comments. Comment at: lldb/source/Symbol/CompilerType.cpp:35 + bool unused; + if (GetTypeSystemGraveyard().Lookup(m_type_system, unused)) { +lldbassert(false && "CompilerType belongs to deleted Typesystem"); hawkinsw wrote: > I am

[Lldb-commits] [PATCH] D136650: Add a check for TypeSystem use-after-free problems

hawkinsw added a comment. There are *so* many reasons that I love this patch. First and foremost: I am a professor of computer science at University of Cincinnati and teaching Programming Languages this semester and I am about to teach *this very technique* for protecting against

[Lldb-commits] [PATCH] D136177: [lldb-vscode] Send Statistics Dump in terminated event

This revision was automatically updated to reflect the committed changes. kusmour marked 3 inline comments as done. Closed by commit rGc8a26f8c6de3: [lldb-vscode] Send Statistics Dump in terminated event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] c8a26f8 - [lldb-vscode] Send Statistics Dump in terminated event

Author: Wanyi Ye Date: 2022-10-25T18:47:29-07:00 New Revision: c8a26f8c6de30dbd814546f02e4c89a4fcb2b4ef URL: https://github.com/llvm/llvm-project/commit/c8a26f8c6de30dbd814546f02e4c89a4fcb2b4ef DIFF: https://github.com/llvm/llvm-project/commit/c8a26f8c6de30dbd814546f02e4c89a4fcb2b4ef.diff

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda updated this revision to Diff 470652. jasonmolenda added a comment. Update patch to also update the loop in HandlePacket_qProcessInfo() which iterates over the binaries, looking for a binary that declares its platform. The first binary in the list is dyld, and this binary does not

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda added a comment. Ah, one minute on this one. Going over the testsuite, there's a change in behavior of TestMacCatalyst.py and I'm not positive if it's a bug or the test case being overly sensitive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

clayborg added a comment. Looks ok to me. I don't do Android stuff on a daily basis. As long as the old way of connecting still works I think this is ok. It would be great to get more stuff in the Android remove platform connection working at some point. Users still have to manually install

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/lldb/include/lldb/Utility/Diagnostics.h:1 +//===-- Diagnostics.h ---*- C++ -*-===// +//

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:431 + /// Progress events will be delivered to any debuggers that have listeners + /// for the eBroadcastBitError. + /// This comment seems wrong? The code below asserts and returns

[Lldb-commits] [PATCH] D136719: change debugserver to return an empty platform name for unknown platforms, instead of crashing

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. debugserver is sometimes run in bringup environments, where

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -#

[Lldb-commits] [lldb] 2098e2f - [trace][intel pt][simple] Fix errors after switching to libipt's top of tree

Author: Walter Erquinigo Date: 2022-10-25T14:34:27-07:00 New Revision: 2098e2f472578f793c565b669500dca454b4a608 URL: https://github.com/llvm/llvm-project/commit/2098e2f472578f793c565b669500dca454b4a608 DIFF:

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470617. aeubanks added a comment. revert breakpoint test change we can leave that to a later change, so I think this change is ready to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/

[Lldb-commits] [lldb] 779a455 - Quick fix for previous commit; small code change before commit

Author: Jason Molenda Date: 2022-10-25T13:56:02-07:00 New Revision: 779a45515134a040006c17d8b85f91a4d9f810ed URL: https://github.com/llvm/llvm-project/commit/779a45515134a040006c17d8b85f91a4d9f810ed DIFF: https://github.com/llvm/llvm-project/commit/779a45515134a040006c17d8b85f91a4d9f810ed.diff

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG256c16e8f4e4: Change debugserver to clear PAC auth bits manually (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136620/new/

[Lldb-commits] [lldb] 256c16e - Change debugserver to clear PAC auth bits manually

Author: Jason Molenda Date: 2022-10-25T13:49:05-07:00 New Revision: 256c16e8f4e483ff19ed7096d3c41947a8a93144 URL: https://github.com/llvm/llvm-project/commit/256c16e8f4e483ff19ed7096d3c41947a8a93144 DIFF: https://github.com/llvm/llvm-project/commit/256c16e8f4e483ff19ed7096d3c41947a8a93144.diff

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG51effa57818b: Fix exception description in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/

[Lldb-commits] [lldb] 51effa5 - Fix exception description in lldb-vscode

Author: Jeffrey Tan Date: 2022-10-25T13:24:22-07:00 New Revision: 51effa57818bf937fb7c889b8f567c146bb4eefe URL: https://github.com/llvm/llvm-project/commit/51effa57818bf937fb7c889b8f567c146bb4eefe DIFF: https://github.com/llvm/llvm-project/commit/51effa57818bf937fb7c889b8f567c146bb4eefe.diff

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGc49d14aca5c7: [trace][intel pt] Simple detection of infinite decoding loops (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c49d14a - [trace][intel pt] Simple detection of infinite decoding loops

Author: Walter Erquinigo Date: 2022-10-25T10:20:49-07:00 New Revision: c49d14aca5c7b06a4f896e9923bdab8a33f2866d URL: https://github.com/llvm/llvm-project/commit/c49d14aca5c7b06a4f896e9923bdab8a33f2866d DIFF:

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks. Your explanation of why the verbose error is useful was good :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136610/new/

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] 93a5a03 - [lldb] Host::ShellExpandArguments - fix error check for valid dictionary

Author: Simon Pilgrim Date: 2022-10-25T17:44:04+01:00 New Revision: 93a5a03030ab9f49120f7bd2ec8e84f063da9987 URL: https://github.com/llvm/llvm-project/commit/93a5a03030ab9f49120f7bd2ec8e84f063da9987 DIFF: https://github.com/llvm/llvm-project/commit/93a5a03030ab9f49120f7bd2ec8e84f063da9987.diff

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136620/new/ https://reviews.llvm.org/D136620

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:70 - Error error = Create(FileSpec(diagnostics_dir.str())); + Error error = Create(*diagnostics_dir); if (error) { DavidSpickett wrote: > JDevlieghere wrote: > >

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere updated this revision to Diff 470503. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Update wording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 Files: lldb/include/lldb/Utility/Diagnostics.h

[Lldb-commits] [PATCH] D136674: [LLDB] Fix RISCV build

This revision was automatically updated to reflect the committed changes. Closed by commit rGc094b1eef08c: [LLDB] Fix RISCV build (authored by Emmmer). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c094b1e - [LLDB] Fix RISCV build

Author: Emmmer Date: 2022-10-25T23:03:16+08:00 New Revision: c094b1eef08cee93e4dd9e69d0f7f511037c8500 URL: https://github.com/llvm/llvm-project/commit/c094b1eef08cee93e4dd9e69d0f7f511037c8500 DIFF: https://github.com/llvm/llvm-project/commit/c094b1eef08cee93e4dd9e69d0f7f511037c8500.diff LOG:

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

JDevlieghere added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

varunkumare99 added a comment. In D136462#3878895 , @DavidSpickett wrote: > I agree that this change names - print - restore names is going to cause > problems. Pavel is right that this should happen in some dump function > somewhere. > > But,

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

varunkumare99 added a comment. In D136462#3878682 , @labath wrote: > This is definitely not a good way to implement this functionality. There's no > telling who else might be accessing the symbols while their names are being > changed. > > The

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:299-307 + uint64_t offset; + int status = pt_insn_get_offset(m_decoder_up.get(), ); + if (!IsLibiptError(status)) { +err_msg = +

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 updated this revision to Diff 470472. jj10306 marked 7 inline comments as done. jj10306 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136610/new/ https://reviews.llvm.org/D136610 Files:

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett added a comment. Landed as https://github.com/llvm/llvm-project/commit/a3be778ed09b7badcda20c5c8738ba19531dad48. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3be778ed09b: [LLDB] [LoongArch] Add minimal LoongArch support (authored by seehearfeel, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a3be778 - [LLDB] [LoongArch] Add minimal LoongArch support

Author: Tiezhu Yang Date: 2022-10-25T12:59:15Z New Revision: a3be778ed09b7badcda20c5c8738ba19531dad48 URL: https://github.com/llvm/llvm-project/commit/a3be778ed09b7badcda20c5c8738ba19531dad48 DIFF: https://github.com/llvm/llvm-project/commit/a3be778ed09b7badcda20c5c8738ba19531dad48.diff LOG:

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett added a comment. > I am a newcomer, here are some of my thoughts: > (1) Add the minimal changes to fix the build errors. > (2) Submit other more patches step by step to make > the basic command "run", "breakpoint", "next" ... > can be used to debug, single patch or patch series. >

[Lldb-commits] [lldb] 891eb20 - [LLDB][Docs][NFC] Fix formatting in -gmodules documentation

Author: Michael Buch Date: 2022-10-25T12:34:00+01:00 New Revision: 891eb20104b6b77c7ff85f532bbce2a28ee9eeb0 URL: https://github.com/llvm/llvm-project/commit/891eb20104b6b77c7ff85f532bbce2a28ee9eeb0 DIFF: https://github.com/llvm/llvm-project/commit/891eb20104b6b77c7ff85f532bbce2a28ee9eeb0.diff

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining accepted this revision. SixWeining added a comment. LGTM for LoongArch related changes. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + struct GPR { +uint64_t gpr[32]; xry111 wrote: > SixWeining

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

seehearfeel added a comment. In D136578#3881955 , @DavidSpickett wrote: > This LGTM from the lldb side. OK, thank you. > Feel free to upload a series of patches in future if you want. You don't have > to do one at a time, just update the whole stack

[Lldb-commits] [PATCH] D136362: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rG05ae747a5353: [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 05ae747 - [LLDB][RISCV] Add RV64C instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2022-10-25T19:12:45+08:00 New Revision: 05ae747a5353811f93f5814f24d2335e6229d78a URL: https://github.com/llvm/llvm-project/commit/05ae747a5353811f93f5814f24d2335e6229d78a DIFF: https://github.com/llvm/llvm-project/commit/05ae747a5353811f93f5814f24d2335e6229d78a.diff LOG:

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

xry111 added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + struct GPR { +uint64_t gpr[32]; SixWeining wrote: > Why is this structure and below `FPR` defined like this? Do you intent to >

[Lldb-commits] [lldb] 3d9bf8c - [LLDB] Add missing breaks to current frame row in command map

Author: David Spickett Date: 2022-10-25T10:20:07Z New Revision: 3d9bf8ce7bdf96f8b3cd9ed8b5ec696f537cc8de URL: https://github.com/llvm/llvm-project/commit/3d9bf8ce7bdf96f8b3cd9ed8b5ec696f537cc8de DIFF: https://github.com/llvm/llvm-project/commit/3d9bf8ce7bdf96f8b3cd9ed8b5ec696f537cc8de.diff

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + struct GPR { +uint64_t gpr[32]; Why is this structure and below `FPR` defined like this? Do you intent to keep the layout same

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

DavidSpickett added inline comments. Comment at: lldb/source/Utility/Diagnostics.cpp:70 - Error error = Create(FileSpec(diagnostics_dir.str())); + Error error = Create(*diagnostics_dir); if (error) { JDevlieghere wrote: > DavidSpickett wrote: > > Silly

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM from the lldb side. Feel free to upload a series of patches in future if you want. You don't have to do one at a time, just update the whole stack as needed. Plus it

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. (Unsurprisingly, I guess), this looks much better to me. And I'm totally open to automatically logging these diagnostics somewhere as well (to a dedicated log channel/category, or by passing

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 updated this revision to Diff 470421. mark2185 added a comment. Make remote-android local ports configurable The local ports for `platform connect` and `attach` were always random, this allows the user to configure them. This is useful for debugging a truly remote android (when the

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. Yes, somehow, and yes just update again. Happens to us all, I have learned to not try to be clever with arc and just keep one commit per review. Tip: if you look in the "Revision Contents" box there is a "history" and you can diff between versions of the patch,

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 marked 2 inline comments as done. mark2185 added a comment. Did I just overwrite the initial commit with a new one, instead of just creating a diff based on the two comments? I'm terribly sorry, should I just squash my two commits and run `arc diff --update=D136465` again?

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 updated this revision to Diff 470381. mark2185 added a comment. Remove {} for single line if statements per LLVM coding guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://reviews.llvm.org/D136465 Files: