[Lldb-commits] [libc] [compiler-rt] [libunwind] [flang] [lldb] [libcxx] [lld] [clang] [llvm] [clang-tools-extra] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
@@ -17,7 +17,7 @@ "`P0792R14 `__","LWG","``function_ref``: a type-erased callable reference","Varna June 2023","","","" "`P2874R2 `__","LWG","Mandating Annex D Require No More","Varna June 2023","","","" "`P2757R3

[Lldb-commits] [clang] [libc] [lld] [lldb] [libunwind] [libcxx] [compiler-rt] [llvm] [clang-tools-extra] [flang] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
@@ -16,7 +16,7 @@ Number,Name,Standard,Assignee,Status,First released version "`P2693R1 `__","Formatting ``thread::id`` and ``stacktrace``","C++23","Mark de Wever","|In Progress|" "`P2510R3 `__","Formatting

[Lldb-commits] [llvm] [libunwind] [clang] [lld] [clang-tools-extra] [flang] [lldb] [libcxx] [libc] [compiler-rt] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
@@ -79,6 +79,7 @@ Implemented Papers - P1759R6 - Native handles and file streams - P2868R3 - Remove Deprecated ``std::allocator`` Typedef From C++26 - P2517R1 - Add a conditional ``noexcept`` specification to ``std::apply`` +- P2637R3 - Member ``visit`` - P2447R6 - ``span``

[Lldb-commits] [clang-tools-extra] [flang] [compiler-rt] [lldb] [libc] [clang] [libcxx] [libunwind] [llvm] [lld] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/79032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [flang] [clang] [lld] [libc] [libcxx] [lldb] [clang-tools-extra] [compiler-rt] [libunwind] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
https://github.com/H-G-Hristov commented: @mordante I guess the PR missed LLVM18 release. I'll update the release notes accordingly. Is that OK? https://github.com/llvm/llvm-project/pull/79032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [mlir] [libunwind] [lld] [flang] [clang-tools-extra] [libc] [libcxx] [llvm] [clang] [compiler-rt] [lldb] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [libunwind] [lld] [flang] [clang-tools-extra] [libc] [libcxx] [llvm] [clang] [compiler-rt] [lldb] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79239 >From 3725fa4eac3d3d946289d7eb7213f3a1751a2770 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 17:58:07 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [mlir] [libunwind] [lld] [flang] [clang-tools-extra] [libc] [libcxx] [llvm] [clang] [compiler-rt] [lldb] [Driver, CodeGen] Support -mtls-dialect= (PR #79256)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79256 >From be08e64c2c1f433b017185ce78525ad097e609be Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 21:37:04 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[Lldb-commits] [libc] [lldb] [libunwind] [clang] [compiler-rt] [mlir] [llvm] [lld] [flang] [libcxx] [clang-tools-extra] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
@@ -513,29 +547,113 @@ void RISCV::relocate(uint8_t *loc, const Relocation , uint64_t val) const { break; case R_RISCV_RELAX: -return; // Ignored (for now) - +return; + case R_RISCV_TLSDESC: +// The addend is stored in the second word. +if

[Lldb-commits] [libc] [lldb] [libunwind] [clang] [compiler-rt] [mlir] [llvm] [lld] [flang] [libcxx] [clang-tools-extra] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [flang] [libc] [clang] [lld] [clang-tools-extra] [libcxx] [compiler-rt] [libunwind] [llvm] [mlir] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79239 >From 3725fa4eac3d3d946289d7eb7213f3a1751a2770 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 17:58:07 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [lldb] [libcxx] [libc] [clang] [clang-tools-extra] [libunwind] [compiler-rt] [lld] [flang] [llvm] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
H-G-Hristov wrote: I noticed some of clang-cl test crashed. I rebased again. https://github.com/llvm/llvm-project/pull/79032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libcxx] [libc] [clang] [clang-tools-extra] [libunwind] [compiler-rt] [lld] [flang] [llvm] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #7903

2024-01-24 Thread Hristo Hristov via lldb-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/79032 >From e03452fda84a5284420bba1913299b68caabb6cd Mon Sep 17 00:00:00 2001 From: Zingam Date: Mon, 22 Jan 2024 20:35:00 +0200 Subject: [PATCH 1/2] Revert "Revert "[libc++][format] P2637R3: Member `visit`

[Lldb-commits] [libunwind] [llvm] [libc] [flang] [clang-tools-extra] [clang] [libcxx] [lld] [compiler-rt] [lldb] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Paul Kirth via lldb-commits
https://github.com/ilovepi approved this pull request. LGTM on my end. Thanks for all the help on this. https://github.com/llvm/llvm-project/pull/79239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [flang] [libunwind] [llvm] [clang] [lld] [lldb] [libc] [clang-tools-extra] [compiler-rt] [libcxx] [X86] Use RORX over SHR imm (PR #77964)

2024-01-24 Thread Bryce Wilson via lldb-commits
https://github.com/Bryce-MW updated https://github.com/llvm/llvm-project/pull/77964 >From d4c312b9dbf447d0a53dda0e6cdc482bd908430b Mon Sep 17 00:00:00 2001 From: Bryce Wilson Date: Fri, 12 Jan 2024 16:01:32 -0600 Subject: [PATCH 01/14] [X86] Use RORX over SHR imm ---

[Lldb-commits] [flang] [libunwind] [llvm] [clang] [lldb] [libc] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [libunwind] [llvm] [clang] [lldb] [libc] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
@@ -0,0 +1,125 @@ +# REQUIRES: riscv +# RUN: rm -rf %t && split-file %s %t && cd %t +# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax a.s -o a.64.o +# RUN: llvm-mc -filetype=obj -triple=riscv64 -mattr=+c,+relax c.s -o c.64.o +# RUN: ld.lld -shared -soname=c.64.so

[Lldb-commits] [lldb] [llvm] [compiler-rt] [flang] [clang] [clang-tools-extra] [libunwind] [lld] [libc] [libcxx] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79239 >From 3725fa4eac3d3d946289d7eb7213f3a1751a2770 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 17:58:07 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [flang] [libunwind] [llvm] [clang] [lldb] [libc] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [ELF] Implement R_RISCV_TLSDESC for RISC-V (PR #79239)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [clang-tools-extra] [flang] [libc] [llvm] [lld] [compiler-rt] [lldb] [clang] [libunwind] [Driver, CodeGen] Support -mtls-dialect= (PR #79256)

2024-01-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bb6a4850553dd4140a5bd63187ec1b14d0b731f9 7953afb6b942ac645c5165bc38e3694265ef4d5d --

[Lldb-commits] [libcxx] [clang-tools-extra] [flang] [libc] [llvm] [lld] [compiler-rt] [lldb] [clang] [libunwind] [Driver, CodeGen] Support -mtls-dialect= (PR #79256)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libunwind] [compiler-rt] [lld] [clang-tools-extra] [clang] [lldb] [libcxx] [flang] [llvm] [libc] [Driver, CodeGen] Support -mtls-dialect= (PR #79256)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79256 >From be08e64c2c1f433b017185ce78525ad097e609be Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 21:37:04 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

[Lldb-commits] [llvm] [libcxx] [libc] [clang] [flang] [compiler-rt] [libcxxabi] [lldb] [clang-tools-extra] [lld] [NVPTX] Improve lowering of v4i8 (PR #67866)

2024-01-24 Thread Justin Fargnoli via lldb-commits
@@ -2110,6 +2214,29 @@ def : Pat<(seteq Int1Regs:$a, Int1Regs:$b), def : Pat<(setueq Int1Regs:$a, Int1Regs:$b), (NOT1 (XORb1rr Int1Regs:$a, Int1Regs:$b))>; +// comparisons of i8 extracted with BFE as i32 +def: Pat<(setgt (sext_inreg (trunc Int32Regs:$a), i8),

[Lldb-commits] [lldb] [clang] [NFC][Clang] Improve const correctness for IdentifierInfo (PR #79365)

2024-01-24 Thread Bill Wendling via lldb-commits
bwendling wrote: > I'd like to wait a few weeks before we land it, I'm afraid these changes > (which do contain some small white spaces-only changes too) might disrupt the > release process as lot of cherry-picking between main and the llvm18 branch > are happening and we should minimize the

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResource::SetID method (PR #79389)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/79389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 56da799 - [lldb] [NFC] Remove unused WatchpointResource::SetID method (#79389)

2024-01-24 Thread via lldb-commits
Author: Jason Molenda Date: 2024-01-24T15:18:49-08:00 New Revision: 56da7991ead442b7c0ef9ec47d625253ed6b926e URL: https://github.com/llvm/llvm-project/commit/56da7991ead442b7c0ef9ec47d625253ed6b926e DIFF: https://github.com/llvm/llvm-project/commit/56da7991ead442b7c0ef9ec47d625253ed6b926e.diff

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResourceList class (PR #79385)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/79385 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bddeef5 - [lldb] [NFC] Remove unused WatchpointResourceList class (#79385)

2024-01-24 Thread via lldb-commits
Author: Jason Molenda Date: 2024-01-24T15:18:33-08:00 New Revision: bddeef54cb66609ad0a32d840051713cd8487adb URL: https://github.com/llvm/llvm-project/commit/bddeef54cb66609ad0a32d840051713cd8487adb DIFF: https://github.com/llvm/llvm-project/commit/bddeef54cb66609ad0a32d840051713cd8487adb.diff

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResource::SetID method (PR #79389)

2024-01-24 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResourceList class (PR #79385)

2024-01-24 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Thanks for taking care of that! https://github.com/llvm/llvm-project/pull/79385 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang-tools-extra] [libclc] [libcxxabi] [clang] [lld] [lldb] [flang] [libc] [llvm] [libcxx] [compiler-rt] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
@@ -498,10 +498,34 @@ static VPValue *createScalarIVSteps(VPlan , const InductionDescriptor , VPCanonicalIVPHIRecipe *CanonicalIV = Plan.getCanonicalIV(); Type *TruncTy = TruncI ? TruncI->getType() : IVTy; VPValue *BaseIV = CanonicalIV; ayalz wrote:

[Lldb-commits] [flang] [compiler-rt] [libclc] [clang-tools-extra] [llvm] [clang] [libc] [libcxxabi] [lldb] [libcxx] [lld] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
https://github.com/ayalz commented: Nice reuse and clean-up! Title and commit message deserve an update. https://github.com/llvm/llvm-project/pull/78113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [libc] [llvm] [clang-tools-extra] [libcxxabi] [flang] [lld] [compiler-rt] [clang] [libcxx] [libclc] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
@@ -1469,6 +1461,52 @@ void VPReplicateRecipe::print(raw_ostream , const Twine , } #endif +static bool isUniformAcrossVFsAndUFs(VPScalarCastRecipe *C) { ayalz wrote: Worth documenting, potentially leaving behind a note that uniformity should essentially be

[Lldb-commits] [llvm] [clang] [flang] [lldb] [libcxxabi] [libc] [libcxx] [libclc] [lld] [compiler-rt] [clang-tools-extra] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
@@ -1469,6 +1461,52 @@ void VPReplicateRecipe::print(raw_ostream , const Twine , } #endif +static bool isUniformAcrossVFsAndUFs(VPScalarCastRecipe *C) { + return C->isDefinedOutsideVectorRegions() || + isa(C->getOperand(0)) || + isa(C->getOperand(0)); +} +

[Lldb-commits] [libc] [clang] [flang] [llvm] [compiler-rt] [libcxxabi] [clang-tools-extra] [libcxx] [lldb] [lld] [libclc] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
@@ -230,7 +230,11 @@ Type *VPTypeAnalysis::inferScalarType(const VPValue *V) { return V->getUnderlyingValue()->getType(); }) .Case( - [](const VPWidenCastRecipe *R) { return R->getResultType(); }); + [](const

[Lldb-commits] [libcxx] [compiler-rt] [libclc] [lld] [clang] [llvm] [libc] [lldb] [clang-tools-extra] [libcxxabi] [flang] [VPlan] Add new VPUniformPerUFRecipe, use for step truncation. (PR #78113)

2024-01-24 Thread via lldb-commits
https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/78113 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResource::SetID method (PR #79389)

2024-01-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes I originally thought to try to guesstimate the hardware watchpoint index number that a Resource was associated with, but gdb remote serial protocol doesn't give us the hardware register index used so

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResource::SetID method (PR #79389)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/79389 I originally thought to try to guesstimate the hardware watchpoint index number that a Resource was associated with, but gdb remote serial protocol doesn't give us the hardware register index used so it

[Lldb-commits] [lldb] Remove watchpointresource setid method (PR #79388)

2024-01-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/79388.diff 4 Files Affected: - (modified) lldb/include/lldb/Breakpoint/WatchpointResource.h (-8) - (removed)

[Lldb-commits] [lldb] Remove watchpointresource setid method (PR #79388)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/79388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove watchpointresource setid method (PR #79388)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/79388 None >From 229ea2a0311c7c0ecd8554016d3827f8c8ae6c5f Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 24 Jan 2024 14:45:41 -0800 Subject: [PATCH 1/2] [lldb] [NFC] Remove unused WatchpointResourceList

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResourceList class (PR #79385)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/79385 >From 229ea2a0311c7c0ecd8554016d3827f8c8ae6c5f Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 24 Jan 2024 14:45:41 -0800 Subject: [PATCH 1/2] [lldb] [NFC] Remove unused WatchpointResourceList class

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResourceList class (PR #79385)

2024-01-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In `[lldb] [mostly NFC] Large WP foundation: WatchpointResources (#68845)` I added a new template StopPointSiteList to combine WatchpointResourceList and BreakpointSiteList. But I didn't remove the

[Lldb-commits] [lldb] [lldb] [NFC] Remove unused WatchpointResourceList class (PR #79385)

2024-01-24 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/79385 In `[lldb] [mostly NFC] Large WP foundation: WatchpointResources (#68845)` I added a new template StopPointSiteList to combine WatchpointResourceList and BreakpointSiteList. But I didn't remove the

[Lldb-commits] [lldb] [clang] [openmp] [compiler-rt] [lld] [llvm] [libc] [libcxx] [clang-tools-extra] [mlir] [pstl] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Joseph Huber via lldb-commits
jhuber6 wrote: Maybe need to specify `--target=x86_64-unknown-linux-gnu` in the test? https://github.com/llvm/llvm-project/pull/79222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [clang] [openmp] [compiler-rt] [lld] [llvm] [libc] [libcxx] [clang-tools-extra] [mlir] [pstl] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread via lldb-commits
gulfemsavrun wrote: We started seeing a test failure in our Clang toolchain builders for Mac: ``` FAIL: Clang :: Driver/unsupported-option-gpu.c (10452 of 19269) TEST 'Clang :: Driver/unsupported-option-gpu.c' FAILED Exit Code: 1 Command Output

[Lldb-commits] [lldb] [clang] [NFC][Clang] Improve const correctness for IdentifierInfo (PR #79365)

2024-01-24 Thread via lldb-commits
cor3ntin wrote: I think this is nice, thanks! I'd like to wait a few weeks before we land it, I'm afraid these changes (which do contain some small white spaces-only changes too) might disrupt the release process as lot of cherry-picking between main and the llvm18 branch are happening and

[Lldb-commits] [clang] [lldb] [NFC][Clang] Improve const correctness for IdentifierInfo (PR #79365)

2024-01-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang-modules Author: Bill Wendling (bwendling) Changes The IdentifierInfo isn't typically modified. Use 'const' wherever possible. --- Patch is 173.17 KiB, truncated to 20.00 KiB below, full version:

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread Erich Keane via lldb-commits
erichkeane wrote: Fixed in : e3ee3762304aa81e4a240500844bfdd003401b36 https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang] [clang-tools-extra] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread Erich Keane via lldb-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Erich Keane via lldb-commits
erichkeane wrote: Fixed in: e3ee3762304aa81e4a240500844bfdd003401b36 I'll submit a request to cherry-pick to the release branch. https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: The tests are passed. Maybe, someone else could write a test and commit? I'm slightly busy. https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [compiler-rt] [flang] [clang-tools-extra] [libc] [lld] [libcxx] [lldb] [clang] [llvm] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-24 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/4] Make clang report invalid target versions for all

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Erich Keane via lldb-commits
erichkeane wrote: That certainly makes sense to me. Can you submit a patch for review to do so, then we can get it cherry-picked to 18? It would be great if we could save this feature in 18. https://github.com/llvm/llvm-project/pull/78041 ___

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: @erichkeane, @cor3ntin, argument types [here](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaTemplateDeduction.cpp#L3022) occurs to be different with sugar added to one of them. This patch fixes the problem: ``` --- a/clang/lib/AST/TemplateBase.cpp +++

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [lld] [libc] [compiler-rt] [llvm] [libcxx] [flang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-24 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/3] Make clang report invalid target versions for all

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [lld] [libc] [compiler-rt] [llvm] [libcxx] [flang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-24 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/3] Make clang report invalid target versions for all

[Lldb-commits] [lld] [flang] [libc] [libcxx] [clang-tools-extra] [llvm] [lldb] [clang] [compiler-rt] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-24 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH 1/2] Make clang report invalid target versions for all

[Lldb-commits] [lld] [libc] [openmp] [lldb] [compiler-rt] [clang] [libcxx] [llvm] [clang-tools-extra] [mlir] [pstl] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/79222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [libc] [openmp] [lldb] [compiler-rt] [clang] [libcxx] [llvm] [clang-tools-extra] [mlir] [pstl] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Fangrui Song via lldb-commits
@@ -0,0 +1,5 @@ +/// Some target-specific options are ignored for GPU, so %clang exits with code 0. +// DEFINE: %{check} = %clang -### -c -mcmodel=medium MaskRay wrote: In general the error reporting is done in the driver and cc1 allows and ignores options

[Lldb-commits] [lldb] [lld] [mlir] [flang] [clang-tools-extra] [libunwind] [clang] [openmp] [libcxx] [compiler-rt] [llvm] [libc] [pstl] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone

2024-01-24 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: Hmm, interesting. Thanks for the fix. https://github.com/llvm/llvm-project/pull/79238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2024-01-24 Thread via lldb-commits
jimingham wrote: The reason that we use ValueObjectSP() returns rather than {} in a lot of this code is because the `return {}` construct came along with C++11, which was not available when most of this code was written. I don't think anyone would mind switching over to {}. I usually like

[Lldb-commits] [libcxx] [pstl] [lld] [llvm] [lldb] [clang] [libc] [compiler-rt] [mlir] [clang-tools-extra] [openmp] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Artem Belevich via lldb-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/79222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [pstl] [lld] [llvm] [lldb] [clang] [libc] [compiler-rt] [mlir] [clang-tools-extra] [openmp] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Artem Belevich via lldb-commits
@@ -0,0 +1,5 @@ +/// Some target-specific options are ignored for GPU, so %clang exits with code 0. +// DEFINE: %{check} = %clang -### -c -mcmodel=medium Artem-B wrote: In this particular case, the changes we test (and the error messages) were originating in

[Lldb-commits] [lldb] [pstl] [llvm] [mlir] [libc] [compiler-rt] [libcxx] [openmp] [clang-tools-extra] [clang] [lld] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Joseph Huber via lldb-commits
@@ -0,0 +1,5 @@ +/// Some target-specific options are ignored for GPU, so %clang exits with code 0. +// DEFINE: %{check} = %clang -### -c -mcmodel=medium jhuber6 wrote: Probably depends on the option we're testing. We could do both.

[Lldb-commits] [lldb] [clang-tools-extra] [clang] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: I suspect the reason is in the array-to-pointer conversion in `StructuralValue` argument. Maybe this will help someone to invent a fix quickly... https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [pstl] [llvm] [mlir] [libc] [compiler-rt] [libcxx] [openmp] [clang-tools-extra] [clang] [lld] [Driver] Test ignored target-specific options for AMDGPU/NVPTX (PR #79222)

2024-01-24 Thread Artem Belevich via lldb-commits
@@ -0,0 +1,5 @@ +/// Some target-specific options are ignored for GPU, so %clang exits with code 0. +// DEFINE: %{check} = %clang -### -c -mcmodel=medium Artem-B wrote: > Also, what exactly are we checking here? With `-###` CC1 sub-compilations do > not run

[Lldb-commits] [lldb] [llvm] [libc] [compiler-rt] [libcxx] [flang] [clang-tools-extra] [clang] [lld] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread via lldb-commits
cor3ntin wrote: > @cor3ntin , I wonder, since we want to claim it as an extension in earlier > language modes, should I actually add an option for this extension and set > these flags to this option value, not even language mode? Or is that not > worth it? As long as there is an extension

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread David Blaikie via lldb-commits
@@ -5401,6 +5409,8 @@ std::string CGDebugInfo::GetName(const Decl *D, bool Qualified) const { // feasible some day. return TA.getAsIntegral().getBitWidth() <= 64 && IsReconstitutableType(TA.getIntegralType()); + case

[Lldb-commits] [libc] [lld] [clang] [libunwind] [compiler-rt] [flang] [lldb] [openmp] [libcxx] [mlir] [llvm] [pstl] [clang-tools-extra] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/79238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lld] [clang] [libunwind] [compiler-rt] [flang] [lldb] [openmp] [libcxx] [mlir] [llvm] [pstl] [clang-tools-extra] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone

2024-01-24 Thread Fangrui Song via lldb-commits
MaskRay wrote: Fixed a typo and added an example > ``` > // clang -g > __attribute__((weak)) int symbol; > int *foo() { return } > > 0x0023: DW_TAG_variable [2] (0x000c) > ... > DW_AT_location [DW_FORM_exprloc](DW_OP_addrx 0x0) > ``` > >

[Lldb-commits] [libc] [lld] [clang] [libunwind] [compiler-rt] [flang] [lldb] [openmp] [libcxx] [mlir] [llvm] [pstl] [clang-tools-extra] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79238 >From 97b500a7061041b5478b6b1b1094e76140e3d9c3 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 17:53:31 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [pstl] [libcxx] [lldb] [llvm] [compiler-rt] [libunwind] [mlir] [clang-tools-extra] [libc] [flang] [clang] [lld] [openmp] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [clang] [compiler-rt] [flang] [lldb] [libcxx] [llvm] [libc] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
Fznamznon wrote: > Line 551 in > [99cae9a](https://github.com/llvm/llvm-project/commit/99cae9a44fca4cfbd6ee82f196051cbdf6571fa1) will set DefaultedDestructorIsConstexpr regardless of language mode, which it should not. @cor3ntin , I wonder, since we want to claim it as an extension in

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/77753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
@@ -356,14 +356,7 @@ C++23 implementation status Relaxing some constexpr restrictions https://wg21.link/P2448R2;>P2448R2 - -Clang 17 (Partial) - We do not support outside of defaulted special memeber functions the change that constexpr

[Lldb-commits] [lld] [libcxx] [flang] [clang] [libc] [compiler-rt] [lldb] [llvm] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread via lldb-commits
cor3ntin wrote: This is rather unfortunate, I hope we can figure that out quickly https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread via lldb-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2024-01-24 Thread Michał Górny via lldb-commits
mgorny wrote: I'm sorry for the complexity. I've finally gotten around to figuring it out, and it turns out it's a problem with CMake files: #79305 fixes it for me. https://github.com/llvm/llvm-project/pull/70996 ___ lldb-commits mailing list

[Lldb-commits] [clang-tools-extra] [lldb] [clang] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-codegen Author: Erich Keane (erichkeane) Changes Reverts llvm/llvm-project#78041 Based on this comment: https://github.com/llvm/llvm-project/pull/78041#issuecomment-1908243345

[Lldb-commits] [lldb] [clang] [clang-tools-extra] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff aaa93ce7323332d8290b8f563d4d71689c1094c5 7d1982f62bfc9ec897d8dc8837100c6c2f2de156 --

[Lldb-commits] [lldb] [clang] [clang-tools-extra] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread Erich Keane via lldb-commits
https://github.com/erichkeane ready_for_review https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang] [clang-tools-extra] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread Erich Keane via lldb-commits
erichkeane wrote: Waiting on CI bots, then I'll submit this revert, then request this for cherry-pick to the 18 branch. https://github.com/llvm/llvm-project/pull/79302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [clang] [clang-tools-extra] Revert "[c++20] P1907R1: Support for generalized non-type template arguments of scalar type." (PR #79302)

2024-01-24 Thread Erich Keane via lldb-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/79302 Reverts llvm/llvm-project#78041 Based on this comment: https://github.com/llvm/llvm-project/pull/78041#issuecomment-1908243345 and the author's nonavailability to get to it quickly, we're reverting (and

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread Andrey Ali Khan Bolshakov via lldb-commits
bolshakov-a wrote: Thanks! I'll probably take a look in my spare time. Feel free to revert this. https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-01-24 Thread via lldb-commits
bgra8 wrote: @bolshakov-a this is causing a regression in the way partial template specializations work. For the following reproducer the partial template specialization is not used by the compiler when it is expected it should be used: ``` const char kt[] = "dummy"; template class

[Lldb-commits] [libcxx] [lld] [clang] [lldb] [clang-tools-extra] [flang] [libc] [compiler-rt] [llvm] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread via lldb-commits
@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect

[Lldb-commits] [libc] [lld] [flang] [clang] [libcxx] [compiler-rt] [llvm] [clang-tools-extra] [lldb] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect

[Lldb-commits] [clang] [libc] [compiler-rt] [libcxx] [lldb] [pstl] [flang] [clang-tools-extra] [mlir] [openmp] [lld] [llvm] [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (PR #

2024-01-24 Thread Mariusz Sikora via lldb-commits
Mirko =?utf-8?q?Brkušanin?= , Mirko =?utf-8?q?Brkušanin?= ,Mirko Brkusanin ,Mariusz Sikora Message-ID: In-Reply-To: https://github.com/mariusz-sikora-at-amd closed https://github.com/llvm/llvm-project/pull/78414 ___ lldb-commits mailing list

[Lldb-commits] [clang-tools-extra] [flang] [compiler-rt] [lld] [llvm] [libcxx] [clang] [lldb] [libc] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread via lldb-commits
@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect

[Lldb-commits] [clang-tools-extra] [flang] [compiler-rt] [lld] [llvm] [libcxx] [clang] [lldb] [libc] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread via lldb-commits
@@ -356,14 +356,7 @@ C++23 implementation status Relaxing some constexpr restrictions https://wg21.link/P2448R2;>P2448R2 - -Clang 17 (Partial) - We do not support outside of defaulted special memeber functions the change that constexpr

[Lldb-commits] [libcxx] [mlir] [openmp] [pstl] [clang-tools-extra] [llvm] [lld] [lldb] [clang] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone in non-SHF_ALLOC sections (PR #79238)

2024-01-24 Thread Peter Smith via lldb-commits
https://github.com/smithp35 approved this pull request. Code changes LGTM too. I can't think of a case when a C/C++ compiler would directly generate a reference to an SHN_ABS symbol as I don't think there is a way of expressing such a symbol in C/C++ and debug generation concentrates on

[Lldb-commits] [lldb] [flang] [clang-tools-extra] [libcxx] [clang] [lld] [llvm] [compiler-rt] [libc] [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (PR #78414)

2024-01-24 Thread Mariusz Sikora via lldb-commits
Mirko =?utf-8?q?Brkušanin?= , Mirko =?utf-8?q?Brkušanin?= ,Mirko Brkusanin ,Mariusz Sikora Message-ID: In-Reply-To: @@ -8770,6 +8781,22 @@ void AMDGPUAsmParser::cvtVOP3DPP(MCInst , const OperandVector , } } +int VdstInIdx = AMDGPU::getNamedOperandIdx(Opc,

[Lldb-commits] [llvm] [pstl] [clang] [mlir] [libcxx] [clang-tools-extra] [lld] [openmp] [lldb] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone in non-SHF_ALLOC sections (PR #79238)

2024-01-24 Thread Bevin Hansson via lldb-commits
https://github.com/bevin-hansson commented: This looks good to me, but someone else should probably chime in as well to approve. https://github.com/llvm/llvm-project/pull/79238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [flang] [libc] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [libcxx] [lld] [clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
@@ -9108,7 +9123,8 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S, FunctionDecl *FD, // declaration, it is implicitly considered to be constexpr. // FIXME: Only applying this to the first declaration seems problematic, as // simple reorderings can affect

[Lldb-commits] [flang] [libc] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [libcxx] [lld] [clang] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
@@ -356,14 +356,7 @@ C++23 implementation status Relaxing some constexpr restrictions https://wg21.link/P2448R2;>P2448R2 - -Clang 17 (Partial) - We do not support outside of defaulted special memeber functions the change that constexpr

[Lldb-commits] [compiler-rt] [lld] [clang] [llvm] [libc] [libcxx] [lldb] [flang] [clang-tools-extra] [Clang][C++23] Implement P2448R2: Relaxing some constexpr restrictions (PR #77753)

2024-01-24 Thread Mariya Podchishchaeva via lldb-commits
Fznamznon wrote: > CheckConstexprFunctionDefinition will return false for a destructor if > defaultedDestructorIsConstexpr returns false (unless we want to emit a > diagnostic)` I see. So defaulted special members now *actually* constexpr. I've made that change. I confused everything with

[Lldb-commits] [lld] [clang] [llvm] [mlir] [pstl] [libcxx] [openmp] [lldb] [clang-tools-extra] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone in non-SHF_ALLOC sections (PR #79238)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79238 >From 97b500a7061041b5478b6b1b1094e76140e3d9c3 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Tue, 23 Jan 2024 17:53:31 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[Lldb-commits] [pstl] [lldb] [llvm] [openmp] [clang-tools-extra] [libcxx] [lld] [mlir] [clang] [ELF] Don't resolve relocations referencing SHN_ABS to tombstone in non-SHF_ALLOC sections (PR #79238)

2024-01-24 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >