@@ -0,0 +1,125 @@
+//===-- ProgressReportTest.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,125 @@
+//===-- ProgressReportTest.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData {
GetAsStructuredData(const Event *event_ptr);
uint64_t GetID() const { return m_id; }
- bool IsFinite() const { return m_total != UINT64_MAX; }
+ bool IsFinite() const { return m_total != 1; }
https://github.com/ampandey-1995 closed
https://github.com/llvm/llvm-project/pull/79795
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -218,6 +219,104 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass(
m_fallback.GetCompleteObjCClass(class_name, must_be_implementation,
callback);
}
+namespace {
+using Entry = llvm::DWARFDebugNames::Entry;
+
+/// If `entry` and all of its parents have an `IDX_parent`,
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData {
GetAsStructuredData(const Event *event_ptr);
uint64_t GetID() const { return m_id; }
- bool IsFinite() const { return m_total != UINT64_MAX; }
+ bool IsFinite() const { return m_total != 1; }
@@ -23,7 +23,6 @@ Progress::Progress(std::string title, std::string details,
lldb_private::Debugger *debugger)
: m_title(title), m_details(details), m_id(++g_id), m_completed(0),
m_total(1) {
clayborg wrote:
```
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData {
GetAsStructuredData(const Event *event_ptr);
uint64_t GetID() const { return m_id; }
- bool IsFinite() const { return m_total != UINT64_MAX; }
+ bool IsFinite() const { return m_total != 1; }
@@ -41,7 +41,7 @@ void ProgressEventData::Dump(Stream *s) const {
s->PutCString(", type = update");
// If m_total is UINT64_MAX, there is no progress to report, just "start"
// and "end". If it isn't we will show the completed and total amounts.
- if (m_total !=
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
6b330470df7db34ee1b894e0e2edf8270d5c51da...edd3cfa6559acb37331945e45887d2d5069d5179
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
This removes the dependency LLDB API tests have on
lldb/third_party/Python/module/unittest2, and instead uses the standard one
provided by Python.
This does not actually remove the vendored dep yet,
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/79945
This removes the dependency LLDB API tests have on
lldb/third_party/Python/module/unittest2, and instead uses the standard one
provided by Python.
This does not actually remove the vendored dep yet, nor
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/79795
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/79912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/NxPKG updated https://github.com/llvm/llvm-project/pull/79697
>From f7b4f61db6016a1a02d775efc1e921fac785e823 Mon Sep 17 00:00:00 2001
From: snyk-bot
Date: Fri, 19 Jan 2024 07:12:22 +
Subject: [PATCH 1/6] feat: upgrade vscode-languageclient from 8.0.2-next.5 to
9.0.1
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/79935
>From fa5210448dea1f88d8e0a242543ad1be655087e0 Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 30 Jan 2024 01:01:52 +
Subject: [PATCH 1/3] [mlir][sparse] Expand LevelType to 64 bit and implement
https://github.com/shamithoke updated
https://github.com/llvm/llvm-project/pull/77107
>From a0ccb2cbe3882a6ea8bb020dd54460f57dd84a90 Mon Sep 17 00:00:00 2001
From: shami
Date: Thu, 28 Dec 2023 21:29:36 +0530
Subject: [PATCH] LLVM_FAULTMAPS section can be put after the DWARF section.
---
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This commit changes DebugNamesDWARFIndex so that it now overrides
`GetFullyQualifiedType` and attempts to use DW_IDX_parent, when available, to
speed up such queries. When this type of
felipepiovezan wrote:
The unittests here depend on https://github.com/llvm/llvm-project/pull/79666
https://github.com/llvm/llvm-project/pull/79932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/79932
This commit changes DebugNamesDWARFIndex so that it now overrides
`GetFullyQualifiedType` and attempts to use DW_IDX_parent, when available, to
speed up such queries. When this type of information is not
https://github.com/dcaballe closed
https://github.com/llvm/llvm-project/pull/79494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1666,33 +1646,52 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
// the user's options.
ProcessSP process_sp = target.GetProcessSP();
-int stop_action = -1; // -1 means leave the current setting alone
-int pass_action = -1; // -1
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Sounds like a good plan.
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 3cd6afa16fb8b282712b1d3cf103abbd3329fc17 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Minor refactor to
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public
CommandObjectRaw {
CompletionType m_completion_type = eNoCompletion;
};
+
+/// This command implements a lldb parsed scripted command. The command
+/// provides a definition of the options and arguments,
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public
CommandObjectRaw {
CompletionType m_completion_type = eNoCompletion;
};
+
+/// This command implements a lldb parsed scripted command. The command
+/// provides a definition of the options and arguments,
bulbazord wrote:
Okay, here's what I'll do then:
1. I will remove `VerifyCommandOptionValue` and replace uses of it with
`OptionArgParser::ToBoolean`.
2. Afterwards, I will change the interface of `OptionArgParser::ToBoolean`.
https://github.com/llvm/llvm-project/pull/79901
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public
CommandObjectRaw {
CompletionType m_completion_type = eNoCompletion;
};
+
+/// This command implements a lldb parsed scripted command. The command
+/// provides a definition of the options and arguments,
@@ -1591,24 +1591,24 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
Options *GetOptions() override { return _options; }
- bool VerifyCommandOptionValue(const std::string , int _value) {
-bool okay = true;
+ std::optional
jimingham wrote:
Looks like I wasn't the one that added this, so I don't feel so bad I can't
remember why I did it this way...
I think this VerifyCommandOptionValue is just a historical artifact, we should
remove it and do what all the other boolean options do.
Jim
> On Jan 29, 2024, at
@@ -1591,24 +1591,24 @@ class CommandObjectProcessHandle : public
CommandObjectParsed {
Options *GetOptions() override { return _options; }
- bool VerifyCommandOptionValue(const std::string , int _value) {
-bool okay = true;
+ std::optional
https://github.com/clayborg requested changes to this pull request.
We should be modify `OptionArgParser::ToBoolean(...)` to return a
`std::optional` instead of a local function. It already handles integer
strings "0" and "1" correctly. Granted it doesn't allow "00" or "01" to be
specified,
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/79901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,315 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for you command that inherits from
ParsedCommandBase.
+That will make an LLDBOVParser which you will use for your
jimingham wrote:
> > This version is still a little awkward because there's an ambiguity about
> > what the incoming string being empty means. In the
> > VerifyCommandOptionValue, it means "No Value" and the return is not
> > distinguishable from "error" - but in a bunch of the places where
clayborg wrote:
Even if we want to have the skeleton compile unit be parsed first, we would
need to know this from any accelerator table entry, wether it be from
.debug_names or from our internal manual index. Our internal manual index
creates a DIERef object with a magic .dwp file index + a
https://github.com/nmustakin updated
https://github.com/llvm/llvm-project/pull/70667
>From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001
From: Nafis Mustakin
Date: Mon, 30 Oct 2023 07:50:59 -0700
Subject: [PATCH 1/6] Add memory diff dump for kernel record-replay
---
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/79912
>From af9a5581702b5c9ca8009fc32c7ae10a1654d391 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 29 Jan 2024 15:29:46 -0800
Subject: [PATCH] [lldb][progress] Correctly check total for
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
The `total` parameter for the constructor for Progress was changed to a
std::optional in https://github.com/llvm/llvm-project/pull/77547. When
initializing the `m_total` member variable for
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/79912
The `total` parameter for the constructor for Progress was changed to a
std::optional in https://github.com/llvm/llvm-project/pull/77547. When
initializing the `m_total` member variable for progress, it
https://github.com/yronglin closed
https://github.com/llvm/llvm-project/pull/76361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> This version is still a little awkward because there's an ambiguity about
> what the incoming string being empty means. In the VerifyCommandOptionValue,
> it means "No Value" and the return is not distinguishable from "error" - but
> in a bunch of the places where you use
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From 1f81c3e01a12682ad514038d2e9f1baea80dcf03 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/3] [lldb][NFCI] Remove m_being_created from Breakpoint
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
jimingham wrote:
I don't think you need to mention crashing lldb. Even if we fix that, telling
the world about something that's not
jimingham wrote:
This version is still a little awkward because there's an ambiguity about what
the incoming string being empty means. In the VerifyCommandOptionValue, it
means "No Value" and the return is not distinguishable from "error" - but in a
bunch of the places where you use
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79901
>From 7ce769f1a5bde83e0ff7ae36852c7a742bbb990b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 29 Jan 2024 13:15:24 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Minor refactor to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e633807a1fccbed91dbfe1fdc2c78adcaf21d99c
7ce769f1a5bde83e0ff7ae36852c7a742bbb990b --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
I was refactoring something else but ran into this function. It was somewhat
confusing to read through and understand, but it boils down to two steps:
- First we try `OptionArgParser::ToBoolean`. If that
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/79901
I was refactoring something else but ran into this function. It was somewhat
confusing to read through and understand, but it boils down to two steps:
- First we try `OptionArgParser::ToBoolean`. If that
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
@jimingham how does this look to you?
https://github.com/llvm/llvm-project/pull/79716
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/srcarroll updated
https://github.com/llvm/llvm-project/pull/79626
>From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001
From: Sam
Date: Fri, 26 Jan 2024 11:55:06 -0600
Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body
---
https://github.com/evodius96 approved this pull request.
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
evodius96 wrote:
Added a couple of comments, but otherwise LGTM. Thank you for optimizing this.
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Jason Molenda
Date: 2024-01-29T11:01:08-08:00
New Revision: 547c395b279a93357082ac06cf3e8fe37ebfc3fe
URL:
https://github.com/llvm/llvm-project/commit/547c395b279a93357082ac06cf3e8fe37ebfc3fe
DIFF:
https://github.com/llvm/llvm-project/commit/547c395b279a93357082ac06cf3e8fe37ebfc3fe.diff
Author: Adrian Prantl
Date: 2024-01-29T11:00:49-08:00
New Revision: 5dce6353b5e42248c7271f7694613831a6d427de
URL:
https://github.com/llvm/llvm-project/commit/5dce6353b5e42248c7271f7694613831a6d427de
DIFF:
https://github.com/llvm/llvm-project/commit/5dce6353b5e42248c7271f7694613831a6d427de.diff
https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/79032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-01-29T10:43:33-08:00
New Revision: 61384850c5950b8c5ee0abd75982f5cad8f98536
URL:
https://github.com/llvm/llvm-project/commit/61384850c5950b8c5ee0abd75982f5cad8f98536
DIFF:
https://github.com/llvm/llvm-project/commit/61384850c5950b8c5ee0abd75982f5cad8f98536.diff
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -353,71 +331,30 @@ class MCDCRecordProcessor {
}
}
- /// For a given condition and two executed Test Vectors, A and B, see if the
- /// two test vectors match forming an Independence Pair for the condition.
- /// For two test vectors to match, the following must
@@ -458,7 +395,7 @@ class MCDCRecordProcessor {
MCDCRecord::TestVector TV(NumConditions, MCDCRecord::MCDC_DontCare);
// Use the base test vector to build the list of all possible test vectors.
-buildTestVector(TV);
+buildTestVector(TV, 1, 0);
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/79727
>From 1d2470c2d67673f9ef9ea504e0abb3e964d43ebb Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Sat, 27 Jan 2024 22:24:39 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/79727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/79716
>From fc0c5da871d32a7cf5a6c96ef7f36c49aeccd074 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Sat, 27 Jan 2024 15:54:16 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Remove m_being_created from Breakpoint
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
bulbazord wrote:
Sure
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits
https://github.com/srcarroll updated
https://github.com/llvm/llvm-project/pull/79626
>From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001
From: Sam
Date: Fri, 26 Jan 2024 11:55:06 -0600
Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body
---
jimingham wrote:
LGTM - the new API could use a comment but otherwise this is fine.
https://github.com/llvm/llvm-project/pull/79716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -313,6 +313,8 @@ class BreakpointLocation
void UndoBumpHitCount();
+ void SetThreadIDInternal(lldb::tid_t thread_id);
jimingham wrote:
Could you put a comment in here saying how this is different from SetThreadID?
https://github.com/srcarroll updated
https://github.com/llvm/llvm-project/pull/79626
>From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001
From: Sam
Date: Fri, 26 Jan 2024 11:55:06 -0600
Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body
---
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/76361
>From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 27 Jan 2024 23:25:57 +0800
Subject: [PATCH 1/4] [Clang] Implement P2718R0 "Lifetime extension in
range-based
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/76361
>From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 27 Jan 2024 23:25:57 +0800
Subject: [PATCH 1/3] [Clang] Implement P2718R0 "Lifetime extension in
range-based
https://github.com/srcarroll updated
https://github.com/llvm/llvm-project/pull/79626
>From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001
From: Sam
Date: Fri, 26 Jan 2024 11:55:06 -0600
Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body
---
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/3] Add support for DW_OP_WASM_location to DWARFExpression
https://github.com/alexey-bataev approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/79475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
paolosevMSFT wrote:
Adding unit tests turned out to be a little complicated.
There were already a couple of unit tests in file
_lldb/unittests/Expression/DWARFExpressionTest.cpp_ that actually were failing
with these changes, so I replaced them.
>From the tests I learned that the
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cabe8be6bb2120828a741217365be975c59ac7b6
639295de7bdd4a2e710b62337a511ded92eb702a --
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/2] Add support for DW_OP_WASM_location to DWARFExpression
bolshakov-a wrote:
@zmodem, thanks! Added the fix to #79764.
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-01-29T03:50:36-08:00
New Revision: febb4c42b192ed7c88c17f91cb903a59acf20baf
URL:
https://github.com/llvm/llvm-project/commit/febb4c42b192ed7c88c17f91cb903a59acf20baf
DIFF:
RamaMalladiAWS wrote:
> @RamaMalladiAWS Do you have examples of the IR that fails to lower to BFI?
> These things often turn out to be either a missing middle-end
> canonicalization or maybe a case that could be added to existing pattern
> matching in the back-end.
Yes, @RKSimon, I will try
Author: Med Ismail Bennani
Date: 2024-01-29T03:17:33-08:00
New Revision: 888501bc631c4f6d373b4081ff6c504a1ce4a682
URL:
https://github.com/llvm/llvm-project/commit/888501bc631c4f6d373b4081ff6c504a1ce4a682
DIFF:
RKSimon wrote:
@RamaMalladiAWS Do you have examples of the IR that fails to lower to BFI?
These things often turn out to be either a missing middle-end canonicalization
or maybe a case that could be added to existing pattern matching in the
back-end.
TamarChristinaArm wrote:
@vitalybuka I'm trying to backport the fixes to the GCC branches. Do I just
need to backport these 4 commits?
https://github.com/llvm/llvm-project/pull/74000
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
RamaMalladiAWS wrote:
> OK. We would not usually add intrinsics like this without a strong motivating
> case, that could not be optimized in some other way. It is better to use
> target independent options when available, and inline assembly is available
> as a fallback if it is really
RamaMalladiAWS wrote:
Thank you @DavidSpickett
https://github.com/llvm/llvm-project/pull/79655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zmodem wrote:
We're hitting a "dyn_cast on a non-existent value" assert in Chromium after
this change. I've attached a reproducer here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1522775#c2
Based on the stack, this doesn't look the same as the analyzer issue (#79575)
but there are
Author: David Spickett
Date: 2024-01-29T10:11:16Z
New Revision: 89c9fee420e1ed099aaa4aab48f3b58e233a3ea9
URL:
https://github.com/llvm/llvm-project/commit/89c9fee420e1ed099aaa4aab48f3b58e233a3ea9
DIFF:
https://github.com/llvm/llvm-project/commit/89c9fee420e1ed099aaa4aab48f3b58e233a3ea9.diff
Author: David Spickett
Date: 2024-01-29T10:04:29Z
New Revision: 34d80f559a3ebaa354f7820022c5e050a47a9870
URL:
https://github.com/llvm/llvm-project/commit/34d80f559a3ebaa354f7820022c5e050a47a9870
DIFF:
https://github.com/llvm/llvm-project/commit/34d80f559a3ebaa354f7820022c5e050a47a9870.diff
@@ -14428,15 +14431,52 @@ SDValue PPCTargetLowering::combineSetCC(SDNode *N,
// x != 0-y --> x+y != 0
if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) &&
RHS.hasOneUse()) {
- SDLoc DL(N);
- SelectionDAG = DCI.DAG;
- EVT VT =
@@ -14428,15 +14431,52 @@ SDValue PPCTargetLowering::combineSetCC(SDNode *N,
// x != 0-y --> x+y != 0
if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) &&
RHS.hasOneUse()) {
- SDLoc DL(N);
- SelectionDAG = DCI.DAG;
- EVT VT =
@@ -14428,15 +14431,52 @@ SDValue PPCTargetLowering::combineSetCC(SDNode *N,
// x != 0-y --> x+y != 0
if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) &&
RHS.hasOneUse()) {
- SDLoc DL(N);
- SelectionDAG = DCI.DAG;
- EVT VT =
DavidSpickett wrote:
If you're referring to the CI that runs here, we've been having capacity issues
lately. Another way to "resubmit" is to rebase the PR.
https://github.com/llvm/llvm-project/pull/79655
___
lldb-commits mailing list
bzEq wrote:
Please provide more description in PR summary.
https://github.com/llvm/llvm-project/pull/66978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davemgreen wrote:
OK. We would not usually add intrinsics like this without a strong motivating
case, that could not be optimized in some other way. It is better to use target
independent options when available, and inline assembly is available as a
fallback if it is really needed. But I
98 matches
Mail list logo
