https://github.com/mtrofin approved this pull request.
LGTM for the `ctx_profile` part.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91886
>From f6135c1b825afd9fe733b845dfd12ffe3c162840 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sun, 12 May 2024 18:08:50 +0400
Subject: [PATCH 1/2] [lldb] Fixed the test TestQuoting
os.path.join() uses
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91887
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows host.
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1d6bf0ca29322b08e8b50681d440e7182441b025...f6135c1b825afd9fe733b845dfd12ffe3c162840
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
os.path.join() uses the path separator of the host OS by default. outfile_arg
will be incorrect in case of Windows host and Linux target. Use
lldbutil.append_to_process_working_directory() instead.
---
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91886
os.path.join() uses the path separator of the host OS by default. outfile_arg
will be incorrect in case of Windows host and Linux target. Use
lldbutil.append_to_process_working_directory() instead.
>From
https://github.com/ftynse approved this pull request.
LGTM for the MLIR part. Please seek approval from relevant reviewers for all
other subprojects.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
https://github.com/JOE1994 closed
https://github.com/llvm/llvm-project/pull/91880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JOE1994 wrote:
A new user already asked to be assigned to work on #91209 2 days ago in the
comments.
**I think that user deserves an opportunity to work on the issue**.
Next time when you see a **"good first issue"** which a new user had already
asked to get assigned to,
please assign it to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 63224d717108d927e998da8a67050a6cc5dd74a2
9b4160975efe059f39a842689b1f750a10453203 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (aabhinavg)
Changes
This commit addresses issue #87244, where a redundant condition was
found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
---
Full diff:
https://github.com/aabhinavg created
https://github.com/llvm/llvm-project/pull/91882
This commit addresses issue #87244, where a redundant condition was found in
the Target.cpp file. Static analyzer cppcheck flagged the issue in the
Target.cpp file
fix #87244
>From
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: None (aabhinavg)
Changes
Author: aabhinavg tiwariabhinavak@gmail.com
Date: Sun May 12 12:46:54 2024 +0800
Reviewers: @JOE1994, @chelcassanova, @dcb314
Fixes: #91209
Summary of Changes:
- Replaced the ineffective call to 'substr'
https://github.com/aabhinavg created
https://github.com/llvm/llvm-project/pull/91880
Author: aabhinavg
Date: Sun May 12 12:46:54 2024 +0800
Reviewers: @JOE1994, @chelcassanova, @dcb314
Fixes: #91209
Summary of Changes:
- Replaced the ineffective call to 'substr' with a more efficient use of
15 matches
Mail list logo
