[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/17] Add SBCommandInterpreter::GetTranscript() ---

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph approved this pull request. If you can push this to main in separate commits (one per project as it was mentioned?), that'd be great! https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list

[Lldb-commits] [lldb] c339226 - [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (#92476)

2024-05-16 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-05-16T20:47:12-07:00 New Revision: c33922666ce219fd6cb3341c3394f72050599552 URL: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552 DIFF: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552.diff

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > The change looks fine. Was this done with by hand or with the help of a > script? If so please put that in the commit message so we can do the same > downstream. Thank you for reviewing the patch! I did get help from a script, but it's a bit too involved for a commit

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92492 As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/92017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/92017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#92470 --- Full diff: https://github.com/llvm/llvm-project/pull/92490.diff 3 Files Affected: - (modified) lldb/bindings/CMakeLists.txt (-2) - (modified)

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/92490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5529278 - Revert "[lldb] Include SBLanguages in the SWIG bindings" (#92490)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:58:58-07:00 New Revision: 552927840319572a649cdec2d8bf2e688a5df490 URL: https://github.com/llvm/llvm-project/commit/552927840319572a649cdec2d8bf2e688a5df490 DIFF:

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/92490 Reverts llvm/llvm-project#92470 >From ebb9f82e4c6f9b7c6f627da71ffbfb858f655d1e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 May 2024 19:58:44 -0700 Subject: [PATCH] Revert "[lldb] Include

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: This should really be broken up into separate PRs per subproject. One large PR like this makes reviewing harder and causes unnecessary churn in the case that this gets reverted. https://github.com/llvm/llvm-project/pull/91857

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/92470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ebf2831 - [lldb] Include SBLanguages in the SWIG bindings (#92470)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:31:43-07:00 New Revision: ebf283162f5a0e7e9392c3a825e060856eee0991 URL: https://github.com/llvm/llvm-project/commit/ebf283162f5a0e7e9392c3a825e060856eee0991 DIFF:

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. The change looks fine. Was this done with by hand or with the help of a script? If so please put that in the commit message so we can do the same downstream. https://github.com/llvm/llvm-project/pull/92476

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Jakub Kuderski via lldb-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -1312,11 +1312,13 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream , bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_source, -

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -590,6 +591,7 @@ class ThreadPlanNull : public ThreadPlan { const Status () { return m_status; } protected: + friend class ThreadPlanSingleThreadTimeout; jeffreytan81 wrote: Hmm, I thought there is a reason I can't remember, apparently not. Removed.

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From b72df8cf2a047ed731913609b58bdb4a3601e111 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/4] Single thread timeout feature ---

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes Note that StringRef::equals has been deprecated in favor of operator==(StringRef, StringRef). --- Patch is 40.84 KiB, truncated to 20.00 KiB below, full version:

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/92476 StringRef) instead of StringRef::equals (NFC),Note that StringRef::equals has been deprecated in favor of operator==(StringRef, StringRef). >From ec50a9b1b95ed98e0ce0b7264bd4174e965d80f5 Mon Sep 17

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/18] Allow multiple destroy callbacks in

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-05-16 Thread John Harrison via lldb-commits
ashgti wrote: I just checked and I'm not seeing the hover's in the same format as they were when I made the pull request. The expression context should still have the expanded forms though for example: https://github.com/llvm/llvm-project/assets/22535/28db4adc-d488-44ff-8d99-78966e0e0e05;> I

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Ok, that should work. CMake knows about SBLanguages.h since there are rules to generate it. https://github.com/llvm/llvm-project/pull/92470 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/92470 >From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 May 2024 15:46:36 -0700 Subject: [PATCH 1/2] [lldb] Include SBLanguages in the SWIG bindings

[Lldb-commits] [lldb] [lldb-dap] Correctly detect alias commands with arguments in repl (PR #92137)

2024-05-16 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/92137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Actually, this has no dependency tracking. You'll need to add that for this > to work every time. It does actually, that's what the `SWIG_HEADERS` glob is used for. https://github.com/llvm/llvm-project/pull/92470 ___

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. Actually, this has no dependency tracking. You'll need to add that for this to work every time. https://github.com/llvm/llvm-project/pull/92470 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/92470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/92470.diff 3 Files Affected: - (modified) lldb/bindings/CMakeLists.txt (+2) - (modified) lldb/bindings/headers.swig (+1) - (modified)

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/92470 None >From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 May 2024 15:46:36 -0700 Subject: [PATCH] [lldb] Include SBLanguages in the SWIG bindings

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The stream already knows whether color support is enabled, but it looks like we're only storing that in the underlying llvm stream, which is commonly used in combination with `WithColor`. I think we could add a member to check if the stream has colors enabled. It's already

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread via lldb-commits
github-actions[bot] wrote: @Jlalond Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 47d80ec - [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (#92002)

2024-05-16 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-05-16T14:17:19-07:00 New Revision: 47d80ec1802d70082c8fd32b4396c98db2c4dba2 URL: https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2 DIFF: https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2.diff

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Zequan Wu via lldb-commits
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , if (!die) return false; + ParsedDWARFTypeAttributes attrs(die); ZequanWu wrote: The parsing happens every time when constructing this object, which makes it a

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Jacob Lalonde via lldb-commits
@@ -3857,8 +3857,8 @@ thread_result_t Process::RunPrivateStateThread(bool is_secondary_thread) { // case we should tell it to stop doing that. Normally, we don't NEED // to do that because we will next close the communication to the stub // and that

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Zequan Wu via lldb-commits
@@ -321,6 +326,10 @@ class SymbolFileDWARFDebugMap : public SymbolFileCommon { std::vector m_func_indexes; // Sorted by address std::vector m_glob_indexes; std::map>, OSOInfoSP> m_oso_map; + // A map from CompilerType to the struct/class/union/enum DIE (might be a +

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Zequan Wu via lldb-commits
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , if (!die) return false; + ParsedDWARFTypeAttributes attrs(die); ZequanWu wrote: This extra check was added in https://github.com/llvm/llvm-project/pull/91799 to

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2024-05-16 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Cool, sorry for the delay but I made changes to `Stream` and `SBStream` to add a `GetUseColor()` accessor and to change the bool it uses in initialization to a `std::optional` and I'm gonna put them up in a separate PR. https://github.com/llvm/llvm-project/pull/91404

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Jacob Lalonde via lldb-commits
@@ -6335,16 +6335,51 @@ static void AddRegion(const MemoryRegionInfo , bool try_dirty_pages, ranges.push_back(CreateCoreFileMemoryRange(region)); } +static void +SaveOffRegionsWithStackPointers(Process , + const MemoryRegionInfos , +

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/92002 >From 2d192f640b332c2f1381cf96b75be60ad18de3ac Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 10 May 2024 09:35:11 -0700 Subject: [PATCH 1/5] change core dump stacks to only include up to the stack

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Alex Langford via lldb-commits
@@ -0,0 +1,58 @@ +//===-- SBAddressRangeList.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Alex Langford via lldb-commits
@@ -242,6 +244,12 @@ class AddressRange { lldb::addr_t m_byte_size = 0; ///< The size in bytes of this address range. }; +// Forward-declarable wrapper. +class AddressRanges : public std::vector { +public: + using std::vector::vector; +}; bulbazord wrote:

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/92014 >From 1be2c95ae31621c6f5df72159f35b938318f9ed7 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 10 May 2024 12:42:03 -0700 Subject: [PATCH] Add AddressRange to SB API Summary: This adds new SB API calls and

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but the first file looks like this: ``` foundSpec = False if [...] foundSpec = True [...] if foundSpec is False: ``` It's pretty obvious this is a boolean and should use `if not foundSpec`.

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -6335,16 +6335,51 @@ static void AddRegion(const MemoryRegionInfo , bool try_dirty_pages, ranges.push_back(CreateCoreFileMemoryRange(region)); } +static void +SaveOffRegionsWithStackPointers(Process , + const MemoryRegionInfos , +

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -490,9 +491,12 @@ findStackHelper(const lldb::ProcessSP _sp, uint64_t rsp) { return llvm::createStringError( std::errc::not_supported, "unable to load stack segment of the process"); - - const addr_t addr = range_info.GetRange().GetRangeBase(); -

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -6335,16 +6335,51 @@ static void AddRegion(const MemoryRegionInfo , bool try_dirty_pages, ranges.push_back(CreateCoreFileMemoryRange(region)); } +static void +SaveOffRegionsWithStackPointers(Process , + const MemoryRegionInfos , +

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -6335,16 +6335,51 @@ static void AddRegion(const MemoryRegionInfo , bool try_dirty_pages, ranges.push_back(CreateCoreFileMemoryRange(region)); } +static void +SaveOffRegionsWithStackPointers(Process , + const MemoryRegionInfos , +

[Lldb-commits] [lldb] [lldb] Fixed the TestDebuggerAPI test on x86_64 Windows host (PR #90580)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/90580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 525bd66 - [lldb-dap] Separate user and developer documentation (#92428)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T10:41:06-07:00 New Revision: 525bd66fc29fd056ef18118dfff3c9cc05fdd5e3 URL: https://github.com/llvm/llvm-project/commit/525bd66fc29fd056ef18118dfff3c9cc05fdd5e3 DIFF:

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/92428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/92428 >From ca9fc570e4b721c36e5a0f9154e3158573bc5483 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 May 2024 09:44:57 -0700 Subject: [PATCH] [lldb-dap] Separate user and developer documentation

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process , if (!reg_ctx_sp) continue; const addr_t sp = reg_ctx_sp->GetSP(); +const size_t red_zone = process.GetABI()->GetRedZoneSize(); lldb_private::MemoryRegionInfo sp_region; if

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -731,8 +746,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton =

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/92416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c7ae8c6 - [lldb] Fixed the DAP tests in case of a remote target (#92416)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T21:30:31+04:00 New Revision: c7ae8c6639370ccbc583dca019bbb78761ce423d URL: https://github.com/llvm/llvm-project/commit/c7ae8c6639370ccbc583dca019bbb78761ce423d DIFF:

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/92014 >From 750414bde848902d3fe471e84912020a1f67d193 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 10 May 2024 12:42:03 -0700 Subject: [PATCH] Add AddressRange to SB API Summary: This adds new SB API calls and

[Lldb-commits] [lldb] [lldb] Fixed unresolved test lldb-api python_api/debugger/TestDebuggerAPI.py on x86_64 host (PR #90580)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I have added [the issuee](https://github.com/llvm/llvm-project/issues/92419) and updated the test with @expectedFailureAll and the bugnumber. https://github.com/llvm/llvm-project/pull/90580 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Fixed unresolved test lldb-api python_api/debugger/TestDebuggerAPI.py on x86_64 host (PR #90580)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/90580 >From 0d6ff964ed83e06ed3947d709884ed6dd43e90b5 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Tue, 30 Apr 2024 13:42:45 +0400 Subject: [PATCH 1/2] [lldb][Windows] Fixed unresolved test lldb-api

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Michael Buch via lldb-commits
@@ -321,6 +326,10 @@ class SymbolFileDWARFDebugMap : public SymbolFileCommon { std::vector m_func_indexes; // Sorted by address std::vector m_glob_indexes; std::map>, OSOInfoSP> m_oso_map; + // A map from CompilerType to the struct/class/union/enum DIE (might be a +

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Michael Buch via lldb-commits
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , if (!die) return false; + ParsedDWARFTypeAttributes attrs(die); Michael137 wrote: I've been wondering how expensive constructing this object is. On a brief

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster, CommandUsageMap m_command_usages; StreamString m_transcript_stream; + + /// Contains a list of handled commands, output and error. Each element in + /// the list is a dictionary with three keys:

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster, CommandUsageMap m_command_usages; StreamString m_transcript_stream; + + /// Contains a list of handled commands, output and error. Each element in + /// the list is a dictionary with three keys:

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. beautiful https://github.com/llvm/llvm-project/pull/92428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -571,6 +571,15 @@ SBStructuredData SBCommandInterpreter::GetStatistics() { return data; } +SBStructuredData SBCommandInterpreter::GetTranscript() { + LLDB_INSTRUMENT_VA(this); + + SBStructuredData data; + if (IsValid()) +

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread Greg Clayton via lldb-commits
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster, CommandUsageMap m_command_usages; StreamString m_transcript_stream; + + /// Contains a list of handled commands, output and error. Each element in + /// the list is a dictionary with three keys:

[Lldb-commits] [lldb] bd6c358 - [lldb-dap] Update repository in package.json

2024-05-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T09:54:47-07:00 New Revision: bd6c358d01f6ebc3851996e2c29c47b08e992525 URL: https://github.com/llvm/llvm-project/commit/bd6c358d01f6ebc3851996e2c29c47b08e992525 DIFF:

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

2024-05-16 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The README.md is what users see when they look for the extension in the Marketplace [1]. Right now, it's a mix of developer documentation (for us) and user documentation. This commit moves the

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/92428 The README.md is what users see when they look for the extension in the Marketplace [1]. Right now, it's a mix of developer documentation (for us) and user documentation. This commit moves the developer

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-16 Thread Miro Bucko via lldb-commits
@@ -44,6 +45,8 @@ class LLDB_API SBFunction { lldb::SBAddress GetEndAddress(); + lldb::SBAddressRange GetRange(); + mbucko wrote: Or did you want me to return SBAddressRangeList which will always contain only one SBAddressRange unless SBFunction ever

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-16 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/92328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -1891,6 +1893,12 @@ bool CommandInterpreter::HandleCommand(const char *command_line, m_transcript_stream << "(lldb) " << command_line << '\n'; + // The same `transcript_item` will be used below to add output and error of + // the command. + auto transcript_item =

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -135,7 +136,8 @@ CommandInterpreter::CommandInterpreter(Debugger , m_skip_lldbinit_files(false), m_skip_app_init_files(false), m_comment_char('#'), m_batch_command_mode(false), m_truncation_warning(eNoOmission), m_max_depth_warning(eNoOmission), -

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -247,13 +247,13 @@ class SBCommandInterpreter { lldb::SBStringList , lldb::SBStringList ); - /// Returns whether an interrupt flag was raised either by the SBDebugger - + /// Returns whether

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target. --- Full diff: https://github.com/llvm/llvm-project/pull/92416.diff 2 Files

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/92416 These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target. >From 1760995804d1a37e144fc778fcda7de23903e337 Mon Sep 17 00:00:00 2001 From: Dmitry

[Lldb-commits] [lldb] [lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target (PR #92413)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Install `_exe_to_attach` to a remote target if necessary. --- Full diff: https://github.com/llvm/llvm-project/pull/92413.diff 1 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target (PR #92413)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/92413 Install `_exe_to_attach` to a remote target if necessary. >From d88cc6d992e1f753066aa5dccaa510d8a0a35b94 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Thu, 16 May 2024 19:18:21 +0400 Subject: [PATCH]

[Lldb-commits] [lldb] d665d51 - [lldb] Fixed the DAP tests in case of a remote target (#92398)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T18:34:58+04:00 New Revision: d665d51c9296fc0b57945bb67e06040e26cd03c5 URL: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5 DIFF:

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92398)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/92398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d665d51 - [lldb] Fixed the DAP tests in case of a remote target (#92398)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T18:34:58+04:00 New Revision: d665d51c9296fc0b57945bb67e06040e26cd03c5 URL: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5 DIFF:

[Lldb-commits] [lldb] [lldb] Fixed an invalid error message in the DAP disconnect response (PR #92345)

2024-05-16 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/92345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >