[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

joker-eph wrote: > It's a sed s/== None/is None/g - what is there to review? On my I'm not asking for more reviews, this is why I commented that this should be **pushed** in multiple commits, I don't even need to see PRs. Another thing also mentioned above was the problem of reverts. If there

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

https://github.com/joker-eph approved this pull request. If you can push this to main in separate commits (one per project as it was mentioned?), that'd be great! https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list

[Lldb-commits] [clang] [compiler-rt] [libc] [libclc] [libcxxabi] [lld] [lldb] [llvm] [mlir] llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3804: lacking () for c… (PR #90391)

joker-eph wrote: PR should be named according to what they are actually achieving, I'm not sure why the GitHub issue title is relevant? https://github.com/llvm/llvm-project/pull/90391 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

joker-eph wrote: LGTM overall, but the CI failure looks real. https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

@@ -104,7 +104,7 @@ static std::recursive_mutex *g_debugger_list_mutex_ptr = nullptr; // NOTE: intentional leak to avoid issues with C++ destructor chain static Debugger::DebuggerList *g_debugger_list_ptr = nullptr; // NOTE: intentional leak to avoid issues with C++

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From d1dc1dfb1bb601fe90289bf29176c74a38ac5697 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 5 Mar 2024 10:38:41 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From ea79b6037497230b23caf36024a9e6883d3cac04 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 5 Mar 2024 10:38:41 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From 1b407d9d5abc9a1cf58afaf7f32ed40446d55f52 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 5 Mar 2024 10:38:41 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

joker-eph wrote: Actually no: the first patch landed already, so `ThreadPoolInterface` is now the base class in the codebase. I have some mixup here in that when renaming ThreadPool -> DefaultThreadPool, I used the base class ThreadPoolInterface when updating some of the uses. I will push

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

joker-eph wrote: I did the first part of the renaming @dwblaikie : looks good? https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From f961f22a3643673c1f3a040715dcfa2887ee1dca Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From 41e5c286c29a4fea65f6116f6844b44a3847f9db Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From 08a5dde36450c99137c7b03bec503daca18bc2d2 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From 5f657d872a78af9fb0035fc2f04dfa7ead7abadd Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

joker-eph wrote: > One patch ThreadPool->DefaultThreadPool (people get a build error about > ThreadPool not being the name of anything, find this patch as the root cause, > and rename all their ThreadPool->DefaultThreadPool) Gotcha, thanks for elaborating, somehow my brain was slow on a

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

joker-eph wrote: @dwblaikie : how would you split it? I didn't quite get the two renamings you have in mind? https://github.com/llvm/llvm-project/pull/83702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] e52650c - Fix LLDB build after renaming the base class for ThreadPool to ThreadPoolInterface

Author: Mehdi Amini Date: 2024-03-02T19:30:33-08:00 New Revision: e52650cfc3aa5d134186c5a8fd6701a6fd0a1051 URL: https://github.com/llvm/llvm-project/commit/e52650cfc3aa5d134186c5a8fd6701a6fd0a1051 DIFF: https://github.com/llvm/llvm-project/commit/e52650cfc3aa5d134186c5a8fd6701a6fd0a1051.diff

[Lldb-commits] [lld] [lldb] [llvm] [mlir] Rename ThreadPool->DefaultThreadPool and ThreadPoolInterface->ThreadPool (NFC) (PR #83702)

https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/83702 This is a breaking change: clients who use to create a ThreadPool must now create a DefaultThreadPool. >From aec355378bcb453adc4d697b02c69af30eb5f0ae Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 27

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 5f47d05b0310ffe5b20b972c507bce09399aec77 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 375add7f2ea7c8aa805c022936e7b65fdefe80b6 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 6864303679435f51ce899e348e49bfd11eb4146f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From d39dfe51ee866a9f45337b015e09d307b0ea994e Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 41404ed9b7038d712d18b0e16896fae66a954f87 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 5851f2980e699f7265bf556ea1889a63f080dc4d Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From eb630caf1bb9689f23c1f7dfe62a80f4c276da0d Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -140,54 +142,74 @@ class ThreadPool { }, std::move(F)}; } +}; + +/// A ThreadPool implementation using std::threads. +/// +/// The pool keeps a vector of threads alive, waiting on a condition variable +/// for some work to become available. +class

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From 75c17b79beeb117dbfc407051bb9a7660b69ee62 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From fa249b44a8bbcbc7b0da148c51acd5792f393869 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From e2a6d2860c21489445a87bfd4ced85108462f601 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -209,25 +231,66 @@ class ThreadPool { /// Number of threads active for tasks in the given group (only non-zero). DenseMap ActiveGroups; -#if LLVM_ENABLE_THREADS // avoids warning for unused variable /// Signal for the destruction of the pool, asking thread to exit.

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { joker-eph wrote: > Uniqueness is "guaranteed" through memory addressing. Someone can break > uniqueness when going through the public ThreadPool API. How so? > Type safety; sure you don't

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { joker-eph wrote: > What you get is probably a cleaner API IMHO I don't quite get why it would cleaner actually? This makes is for a weaker interface that does not guarantee any uniqueness

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { joker-eph wrote: > We could change for example this with a std::string or uint64_t with probably > minimal changes to any call site. How would you get a unique id at runtime if not for the

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From f13befdfdb8715c034eed6dd4c04f712d30d043a Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/82094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -227,7 +265,7 @@ class ThreadPool { class ThreadPoolTaskGroup { joker-eph wrote: > Wouldn't the implemention for ThreadPoolTaskGroup come in hand with the one > for ThreadPool? Right now the only thing the TaskGroup provide is a unique ID in the form of

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

@@ -92,30 +104,32 @@ class ThreadPool { ); } - /// Blocking wait for all the threads to complete and the queue to be empty. - /// It is an error to try to add new tasks while blocking on this call. - /// Calling wait() from a task would deadlock

[Lldb-commits] [lldb] [llvm] [mlir] Split the llvm::ThreadPool into an abstract base class and an implementation (PR #82094)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/82094 >From f9f2e9380b1333b3b2503aebb6ee234b84b8c035 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 16 Feb 2024 21:55:57 -0800 Subject: [PATCH] Split the llvm::ThreadPool into an abstract base class and an

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)

joker-eph wrote: Fine with me if we want to land this as is, but per-top-level subproject may be a better granularity. https://github.com/llvm/llvm-project/pull/82838 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [mlir] [lldb] [llvm] [mlir] Introduce replaceWithZeroTripCheck in LoopLikeOpInterface (PR #80331)

@@ -0,0 +1,101 @@ +//===- LoopLikeInterfaceTest.cpp - Unit tests for Loop Like Interfaces. ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [libcxx] [libc] [clang] [lldb] [llvm] [mlir] [mlir] Skip invalid test on big endian platform (s390x) (PR #80246)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/80246 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir] [llvm] [mlir] Introduce replaceWithZeroTripCheck in LoopLikeOpInterface (PR #80331)

https://github.com/joker-eph requested changes to this pull request. Can you add some tests for this? https://github.com/llvm/llvm-project/pull/80331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [mlir] [libc] [lldb] [flang] [libcxxabi] [lld] [libcxx] [clang-tools-extra] [compiler-rt] [llvm] [clang] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

joker-eph wrote: I had to revert because this broke a bot: https://lab.llvm.org/buildbot/#/builders/264/builds/6131 ``` # RUN: at line 1 /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt

[Lldb-commits] [lldb] [polly] [libcxx] [openmp] [libcxxabi] [mlir] [compiler-rt] [clang] [llvm] [clang-tools-extra] [libc] [flang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/76292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [libcxxabi] [lldb] [libcxx] [polly] [openmp] [compiler-rt] [flang] [libc] [mlir] [clang-tools-extra] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto

[Lldb-commits] [compiler-rt] [lld] [openmp] [libcxx] [mlir] [clang] [lldb] [llvm] [flang] [libc] [clang-tools-extra] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/71430 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [lld] [openmp] [libcxx] [mlir] [clang] [lldb] [llvm] [flang] [libc] [clang-tools-extra] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry ) { registerLLVMDialectTranslation(registry); registerNVVMDialectTranslation(registry); registerROCDLDialectTranslation(registry); + registerSPIRVDialectTranslation(registry);

[Lldb-commits] [compiler-rt] [lld] [openmp] [libcxx] [mlir] [clang] [lldb] [llvm] [flang] [libc] [clang-tools-extra] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -0,0 +1,31 @@ +//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [clang] [libcxx] [lld] [lldb] [compiler-rt] [mlir] [llvm] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

joker-eph wrote: FYI the build is failing (maybe re-running would be enough though) https://github.com/llvm/llvm-project/pull/72801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [compiler-rt] [llvm] [clang] [lld] [mlir] [flang] [libcxx] [mlir][async] Avoid crash when not using `func.func` (PR #72801)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/72801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang-tools-extra] [mlir] [compiler-rt] [lld] [libcxx] [clang] [flang] [lldb] [llvm] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/71430 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang-tools-extra] [mlir] [compiler-rt] [lld] [libcxx] [clang] [flang] [lldb] [llvm] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry ) { registerLLVMDialectTranslation(registry); registerNVVMDialectTranslation(registry); registerROCDLDialectTranslation(registry); + registerSPIRVDialectTranslation(registry);

[Lldb-commits] [libc] [clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [libcxx] [lld] [mlir] [lldb] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -0,0 +1,31 @@ +//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libc] [clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [libcxx] [lld] [mlir] [lldb] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry ) { registerLLVMDialectTranslation(registry); registerNVVMDialectTranslation(registry); registerROCDLDialectTranslation(registry); + registerSPIRVDialectTranslation(registry);

[Lldb-commits] [libcxxabi] [flang] [libcxx] [llvm] [clang] [mlir] [clang-tools-extra] [lldb] [lld] [compiler-rt] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/71165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [flang] [libcxx] [llvm] [clang] [mlir] [clang-tools-extra] [lldb] [lld] [compiler-rt] Refactor ModuleToObject to offer more flexibility to subclass (NFC) (PR #71165)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/71165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/69878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; +

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( +

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/65539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r306134 - Fix typo: using && instead of & when evaluating a mask

Author: mehdi_amini Date: Fri Jun 23 13:20:13 2017 New Revision: 306134 URL: http://llvm.org/viewvc/llvm-project?rev=306134=rev Log: Fix typo: using && instead of & when evaluating a mask Summary: Reported by coverity, I don't know how to provide a test. Reviewers: zturner Subscribers:

[Lldb-commits] [lldb] r286565 - Revert unwanted changes in lldb when updating llvm::Error()

Author: mehdi_amini Date: Thu Nov 10 23:07:57 2016 New Revision: 286565 URL: http://llvm.org/viewvc/llvm-project?rev=286565=rev Log: Revert unwanted changes in lldb when updating llvm::Error() My script updated lldb::Errors, and I failed to fix it entirely before pushing. This restore everything

[Lldb-commits] [lldb] r286562 - Prevent at compile time converting from Error::success() to Expected

Author: mehdi_amini Date: Thu Nov 10 22:29:25 2016 New Revision: 286562 URL: http://llvm.org/viewvc/llvm-project?rev=286562=rev Log: Prevent at compile time converting from Error::success() to Expected This would trigger an assertion at runtime otherwise. Differential Revision:

[Lldb-commits] [lldb] r286561 - Make the Error class constructor protected

Author: mehdi_amini Date: Thu Nov 10 22:28:40 2016 New Revision: 286561 URL: http://llvm.org/viewvc/llvm-project?rev=286561=rev Log: Make the Error class constructor protected This is forcing to use Error::success(), which is in a wide majority of cases a lot more readable. Differential

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

mehdi_amini added a comment. Just to clarify: I don't have a dog in this, I'm just lurking here to learn something, and I'm curious about the tradeoff. In https://reviews.llvm.org/D26190#585059, @labath wrote: > In https://reviews.llvm.org/D26190#585016, @mehdi_amini wrote: > > > > Does that

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

mehdi_amini added a comment. > Does that make sense? This makes sense (assuming static linking reduces some possibility though), but LLVM is not robust to mix and match build settings: building half of the source with -DNDEBUG and not the other is likely to cause weird runtime failures. That

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

mehdi_amini added a comment. OK! How is it different from the other proposal? In the other proposal, using a LLVM class in the API boundary would break the same way under the same conditions, or did I miss something? Something that isn't clear to me with this proposal, is how a user supposed

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

mehdi_amini added a comment. > and has potential to introduce latent bugs. Can you elaborate on this? https://reviews.llvm.org/D26190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r283298 - Re-commit "Use StringRef in Support/Darf APIs (NFC)"

Author: mehdi_amini Date: Wed Oct 5 00:59:29 2016 New Revision: 283298 URL: http://llvm.org/viewvc/llvm-project?rev=283298=rev Log: Re-commit "Use StringRef in Support/Darf APIs (NFC)" This reverts commit r283285 and re-commit r283275 with a fix for format("%s", Str); where Str is a StringRef.

[Lldb-commits] [lldb] r283285 - Revert "Re-commit "Use StringRef in Support/Darf APIs (NFC)""

Author: mehdi_amini Date: Tue Oct 4 20:04:02 2016 New Revision: 283285 URL: http://llvm.org/viewvc/llvm-project?rev=283285=rev Log: Revert "Re-commit "Use StringRef in Support/Darf APIs (NFC)"" One test seems randomly broken: DebugInfo/X86/gnu-public-names.ll Modified:

[Lldb-commits] [lldb] r283281 - Re-commit "Use StringRef in Support/Darf APIs (NFC)"

Author: mehdi_amini Date: Tue Oct 4 19:37:18 2016 New Revision: 283281 URL: http://llvm.org/viewvc/llvm-project?rev=283281=rev Log: Re-commit "Use StringRef in Support/Darf APIs (NFC)" This reverts commit r283278 and re-commit r283275 with the update to fix the build on the LLDB side.

[Lldb-commits] [lldb] r283018 - Use StringRef instead of raw pointers in MCAsmInfo/MCInstrInfo APIs (NFC)

Author: mehdi_amini Date: Sat Oct 1 01:46:33 2016 New Revision: 283018 URL: http://llvm.org/viewvc/llvm-project?rev=283018=rev Log: Use StringRef instead of raw pointers in MCAsmInfo/MCInstrInfo APIs (NFC) Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits > wrote: > >>> Can't handle the update of the umbrella *because of GitHub*, this could be >>> possible with our own hosting of git for instance. >>> >> Pre-commit hooks are not designed to update the

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added a subscriber: mehdi_amini. Comment at: docs/Proposals/GitHub.rst:122 @@ +121,3 @@ +of understanding the *sequence* in which commits were added by using the +``git rev-list --count hash`` or ``git describe hash`` commands. + filcab wrote: > How

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:199 @@ +198,3 @@ + +Here's a proposed plan: + Annoyingly my comment does no longer show-up next to the point it was referring to, it was about your third point: > Make sure we have an

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project