JDevlieghere wrote:
I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but
the first file looks like this:
```
foundSpec = False
if [...]
foundSpec = True
[...]
if foundSpec is False:
```
It's pretty obvious this is a boolean and should use `if not foundSpec`.
NagyDonat wrote:
The main problem with comparison to `True`/`False` is that it's completely
redundant when the variable is _guaranteed to be boolean_. However, if a
variable may contain either a boolean or something else, it's reasonable to
compare it with `True` or `False`.
For the operator
https://github.com/bulbazord requested changes to this pull request.
Hmm, actually, I'm not so sure about this change anymore. I went through PEP8
again and saw this:
```
Don’t compare boolean values to True or False using ==:
# Correct:
if greeting:
# Wrong:
if greeting == True:
Worse:
#
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
DavidSpickett wrote:
If this is split out from the other larger PR, should there be `clang/` changes
in here?
I've copied your commit message into the PR description, because with the way
llvm is setup, we use the PR's description as the commit message for a squashed
version of the changes.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM
The PR summary is empty, but it looks like the commit message has an
explanation for this change, so that's fine.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing
https://github.com/e-kwsm updated
https://github.com/llvm/llvm-project/pull/91858
>From 12e8ea6a0e104efbe130dd15d4d9051a7d86d50e Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
from PEP8
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Eisuke Kawashima (e-kwsm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91858.diff
18 Files Affected:
- (modified) clang/tools/scan-build/bin/set-xcode-analyzer (+1-1)
- (modified) clang/utils/check_cfc/check_cfc.py
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/e-kwsm created
https://github.com/llvm/llvm-project/pull/91858
None
>From 1e31186c01024c63fa4c0bd378fec7131ce84d56 Mon Sep 17 00:00:00 2001
From: Eisuke Kawashima
Date: Sun, 12 May 2024 00:06:53 +0900
Subject: [PATCH] fix(python): fix comparison to True/False
---
11 matches
Mail list logo
