https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
I like this new version, thanks for sticking with me.
https://github.com/llvm/llvm-project/pull/91887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
slydiman wrote:
@labath, Sorry for not being clear with my comment. Let me re-phrase.
I think unconditionally setting the executable flag for everything installed by
Platform::Install by default for all platforms is overkill.
BTW, there is no API to change this behavior, so `by default` means
labath wrote:
I'm not sure I'm following your reasoning. I'm not saying we should
replace/remove Target::Install. I'm saying we should make everything installed
by Platform::Install executable by default (which, by extension, includes
everything installed by Target::Install, because it
slydiman wrote:
Target::Install() and Platform::Install() are used indirectly in many cases.
For example look at the test
`lldb/test/API/python_api/hello_world/TestHelloWorld.py`. target.LaunchSimple()
uses Target::Install() and there is no problem with the exec permission.
spawnSubprocess()
labath wrote:
The `ifdef` in the generic code is not exactly ideal, and I'm wondering if we
should just do the same thing as Target::Install does (i.e., set the execute
flag unconditionally). Looking at the history, it appears that the
Target::Install code was
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91887
Target::Install() set 0700 permissions for the main executable file.
Platform::Install() just copies permissions from the source. But the permission
eFilePermissionsUserExecute is missing on the Windows host.
