[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-17 Thread Youngsuk Kim via lldb-commits
https://github.com/JOE1994 requested changes to this pull request. * The PR contains irrelevant changes to `X86` codegen. * Author of the commit shows up as another contributor. It seems like the author of this PR did a `git commit --amend` on top of e586556e375fc5c4f7e76b5c299cb981f2016108 to

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-17 Thread Youngsuk Kim via lldb-commits
https://github.com/JOE1994 reopened https://github.com/llvm/llvm-project/pull/91880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-14 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: That's just not how the LLVM project operates. I'd rather deal with two conflicting PRs than deal with an assigned orphaned issue that the assignee lost interest in. This is in the end a communication problem, and I don't mind if someone responds to the bug to say that

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-13 Thread Youngsuk Kim via lldb-commits
JOE1994 wrote: > We usually don't grant exclusive rights to work on an issue in the project, > since individual priorities may always change and people might loose interest > in an issue. Typically this kind of conflict doesn't happen very often > either. I understand that, but just for

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-13 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > A new user already asked to be assigned to work on #91209 2 days ago in the > comments. **I think that user deserves an opportunity to work on the issue**. > > Next time when you see a **"good first issue"** which a new user had already > asked to get assigned to,

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-12 Thread Youngsuk Kim via lldb-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/91880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-12 Thread Youngsuk Kim via lldb-commits
JOE1994 wrote: A new user already asked to be assigned to work on #91209 2 days ago in the comments. **I think that user deserves an opportunity to work on the issue**. Next time when you see a **"good first issue"** which a new user had already asked to get assigned to, please assign it to

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (aabhinavg) Changes Author: aabhinavg tiwariabhinavak@gmail.com Date: Sun May 12 12:46:54 2024 +0800 Reviewers: @JOE1994, @chelcassanova, @dcb314 Fixes: #91209 Summary of Changes: - Replaced the ineffective call to 'substr'

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

2024-05-12 Thread via lldb-commits
https://github.com/aabhinavg created https://github.com/llvm/llvm-project/pull/91880 Author: aabhinavg Date: Sun May 12 12:46:54 2024 +0800 Reviewers: @JOE1994, @chelcassanova, @dcb314 Fixes: #91209 Summary of Changes: - Replaced the ineffective call to 'substr' with a more efficient use of