@@ -17,38 +17,17 @@ module;
// The headers of Table 24: C++ library headers [tab:headers.cpp]
// and the headers of Table 25: C++ headers for C library facilities
[tab:headers.cpp.c]
-#include
-#include
-#include
-#if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER)
-# include
mordante wrote:
Good point, I actually think that's true. I think we should do that in a
separate PR. Maybe discuss it on Discord after the holidays.
https://github.com/llvm/llvm-project/pull/76268
___
llvm-branch-commits mailing list
philnik777 wrote:
Oh shit. I just realized that this is most likely a latent bug no matter what.
We build the module with Clang 18, and then essentially try to load it with
Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, and probably
just happens to work currently with
mordante wrote:
It's the line `export import std;` in
https://github.com/llvm/llvm-project/pull/76330/files#diff-e881fdd0e6e66610142a28228b2bbf0e38520ee7186946bca06cb8d195dcd2b4
This works with Clang-17, Clang-18, and clang-tidy-18. It fails with
clang-tidy-17. Clang-tidy tests that directly
mordante wrote:
> > > If you are okay with the suggestions that I made for some typos in the
> > > documentation, I will preemptively incorporate it into my documentation
> > > PR.
> >
> >
> > Thanks for the suggestions! Please do no incorporate these in your PR.
> > Other reviewers may
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76330
>From 6134779ac0f53ed22d8ddfc14908e595eb94fb65 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Sun, 24 Dec 2023 12:13:00 +0100
Subject: [PATCH] [libc++][modules] Improves std.compat module.
Let the
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Mark de Wever (mordante)
Changes
Let the std.compat module use the std module instead of duplicating the exports.
Based on @ChuanqiXu9's suggestion in #71438.
---
Full diff: https://github.com/llvm/llvm-project/pull/76330.diff
7 Files
https://github.com/mordante created
https://github.com/llvm/llvm-project/pull/76330
Let the std.compat module use the std module instead of duplicating the exports.
Based on @ChuanqiXu9's suggestion in #71438.
>From 246a8a14f125934b5e8c84b2d391db72ee4dc647 Mon Sep 17 00:00:00 2001
From: Mark
