[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [mlir] [flang] [compiler-rt] [llvm] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [mlir] [llvm] [flang] [libcxx] [clang-tools-extra] [clang] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [clang] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/kstoimenov approved this pull request. https://github.com/llvm/llvm-project/pull/77162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [compiler-rt] [llvm] [mlir] [clang-tools-extra] [libcxx] [ubsan] Drop terminal "in " from reports without functions (PR #77163)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77163 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [clang] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [clang-tools-extra] [clang] [compiler-rt] [llvm] [libcxx] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang-tools-extra] [llvm] [libcxx] [mlir] [compiler-rt] [clang] [ubsan] Drop terminal "in " from reports without functions (PR #77163)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77163 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [ubsan] Drop terminal "in " from reports without functions (PR #77163)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/77163 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/77162.diff 3 Files Affected: - (modified) compiler-rt/lib/sanitizer_common/sanitizer_common.h (+1-1) - (modified)

[llvm-branch-commits] [compiler-rt] [ubsan] Drop terminal "in " from reports without functions (PR #77163)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/77163.diff 2 Files Affected: - (modified) compiler-rt/lib/ubsan/ubsan_diag.cpp (+1-1) - (modified)

[llvm-branch-commits] [compiler-rt] [ubsan] Drop terminal "in " from reports without functions (PR #77163)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77163 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] [NFC][sanitizer] Move SymbolizedStackHolder into sanitizer_common (PR #77152)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] [NFC][sanitizer] Move SymbolizedStackHolder into sanitizer_common (PR #77152)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [NFC][sanitizer] Add consts to SkipInternalFrames (PR #77162)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77162 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [libc] [libcxx] [compiler-rt] [libunwind] [llvm] [NFC][tsan] Move SkipInternalFrames into sanitizer_common (PR #77146)

https://github.com/kstoimenov approved this pull request. https://github.com/llvm/llvm-project/pull/77146 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] [llvm] [libcxx] [libunwind] [clang] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/77145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] [llvm] [libcxx] [libunwind] [clang] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

vitalybuka wrote: > > Probably it's not important, as it should not happen, but if all frames are > > internal we should pick top, not the bottom frame. > > If we encounter a case that "should not happen", wouldn't it be better to > fail/assert? usually should not happen e.g. without

[llvm-branch-commits] [libc] [llvm] [libcxx] [libunwind] [clang] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/77145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] [llvm] [libcxx] [libunwind] [clang] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/77145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [NFC][sanitizer] Move SymbolizedStackHolder into sanitizer_common (PR #77152)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes And replace most `ClearAll()` uses. --- Full diff: https://github.com/llvm/llvm-project/pull/77152.diff 7 Files Affected: - (modified) compiler-rt/lib/asan/asan_suppressions.cpp (+3-4)

[llvm-branch-commits] [clang] [compiler-rt] [libc] [libcxx] [libunwind] [llvm] [NFC][tsan] Move SkipInternalFrames into sanitizer_common (PR #77146)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77146 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [NFC][sanitizer] Move SymbolizedStackHolder into sanitizer_common (PR #77152)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77152 And replace most `ClearAll()` uses. ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libunwind] [clang] [compiler-rt] [libc] [libcxx] [llvm] [NFC][tsan] Move SkipInternalFrames into sanitizer_common (PR #77146)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77146 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] [libunwind] [clang] [libcxx] [libc] [tsan] Fallback to top frame (PR #77145)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libunwind] [libc] [llvm] [compiler-rt] [clang] [tsan] Fallback to top frame (PR #77145)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/77145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

thurstond wrote: > Probably it's not important, as it should not happen, but if all frames are > internal we should pick top, not the bottom frame. If we encounter a case that "should not happen", wouldn't it be better to fail/assert? https://github.com/llvm/llvm-project/pull/77145

[llvm-branch-commits] [compiler-rt] [NFC][tsan] `ptr != 0` to implicit check (PR #77144)

https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/77144 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes Probably it's not important, as it should not happen, but if all frames are internal we should pick top, not the bottom frame. --- Full diff:

[llvm-branch-commits] [compiler-rt] [NFC][tsan] Move SkipInternalFrames into sanitizer_common (PR #77146)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/77146.diff 3 Files Affected: - (modified) compiler-rt/lib/sanitizer_common/sanitizer_common.h (+3) - (modified)

[llvm-branch-commits] [compiler-rt] [NFC][tsan] `ptr != 0` to implicit check (PR #77144)

llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/77144.diff 1 Files Affected: - (modified) compiler-rt/lib/tsan/rtl/tsan_report.cpp (+3-3) ``diff diff --git

[llvm-branch-commits] [compiler-rt] [tsan] Fallback to top frame (PR #77145)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77145 Probably it's not important, as it should not happen, but if all frames are internal we should pick top, not the bottom frame. ___ llvm-branch-commits mailing

[llvm-branch-commits] [compiler-rt] [NFC][tsan] Move SkipInternalFrames into sanitizer_common (PR #77146)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77146 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [NFC][tsan] `ptr != 0` to implicit check (PR #77144)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/77144 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: > > Then I can prohibit clang-16 and clang-17. > > Yeah, that's the solution. clang-tidy defines the same version macros as > clang does, so prohibiting it from clang-16 is the same as prohibiting it for > clang-tidy 16. What makes it currently hard for modules is that in the

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

philnik777 wrote: > > > Oh shit. I just realized that this is most likely a latent bug no matter > > > what. We build the module with Clang 18, and then essentially try to load > > > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to > > > work, and probably just happens to

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

mordante wrote: > > Oh shit. I just realized that this is most likely a latent bug no matter > > what. We build the module with Clang 18, and then essentially try to load > > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, > > and probably just happens to work

[llvm-branch-commits] [flang] [mlir] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

https://github.com/Dinistro updated https://github.com/llvm/llvm-project/pull/77093 >From 33ee6deadd6318adcfc45dba1d39bc38514bcd4b Mon Sep 17 00:00:00 2001 From: Christian Ulmann Date: Fri, 5 Jan 2024 13:20:10 + Subject: [PATCH 1/2] [MLIR][LLVM] Add distinct identifier to the DISubprogram

[llvm-branch-commits] [mlir] [flang] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

https://github.com/gysit approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77093 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [flang] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

@@ -66,12 +66,28 @@ static void addScopeToFunction(LLVM::LLVMFuncOp llvmFunc, LLVM::DISubroutineTypeAttr::get(context, llvm::dwarf::DW_CC_normal, {}); StringAttr funcNameAttr = llvmFunc.getNameAttr(); - auto subprogramAttr = LLVM::DISubprogramAttr::get( -

[llvm-branch-commits] [flang] [mlir] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

https://github.com/gysit edited https://github.com/llvm/llvm-project/pull/77093 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

llvmbot wrote: @llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-flang-fir-hlfir @llvm/pr-subscribers-mlir Author: Christian Ulmann (Dinistro) Changes This commit adds an optional distinct attribute parameter to the DISubprogramAttr. This enables modeling of distinct subprograms, as

[llvm-branch-commits] [mlir] [flang] [MLIR][LLVM] Add distinct identifier to the DISubprogram attribute (PR #77093)

https://github.com/Dinistro created https://github.com/llvm/llvm-project/pull/77093 This commit adds an optional distinct attribute parameter to the DISubprogramAttr. This enables modeling of distinct subprograms, as required for LLVM IR. This change is required to avoid accidential uniquing

[llvm-branch-commits] [llvm] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

@@ -59,6 +68,8 @@ struct PfmCountersInfo { const IssueCounter *IssueCounters; unsigned NumIssueCounters; + std::unordered_map ValidationCounters; legrosbuffle wrote: `unordered_map` means that: - We'll allocate on startup. - We don't have consistent

[llvm-branch-commits] [llvm] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

@@ -28,6 +28,22 @@ class PfmIssueCounter string ResourceName = resource_name; } +class ValidationEvent { legrosbuffle wrote: This needs doc to explain what a `ValidationEvent` and `PfmValidationCounter` are.

[llvm-branch-commits] [llvm] [llvm-exegesis] Add additional validation counters (PR #76788)

RKSimon wrote: Thanks, no more comments from me - but a exegesis owner should review the rest https://github.com/llvm/llvm-project/pull/76788 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

philnik777 wrote: > > Oh shit. I just realized that this is most likely a latent bug no matter > > what. We build the module with Clang 18, and then essentially try to load > > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, > > and probably just happens to work

[llvm-branch-commits] [libcxx] [libc++][modules] Increase clang-tidy version used. (PR #76268)

H-G-Hristov wrote: > Oh shit. I just realized that this is most likely a latent bug no matter > what. We build the module with Clang 18, and then essentially try to load it > with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, and > probably just happens to work currently