[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread Tom Stellard via llvm-branch-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/85266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] 122ba9f - [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167)

2024-03-14 Thread via llvm-branch-commits
Author: Fangrui Song Date: 2024-03-14T17:01:14Z New Revision: 122ba9f100705213774cff2038db953ff8174d91 URL: https://github.com/llvm/llvm-project/commit/122ba9f100705213774cff2038db953ff8174d91 DIFF: https://github.com/llvm/llvm-project/commit/122ba9f100705213774cff2038db953ff8174d91.diff LOG:

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread Aart Bik via llvm-branch-commits
@@ -140,10 +140,16 @@ module { sparse_tensor.print %s1 : tensor<4x3x2xf32, #BatchedCSR> sparse_tensor.print %s2 : tensor<4x3x2xf32, #CSRDense> -// FIXME: doing this explicitly crashes runtime -// bufferization.dealloc_tensor %s0 : tensor<4x3x2xf32, #CCC> -

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread Aart Bik via llvm-branch-commits
https://github.com/aartbik edited https://github.com/llvm/llvm-project/pull/85355 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread Aart Bik via llvm-branch-commits
https://github.com/aartbik approved this pull request. https://github.com/llvm/llvm-project/pull/85355 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread Aart Bik via llvm-branch-commits
@@ -114,12 +114,14 @@ module { call @dump(%d31) : (tensor<2x3x4xf64>) -> () // -// Release sparse tensors. +// Release tensors. aartbik wrote: we usually say // Release the resources. so perhaps use that here too

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread Aart Bik via llvm-branch-commits
https://github.com/aartbik edited https://github.com/llvm/llvm-project/pull/85184 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread Aart Bik via llvm-branch-commits
@@ -167,12 +169,14 @@ module { call @dump(%d31) : (tensor<2x3x4xf64>) -> () // -// Release sparse tensors. +// Release tensors. aartbik wrote: same https://github.com/llvm/llvm-project/pull/85184

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread Aart Bik via llvm-branch-commits
https://github.com/aartbik approved this pull request. https://github.com/llvm/llvm-project/pull/85184 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread Matthias Springer via llvm-branch-commits
@@ -140,10 +140,16 @@ module { sparse_tensor.print %s1 : tensor<4x3x2xf32, #BatchedCSR> sparse_tensor.print %s2 : tensor<4x3x2xf32, #CSRDense> -// FIXME: doing this explicitly crashes runtime -// bufferization.dealloc_tensor %s0 : tensor<4x3x2xf32, #CCC> -

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) Changes This commit adds a new test-only op: `sparse_tensor.has_runtime_library`. The op returns "1" if the sparse compiler runs in runtime library mode. This op is useful for writing test cases that

[llvm-branch-commits] [mlir] [mlir][sparse] Add `has_runtime_library` test op (PR #85355)

2024-03-14 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/85355 This commit adds a new test-only op: `sparse_tensor.has_runtime_library`. The op returns "1" if the sparse compiler runs in runtime library mode. This op is useful for writing test cases that require

[llvm-branch-commits] [clang] [InstallAPI] Verify that declarations in headers map to exports found in dylib (PR #85348)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes * This completes support for verifying every declaration found in a header is discovered in the dylib. Diagnostics are reported for each class for differences that are representable in TBD files. *

[llvm-branch-commits] [clang] [InstallAPI] Verify that declarations in headers map to exports found in dylib (PR #85348)

2024-03-14 Thread Cyndy Ishida via llvm-branch-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/85348 * This completes support for verifying every declaration found in a header is discovered in the dylib. Diagnostics are reported for each class for differences that are representable in TBD files. * This

[llvm-branch-commits] [flang][runtime] Added custom visitor for IoStatementState variants. (PR #85179)

2024-03-14 Thread Slava Zakharin via llvm-branch-commits
vzakhari wrote: > It would be better to have the types that are available on the device declare > themselves so in their declarations via a member or (better) inherited trait. Like this. I will add the type trait for those types that are available on the device. > The big variant union in

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/84404 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Vitaly Buka via llvm-branch-commits
@@ -1246,32 +1244,16 @@ Value *HWAddressSanitizer::getHwasanThreadSlotPtr(IRBuilder<> , Type *Ty) { return nullptr; } -Value *HWAddressSanitizer::getPC(IRBuilder<> ) { - if (TargetTriple.getArch() == Triple::aarch64) -return readRegister(IRB, "pc"); - return

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/84404 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/84404 >From de96c71240c4c1021d8267cd8ccee4abc9299257 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 14 Mar 2024 13:52:22 -0700 Subject: [PATCH 1/2] rename Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/85266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
@@ -236,5 +238,37 @@ void alignAndPadAlloca(memtag::AllocaInfo , llvm::Align Alignment) { Info.AI = NewAI; } +Value *readRegister(IRBuilder<> , StringRef Name) { + Module *M = IRB.GetInsertBlock()->getParent()->getParent(); + Function *ReadRegister =

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
@@ -236,5 +238,37 @@ void alignAndPadAlloca(memtag::AllocaInfo , llvm::Align Alignment) { Info.AI = NewAI; } +Value *readRegister(IRBuilder<> , StringRef Name) { + Module *M = IRB.GetInsertBlock()->getParent()->getParent(); + Function *ReadRegister =

[llvm-branch-commits] [llvm] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/84404 >From de96c71240c4c1021d8267cd8ccee4abc9299257 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 14 Mar 2024 13:52:22 -0700 Subject: [PATCH] rename Created using spr 1.3.4 ---

[llvm-branch-commits] [NFC] [hwasan] factor get[PC|FP] out of HWASan class (PR #84404)

2024-03-14 Thread Florian Mayer via llvm-branch-commits
@@ -1246,32 +1244,16 @@ Value *HWAddressSanitizer::getHwasanThreadSlotPtr(IRBuilder<> , Type *Ty) { return nullptr; } -Value *HWAddressSanitizer::getPC(IRBuilder<> ) { - if (TargetTriple.getArch() == Triple::aarch64) -return readRegister(IRB, "pc"); - return

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: No worries! I just created https://github.com/llvm/llvm-project/pull/85305, hopefully that should do the trick. https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) Changes This works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes #85242 --- Full diff: https://github.com/llvm/llvm-project/pull/85305.diff 1 Files Affected: -

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85305 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85305 This works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes #85242 >From 810c55db5c92f5786a4c2b1b1336dd8b62f28f86 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date:

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Mark de Wever via llvm-branch-commits
mordante wrote: > Is the fix only to switch to 18.1 in the cmake? I can do that if that's it, I > just don't fully understand the situation w/ clang tidy ODR violations since > you were the one to make these changes That should be all. I'm also happy to do it, but that will be tomorrow.

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: Is the fix only to switch to 18.1 in the cmake? I can do that if that's it, I just don't fully understand the situation w/ clang tidy ODR violations since you were the one to make these changes https://github.com/llvm/llvm-project/pull/85247

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Mark de Wever via llvm-branch-commits
mordante wrote: > @mordante So should I close this PR? I see you already did. Do you want to make a fix for the release branch or do you want me to pick that up? https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: @mordante So should I close this PR? https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [InstallAPI] Introduce Basic Verifier (PR #85106)

2024-03-14 Thread Cyndy Ishida via llvm-branch-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/85106 >From 192f306f8d693af77e267e1caa52799a353f4064 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Tue, 12 Mar 2024 20:56:23 -0700 Subject: [PATCH] [InstallAPI] Introduce Basic Verifier This adds basic

[llvm-branch-commits] [clang] [llvm] [InstallAPI] Introduce Basic Verifier (PR #85106)

2024-03-14 Thread Cyndy Ishida via llvm-branch-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/85106 >From 192f306f8d693af77e267e1caa52799a353f4064 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Tue, 12 Mar 2024 20:56:23 -0700 Subject: [PATCH 1/3] [InstallAPI] Introduce Basic Verifier This adds basic

[llvm-branch-commits] [flang] 3cf4d10 - Revert "[flang] Lower c_ptr_eq/ne for iso_c_binding (#85135)"

2024-03-14 Thread via llvm-branch-commits
Author: Valentin Clement (バレンタイン クレメン) Date: 2024-03-14T11:26:57-07:00 New Revision: 3cf4d107af3a283c43e416aa30a6bd678cb44fcc URL: https://github.com/llvm/llvm-project/commit/3cf4d107af3a283c43e416aa30a6bd678cb44fcc DIFF:

[llvm-branch-commits] [llvm] 8b409ee - Revert "[llvm][AArch64] Autoupgrade function attributes from Module attribute…"

2024-03-14 Thread via llvm-branch-commits
Author: Daniel Kiss Date: 2024-03-14T19:15:27+01:00 New Revision: 8b409ee0cbb362e09cc80e4af9ef67681a7d9fbc URL: https://github.com/llvm/llvm-project/commit/8b409ee0cbb362e09cc80e4af9ef67681a7d9fbc DIFF: https://github.com/llvm/llvm-project/commit/8b409ee0cbb362e09cc80e4af9ef67681a7d9fbc.diff

[llvm-branch-commits] [llvm] release/18.x: [llvm][AArch64] Autoupgrade function attributes from Module attributes. (#82763) (PR #84039)

2024-03-14 Thread Nick Desaulniers via llvm-branch-commits
https://github.com/nickdesaulniers closed https://github.com/llvm/llvm-project/pull/84039 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/18.x: [llvm][AArch64] Autoupgrade function attributes from Module attributes. (#82763) (PR #84039)

2024-03-14 Thread Nick Desaulniers via llvm-branch-commits
nickdesaulniers wrote: Changing my mind here, we've identified the issue with this commit. https://github.com/llvm/llvm-project/pull/82763#issuecomment-1997950893 https://github.com/llvm/llvm-project/pull/84039 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-lld-elf Author: None (llvmbot) Changes Backport 8fe3e70e810b409dce36f6d415e86f0f9b1cf22d Requested by: @nikic --- Full diff: https://github.com/llvm/llvm-project/pull/85266.diff 2 Files Affected: - (modified) lld/ELF/Writer.cpp (+3) - (modified)

[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/85266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @nikic What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/85266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [lld] release/18.x: [ELF] Eliminate symbols demoted due to /DISCARD/ discarded sections (#85167) (PR #85266)

2024-03-14 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/85266 Backport 8fe3e70e810b409dce36f6d415e86f0f9b1cf22d Requested by: @nikic >From 122ba9f100705213774cff2038db953ff8174d91 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 14 Mar 2024 09:51:27 -0700 Subject:

[llvm-branch-commits] [flang] [flang] run CFG conversion on omp reduction declare ops (PR #84953)

2024-03-14 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
clementval wrote: > > Wouldn't it be cleaner to expose the patterns via a > > `populateFirCfgConversionPatterns` function and reuse it in you extra pass > > instead of making two pass from the initial file? > > We did this recently for the FirToLLVM patterns. #83492 > > Thanks for taking a

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
https://github.com/clementval edited https://github.com/llvm/llvm-project/pull/84954 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
https://github.com/clementval edited https://github.com/llvm/llvm-project/pull/84954 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
https://github.com/clementval approved this pull request. LGTM. Just a nit comment for an even cleaner code. https://github.com/llvm/llvm-project/pull/84954 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
@@ -314,11 +314,8 @@ class CodeGenRewrite : public fir::impl::CodeGenRewriteBase { void runOnOperation() override final { // Call runOn on all top level regions that may contain emboxOp/arrayCoorOp. -auto mod = getOperation(); -for (auto func : mod.getOps()) -

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Mark de Wever via llvm-branch-commits
mordante wrote: I'd rather fix the clang-tidy integration. I'm quite sure we have ODR violations since we use clang-tidy 18 with clang 17 libraries. These violations break the modules, but other clang-tidy checks may also have issues. Changing

[llvm-branch-commits] [flang][runtime] Enable PRINT of integer32 for device. (PR #85182)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -368,7 +368,12 @@ static bool FormattedDerivedTypeIO(IoStatementState , ++j, descriptor.IncrementSubscripts(subscripts)) { Fortran::common::optional result; if (special) { +#if !defined(RT_DEVICE_COMPILATION) result = DefinedFormattedIo(io, descriptor,

[llvm-branch-commits] [flang][runtime] Enable PRINT of integer32 for device. (PR #85182)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler approved this pull request. https://github.com/llvm/llvm-project/pull/85182 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang][runtime] Enable PRINT of integer32 for device. (PR #85182)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler edited https://github.com/llvm/llvm-project/pull/85182 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -48,6 +55,10 @@ template class InternalDescriptorUnit : public ConnectionState { void BlankFillOutputRecord(); StaticDescriptor staticDescriptor_; + RT_OFFLOAD_VAR_GROUP_BEGIN + static constexpr std::size_t ownBufferSizeInBytes{1024}; + RT_OFFLOAD_VAR_GROUP_END +

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -119,6 +120,9 @@ template void InternalIoStatementState::BackspaceRecord() { } template int InternalIoStatementState::EndIoStatement() { + if constexpr (DIR == Direction::Output) { klausler wrote: If it is possible for the buffer flush to raise an

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -41,6 +52,26 @@ InternalDescriptorUnit::InternalDescriptorUnit( endfileRecordNumber = d.Elements() + 1; } +template void InternalDescriptorUnit::EndIoStatement() { + if constexpr (DIR == Direction::Output) { +if (usesOwnBuffer) { + // Null terminate the buffer

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -41,6 +52,26 @@ InternalDescriptorUnit::InternalDescriptorUnit( endfileRecordNumber = d.Elements() + 1; } +template void InternalDescriptorUnit::EndIoStatement() { + if constexpr (DIR == Direction::Output) { +if (usesOwnBuffer) { + // Null terminate the buffer

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler commented: If you want to support child I/O (user-defined derived type I/O) on the device, this approach of adding special behavior to the internal units won't work -- child I/O is embedded in external units. It might be clearer to support this device output path

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
@@ -48,6 +55,10 @@ template class InternalDescriptorUnit : public ConnectionState { void BlankFillOutputRecord(); StaticDescriptor staticDescriptor_; + RT_OFFLOAD_VAR_GROUP_BEGIN + static constexpr std::size_t ownBufferSizeInBytes{1024}; + RT_OFFLOAD_VAR_GROUP_END

[llvm-branch-commits] [flang][runtime] Added self-printing for InternalUnit. (PR #85181)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler edited https://github.com/llvm/llvm-project/pull/85181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) Changes LIT was never really meant to generate tests during discovery, and we probably shouldn't be doing this. This hack is even worse than the initial attempt because it buries the "UNSUPPORTED" at the bottom

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85247 LIT was never really meant to generate tests during discovery, and we probably shouldn't be doing this. This hack is even worse than the initial attempt because it buries the "UNSUPPORTED" at the bottom of the

[llvm-branch-commits] [NFC][flang] Reorder const and RT_API_ATTRS. (PR #85180)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler approved this pull request. https://github.com/llvm/llvm-project/pull/85180 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang][runtime] Added custom visitor for IoStatementState variants. (PR #85179)

2024-03-14 Thread Peter Klausler via llvm-branch-commits
https://github.com/klausler requested changes to this pull request. It would be better to have the types that are available on the device declare themselves so in their declarations via a member or (better) inherited trait. The big variant union in `IoStatementState` could omit the host-only

[llvm-branch-commits] [libcxx] [libcxxabi] [libunwind] release/18.x: [runtimes] Prefer -fvisibility-global-new-delete=force-hidden (#84917) (PR #85126)

2024-03-14 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: @tstellar Yes. I think I'll disable these tests which keep failing in the LLVM 18 release branch so we can remove some of the noise here. https://github.com/llvm/llvm-project/pull/85126 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [flang][runtime] Added Fortran::common::reference_wrapper for use on device. (PR #85178)

2024-03-14 Thread via llvm-branch-commits
https://github.com/jeanPerier approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85178 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread via llvm-branch-commits
https://github.com/jeanPerier approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/84954 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [lld] release/18.x: [lld][LoongArch] Fix handleUleb128 (PR #85238)

2024-03-14 Thread via llvm-branch-commits
https://github.com/llvmbot updated https://github.com/llvm/llvm-project/pull/85238 >From 0f067065dd5e5411d5ada08397abb79336e997c8 Mon Sep 17 00:00:00 2001 From: Weining Lu Date: Tue, 5 Mar 2024 22:01:07 +0800 Subject: [PATCH 1/2] [lld][test] Fix sanitizer buildbot failure Buildbot failure:

[llvm-branch-commits] [lld] release/18.x: [lld][LoongArch] Fix handleUleb128 (PR #85238)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: None (llvmbot) Changes Backport d9b435c24ddd a41bcb393053 Requested by: @SixWeining --- Full diff: https://github.com/llvm/llvm-project/pull/85238.diff 2 Files Affected: - (modified) lld/ELF/Arch/LoongArch.cpp (+3-2) - (modified)

[llvm-branch-commits] [lld] release/18.x: [lld][LoongArch] Fix handleUleb128 (PR #85238)

2024-03-14 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/85238 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] release/18.x: [lld][LoongArch] Fix handleUleb128 (PR #85238)

2024-03-14 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/85238 Backport d9b435c24ddd a41bcb393053 Requested by: @SixWeining >From d71cc94f3111af54a66fe200a344ce2a1dbb4f43 Mon Sep 17 00:00:00 2001 From: Weining Lu Date: Tue, 5 Mar 2024 22:01:07 +0800 Subject: [PATCH 1/2]

[llvm-branch-commits] [lld] [llvm] Backport fixes for ARM64EC import libraries (PR #84590)

2024-03-14 Thread Daniel Paoliello via llvm-branch-commits
dpaoliello wrote: @tstellar change made as requested, this is now ready to merge https://github.com/llvm/llvm-project/pull/84590 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/84954 >From f951d16cf6cb1ab221f47ca2e712020b9af0af87 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Fri, 1 Mar 2024 16:59:09 + Subject: [PATCH 1/4] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops

[llvm-branch-commits] [llvm] [RISCV] Support select optimization (PR #80124)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
wangpc-pp wrote: Ping. Any more concerns? https://github.com/llvm/llvm-project/pull/80124 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [RISCV] Store VLMul/NF into RegisterClass's TSFlags (PR #84894)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/84894 >From 951478b16d8aa834bff4494dc6d05c5f1175d59f Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Tue, 12 Mar 2024 18:41:50 +0800 Subject: [PATCH] Fix wrong arguments Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [RISCV] Store VLMul/NF into RegisterClass's TSFlags (PR #84894)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
https://github.com/wangpc-pp edited https://github.com/llvm/llvm-project/pull/84894 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [RISCV] Store VLMul/NF into RegisterClass's TSFlags (PR #84894)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/84894 >From 951478b16d8aa834bff4494dc6d05c5f1175d59f Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Tue, 12 Mar 2024 18:41:50 +0800 Subject: [PATCH] Fix wrong arguments Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [RISCV] Use larger copies when register tuples are aligned (PR #84455)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/84455 >From 35d0ea085b43a67c092e6263e6ec9d34e66e1453 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Tue, 12 Mar 2024 17:31:47 +0800 Subject: [PATCH 1/3] Reduce copies Created using spr 1.3.4 ---

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Kiran Chandramohan via llvm-branch-commits
@@ -18,6 +18,7 @@ #include "flang/Optimizer/Dialect/FIROps.h" #include "flang/Optimizer/Dialect/FIRType.h" #include "flang/Optimizer/Dialect/Support/FIRContext.h" +#include "mlir/Dialect/OpenMP/OpenMPDialect.h" kiranchandramohan wrote: The header is not

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Kiran Chandramohan via llvm-branch-commits
https://github.com/kiranchandramohan approved this pull request. LG. Please wait for @clementval. https://github.com/llvm/llvm-project/pull/84954 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [flang] [flang] run CFG conversion on omp reduction declare ops (PR #84953)

2024-03-14 Thread Tom Eccles via llvm-branch-commits
tblah wrote: > Wouldn't it be cleaner to expose the patterns via a > `populateFirCfgConversionPatterns` function and reuse it in you extra pass > instead of making two pass from the initial file? > > We did this recently for the FirToLLVM patterns. #83492 Thanks for taking a look at this. I

[llvm-branch-commits] [llvm] [RISCV] Use larger copies when register tuples are aligned (PR #84455)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
@@ -302,102 +302,87 @@ void RISCVInstrInfo::copyPhysRegVector(MachineBasicBlock , RISCVII::VLMUL LMul, unsigned NF) const { const TargetRegisterInfo *TRI = STI.getRegisterInfo(); - unsigned Opc; - unsigned SubRegIdx; - unsigned

[llvm-branch-commits] [llvm] [RISCV] Use larger copies when register tuples are aligned (PR #84455)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
@@ -302,102 +302,87 @@ void RISCVInstrInfo::copyPhysRegVector(MachineBasicBlock , RISCVII::VLMUL LMul, unsigned NF) const { const TargetRegisterInfo *TRI = STI.getRegisterInfo(); - unsigned Opc; - unsigned SubRegIdx; - unsigned

[llvm-branch-commits] [llvm] [RISCV] Use larger copies when register tuples are aligned (PR #84455)

2024-03-14 Thread Wang Pengcheng via llvm-branch-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/84455 >From 35d0ea085b43a67c092e6263e6ec9d34e66e1453 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Tue, 12 Mar 2024 17:31:47 +0800 Subject: [PATCH 1/2] Reduce copies Created using spr 1.3.4 ---

[llvm-branch-commits] [mlir] release/18.x: [mlir][NFC] Apply rule of five to *Pass classes (#80998) (PR #83971)

2024-03-14 Thread Andrei Golubev via llvm-branch-commits
andrey-golubev wrote: > I think it's an ABI change (but I could be wrong), because some of the > implicit constructors are being deleted. What happens if a user of the > library was using these deleted constructors? I see your point. In this specific case, the special member functions were

[llvm-branch-commits] [flang] [flang] run CFG conversion on omp reduction declare ops (PR #84953)

2024-03-14 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/84953 >From 192da3c05fd8c0759f280e0895ffc2f09b2203e4 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Thu, 15 Feb 2024 12:12:29 + Subject: [PATCH 1/2] [flang] run CFG conversion on omp reduction declare ops Most FIR

[llvm-branch-commits] [llvm] [AArch64][GlobalISel] Avoid splitting loads of large vector types into individual element loads (PR #85042)

2024-03-14 Thread David Green via llvm-branch-commits
https://github.com/davemgreen approved this pull request. Thanks. LGTM https://github.com/llvm/llvm-project/pull/85042 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Tom Eccles via llvm-branch-commits
@@ -319,6 +320,10 @@ class CodeGenRewrite : public fir::impl::CodeGenRewriteBase { runOn(func, func.getBody()); for (auto global : mod.getOps()) runOn(global, global.getRegion()); +for (auto omp : mod.getOps()) { tblah wrote: Good idea.

[llvm-branch-commits] [flang] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops (PR #84954)

2024-03-14 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/84954 >From f951d16cf6cb1ab221f47ca2e712020b9af0af87 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Fri, 1 Mar 2024 16:59:09 + Subject: [PATCH 1/3] [flang][CodeGen] Run PreCGRewrite on omp reduction declare ops

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) Changes This commit fixes memory leaks in sparse tensor integration tests by adding `bufferization.dealloc_tensor` ops. Note: Buffer deallocation will be automated in the future with the

[llvm-branch-commits] [mlir] [mlir][sparse] Fix memory leaks (part 3) (PR #85184)

2024-03-14 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/85184 This commit fixes memory leaks in sparse tensor integration tests by adding `bufferization.dealloc_tensor` ops. Note: Buffer deallocation will be automated in the future with the ownership-based