https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/3] [libc++][modules] Adds module testing.
This adds a new
@@ -52,6 +52,21 @@ def _executeScriptInternal(test, litConfig, commands):
return (out, err, exitCode, timeoutInfo, parsedCommands)
+def _validateModuleDependencies(modules):
+for m in modules:
+if m not in ("std", "std.compat"):
+raise
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/2] [libc++][modules] Adds module testing.
This adds a new
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
@@ -52,6 +52,21 @@ def _executeScriptInternal(test, litConfig, commands):
return (out, err, exitCode, timeoutInfo, parsedCommands)
+def _validateModuleDependencies(modules):
+for m in modules:
+if m not in ("std", "std.compat"):
+raise
@@ -0,0 +1,22 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
https://github.com/ldionne approved this pull request.
LGTM with some comments, thanks!
https://github.com/llvm/llvm-project/pull/76246
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
@@ -0,0 +1,24 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,24 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
+# test. So add these flags before adding the modules.
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
script += scriptInTest
# Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+# Modules need to be build with the same compilation flags as the
ldionne wrote:
```suggestion
#
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/76246
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -156,7 +156,9 @@ export namespace std {
using std::reinterpret_pointer_cast;
using std::static_pointer_cast;
+#ifndef _LIBCPP_HAS_NO_RTTI
using std::get_deleter;
+#endif // _LIBCPP_HAS_NO_RTTI
mordante wrote:
This tested here, but should land
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From eebe9b2fab5c5eef4776852270bf70af4626cfcb Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH] [libc++][modules] Adds module testing.
This adds a new module
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From 196cedd36534b02a7c55cf4a1746b34f87ead467 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/3] [libc++][modules] Adds module testing.
This adds a new
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From 196cedd36534b02a7c55cf4a1746b34f87ead467 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/2] [libc++][modules] Adds module testing.
This adds a new
@@ -223,6 +283,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest):
allows adding special compilation flags without having to use a
.sh.cpp test, which would be more powerful but perhaps overkill.
+// MODULE: std std.compat
+
+
@@ -317,6 +317,18 @@ def _getAndroidDeviceApi(cfg):
AddSubstitution("%{clang-tidy}", lambda cfg:
_getSuitableClangTidy(cfg))
],
),
+# Whether module support for the platform is available.
+Feature(
+name="has-no-module-support",
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -223,6 +283,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest):
allows adding special compilation flags without having to use a
.sh.cpp test, which would be more powerful but perhaps overkill.
+// MODULE: std std.compat
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -317,6 +317,18 @@ def _getAndroidDeviceApi(cfg):
AddSubstitution("%{clang-tidy}", lambda cfg:
_getSuitableClangTidy(cfg))
],
),
+# Whether module support for the platform is available.
+Feature(
+name="has-no-module-support",
+
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -131,13 +138,65 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
https://github.com/ldionne requested changes to this pull request.
This generally looks good to me, but I have some feedback per our live review!
Thanks, this is a great simplification overall.
https://github.com/llvm/llvm-project/pull/76246
___
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/76246
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
hawkinsw wrote:
> > > > If you are okay with the suggestions that I made for some typos in the
> > > > documentation, I will preemptively incorporate it into my documentation
> > > > PR.
> > >
> > >
> > > Thanks for the suggestions! Please do no incorporate these in your PR.
> > > Other
mordante wrote:
> > > If you are okay with the suggestions that I made for some typos in the
> > > documentation, I will preemptively incorporate it into my documentation
> > > PR.
> >
> >
> > Thanks for the suggestions! Please do no incorporate these in your PR.
> > Other reviewers may
hawkinsw wrote:
> > If you are okay with the suggestions that I made for some typos in the
> > documentation, I will preemptively incorporate it into my documentation PR.
>
> Thanks for the suggestions! Please do no incorporate these in your PR. Other
> reviewers may have other suggestions
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From fe2406d5fb6c01db9efadc9107c94585a6051c8a Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/4] [libc++][modules] Adds module testing.
This adds a new
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From fe2406d5fb6c01db9efadc9107c94585a6051c8a Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/3] [libc++][modules] Adds module testing.
This adds a new
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From fe2406d5fb6c01db9efadc9107c94585a6051c8a Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH 1/2] [libc++][modules] Adds module testing.
This adds a new
mordante wrote:
> If you are okay with the suggestions that I made for some typos in the
> documentation, I will preemptively incorporate it into my documentation PR.
Thanks for the suggestions! Please do no incorporate these in your PR. Other
reviewers may have other suggestions which you
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76246
>From fe2406d5fb6c01db9efadc9107c94585a6051c8a Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Wed, 20 Dec 2023 20:43:38 +0100
Subject: [PATCH] [libc++][modules] Adds module testing.
This adds a new module
https://github.com/hawkinsw commented:
If you are okay with the suggestions that I made for some typos in the
documentation, I will preemptively incorporate it into my documentation PR.
I really like how you integrated module testing so nicely. I hope my comments
are helpful!
@@ -131,13 +138,62 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
https://github.com/hawkinsw edited
https://github.com/llvm/llvm-project/pull/76246
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -131,13 +138,62 @@ def parseScript(test, preamble):
script += preamble
script += scriptInTest
+has_std_module = False
+has_std_compat_module = False
+for module in modules:
+if module == "std":
+has_std_module = True
+elif
@@ -223,6 +280,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest):
allows adding special compilation flags without having to use a
.sh.cpp test, which would be more powerful but perhaps overkill.
+// MODULE: std std.compat
+
+
@@ -223,6 +280,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest):
allows adding special compilation flags without having to use a
.sh.cpp test, which would be more powerful but perhaps overkill.
+// MODULE: std std.compat
+
+
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/76246
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
52 matches
Mail list logo
