https://github.com/philnik777 approved this pull request.
I'm OK with this as a quick fix, since Mark promised to fix it properly in the
long term.
https://github.com/llvm/llvm-project/pull/76268
___
llvm-branch-commits mailing list
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76268
>From b3c567f4a4369b1d22f189f272a3fa86c1f0f401 Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Fri, 22 Dec 2023 21:43:57 +0100
Subject: [PATCH] [libc++][modules] Increase clang-tidy version used.
As
mordante wrote:
> > Then I can prohibit clang-16 and clang-17.
>
> Yeah, that's the solution. clang-tidy defines the same version macros as
> clang does, so prohibiting it from clang-16 is the same as prohibiting it for
> clang-tidy 16.
What makes it currently hard for modules is that in the
philnik777 wrote:
> > > Oh shit. I just realized that this is most likely a latent bug no matter
> > > what. We build the module with Clang 18, and then essentially try to load
> > > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to
> > > work, and probably just happens to
mordante wrote:
> > Oh shit. I just realized that this is most likely a latent bug no matter
> > what. We build the module with Clang 18, and then essentially try to load
> > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work,
> > and probably just happens to work
philnik777 wrote:
> > Oh shit. I just realized that this is most likely a latent bug no matter
> > what. We build the module with Clang 18, and then essentially try to load
> > it with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work,
> > and probably just happens to work
H-G-Hristov wrote:
> Oh shit. I just realized that this is most likely a latent bug no matter
> what. We build the module with Clang 18, and then essentially try to load it
> with Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, and
> probably just happens to work currently
mordante wrote:
Good point, I actually think that's true. I think we should do that in a
separate PR. Maybe discuss it on Discord after the holidays.
https://github.com/llvm/llvm-project/pull/76268
___
llvm-branch-commits mailing list
philnik777 wrote:
Oh shit. I just realized that this is most likely a latent bug no matter what.
We build the module with Clang 18, and then essentially try to load it with
Clang 17 (aka Clang Tidy 17). AFAIK that's not guaranteed to work, and probably
just happens to work currently with
mordante wrote:
It's the line `export import std;` in
https://github.com/llvm/llvm-project/pull/76330/files#diff-e881fdd0e6e66610142a28228b2bbf0e38520ee7186946bca06cb8d195dcd2b4
This works with Clang-17, Clang-18, and clang-tidy-18. It fails with
clang-tidy-17. Clang-tidy tests that directly
philnik777 wrote:
I'd like to understand what the fixed issues are you're relying on. From what I
can tell, this could just as much be a bug in our setup for the clang-tidy
plugin as an actual fix in trunk.
https://github.com/llvm/llvm-project/pull/76268
mordante wrote:
> I'm really not happy with bumping the clang-tidy version we use all the time
> to the trunk version. We agreed to using the latest stable version, which
> we've not done way too many times now. I'd really like to first understand
> what exactly the issue is that is solved by
https://github.com/mordante updated
https://github.com/llvm/llvm-project/pull/76268
>From 10dcb9404ac63bd1c10936e60f21159e7eabe38b Mon Sep 17 00:00:00 2001
From: Mark de Wever
Date: Fri, 22 Dec 2023 21:43:57 +0100
Subject: [PATCH] [libc++][modules] Increase clang-tidy version used.
As
https://github.com/philnik777 requested changes to this pull request.
I'm really not happy with bumping the clang-tidy version we use all the time to
the trunk version. We agreed to using the latest stable version, which we've
not done way too many times now. I'd really like to first
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
10c2d9a35aafe8e21835a6274eddb780baaa6f2c...082ae9517251ef253ca475a8bcdcdb5519806eee
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Mark de Wever (mordante)
Changes
As suggested in #71438 we should use
export import std;
in the std.compat module.
Testing this locally failed when building with the clang-tidy-17 plugin. The
std module was considered corrupt in the
https://github.com/mordante created
https://github.com/llvm/llvm-project/pull/76268
As suggested in #71438 we should use
export import std;
in the std.compat module.
Testing this locally failed when building with the clang-tidy-17 plugin. The
std module was considered corrupt in the test
17 matches
Mail list logo
