Author: Kazuaki Ishizaki Date: 2021-01-07T02:36:02+09:00 New Revision: 2b638ed5a127c8e1820d68fcc91333fb9c553904
URL: https://github.com/llvm/llvm-project/commit/2b638ed5a127c8e1820d68fcc91333fb9c553904 DIFF: https://github.com/llvm/llvm-project/commit/2b638ed5a127c8e1820d68fcc91333fb9c553904.diff LOG: [mlir] NFC: fix trivial typos fix typos under docs, test, and tools directories Reviewed By: ftynse Differential Revision: https://reviews.llvm.org/D94158 Added: Modified: mlir/docs/CAPI.md mlir/docs/ConversionToLLVMDialect.md mlir/docs/Dialects/LLVM.md mlir/docs/Dialects/TOSA.md mlir/docs/PassManagement.md mlir/test/Dialect/Async/async-ref-counting-optimization.mlir mlir/test/Transforms/buffer-deallocation.mlir mlir/test/Transforms/normalize-memrefs-ops.mlir mlir/test/Transforms/promote-buffers-to-stack.mlir mlir/test/lib/Dialect/Test/TestPatterns.cpp mlir/test/lib/Transforms/TestSparsification.cpp mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp mlir/tools/mlir-tblgen/TypeDefGen.cpp Removed: ################################################################################ diff --git a/mlir/docs/CAPI.md b/mlir/docs/CAPI.md index a292c1fc1833..4feb1faf1b8e 100644 --- a/mlir/docs/CAPI.md +++ b/mlir/docs/CAPI.md @@ -107,7 +107,7 @@ these are represented as instances of `MlirStringRef` structure that contains a pointer to the first character of the string fragment (`str`) and the fragment length (`length`). Note that the fragment is _not necessarily_ null-terminated, the `length` field must be used to identify the last character. `MlirStringRef` -is a non-owning pointer, the caller is in charge of perfoming the copy or +is a non-owning pointer, the caller is in charge of performing the copy or ensuring that the pointee outlives all uses of `MlirStringRef`. ### Printing diff --git a/mlir/docs/ConversionToLLVMDialect.md b/mlir/docs/ConversionToLLVMDialect.md index 2b5f98b37686..55b62ff70376 100644 --- a/mlir/docs/ConversionToLLVMDialect.md +++ b/mlir/docs/ConversionToLLVMDialect.md @@ -126,7 +126,7 @@ memref<1x? x vector<4xf32>> -> !llvm.struct<(ptr<vec<4 x float>>, Ranked memrefs with static shape and default layout can be converted into an LLVM dialect pointer to their element type. Only the default alignment is -supported in such cases, e.g. the `alloc` operation cannot have an alignemnt +supported in such cases, e.g. the `alloc` operation cannot have an alignment attribute. Examples: @@ -233,11 +233,11 @@ Examples: When used as function arguments, both ranked and unranked memrefs are converted into a list of arguments that represents each _scalar_ component of their -descriptor. This is intended for some comaptibility with C ABI, in which +descriptor. This is intended for some compatibility with C ABI, in which structure types would need to be passed by-pointer leading to the need for allocations and related issues, as well as for aliasing annotations, which are currently attached to pointer in function arguments. Having scalar components -means that each size and stride is passed as an invidivual value. +means that each size and stride is passed as an individual value. When used as function results, memrefs are converted as usual, i.e. each memref is converted to a descriptor struct (default convention) or to a pointer (bare diff --git a/mlir/docs/Dialects/LLVM.md b/mlir/docs/Dialects/LLVM.md index 3b9150f0e69d..0f5b69104775 100644 --- a/mlir/docs/Dialects/LLVM.md +++ b/mlir/docs/Dialects/LLVM.md @@ -385,7 +385,7 @@ structure `A` is represented as `!llvm.struct<"A", (ptr<"B", (ptr<"A">)>, ptr<"B", (ptr<"A">))>`. Note that the structure `B` is "unrolled" for both elements. _A structure with the same name but diff erent body is a syntax error._ **The user must ensure structure name uniqueness across all modules processed in -a given MLIR context.** Stucture names are arbitrary string literals and may +a given MLIR context.** Structure names are arbitrary string literals and may include, e.g., spaces and keywords. Identified structs may be _opaque_. In this case, the body is unknown but the diff --git a/mlir/docs/Dialects/TOSA.md b/mlir/docs/Dialects/TOSA.md index e0d9eaf32818..cd95f4da69cd 100644 --- a/mlir/docs/Dialects/TOSA.md +++ b/mlir/docs/Dialects/TOSA.md @@ -17,14 +17,14 @@ that attempt to manage both sets of requirements. ## TOSA and Tensor Level Expressiveness TOSA endeavors to provide an operator set that tries to fulfil the following -expressivenes goals at the *tensor level of abstraction* : +expressiveness goals at the *tensor level of abstraction* : ### Complete This is driven by the top-down perspective, needing to express as much of multiple high level frameworks fully in TOSA, as possible. This was originally done from an operator frequency analysis done upon dozens of high level -networks in diff erent frameworks, to select the most frequently occuring ones +networks in diff erent frameworks, to select the most frequently occurring ones and establish a common set of tensor-level operators that could express them. TOSA categorizes its operator set into classes and attempts to address major diff --git a/mlir/docs/PassManagement.md b/mlir/docs/PassManagement.md index b71859f7d974..ee47d0bcc437 100644 --- a/mlir/docs/PassManagement.md +++ b/mlir/docs/PassManagement.md @@ -271,7 +271,7 @@ Passes can be added to a pass manager via `addPass`. The pass must either be an `op-specific` pass operating on the same operation type as `OpPassManager`, or an `op-agnostic` pass. -An `OpPassManager` is generally creted by explicitly nesting a pipeline within +An `OpPassManager` is generally created by explicitly nesting a pipeline within another existing `OpPassManager` via the `nest<>` method. This method takes the operation type that the nested pass manager will operate on. At the top-level, a `PassManager` acts as an `OpPassManager`. Nesting in this sense, corresponds to diff --git a/mlir/test/Dialect/Async/async-ref-counting-optimization.mlir b/mlir/test/Dialect/Async/async-ref-counting-optimization.mlir index 6500fa0b1d8a..0ceea92bff19 100644 --- a/mlir/test/Dialect/Async/async-ref-counting-optimization.mlir +++ b/mlir/test/Dialect/Async/async-ref-counting-optimization.mlir @@ -87,7 +87,7 @@ func @not_cancellable_operations_0(%arg0: !async.token, %arg1: i1) { // CHECK-LABEL: @not_cancellable_operations_1 func @not_cancellable_operations_1(%arg0: !async.token, %arg1: i1) { // Same reason as above, although `async.execute` is inside the nested - // region or "regular" opeation. + // region or "regular" operation. // // NOTE: This test is not correct w.r.t. reference counting, and at runtime // would leak %arg0 value if %arg1 is false. IR like this will not be diff --git a/mlir/test/Transforms/buffer-deallocation.mlir b/mlir/test/Transforms/buffer-deallocation.mlir index 079988103947..f0eccbd2ae82 100644 --- a/mlir/test/Transforms/buffer-deallocation.mlir +++ b/mlir/test/Transforms/buffer-deallocation.mlir @@ -907,7 +907,7 @@ func @loop_alloc( // Test Case: structured control-flow loop with a nested if operation. // The loop yields buffers that have been defined outside of the loop and the -// backeges only use the iteration arguments (or one of its aliases). +// backedges only use the iteration arguments (or one of its aliases). // Therefore, we do not have to (and are not allowed to) free any buffers // that are passed via the backedges. diff --git a/mlir/test/Transforms/normalize-memrefs-ops.mlir b/mlir/test/Transforms/normalize-memrefs-ops.mlir index 9567ab5f8f83..84b817aa7f24 100644 --- a/mlir/test/Transforms/normalize-memrefs-ops.mlir +++ b/mlir/test/Transforms/normalize-memrefs-ops.mlir @@ -6,7 +6,7 @@ // that include this operation are constructed so that the normalization should // happen. // * test_op_nonnorm: this operation does not have the MemRefsNormalization -// attribute. The tests that include this operation are contructed so that the +// attribute. The tests that include this operation are constructed so that the // normalization should not happen. #map0 = affine_map<(d0, d1, d2, d3) -> (d0, d1, d2 floordiv 32, d3 floordiv 64, d2 mod 32, d3 mod 64)> diff --git a/mlir/test/Transforms/promote-buffers-to-stack.mlir b/mlir/test/Transforms/promote-buffers-to-stack.mlir index 8fabd4fe6a01..1d9806e53036 100644 --- a/mlir/test/Transforms/promote-buffers-to-stack.mlir +++ b/mlir/test/Transforms/promote-buffers-to-stack.mlir @@ -498,7 +498,7 @@ func @loop_alloc( // Test Case: structured control-flow loop with a nested if operation. // The loop yields buffers that have been defined outside of the loop and the -// backeges only use the iteration arguments (or one of its aliases). +// backedges only use the iteration arguments (or one of its aliases). // Therefore, we do not have to (and are not allowed to) free any buffers // that are passed via the backedges. The alloc is converted to an AllocaOp. diff --git a/mlir/test/lib/Dialect/Test/TestPatterns.cpp b/mlir/test/lib/Dialect/Test/TestPatterns.cpp index 849c6c6e2ea6..34e8b4d34a4f 100644 --- a/mlir/test/lib/Dialect/Test/TestPatterns.cpp +++ b/mlir/test/lib/Dialect/Test/TestPatterns.cpp @@ -61,7 +61,7 @@ struct FoldingPattern : public RewritePattern { LogicalResult matchAndRewrite(Operation *op, PatternRewriter &rewriter) const override { - // Exercice OperationFolder API for a single-result operation that is folded + // Exercise OperationFolder API for a single-result operation that is folded // upon construction. The operation being created through the folder has an // in-place folder, and it should be still present in the output. // Furthermore, the folder should not crash when attempting to recover the diff --git a/mlir/test/lib/Transforms/TestSparsification.cpp b/mlir/test/lib/Transforms/TestSparsification.cpp index a960ca75b9f3..3b80f8dc5990 100644 --- a/mlir/test/lib/Transforms/TestSparsification.cpp +++ b/mlir/test/lib/Transforms/TestSparsification.cpp @@ -106,7 +106,7 @@ namespace test { void registerTestSparsification() { PassRegistration<TestSparsification> sparsificationPass( "test-sparsification", - "Test automatic geneneration of sparse tensor code"); + "Test automatic generation of sparse tensor code"); } } // namespace test diff --git a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp index 0342fab5ab9f..592e6cb774fb 100644 --- a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp +++ b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp @@ -994,7 +994,7 @@ class TCParser { void printRegionBuilder(llvm::raw_ostream &os, StringRef cppOpName, ComprehensionParsingState &state); - /// Print the C++ impl for named ops canonicalizers and fodlers. + /// Print the C++ impl for named ops canonicalizers and folders. void printCanonicalizersAndFolders(llvm::raw_ostream &os, StringRef cppOpName); diff --git a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp index b1c86522c6b5..39053cd33ecd 100644 --- a/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp +++ b/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp @@ -1010,7 +1010,7 @@ void OpEmitter::genNamedRegionGetters() { if (region.name.empty()) continue; - // Generate the accessors for a varidiadic region. + // Generate the accessors for a variadic region. if (region.isVariadic()) { auto *m = opClass.addMethodAndPrune("::mlir::MutableArrayRef<Region>", region.name); @@ -2378,7 +2378,7 @@ void OpOperandAdaptorEmitter::addVerification() { FmtContext verifyCtx; populateSubstitutions(op, "odsAttrs.get", "getODSOperands", - "<no results should be genarated>", verifyCtx); + "<no results should be generated>", verifyCtx); genAttributeVerifier(op, "odsAttrs.get", Twine("emitError(loc, \"'") + op.getOperationName() + "' op \"", diff --git a/mlir/tools/mlir-tblgen/TypeDefGen.cpp b/mlir/tools/mlir-tblgen/TypeDefGen.cpp index afe174ff84bf..8fdb5f4feeaf 100644 --- a/mlir/tools/mlir-tblgen/TypeDefGen.cpp +++ b/mlir/tools/mlir-tblgen/TypeDefGen.cpp @@ -296,7 +296,7 @@ static void emitTypeDefList(SmallVectorImpl<TypeDef> &typeDefs, /// {0}: Storage class namespace. /// {1}: Storage class c++ name. /// {2}: Parameters parameters. -/// {3}: Parameter initialzer string. +/// {3}: Parameter initializer string. /// {4}: Parameter name list. /// {5}: Parameter types. static const char *const typeDefStorageClassBegin = R"( _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits