Re: [Ltrace-devel] [PATCH] Support for ppc64le (Little Endian and ABIv2) Add new testsuite/ltrace.main/parameters-str.exp file Handles HFA and irelative support

2014-05-12 Thread Petr Machata
Thierry Fauck ( thierry @ linux.vnet.ibm.com ) thie...@linux.vnet.ibm.com writes: +#ifndef EF_PPC64_ABI +# define EF_PPC64_ABI 3 +#endif Shouldn't I had this defintion is arch.h when I am not in case _CALL_ELF==2 so when I want to use it I can bail out if EF_PPC_ABI undefined in

Re: [Ltrace-devel] [PATCH] Support for ppc64le (Little Endian and ABIv2) Add new testsuite/ltrace.main/parameters-str.exp file Handles HFA and irelative support

2014-05-11 Thread Petr Machata
Thierry, will you be able to address these last nits? It's the last hump before I can merge this without breaking compilation on hosts that don't know about ELFv2 ABI yet. Thank you, PM Petr Machata pmach...@redhat.com writes: This looks all pretty good. I compile-tested it on plain PPC64

Re: [Ltrace-devel] [PATCH] Support for ppc64le (Little Endian and ABIv2) Add new testsuite/ltrace.main/parameters-str.exp file Handles HFA and irelative support

2014-04-30 Thread Petr Machata
This looks all pretty good. I compile-tested it on plain PPC64 --it's desirable to keep ltrace building on old toolchains as well-- and hit a couple problems with the several new symbols that you use. I think we should have a fallback that disables the new code if the definitions are just