date:20151216

[Maria-developers] Unsubscribe

2015-12-16 Thread Abdul Hakeem


___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Maria-developers] [Commits] 0b0d341: MDEV-9044 : Binlog corruption in Galera

2015-12-16 Thread Sergei Golubchik

Hi, Nirbhay!

On Dec 07, Nirbhay Choubey wrote:
> revision-id: 0b0d34138300b891ccbec58e01f3ab5bebe24d71
> parent(s): 3c0e9d31b3e6494931deb09f5c93b05a96df8471
> committer: Nirbhay Choubey
> branch nick: 10.1.b9044
> timestamp: 2015-12-07 14:01:52 -0500
> message:
> 
> MDEV-9044 : Binlog corruption in Galera
> 
> While refreshing the IO_CACHE, do not update its parameters (read_pos,
> read_end & pos_in_file) if there is nothing left to read.

I'm sorry, but I don't understand the fix. Why should parameters be not
updated? If there's nothing left to read, the cache is marked as empty,
that seems to be correct.

> diff --git a/mysys/mf_iocache.c b/mysys/mf_iocache.c
> index 28e5e72..db8d0b5 100644
> --- a/mysys/mf_iocache.c
> +++ b/mysys/mf_iocache.c
> @@ -663,7 +663,11 @@ int _my_b_cache_read(IO_CACHE *info, uchar *Buffer, 
> size_t Count)
>info->error= (int) left_length;
>DBUG_RETURN(1);
>  }
> -length=0;/* Didn't read any chars */
> +else
> +{
> +  info->error= 0;
> +  DBUG_RETURN(0);   /* EOF */
> +}
>}

Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
-- 
Vote for my Percona Live 2016 talks:
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-connectors-fast-and-smart-new-protocol-optimizations#community-voting
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-101-security-validation-authentication-encryption#community-voting

___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many

2015-12-16 Thread Sergei Golubchik

Hi, Sergey!

On Dec 16, Sergey Vojtovich wrote:
> 
> > Are you sure we want to fix that at all?
> Definitely daemon_example.

fine

> The rest is nice to have (e.g. I wouldn't want my app to exit if
> embedded gets --print-defaults).

agree

> But the fix should be different: change of abort to exit makes little
> sense.  Either we should pass through error code, or disable code
> which is never executed by embedded/libmysqlclient with ifdefs.

okay. for mysys that means error codes, meaning API changes.

> If you don't mind I'll push daemon_example part of this fix and remove
> my_abort_hook: one line less in lintian report is a progress still.

sure

Regards,
Sergei
Chief Architect MariaDB
and secur...@mariadb.org
-- 
Vote for my Percona Live 2016 talks:
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-connectors-fast-and-smart-new-protocol-optimizations#community-voting
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-101-security-validation-authentication-encryption#community-voting

___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp

[Maria-developers] MDEV-8844 Unreadable control characters printed as is in warnings

2015-12-16 Thread Alexander Barkov


Hi Sergei,

Please review a patch for MDEV-8844.

Thanks!

diff --git a/include/m_ctype.h b/include/m_ctype.h
index a552226..b059258 100644
--- a/include/m_ctype.h
+++ b/include/m_ctype.h
@@ -582,6 +582,7 @@ struct charset_info_st
 extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_bin;
 extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_latin1;
 extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_filename;
+extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_errmsg;
 extern MYSQL_PLUGIN_IMPORT struct charset_info_st my_charset_utf8_general_ci;
 
 extern struct charset_info_st my_charset_big5_bin;
diff --git a/mysql-test/r/ctype_latin1.result b/mysql-test/r/ctype_latin1.result
index 4847592..fce1a07 100644
--- a/mysql-test/r/ctype_latin1.result
+++ b/mysql-test/r/ctype_latin1.result
@@ -8181,5 +8181,44 @@ Warnings:
 Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b`,`test`.`t1`.`c` AS `c`,`test`.`t1`.`d` AS `d` from `test`.`t1` where ((coalesce(`test`.`t1`.`c`,0) = '3 ') and (coalesce(`test`.`t1`.`d`,0) = '3 '))
 DROP TABLE t1;
 #
+# MDEV-8844 Unreadable control characters printed as is in warnings
+#
+SET NAMES latin1;
+SELECT CAST(_latin1 0x610062 AS INT);
+CAST(_latin1 0x610062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\b'
+SELECT CAST(_latin1 0x610162 AS INT);
+CAST(_latin1 0x610162 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\0001b'
+SELECT CAST(_latin1 0x611F62 AS INT);
+CAST(_latin1 0x611F62 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\001Fb'
+SELECT CAST(_latin1 0x617F62 AS INT);
+CAST(_latin1 0x617F62 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\007Fb'
+SELECT CAST(_latin1 0x612062 AS INT);
+CAST(_latin1 0x612062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a b'
+SELECT CAST(_latin1 0x617E62 AS INT);
+CAST(_latin1 0x617E62 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a~b'
+SELECT CAST(_latin1 0x61FF62 AS INT);
+CAST(_latin1 0x61FF62 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'aÿb'
+#
 # End of 10.1 tests
 #
diff --git a/mysql-test/r/ctype_ucs.result b/mysql-test/r/ctype_ucs.result
index 5617431..82e4784 100644
--- a/mysql-test/r/ctype_ucs.result
+++ b/mysql-test/r/ctype_ucs.result
@@ -5649,5 +5649,38 @@ CAST(CONVERT('1Ä²3' USING ucs2) AS SIGNED)
 Warnings:
 Warning	1292	Truncated incorrect INTEGER value: '1Ä²3'
 #
+# MDEV-8844 Unreadable control characters printed as is in warnings
+#
+SELECT CAST(_ucs2 0x00610062 AS INT);
+CAST(_ucs2 0x00610062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\b'
+SELECT CAST(_ucs2 0x006100010062 AS INT);
+CAST(_ucs2 0x006100010062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\0001b'
+SELECT CAST(_ucs2 0x0061D862 AS INT);
+CAST(_ucs2 0x0061D862 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\D800b'
+SELECT CAST(_ucs2 0x0061DFFF0062 AS INT);
+CAST(_ucs2 0x0061DFFF0062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\DFFFb'
+SELECT CAST(_ucs2 0x0061D762 AS INT);
+CAST(_ucs2 0x0061D762 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'aíb'
+SELECT CAST(_ucs2 0x0061E0030062 AS INT);
+CAST(_ucs2 0x0061E0030062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'aîb'
+#
 # End of 10.1 tests
 #
diff --git a/mysql-test/r/ctype_utf16.result b/mysql-test/r/ctype_utf16.result
index 3bd3725..303fa48 100644
--- a/mysql-test/r/ctype_utf16.result
+++ b/mysql-test/r/ctype_utf16.result
@@ -2199,5 +2199,14 @@ CAST(CONVERT('1Ä²3' USING utf16) AS SIGNED)
 Warnings:
 Warning	1292	Truncated incorrect INTEGER value: '1Ä²3'
 #
+# MDEV-8844 Unreadable control characters printed as is in warnings
+#
+SET NAMES utf8;
+SELECT CAST(_utf16 0x0061D83DDE0E0062 AS INT);
+CAST(_utf16 0x0061D83DDE0E0062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a?b'
+#
 # End of 10.1 tests
 #
diff --git a/mysql-test/r/ctype_utf8.result b/mysql-test/r/ctype_utf8.result
index 66db7df..ab340e0 100644
--- a/mysql-test/r/ctype_utf8.result
+++ b/mysql-test/r/ctype_utf8.result
@@ -10213,5 +10213,69 @@ Warnings:
 Note	1003	select `test`.`t1`.`c` AS `c` from `test`.`t1` where (`test`.`t1`.`c` = 'A')
 DROP TABLE t1;
 #
+# MDEV-8844 Unreadable control characters printed as is in warnings
+#
+SET NAMES utf8;
+SELECT CAST(_utf8 0x610062 AS INT);
+CAST(_utf8 0x610062 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\b'
+SELECT CAST(_utf8 0x610162 AS INT);
+CAST(_utf8 0x610162 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\0001b'
+SELECT CAST(_utf8 0x611F62 AS INT);
+CAST(_utf8 0x611F62 AS INT)
+0
+Warnings:
+Warning	1292	Truncated incorrect INTEGER value: 'a\001Fb'
+SELECT CAST(_utf8 0x617F62 AS INT);
+CAST(_utf8

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many

2015-12-16 Thread Sergey Vojtovich

Hi Sergei,

On Tue, Dec 15, 2015 at 10:49:37PM +0100, Sergei Golubchik wrote:
> Hi, Sergey!
> 
> On Dec 14, Sergey Vojtovich wrote:
> > revision-id: 732d45e93b81a104e3f3931e4908e22167a54622 
> > (mariadb-10.0.22-57-g732d45e)
> > parent(s): 3e206a518dec400e084451165f633b78eb2e7fee
> > committer: Sergey Vojtovich
> > timestamp: 2015-12-14 15:27:09 +0400
> > message:
> > 
> > MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in 
> > many
> > of the plugins
> > 
> > Fixed exit/_exit calls from libdaemon_example.so, libmysqlclient.so,
> > libmysqlclient_r.so, libmysqld.so.
> > 
> > Note: this is just rough prototype, not to be pushed. libmysqld.so still has
> > a bunch of exit/_exit calls from InnoDB.
...skip...

> Are you sure we want to fix that at all?
Definitely daemon_example. The rest is nice to have (e.g. I wouldn't want my
app to exit if embedded gets --print-defaults).

But the fix should be different: change of abort to exit makes little sense.
Either we should pass through error code, or disable code which is never
executed by embedded/libmysqlclient with ifdefs.

> And if yes - is it something we need to bother fixing now?
The right fix as described above may become complex, so I'd rather postpone it
for 10.2. But Debian is suffering from this now with 10.0.

I don't know.

> How comes it's "critical"?
I think the reason behind "critical" is our willing to please Debian.

If you don't mind I'll push daemon_example part of this fix and remove
my_abort_hook: one line less in lintian report is a progress still.

Thanks,
Sergey

___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp

[Maria-developers] Unsubscribe

Re: [Maria-developers] [Commits] 0b0d341: MDEV-9044 : Binlog corruption in Galera

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many

[Maria-developers] MDEV-8844 Unreadable control characters printed as is in warnings

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many

5 matches

Site Navigation

Mail list logo

Footer information