Liangent has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137563
Change subject: Use master to load previous tags in ChangeTags::addTags()
......................................................................
Use master to load previous tags in ChangeTags::addTags()
Change-Id: Ie47649ef45f9eebdfeae73a0698ea5d21b150b56
---
M includes/ChangeTags.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/63/137563/1
diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php
index d3dd51a..9cc5a0c 100644
--- a/includes/ChangeTags.php
+++ b/includes/ChangeTags.php
@@ -146,7 +146,10 @@
);
## Update the summary row.
- $prevTags = $dbr->selectField( 'tag_summary', 'ts_tags',
$tsConds, __METHOD__ );
+ // $prevTags can be out of date on slaves, especially when
addTags is called consecutively,
+ // causing loss of tags added recently in tag_summary table.
+ $dbw = wfGetDB( DB_MASTER );
+ $prevTags = $dbw->selectField( 'tag_summary', 'ts_tags',
$tsConds, __METHOD__ );
$prevTags = $prevTags ? $prevTags : '';
$prevTags = array_filter( explode( ',', $prevTags ) );
$newTags = array_unique( array_merge( $prevTags, $tags ) );
@@ -158,7 +161,6 @@
return false;
}
- $dbw = wfGetDB( DB_MASTER );
$dbw->replace(
'tag_summary',
array( 'ts_rev_id', 'ts_rc_id', 'ts_log_id' ),
--
To view, visit https://gerrit.wikimedia.org/r/137563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie47649ef45f9eebdfeae73a0698ea5d21b150b56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Liangent <liang...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
